GNU logs - #49499, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#49499] [PATCH] gnu: add the tos;dr initiative's extension
Resent-From: terramorpha@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 09 Jul 2021 19:34:01 +0000
Resent-Message-ID: <handler.49499.B.16258591983584 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 49499 <at> debbugs.gnu.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Fri, 09 Jul 2021 15:33:08 -0400
From: terramorpha@HIDDEN
Message-ID: <9d44234caf247026a5c19af90f5d4471@HIDDEN>
User-Agent: Roundcube Webmail/1.3.15
Received-SPF: pass client-ip=37.120.193.124; envelope-from=terramorpha@HIDDEN;
 helo=mail.cock.li
X-Spam_score_int: -7
X-Spam_score: -0.8
X-Spam_bar: /
X-Spam_report: (-0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_VALIDITY_RPBL=1.31, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

This is a package definition for the terms of service;didn't read 
initiative. It is useful to easily
know the privacy issues with whatever website the user is using.

diff --git a/gnu/packages/browser-extensions.scm 
b/gnu/packages/browser-extensions.scm
index a6120baf96..6cbe77b9c3 100644
--- a/gnu/packages/browser-extensions.scm
+++ b/gnu/packages/browser-extensions.scm
@@ -121,3 +121,41 @@ ungoogled-chromium.")

  (define-public ublock-origin/chromium
    (make-chromium-extension ublock-origin "chromium"))
+
+(define tosdr
+  (package
+   (name "tosdr")
+   (version "4.1.1")
+   (source (origin
+             (uri
+              (git-reference (url 
"https://github.com/tosdr/browser-extensions.git")
+                             (commit version)))
+             (sha256 (base32 
"0wz31f9rz087yw1a7cdhdgqvgnhbk569jywv846n122m4bpk3yw0"))
+             (method git-fetch)))
+   (inputs `(("bash" ,bash)
+             ("coreutils" ,coreutils)
+             ("node" ,node)
+             ("zip" ,zip)
+             ("unzip" ,unzip)))
+   (arguments
+    `(#:builder
+      (begin
+        (use-modules (guix build utils))
+        (set-path-environment-variable "PATH"
+                                      '("bin")
+                                      (map cdr %build-inputs))
+        (copy-recursively (assoc-ref %build-inputs "source") ".")
+        (invoke "sh" "./build.sh")
+        (invoke "unzip" "dist/chrome.zip" "-d" %output)
+        #t)
+      #:modules ((guix build utils))))
+   (build-system trivial-build-system)
+   (synopsis "extension for the Terms of Service; Didn't Read 
initiative")
+   (description "This extension informs you instantly of your rights 
online by
+showing an unintrusive icon in the toolbar.  You can click on this icon 
to get
+summaries from the Terms of Service; Didn't Read initiative.")
+   (license license:agpl3)
+   (home-page "https://tosdr.org/")))
+
+(define-public tosdr-chromium
+  (make-chromium-extension tosdr))

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: terramorpha@HIDDEN
Subject: bug#49499: Acknowledgement ([PATCH] gnu: add the tos;dr
 initiative's extension)
Message-ID: <handler.49499.B.16258591983584.ack <at> debbugs.gnu.org>
References: <9d44234caf247026a5c19af90f5d4471@HIDDEN>
X-Gnu-PR-Message: ack 49499
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 49499 <at> debbugs.gnu.org
Date: Fri, 09 Jul 2021 19:34:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 49499 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
49499: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D49499
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#49499] [PATCH] gnu: add the tos;dr initiative's extension
Resent-From: Sarah Morgensen <iskarian@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 22 Jul 2021 21:50:02 +0000
Resent-Message-ID: <handler.49499.B49499.162699058619309 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: terramorpha@HIDDEN
Cc: 49499 <at> debbugs.gnu.org
From: Sarah Morgensen <iskarian@HIDDEN>
References: <9d44234caf247026a5c19af90f5d4471@HIDDEN>
Date: Thu, 22 Jul 2021 14:49:36 -0700
In-Reply-To: <9d44234caf247026a5c19af90f5d4471@HIDDEN> (terramorpha@HIDDEN's
 message of "Fri, 09 Jul 2021 15:33:08 -0400")
Message-ID: <8635s6rpcf.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

Thanks for the patch. Unfortunately I am unable to apply your patch; it
looks like your mail client wrapped long lines which broke the
patch. (That's why most of us send patches with `git send-email`, to
avoid this problem.)

I also have a few suggestions for your patch, annotated below...

terramorpha@HIDDEN writes:

> This is a package definition for the terms of service;didn't read initiative. It
> is useful to easily
> know the privacy issues with whatever website the user is using.
>
> diff --git a/gnu/packages/browser-extensions.scm
> b/gnu/packages/browser-extensions.scm
> index a6120baf96..6cbe77b9c3 100644
> --- a/gnu/packages/browser-extensions.scm
> +++ b/gnu/packages/browser-extensions.scm
> @@ -121,3 +121,41 @@ ungoogled-chromium.")
>
>  (define-public ublock-origin/chromium
>    (make-chromium-extension ublock-origin "chromium"))
> +
> +(define tosdr
> +  (package
> +   (name "tosdr")
> +   (version "4.1.1")
> +   (source (origin
> +             (uri
> +              (git-reference (url
> "https://github.com/tosdr/browser-extensions.git")

This line is too long and should be wrapped.

> +                             (commit version)))
> +             (sha256 (base32
> "0wz31f9rz087yw1a7cdhdgqvgnhbk569jywv846n122m4bpk3yw0"))

Likewise.

> +             (method git-fetch)))
> +   (inputs `(("bash" ,bash)
> +             ("coreutils" ,coreutils)
> +             ("node" ,node)
> +             ("zip" ,zip)
> +             ("unzip" ,unzip)))

These should be native-inputs rather than inputs, since they are just
used in building. Perhaps consider just using copy-build-system instead,
to avoid manually including these inputs and setting PATH below.

You can look at the ublock-origin package as an example (though I would
use the copy-build-system instead, adding back in a 'build phase, either
removing the "rm -rf build" from `build.sh` beforehand or unzipping the
zip immediately afterwards).

> +   (arguments
> +    `(#:builder
> +      (begin
> +        (use-modules (guix build utils))
> +        (set-path-environment-variable "PATH"
> +                                      '("bin")
> +                                      (map cdr %build-inputs))
> +        (copy-recursively (assoc-ref %build-inputs "source") ".")
> +        (invoke "sh" "./build.sh")
> +        (invoke "unzip" "dist/chrome.zip" "-d" %output)
> +        #t)
> +      #:modules ((guix build utils))))
> +   (build-system trivial-build-system)
> +   (synopsis "extension for the Terms of Service; Didn't Read initiative")

The synopsis should begin with a capital letter.

> +   (description "This extension informs you instantly of your rights online by
> +showing an unintrusive icon in the toolbar.  You can click on this icon to get
> +summaries from the Terms of Service; Didn't Read initiative.")
> +   (license license:agpl3)
> +   (home-page "https://tosdr.org/")))
> +
> +(define-public tosdr-chromium
> +  (make-chromium-extension tosdr))

--
Sarah

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 25 Jul 2021 02:32:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 24 22:32:47 2021
Received: from localhost ([127.0.0.1]:47293 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1m7Twc-0008IA-UB
	for submit <at> debbugs.gnu.org; Sat, 24 Jul 2021 22:32:47 -0400
Received: from out0.migadu.com ([94.23.1.103]:15044)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <iskarian@HIDDEN>) id 1m7TwY-0008Hz-Cx
 for control <at> debbugs.gnu.org; Sat, 24 Jul 2021 22:32:45 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1;
 t=1627180361;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type;
 bh=1ukQFzFQMgencPyty4BLFkO3xdp91eUjdndjX26T2JA=;
 b=GVmf6dwAYPsPvN9D6LhAmbjxCFWcROugW7MnIovxn6i4Jhdw+N+fZWx/gSreFFrBTF5WyJ
 T2qUEpLcx3/NlWJHfMu6qpRGCXdPvtouBDXI8rEN7I4Hk4O73EgYO6NXpZmimEwwESM2Z8
 jVUHH/zvyO1MS41XVjZH+qcraGiQu/E=
From: Sarah Morgensen <iskarian@HIDDEN>
To: control <at> debbugs.gnu.org
Subject: control message for bug #49499
Date: Sat, 24 Jul 2021 19:32:39 -0700
Message-ID: <86fsw3p1h4.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: iskarian@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

reassign 49582 guix-patches
merge 49499 49582
thanks

Last modified: Sun, 25 Jul 2021 02:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.