GNU bug report logs - #49510
[PATCH] gnu: Add PuTTY.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49510 in the body.
You can then email your comments to 49510 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: terramorpha <at> cock.li
To: bug-guix <at> gnu.org
Subject: [PATCH] gnu: Add PuTTY.
Date: Sat, 10 Jul 2021 15:31:51 -0400

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 19b58501e9..af3082b954 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -4100,3 +4100,37 @@ on hub/switched networks.  It is based on 
@acronym{ARP} packets, it will send
 @acronym{ARP} requests and sniff for replies.")
    (home-page "https://github.com/netdiscover-scanner/netdiscover")
    (license license:gpl3+)))
+
+(define-public putty
+  (package
+    (name "putty")
+    (version "0.74.0")
+    (source (origin
+             ;; (method url-fetch)
+             (method url-fetch)
+             (uri "http://www.putty.be/0.74/putty-0.74.tar.gz")
+             (sha256 (base32 
"0zc43g8ycyf712cdrja4k8ih5s3agw1k0nq0jkifdn8xwn4d7mfx"))))
+    (arguments
+     `(#:tests?
+       #f
+       #:phases (modify-phases %standard-phases
+                 (add-before 'configure 'go-into-unix/
+                   (lambda _ (begin
+                          (chdir "unix")
+                          #t))))))
+    (build-system gnu-build-system)
+    (inputs `(("perl" ,perl)
+             ("python" ,python)
+             ("python2" ,python-2.7)
+             ("pkg-config" ,pkg-config)
+              ("gtk+" ,gtk+)))
+    (synopsis "A graphical @acronym{SSH} and telnet client")
+    (description
+     "Putty is a powerful terminal client.  It supports @acronym{SSH}, 
telnet,
+and raw socket connections with good terminal emulation. It supports 
public
+key authentication and Kerberos single-sign-on. It also includes 
command-line
+@acronym{SFTP} and @acronym{SCP} implementations.")
+    (home-page "https://www.chiark.greenend.org.uk/~sgtatham/putty/")
+    (license  (license:non-copyleft
+              
"https://www.chiark.greenend.org.uk/~sgtatham/putty/licence.html"
+              "The putty license"))))

Message #8 received at 49510 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: terramorpha <at> cock.li, 49510 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add PuTTY.
Date: Mon, 12 Jul 2021 07:42:21 +0200

Hi terramorpha,

your patch is missing the ChangeLog part of the commit message,
see `info '(guix)Submitting Patches'` for more information.

Am Samstag, den 10.07.2021, 15:31 -0400 schrieb terramorpha <at> cock.li:
> diff --git a/gnu/packages/networking.scm
> b/gnu/packages/networking.scm
> index 19b58501e9..af3082b954 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -4100,3 +4100,37 @@ on hub/switched networks.  It is based on 
> @acronym{ARP} packets, it will send
>   @acronym{ARP} requests and sniff for replies.")
>      (home-page "https://github.com/netdiscover-scanner/netdiscover")
>      (license license:gpl3+)))
> +
> +(define-public putty
> +  (package
> +    (name "putty")
> +    (version "0.74.0")
> +    (source (origin
> +             ;; (method url-fetch)
> +             (method url-fetch)
> +             (uri "http://www.putty.be/0.74/putty-0.74.tar.gz")
You ought to reuse version here, so that people don't need to rewrite
it when the version changes.  You can use "version-major+minor" to
access the "0.74" part, but I assume this is one of the versions, that
gets patch added to the tarball if it exists.  Such packages too exist
somewhere in Guix, but I haven't found an example in the quick time I'm
typing this reply.
> +             (sha256 (base32 
> "0zc43g8ycyf712cdrja4k8ih5s3agw1k0nq0jkifdn8xwn4d7mfx"))))
Please watch your line length, it normally shouldn't exceed 80
characters.
> +    (arguments
> +     `(#:tests?
> +       #f
Never let #tests? #f stay uncommented.
> +       #:phases (modify-phases %standard-phases
> +                 (add-before 'configure 'go-into-unix/
> +                   (lambda _ (begin
> +                          (chdir "unix")
> +                          #t))))))
> +    (build-system gnu-build-system)
> +    (inputs `(("perl" ,perl)
> +             ("python" ,python)
> +             ("python2" ,python-2.7)
> +             ("pkg-config" ,pkg-config)
> +              ("gtk+" ,gtk+)))
Your formatting generally looks a bit off.  #:phases should go to an
extra line, as should inputs.  #:tests? #f OTOH is okay in one line
with the aforementioned comment.
> +    (synopsis "A graphical @acronym{SSH} and telnet client")
> +    (description
> +     "Putty is a powerful terminal client.  It supports
> @acronym{SSH}, 
> telnet,
> +and raw socket connections with good terminal emulation. It
> supports 
> public
> +key authentication and Kerberos single-sign-on. It also includes 
> command-line
> +@acronym{SFTP} and @acronym{SCP} implementations.")
> +    (home-page "https://www.chiark.greenend.org.uk/~sgtatham/putty/"
> )
> +    (license  (license:non-copyleft
> +              
> "https://www.chiark.greenend.org.uk/~sgtatham/putty/licence.html"
> +              "The putty license"))))
Putty claims, that this is license:expat and it does look like one.

Regards,
Leo

Message #11 received at 49510 <at> debbugs.gnu.org (full text, mbox):

From: terramorpha <at> cock.li
To: 49510 <at> debbugs.gnu.org
Cc: leo.prikler <at> student.tugraz.at
Subject: [PATCH] gnu: Add PuTTY.
Date: Tue, 13 Jul 2021 13:25:51 -0400

Hi, thank you for the review.

I corrected the version of the package (putty doesn't use 
major.minor.patch, only major.minor),
I fixed the lines that were over the 80 character limit, re added the 
check phase, corrected the
formatting and put in the expat license. However, I do not know what you 
mean by the "ChangeLog
part of the commit message", I thought that standalone patch didn't have 
a commit message attached.
Could you elaborate?

Here is the modified patch.
diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 19b58501e9..ce00a016e6 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -4100,3 +4100,38 @@ on hub/switched networks.  It is based on 
@acronym{ARP} packets, it will send
 @acronym{ARP} requests and sniff for replies.")
    (home-page "https://github.com/netdiscover-scanner/netdiscover")
    (license license:gpl3+)))
+
+(define-public putty
+  (package
+    (name "putty")
+    (version "0.75")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "http://www.putty.be/" version
+                           "/putty-" version ".tar.gz"))
+       (sha256
+        (base32 
"1xgrr1fbirw79zafspg2b6crzfmlfw910y79md4r7gnxgq1kn5yk"))))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'go-into-unix/
+           (lambda _ (begin
+                  (chdir "unix")
+                  #t))))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("gtk+" ,gtk+)
+       ("perl" ,perl)
+       ("python" ,python)
+       ("python2" ,python-2.7)))
+    (synopsis "Graphical @acronym{SSH} and telnet client")
+    (description
+     "Putty is a powerful terminal client.  It supports @acronym{SSH}, 
telnet,
+and raw socket connections with good terminal emulation.  It supports 
public key
+authentication and Kerberos single-sign-on.  It also includes 
command-line
+@acronym{SFTP} and @acronym{SCP} implementations.")
+    (home-page "https://www.chiark.greenend.org.uk/~sgtatham/putty/")
+    (license license:expat)))

Message #14 received at 49510 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: terramorpha <at> cock.li, 49510 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add PuTTY.
Date: Tue, 13 Jul 2021 19:44:54 +0200

Am Dienstag, den 13.07.2021, 13:25 -0400 schrieb terramorpha <at> cock.li:
> Hi, thank you for the review.
> 
> I corrected the version of the package (putty doesn't use 
> major.minor.patch, only major.minor), I fixed the lines that were
> over the 80 character limit, re added the check phase, corrected the
> formatting and put in the expat license. However, I do not know what
> you mean by the "ChangeLog part of the commit message", I thought
> that standalone patch didn't have a commit message attached.
> Could you elaborate?
> 
> Here is the modified patch.
Please don't send raw diffs and more importantly don't copypaste them
into your mail client (unless you know exactly, that your mail client
behaves in a correct manner, which most don't).  Mail clients have a
tendency to mess up whitespace and line lengths, which can and does
break diffs.  Instead, use `git format-patch` and attach the generated
patch file or (the following way is preferred) use `git send-email`. 
When using format-patch/send-email, the full commit message and
name/email of the committer will be transmitted as well, not just a raw
diff.

Your second patch LGTM, perhaps with a few fixable formatting stuffs,
but I'll have to ask you to resend it, since I can't `git am` it.

Thanks,
Leo

> diff --git a/gnu/packages/networking.scm
> b/gnu/packages/networking.scm
> index 19b58501e9..ce00a016e6 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -4100,3 +4100,38 @@ on hub/switched networks.  It is based on 
> @acronym{ARP} packets, it will send
>   @acronym{ARP} requests and sniff for replies.")
>      (home-page "https://github.com/netdiscover-scanner/netdiscover")
>      (license license:gpl3+)))
> +
> +(define-public putty
> +  (package
> +    (name "putty")
> +    (version "0.75")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "http://www.putty.be/" version
> +                           "/putty-" version ".tar.gz"))
> +       (sha256
> +        (base32 
> "1xgrr1fbirw79zafspg2b6crzfmlfw910y79md4r7gnxgq1kn5yk"))))
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'go-into-unix/
> +           (lambda _ (begin
> +                  (chdir "unix")
> +                  #t))))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("gtk+" ,gtk+)
> +       ("perl" ,perl)
> +       ("python" ,python)
> +       ("python2" ,python-2.7)))
> +    (synopsis "Graphical @acronym{SSH} and telnet client")
> +    (description
> +     "Putty is a powerful terminal client.  It supports
> @acronym{SSH}, 
> telnet,
> +and raw socket connections with good terminal emulation.  It
> supports 
> public key
> +authentication and Kerberos single-sign-on.  It also includes 
> command-line
> +@acronym{SFTP} and @acronym{SCP} implementations.")
> +    (home-page "https://www.chiark.greenend.org.uk/~sgtatham/putty/"
> )
> +    (license license:expat)))

Message #17 received at 49510 <at> debbugs.gnu.org (full text, mbox):

From: terramorpha <at> cock.li
To: 49510 <at> debbugs.gnu.org
Cc: leo.prikler <at> student.tugraz.at
Subject: [PATCH] gnu: Add PuTTY.
Date: Tue, 13 Jul 2021 16:33:44 -0400

Thank you for the quick response! I attached a patched created by
`git format-patch`. Hopefully, this one will work.

Message #20 received at 49510 <at> debbugs.gnu.org (full text, mbox):

From: terramorpha <at> cock.li
To: 49510 <at> debbugs.gnu.org
Cc: leo.prikler <at> student.tugraz.at
Subject: [PATCH] gnu: Add PuTTY.
Date: Tue, 13 Jul 2021 16:49:54 -0400

Sorry for wasting your time, there seems to be a problem with my 
client's attachments.

Message #23 received at 49510 <at> debbugs.gnu.org (full text, mbox):

From: Justin Veilleux <justun1011 <at> gmail.com>
To: 49510 <at> debbugs.gnu.org
Cc: leo.prikler <at> student.tugraz.at
Subject: [PATCH]
Date: Thu, 15 Jul 2021 11:36:42 -0400

[Message part 1 (text/plain, inline)]

from another address

[Message part 2 (text/html, inline)]

[file.patch (text/x-patch, attachment)]

Message #28 received at 49510-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Justin Veilleux <justun1011 <at> gmail.com>, 49510-done <at> debbugs.gnu.org
Cc: terramorpha <terramorpha <at> cock.li>
Subject: Re: [PATCH]
Date: Thu, 15 Jul 2021 21:01:59 +0200

Hi,

I've cleaned up the patch and pushed it.

Thanks,
Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.