GNU bug report logs - #49520
[PATCH] Minor fixes to interception-tools and update dual-function-keys.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49520 in the body.
You can then email your comments to 49520 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Paul A. Patience" <paul <at> apatience.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] Minor fixes to interception-tools and update
 dual-function-keys.
Date: Sun, 11 Jul 2021 04:31:58 +0000

[Message part 1 (text/plain, inline)]

Empty Message

[0001-gnu-interception-tools-Make-minor-fixes.patch (text/x-patch, attachment)]

[0003-gnu-interception-dual-function-keys-Update-to-1.4.0.patch (text/x-patch, attachment)]

[0002-gnu-interception-dual-function-keys-Minor-fixes.patch (text/x-patch, attachment)]

Message #8 received at 49520 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Paul A. Patience" <paul <at> apatience.com>
Cc: 49520 <at> debbugs.gnu.org
Subject: Re: bug#49520: [PATCH] Minor fixes to interception-tools and update
 dual-function-keys.
Date: Mon, 26 Jul 2021 19:36:03 +0200

Hi,

"Paul A. Patience" <paul <at> apatience.com> skribis:

> From 34e0d095c51cb37a10b338586446c48eec9c7bca Mon Sep 17 00:00:00 2001
> From: "Paul A. Patience" <paul <at> apatience.com>
> Date: Sun, 11 Jul 2021 00:08:39 -0400
> Subject: [PATCH 1/3] gnu: interception-tools: Make minor fixes.
>
> * gnu/packages/linux.scm (interception-tools)[inputs]: Move boost to...
> [native-inputs]: ...here. New field.
> [license]: gpl3+ -> gpl3.


[...]

> +    (native-inputs
> +     `(("boost" ,boost)))
>      (inputs
> -     `(("boost" ,boost)
> -       ("libevdev" ,libevdev)
> +     `(("libevdev" ,libevdev)

I believe Boost should remain in ‘inputs’ or it would not be found when
cross-compiling.

> -    ;; Dual-licensed under GPLv3+ or "something else" on request, per
> +    ;; Dual-licensed under GPLv3 or "something else" on request, per
>      ;; 'README.md'.
> -    (license license:gpl3+)))
> +    (license license:gpl3)))

AFAICS, nothing in the source says “version 3 only”, so ‘gpl3+’ is correct.

It seems to me this patch can be dropped.  WDYT?

> From c324fef966098f885454f5afb0687db137d4c7d0 Mon Sep 17 00:00:00 2001
> From: "Paul A. Patience" <paul <at> apatience.com>
> Date: Sun, 11 Jul 2021 00:22:46 -0400
> Subject: [PATCH 3/3] gnu: interception-dual-function-keys: Update to 1.4.0.
> 
> * gnu/packages/linux.scm (interception-dual-function-keys)
> [version]: Update to 1.4.0.

Applied.

> From 83c06ca8d7b52c7dc7c38ed2c476ff39047f5cd2 Mon Sep 17 00:00:00 2001
> From: "Paul A. Patience" <paul <at> apatience.com>
> Date: Sun, 11 Jul 2021 00:19:56 -0400
> Subject: [PATCH 2/3] gnu: interception-dual-function-keys: Minor fixes.
>
> * gnu/packages/linux.scm (interception-dual-function-keys)
> [arguments]<#:make-flags>: Make use of cc-for-target, cxx-for-target and
> %output.
> <#:phases>{check}: Undelete phase. Disable tests instead with...
> <#:tests?>: ...this. New field.

Applied, thanks!

Ludo’.

Message #11 received at 49520 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ludovic Courtès <ludo <at> gnu.org>, "Paul A. Patience"
 <paul <at> apatience.com>
Cc: 49520 <at> debbugs.gnu.org
Subject: Re: [bug#49520] [PATCH] Minor fixes to interception-tools and
 update dual-function-keys.
Date: Mon, 26 Jul 2021 20:06:04 +0200

[Message part 1 (text/plain, inline)]

Ludovic Courtès schreef op ma 26-07-2021 om 19:36 [+0200]:
> Hi,
> 
> "Paul A. Patience" <paul <at> apatience.com> skribis:
> 
> > From 34e0d095c51cb37a10b338586446c48eec9c7bca Mon Sep 17 00:00:00 2001
> > From: "Paul A. Patience" <paul <at> apatience.com>
> > Date: Sun, 11 Jul 2021 00:08:39 -0400
> > Subject: [PATCH 1/3] gnu: interception-tools: Make minor fixes.
> > 
> > * gnu/packages/linux.scm (interception-tools)[inputs]: Move boost to...
> > [native-inputs]: ...here. New field.
> > [license]: gpl3+ -> gpl3.
> 
> [...]
> 
> > +    (native-inputs
> > +     `(("boost" ,boost)))
> >      (inputs
> > -     `(("boost" ,boost)
> > -       ("libevdev" ,libevdev)
> > +     `(("libevdev" ,libevdev)
> 
> I believe Boost should remain in ‘inputs’ or it would not be found when
> cross-compiling.
> 
> > -    ;; Dual-licensed under GPLv3+ or "something else" on request, per
> > +    ;; Dual-licensed under GPLv3 or "something else" on request, per
> >      ;; 'README.md'.
> > -    (license license:gpl3+)))
> > +    (license license:gpl3)))
> 
> AFAICS, nothing in the source says “version 3 only”, so ‘gpl3+’ is correct.

Nothing in the source mentions any version number (aside the license text 
itself), so gpl1+ is correct according to section ‘14. Revised Versions of this License’:

  [...].  If the Program does not specify a version number of the
GNU General Public License, you may choose any version ever published
by the Free Software Foundation.

This is probably not the intention of the author though,
so maybe write license:gpl3+ anyway, and ‘someone’ should submit a bug report or patch
upstream.

-- Actually, a version number is specified somewhere.  In the README
(https://gitlab.com/interception/linux/tools#license) there is a ‘GPLv3 Free Software’
icon. So GPLv1 and GPLv2 are out.  I'm not sure if GPLv4, GPLv5 ... are allowed
in this case.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 49520 <at> debbugs.gnu.org (full text, mbox):

From: "Paul A. Patience" <paul <at> apatience.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 49520 <at> debbugs.gnu.org
Subject: Re: bug#49520: [PATCH] Minor fixes to interception-tools and update
 dual-function-keys.
Date: Mon, 26 Jul 2021 23:58:48 +0000

On Monday, July 26th, 2021 at 13:36, Ludovic Courtès <ludo <at> gnu.org> wrote:
> "Paul A. Patience" <paul <at> apatience.com> skribis:
>
>> From 34e0d095c51cb37a10b338586446c48eec9c7bca Mon Sep 17 00:00:00 2001
>> From: "Paul A. Patience" <paul <at> apatience.com>
>> Date: Sun, 11 Jul 2021 00:08:39 -0400
>> Subject: [PATCH 1/3] gnu: interception-tools: Make minor fixes.
>>
>> * gnu/packages/linux.scm (interception-tools)[inputs]: Move boost to...
>> [native-inputs]: ...here. New field.
>> [license]: gpl3+ -> gpl3.

<snip>

> It seems to me this patch can be dropped.  WDYT?

Sounds good.

Thanks,
Paul

Message #17 received at 49520 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 49520 <at> debbugs.gnu.org, "Paul A. Patience" <paul <at> apatience.com>
Subject: Re: [bug#49520] [PATCH] Minor fixes to interception-tools and
 update dual-function-keys.
Date: Tue, 27 Jul 2021 12:05:15 +0200

Hi Maxime,

Maxime Devos <maximedevos <at> telenet.be> skribis:

> Ludovic Courtès schreef op ma 26-07-2021 om 19:36 [+0200]:

[...]

>> > -    ;; Dual-licensed under GPLv3+ or "something else" on request, per
>> > +    ;; Dual-licensed under GPLv3 or "something else" on request, per
>> >      ;; 'README.md'.
>> > -    (license license:gpl3+)))
>> > +    (license license:gpl3)))
>> 
>> AFAICS, nothing in the source says “version 3 only”, so ‘gpl3+’ is correct.
>
> Nothing in the source mentions any version number (aside the license text 
> itself), so gpl1+ is correct according to section ‘14. Revised Versions of this License’:
>
>   [...].  If the Program does not specify a version number of the
> GNU General Public License, you may choose any version ever published
> by the Free Software Foundation.

I agree, though the way we encode it in Guix is ‘gpl3+’.

> -- Actually, a version number is specified somewhere.  In the README
> (https://gitlab.com/interception/linux/tools#license) there is a ‘GPLv3 Free Software’
> icon. So GPLv1 and GPLv2 are out.  I'm not sure if GPLv4, GPLv5 ... are allowed
> in this case.

My interpretation is that it’s “version 3 or later”.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.