GNU bug report logs - #49521
[PATCH] gnu: java-xz: Update to 1.9.

Previous Next

Package: guix-patches;

Reported by: Efraim Flashner <efraim <at> flashner.co.il>

Date: Sun, 11 Jul 2021 11:51:01 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49521 in the body.
You can then email your comments to 49521 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#49521; Package guix-patches. (Sun, 11 Jul 2021 11:51:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Efraim Flashner <efraim <at> flashner.co.il>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 11 Jul 2021 11:51:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: guix-patches <at> gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [PATCH] gnu: java-xz: Update to 1.9.
Date: Sun, 11 Jul 2021 14:48:22 +0300

* gnu/packages/java-compression.scm (java-xz): Update to 1.9.
[arguments]: Build with openjdk9.
---
 gnu/packages/java-compression.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/java-compression.scm b/gnu/packages/java-compression.scm
index 19b11954c1..033b55c988 100644
--- a/gnu/packages/java-compression.scm
+++ b/gnu/packages/java-compression.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2018 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2018 Mark H Weaver <mhw <at> netris.org>
 ;;; Copyright © 2018, 2020 Tobias Geerinckx-Rice <me <at> tobias.gr>
+;;; Copyright © 2021 Efraim Flashner <efraim <at> flashner.co.il>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -289,16 +290,17 @@ It can be used as a replacement for the Apache @code{CBZip2InputStream} /
 (define-public java-xz
   (package
     (name "java-xz")
-    (version "1.6")
+    (version "1.9")
     (source (origin
               (method url-fetch/zipbomb)
               (uri (string-append "https://tukaani.org/xz/xz-java-" version ".zip"))
               (sha256
                (base32
-                "1z3p1ri1gvl07inxn0agx44ck8n7wrzfmvkz8nbq3njn8r9wba8x"))))
+                "007d9f83277qn70swz9inqhyf0qxq6ygajpq5rqg0xgsyh1sdndi"))))
     (build-system ant-build-system)
     (arguments
      `(#:tests? #f; no tests
+       #:jdk ,openjdk9
        #:phases
        (modify-phases %standard-phases
          (add-before 'install 'generate-pom

base-commit: 7760d28920a920791645c4485f1345af45ee7787
-- 
2.32.0
Information forwarded to guix-patches <at> gnu.org:
bug#49521; Package guix-patches. (Sun, 11 Jul 2021 16:10:01 GMT) Full text and rfc822 format available.

Message #8 received at 49521 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Efraim Flashner <efraim <at> flashner.co.il>,49521 <at> debbugs.gnu.org
Subject: Re: [bug#49521] [PATCH] gnu: java-xz: Update to 1.9.
Date: Sun, 11 Jul 2021 12:08:35 -0400

Le 11 juillet 2021 07:48:22 GMT-04:00, Efraim Flashner <efraim <at> flashner.co.il> a écrit :
>* gnu/packages/java-compression.scm (java-xz): Update to 1.9.
>[arguments]: Build with openjdk9.
>---
> gnu/packages/java-compression.scm | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/gnu/packages/java-compression.scm
>b/gnu/packages/java-compression.scm
>index 19b11954c1..033b55c988 100644
>--- a/gnu/packages/java-compression.scm
>+++ b/gnu/packages/java-compression.scm
>@@ -4,6 +4,7 @@
> ;;; Copyright © 2018 Marius Bakke <mbakke <at> fastmail.com>
> ;;; Copyright © 2018 Mark H Weaver <mhw <at> netris.org>
> ;;; Copyright © 2018, 2020 Tobias Geerinckx-Rice <me <at> tobias.gr>
>+;;; Copyright © 2021 Efraim Flashner <efraim <at> flashner.co.il>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
>@@ -289,16 +290,17 @@ It can be used as a replacement for the Apache
>@code{CBZip2InputStream} /
> (define-public java-xz
>   (package
>     (name "java-xz")
>-    (version "1.6")
>+    (version "1.9")
>     (source (origin
>               (method url-fetch/zipbomb)
> (uri (string-append "https://tukaani.org/xz/xz-java-" version ".zip"))
>               (sha256
>                (base32
>-               
>"1z3p1ri1gvl07inxn0agx44ck8n7wrzfmvkz8nbq3njn8r9wba8x"))))
>+               
>"007d9f83277qn70swz9inqhyf0qxq6ygajpq5rqg0xgsyh1sdndi"))))
>     (build-system ant-build-system)
>     (arguments
>      `(#:tests? #f; no tests
>+       #:jdk ,openjdk9
>        #:phases
>        (modify-phases %standard-phases
>          (add-before 'install 'generate-pom
>
>base-commit: 7760d28920a920791645c4485f1345af45ee7787

Looks good, but building dependents will likely cause issues if they still use openjdk8. At the very least, we'll see a warning.
Information forwarded to guix-patches <at> gnu.org:
bug#49521; Package guix-patches. (Mon, 12 Jul 2021 12:40:02 GMT) Full text and rfc822 format available.

Message #11 received at 49521 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 49521 <at> debbugs.gnu.org
Subject: Re: [bug#49521] [PATCH] gnu: java-xz: Update to 1.9.
Date: Mon, 12 Jul 2021 15:38:14 +0300

[Message part 1 (text/plain, inline)]
On Sun, Jul 11, 2021 at 12:08:35PM -0400, Julien Lepiller wrote:
> Le 11 juillet 2021 07:48:22 GMT-04:00, Efraim Flashner <efraim <at> flashner.co.il> a écrit :
> >* gnu/packages/java-compression.scm (java-xz): Update to 1.9.
> >[arguments]: Build with openjdk9.
> >---
> > gnu/packages/java-compression.scm | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> >diff --git a/gnu/packages/java-compression.scm
> >b/gnu/packages/java-compression.scm
> >index 19b11954c1..033b55c988 100644
> >--- a/gnu/packages/java-compression.scm
> >+++ b/gnu/packages/java-compression.scm
> >@@ -4,6 +4,7 @@
> > ;;; Copyright © 2018 Marius Bakke <mbakke <at> fastmail.com>
> > ;;; Copyright © 2018 Mark H Weaver <mhw <at> netris.org>
> > ;;; Copyright © 2018, 2020 Tobias Geerinckx-Rice <me <at> tobias.gr>
> >+;;; Copyright © 2021 Efraim Flashner <efraim <at> flashner.co.il>
> > ;;;
> > ;;; This file is part of GNU Guix.
> > ;;;
> >@@ -289,16 +290,17 @@ It can be used as a replacement for the Apache
> >@code{CBZip2InputStream} /
> > (define-public java-xz
> >   (package
> >     (name "java-xz")
> >-    (version "1.6")
> >+    (version "1.9")
> >     (source (origin
> >               (method url-fetch/zipbomb)
> > (uri (string-append "https://tukaani.org/xz/xz-java-" version ".zip"))
> >               (sha256
> >                (base32
> >-               
> >"1z3p1ri1gvl07inxn0agx44ck8n7wrzfmvkz8nbq3njn8r9wba8x"))))
> >+               
> >"007d9f83277qn70swz9inqhyf0qxq6ygajpq5rqg0xgsyh1sdndi"))))
> >     (build-system ant-build-system)
> >     (arguments
> >      `(#:tests? #f; no tests
> >+       #:jdk ,openjdk9
> >        #:phases
> >        (modify-phases %standard-phases
> >          (add-before 'install 'generate-pom
> >
> >base-commit: 7760d28920a920791645c4485f1345af45ee7787
> 
> Looks good, but building dependents will likely cause issues if they still use openjdk8. At the very least, we'll see a warning.

Is that a problem? Starting with 1.9 they added some code that needs
java 9 to compile. I test built the 4 packages which directly depend on
java-xz and they built without problems.

¹https://git.tukaani.org/?p=xz-java.git;a=blob;f=NEWS;h=d18a53b23efdae4b7d2911ef7898189462fac689;hb=HEAD

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#49521; Package guix-patches. (Mon, 12 Jul 2021 12:43:02 GMT) Full text and rfc822 format available.

Message #14 received at 49521 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 49521 <at> debbugs.gnu.org
Subject: Re: [bug#49521] [PATCH] gnu: java-xz: Update to 1.9.
Date: Mon, 12 Jul 2021 08:42:32 -0400

Le 12 juillet 2021 08:38:14 GMT-04:00, Efraim Flashner <efraim <at> flashner.co.il> a écrit :
>On Sun, Jul 11, 2021 at 12:08:35PM -0400, Julien Lepiller wrote:
>> Le 11 juillet 2021 07:48:22 GMT-04:00, Efraim Flashner
><efraim <at> flashner.co.il> a écrit :
>> >* gnu/packages/java-compression.scm (java-xz): Update to 1.9.
>> >[arguments]: Build with openjdk9.
>> >---
>> > gnu/packages/java-compression.scm | 6 ++++--
>> > 1 file changed, 4 insertions(+), 2 deletions(-)
>> >
>> >diff --git a/gnu/packages/java-compression.scm
>> >b/gnu/packages/java-compression.scm
>> >index 19b11954c1..033b55c988 100644
>> >--- a/gnu/packages/java-compression.scm
>> >+++ b/gnu/packages/java-compression.scm
>> >@@ -4,6 +4,7 @@
>> > ;;; Copyright © 2018 Marius Bakke <mbakke <at> fastmail.com>
>> > ;;; Copyright © 2018 Mark H Weaver <mhw <at> netris.org>
>> > ;;; Copyright © 2018, 2020 Tobias Geerinckx-Rice <me <at> tobias.gr>
>> >+;;; Copyright © 2021 Efraim Flashner <efraim <at> flashner.co.il>
>> > ;;;
>> > ;;; This file is part of GNU Guix.
>> > ;;;
>> >@@ -289,16 +290,17 @@ It can be used as a replacement for the Apache
>> >@code{CBZip2InputStream} /
>> > (define-public java-xz
>> >   (package
>> >     (name "java-xz")
>> >-    (version "1.6")
>> >+    (version "1.9")
>> >     (source (origin
>> >               (method url-fetch/zipbomb)
>> > (uri (string-append "https://tukaani.org/xz/xz-java-" version
>".zip"))
>> >               (sha256
>> >                (base32
>> >-               
>> >"1z3p1ri1gvl07inxn0agx44ck8n7wrzfmvkz8nbq3njn8r9wba8x"))))
>> >+               
>> >"007d9f83277qn70swz9inqhyf0qxq6ygajpq5rqg0xgsyh1sdndi"))))
>> >     (build-system ant-build-system)
>> >     (arguments
>> >      `(#:tests? #f; no tests
>> >+       #:jdk ,openjdk9
>> >        #:phases
>> >        (modify-phases %standard-phases
>> >          (add-before 'install 'generate-pom
>> >
>> >base-commit: 7760d28920a920791645c4485f1345af45ee7787
>> 
>> Looks good, but building dependents will likely cause issues if they
>still use openjdk8. At the very least, we'll see a warning.
>
>Is that a problem? Starting with 1.9 they added some code that needs
>java 9 to compile. I test built the 4 packages which directly depend on
>java-xz and they built without problems.
>
>¹https://git.tukaani.org/?p=xz-java.git;a=blob;f=NEWS;h=d18a53b23efdae4b7d2911ef7898189462fac689;hb=HEAD

If dependents build fine, it should work.
Reply sent to Efraim Flashner <efraim <at> flashner.co.il>:
You have taken responsibility. (Mon, 12 Jul 2021 14:00:02 GMT) Full text and rfc822 format available.
Notification sent to Efraim Flashner <efraim <at> flashner.co.il>:
bug acknowledged by developer. (Mon, 12 Jul 2021 14:00:02 GMT) Full text and rfc822 format available.

Message #19 received at 49521-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 49521-done <at> debbugs.gnu.org
Subject: Re: [bug#49521] [PATCH] gnu: java-xz: Update to 1.9.
Date: Mon, 12 Jul 2021 16:57:53 +0300

[Message part 1 (text/plain, inline)]
On Mon, Jul 12, 2021 at 08:42:32AM -0400, Julien Lepiller wrote:
> If dependents build fine, it should work.

Thanks. Patch pushed.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 10 Aug 2021 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 260 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.