GNU logs - #49533, boring messages


Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#49533] [PATCH] gnu: Add omins-lv2.
Resent-From: Thorsten Wilms <t_w_@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 12 Jul 2021 09:46:02 +0000
Resent-Message-ID: <handler.49533.B.16260831585284 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 49533
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 49533 <at> debbugs.gnu.org
Cc: Thorsten Wilms <t_w_@HIDDEN>
X-Debbugs-Original-To: guix-patches@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.16260831585284
          (code B ref -1); Mon, 12 Jul 2021 09:46:02 +0000
Received: (at submit) by debbugs.gnu.org; 12 Jul 2021 09:45:58 +0000
Received: from localhost ([127.0.0.1]:36609 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1m2sVa-0001My-W0
	for submit <at> debbugs.gnu.org; Mon, 12 Jul 2021 05:45:58 -0400
Received: from lists.gnu.org ([209.51.188.17]:51348)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=08272a2575=t_w_@HIDDEN>) id 1m2sVW-0001Mo-6x
 for submit <at> debbugs.gnu.org; Mon, 12 Jul 2021 05:45:49 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:60918)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <prvs=08272a2575=t_w_@HIDDEN>)
 id 1m2sVR-0004C4-H5
 for guix-patches@HIDDEN; Mon, 12 Jul 2021 05:45:45 -0400
Received: from mout1.freenet.de ([2001:748:100:40::2:3]:38072)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
 (Exim 4.90_1) (envelope-from <prvs=08272a2575=t_w_@HIDDEN>)
 id 1m2sVP-0004v1-DL
 for guix-patches@HIDDEN; Mon, 12 Jul 2021 05:45:41 -0400
Received: from [195.4.92.122] (helo=sub3.freenet.de)
 by mout1.freenet.de with esmtpa (ID t_w_@HIDDEN) (port 25) (Exim 4.92
 #3) id 1m2sVJ-0002zy-Aw
 for guix-patches@HIDDEN; Mon, 12 Jul 2021 11:45:33 +0200
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freenet.de; 
 s=mjaymdexmjqk;
 h=Content-Transfer-Encoding:Content-Type:MIME-Version:
 Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=56hDjMDevBvQwSIpH6aexK+8llP3HMCZzORwn5XRiuM=; b=y/9HOcN7nBswuMMyqOLG7FzJmv
 qfk+/0zpekhdrDcWfM7XUPQq4AAbp2sUZSpDt/d+b/UaREenWo0JDttutjhU7Dp3GtfeA9cq6fG+F
 y7+n7ZZOdJeNBjDAx7RoRhkOR3Tv8M8EKmqujx8Ykh2QV4mpQkXBakh5nit9dLn0m97/5hNUynV+U
 LyZX+sEBjS9wLR9C56PC0TKY6OE1U9xcHoEWJYJjkdxkiwmLgQQgWWTeFh8iPTC1NeKeXduDfa+KB
 Jo5GEarGA6lGPoQAx6z2f4qcLnfMroPxi8bmqw1Yd1B92yl8ys1GDLkrs//TWWDG3WOorDv2A8rmK
 /jBzQ5Yw==;
Received: from p200300e4f7134400d82a174c2581a750.dip0.t-ipconnect.de
 ([2003:e4:f713:4400:d82a:174c:2581:a750]:41320 helo=tango.fritz.box)
 by sub3.freenet.de with esmtpsa (ID t_w_@HIDDEN)
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (port 465) (Exim 4.92 #3)
 id 1m2sVJ-0005IP-8J; Mon, 12 Jul 2021 11:45:33 +0200
From: Thorsten Wilms <t_w_@HIDDEN>
Date: Mon, 12 Jul 2021 11:45:06 +0200
Message-Id: <20210712094506.6432-1-t_w_@HIDDEN>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Originated-At: 2003:e4:f713:4400:d82a:174c:2581:a750!41320
X-FNSign: v=2
 s=6CCF7411C113BBDC6CCA65A42215E3C19EAD0D67E4BE43905A71A2FBF8E7F5EE
X-Scan-TS: Mon, 12 Jul 2021 11:45:33 +0200
Received-SPF: pass client-ip=2001:748:100:40::2:3;
 envelope-from=prvs=08272a2575=t_w_@HIDDEN; helo=mout1.freenet.de
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

* gnu/packages/audio.scm (omins-lv2): New variable.
---
 gnu/packages/audio.scm | 38 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 37 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 3939d4bc7e..8eceb839ad 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -15,7 +15,7 @@
 ;;; Copyright © 2018 Clément Lassieur <clement@HIDDEN>
 ;;; Copyright © 2018 Brett Gilio <brettg@HIDDEN>
 ;;; Copyright © 2018, 2019 Marius Bakke <mbakke@HIDDEN>
-;;; Copyright © 2018 Thorsten Wilms <t_w_@HIDDEN>
+;;; Copyright © 2018, 2021 Thorsten Wilms <t_w_@HIDDEN>
 ;;; Copyright © 2018 Eric Bavier <bavier@HIDDEN>
 ;;; Copyright © 2018 Brendan Tildesley <mail@HIDDEN>
 ;;; Copyright © 2019, 2021 Pierre Langlois <pierre.langlois@HIDDEN>
@@ -5410,3 +5410,39 @@ device.  There is support for mono and/or stereo and 8 or 16 bit samples.")
      "MDA-LV2 is an LV2 port of the MDA plugins.  It includes effects and a few
 instrument plugins.")
     (license license:gpl3+)))
+
+(define-public omins-lv2
+  (package
+   (name "omins-lv2")
+   ;; No release despite being perfectly usable. 0.0.0 seems to be the only
+   ;; version the author ever specified:
+   (version "0.0.0")
+   (source
+    (origin
+     (method git-fetch)
+     (uri
+      (git-reference
+       (url "https://git.drobilla.net/cgit.cgi/omins.lv2.git/")
+       (commit "058f341053067b69a84d4081107fda5058290ff9")))
+     (file-name (git-file-name name version))
+     (sha256
+      (base32 "01hnx4hhbz3ap3bw15s42q4q1mw1mhdjwygq4550wvjfg6k4ga8w"))))
+   (build-system waf-build-system)
+   (arguments
+    `(#:tests? #f  ; There are no tests.
+      #:configure-flags
+      (list (string-append "--prefix="
+			   (assoc-ref %outputs "out")))))
+   (inputs
+    `(("lv2" ,lv2)))
+   (native-inputs
+    `(("pkg-config" ,pkg-config)))
+   (native-search-paths
+    (list (search-path-specification
+           (variable "LV2_PATH")
+           (files '("lib/lv2")))))
+   (home-page "https://git.drobilla.net/cgit.cgi/omins.lv2.git/")
+   (synopsis "LV2 audio plugins for modular synthesis")
+   (description
+    "Omins-lv2 is a small collection of LV2 audio plugins for modular synthesis.")
+   (license (list license:gpl2+ license:gpl2+))))
-- 
2.32.0





Message sent:


Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Thorsten Wilms <t_w_@HIDDEN>
Subject: bug#49533: Acknowledgement ([PATCH] gnu: Add omins-lv2.)
Message-ID: <handler.49533.B.16260831585284.ack <at> debbugs.gnu.org>
References: <20210712094506.6432-1-t_w_@HIDDEN>
X-Gnu-PR-Message: ack 49533
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 49533 <at> debbugs.gnu.org
Date: Mon, 12 Jul 2021 09:46:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 49533 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
49533: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D49533
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems


Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#49533] [PATCH] gnu: Add omins-lv2.
Resent-From: Sarah Morgensen <iskarian@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 22 Jul 2021 04:16:02 +0000
Resent-Message-ID: <handler.49533.B49533.16269273139869 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 49533
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Thorsten Wilms <t_w_@HIDDEN>
Cc: 49533 <at> debbugs.gnu.org
Received: via spool by 49533-submit <at> debbugs.gnu.org id=B49533.16269273139869
          (code B ref 49533); Thu, 22 Jul 2021 04:16:02 +0000
Received: (at 49533) by debbugs.gnu.org; 22 Jul 2021 04:15:13 +0000
Received: from localhost ([127.0.0.1]:39145 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1m6Q6z-0002Yp-Oe
	for submit <at> debbugs.gnu.org; Thu, 22 Jul 2021 00:15:13 -0400
Received: from out0.migadu.com ([94.23.1.103]:17926)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <iskarian@HIDDEN>) id 1m6Q6x-0002Yg-N2
 for 49533 <at> debbugs.gnu.org; Thu, 22 Jul 2021 00:15:05 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1;
 t=1626927302;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=1iNv5XjmC+ayYsAJCxGCnPaxrmx+DHZDZsvud0HWvZ4=;
 b=eAWto9BkNcmBwZmvq4Dazw+trPpLGn5G0/RJiy9UkPEZhEhM1TlkVkOSgOCXEVRFKNn8AJ
 mSwcpMrIoUKXpQ8Hba76Jn9wDT94qFIxhRm/Bv/kK1jI267gSKHai7icRNGKzektYGVlOb
 WrCHWKCv4oWSwNa3d05fu6QkURMJWKM=
From: Sarah Morgensen <iskarian@HIDDEN>
References: <20210712094506.6432-1-t_w_@HIDDEN>
Date: Wed, 21 Jul 2021 21:15:00 -0700
In-Reply-To: <20210712094506.6432-1-t_w_@HIDDEN> (Thorsten Wilms's message
 of "Mon, 12 Jul 2021 11:45:06 +0200")
Message-ID: <86fsw7rnln.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: iskarian@HIDDEN
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

Thanks for the patch. Just a quick comment...

Thorsten Wilms <t_w_@HIDDEN> writes:

> * gnu/packages/audio.scm (omins-lv2): New variable.
> ---
>  gnu/packages/audio.scm | 38 +++++++++++++++++++++++++++++++++++++-
>  1 file changed, 37 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 3939d4bc7e..8eceb839ad 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -15,7 +15,7 @@
>  ;;; Copyright =C2=A9 2018 Cl=C3=A9ment Lassieur <clement@HIDDEN>
>  ;;; Copyright =C2=A9 2018 Brett Gilio <brettg@HIDDEN>
>  ;;; Copyright =C2=A9 2018, 2019 Marius Bakke <mbakke@HIDDEN>
> -;;; Copyright =C2=A9 2018 Thorsten Wilms <t_w_@HIDDEN>
> +;;; Copyright =C2=A9 2018, 2021 Thorsten Wilms <t_w_@HIDDEN>
>  ;;; Copyright =C2=A9 2018 Eric Bavier <bavier@HIDDEN>
>  ;;; Copyright =C2=A9 2018 Brendan Tildesley <mail@HIDDEN>
>  ;;; Copyright =C2=A9 2019, 2021 Pierre Langlois <pierre.langlois@HIDDEN>
> @@ -5410,3 +5410,39 @@ device.  There is support for mono and/or stereo a=
nd 8 or 16 bit samples.")
>       "MDA-LV2 is an LV2 port of the MDA plugins.  It includes effects an=
d a few
>  instrument plugins.")
>      (license license:gpl3+)))
> +
> +(define-public omins-lv2
> +  (package
> +   (name "omins-lv2")
> +   ;; No release despite being perfectly usable. 0.0.0 seems to be the o=
nly
> +   ;; version the author ever specified:
> +   (version "0.0.0")
> +   (source
> +    (origin
> +     (method git-fetch)
> +     (uri
> +      (git-reference
> +       (url "https://git.drobilla.net/cgit.cgi/omins.lv2.git/")
> +       (commit "058f341053067b69a84d4081107fda5058290ff9")))
> +     (file-name (git-file-name name version))
> +     (sha256
> +      (base32 "01hnx4hhbz3ap3bw15s42q4q1mw1mhdjwygq4550wvjfg6k4ga8w"))))
> +   (build-system waf-build-system)
> +   (arguments
> +    `(#:tests? #f  ; There are no tests.
> +      #:configure-flags
> +      (list (string-append "--prefix=3D"
> +			   (assoc-ref %outputs "out")))))

Setting --prefix shouldn't be necessary, as the build systems usually
add that themselves. (And yep, just tried building without it, and the
outputs are identical.)

> +   (inputs
> +    `(("lv2" ,lv2)))
> +   (native-inputs
> +    `(("pkg-config" ,pkg-config)))
> +   (native-search-paths
> +    (list (search-path-specification
> +           (variable "LV2_PATH")
> +           (files '("lib/lv2")))))
> +   (home-page "https://git.drobilla.net/cgit.cgi/omins.lv2.git/")
> +   (synopsis "LV2 audio plugins for modular synthesis")
> +   (description
> +    "Omins-lv2 is a small collection of LV2 audio plugins for modular sy=
nthesis.")
> +   (license (list license:gpl2+ license:gpl2+))))

--
Sarah




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#49533] [PATCH v2] gnu: Add omins-lv2.
Resent-From: Thorsten Wilms <t_w_@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 24 Jul 2021 19:42:02 +0000
Resent-Message-ID: <handler.49533.B49533.162715570318443 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 49533
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 49533 <at> debbugs.gnu.org
Cc: Thorsten Wilms <t_w_@HIDDEN>
Received: via spool by 49533-submit <at> debbugs.gnu.org id=B49533.162715570318443
          (code B ref 49533); Sat, 24 Jul 2021 19:42:02 +0000
Received: (at 49533) by debbugs.gnu.org; 24 Jul 2021 19:41:43 +0000
Received: from localhost ([127.0.0.1]:47087 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1m7NWp-0004nP-6y
	for submit <at> debbugs.gnu.org; Sat, 24 Jul 2021 15:41:43 -0400
Received: from mout2.freenet.de ([195.4.92.92]:50022)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=0839e319e8=t_w_@HIDDEN>) id 1m7NWk-0004nE-CV
 for 49533 <at> debbugs.gnu.org; Sat, 24 Jul 2021 15:41:42 -0400
Received: from [195.4.92.123] (helo=sub4.freenet.de)
 by mout2.freenet.de with esmtpa (ID t_w_@HIDDEN) (port 25) (Exim 4.92
 #3) id 1m7NWi-000Hu3-PG
 for 49533 <at> debbugs.gnu.org; Sat, 24 Jul 2021 21:41:36 +0200
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freenet.de; 
 s=mjaymdexmjqk;
 h=Content-Transfer-Encoding:MIME-Version:References:
 In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=q5pdvgH8z/xrCUaWC6iZDyC5gViywCm6gdJLCeir89I=; b=gHPxM1vqqdUgMAtSae5HuvxnAZ
 AzJ8CL2w1dykuHjqwR3BNc2XRtuxJ8UsfUq1tTZ3Pg9KOgrje4lLSYklcJa/9AtbrmAtbLlIbsqZ9
 gXKjzSZXHYjolz5v42nGloReljps8pwqys2SSqRGy2DdfdmQHpLTCHixbfl+jJzSaZVsYJhQOR+Yl
 fMmJPy6e2cqokQIao/pwmMbojhZeymte1suHCBXaagyruX1uZTJUy+uihYezYWnZDh13xnbN3hded
 yovYMPyclk/KIY6KBi0y8pG7ub8mgIFM6IV9InYF5wPXIhh+y/cHT6n6Ng00MLXzN7+QGqfrAjFgh
 58k6ms0w==;
Received: from p200300e4f713440009784e496776cfc0.dip0.t-ipconnect.de
 ([2003:e4:f713:4400:978:4e49:6776:cfc0]:56046 helo=tango.fritz.box)
 by sub4.freenet.de with esmtpsa (ID t_w_@HIDDEN)
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (port 465) (Exim 4.92 #3)
 id 1m7NWi-0004j7-N4; Sat, 24 Jul 2021 21:41:36 +0200
From: Thorsten Wilms <t_w_@HIDDEN>
Date: Sat, 24 Jul 2021 21:41:17 +0200
Message-Id: <20210724194117.8372-1-t_w_@HIDDEN>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <86fsw7rnln.fsf@HIDDEN>
References: <86fsw7rnln.fsf@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Originated-At: 2003:e4:f713:4400:978:4e49:6776:cfc0!56046
X-FNSign: v=2
 s=DEA93A47DD14FFC75237DC115AECE7C8D7D71C5BBFAAC4E5941FAD3E209B9DB1
X-Scan-TS: Sat, 24 Jul 2021 21:41:36 +0200
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/audio.scm (omins-lv2): New variable.
---
Thanks to Sarah for having a look and noticing the superfluous --prefix.

 gnu/packages/audio.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 3939d4bc7e..b5471c9d3d 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -5410,3 +5410,36 @@ device.  There is support for mono and/or stereo and 8 or 16 bit samples.")
      "MDA-LV2 is an LV2 port of the MDA plugins.  It includes effects and a few
 instrument plugins.")
     (license license:gpl3+)))
+
+(define-public omins-lv2
+  (package
+   (name "omins-lv2")
+   ;; No release despite being perfectly usable. 0.0.0 seems to be the only
+   ;; version the author ever specified:
+   (version "0.0.0")
+   (source
+    (origin
+     (method git-fetch)
+     (uri
+      (git-reference
+       (url "https://git.drobilla.net/cgit.cgi/omins.lv2.git/")
+       (commit "058f341053067b69a84d4081107fda5058290ff9")))
+     (file-name (git-file-name name version))
+     (sha256
+      (base32 "01hnx4hhbz3ap3bw15s42q4q1mw1mhdjwygq4550wvjfg6k4ga8w"))))
+   (build-system waf-build-system)
+   (arguments
+    `(#:tests? #f)) ; There are no tests.
+   (inputs
+    `(("lv2" ,lv2)))
+   (native-inputs
+    `(("pkg-config" ,pkg-config)))
+   (native-search-paths
+    (list (search-path-specification
+           (variable "LV2_PATH")
+           (files '("lib/lv2")))))
+   (home-page "https://git.drobilla.net/cgit.cgi/omins.lv2.git/")
+   (synopsis "LV2 audio plugins for modular synthesis")
+   (description
+    "Omins-lv2 is a small collection of LV2 audio plugins for modular synthesis.")
+   (license (list license:gpl2+ license:gpl2+))))
-- 
2.32.0





Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#49533] [PATCH] gnu: Add omins-lv2.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 29 Jul 2021 19:54:01 +0000
Resent-Message-ID: <handler.49533.B49533.162758841728154 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 49533
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Thorsten Wilms <t_w_@HIDDEN>
Cc: Ricardo Wurmus <rekado@HIDDEN>, 49533 <at> debbugs.gnu.org, Sarah Morgensen <iskarian@HIDDEN>
Received: via spool by 49533-submit <at> debbugs.gnu.org id=B49533.162758841728154
          (code B ref 49533); Thu, 29 Jul 2021 19:54:01 +0000
Received: (at 49533) by debbugs.gnu.org; 29 Jul 2021 19:53:37 +0000
Received: from localhost ([127.0.0.1]:58337 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1m9C65-0007K2-4k
	for submit <at> debbugs.gnu.org; Thu, 29 Jul 2021 15:53:37 -0400
Received: from eggs.gnu.org ([209.51.188.92]:50254)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1m9C63-0007Jo-NH
 for 49533 <at> debbugs.gnu.org; Thu, 29 Jul 2021 15:53:36 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:46996)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@HIDDEN>)
 id 1m9C5x-0003m9-SA; Thu, 29 Jul 2021 15:53:29 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45326 helo=ribbon)
 by fencepost.gnu.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 (envelope-from <ludo@HIDDEN>)
 id 1m9C5x-0002pX-HW; Thu, 29 Jul 2021 15:53:29 -0400
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <86fsw7rnln.fsf@HIDDEN> <20210724194117.8372-1-t_w_@HIDDEN>
Date: Thu, 29 Jul 2021 21:53:28 +0200
In-Reply-To: <20210724194117.8372-1-t_w_@HIDDEN> (Thorsten Wilms's message
 of "Sat, 24 Jul 2021 21:41:17 +0200")
Message-ID: <874kcc28xz.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi Thorsten,

Thorsten Wilms <t_w_@HIDDEN> skribis:

> * gnu/packages/audio.scm (omins-lv2): New variable.

It LGTM, modulo minor issues:

> +(define-public omins-lv2
> +  (package
> +   (name "omins-lv2")

Please consider passing it through ./etc/indent-code.el:

  https://guix.gnu.org/manual/en/html_node/Formatting-Code.html

> +   ;; No release despite being perfectly usable. 0.0.0 seems to be the o=
nly
> +   ;; version the author ever specified:
> +   (version "0.0.0")
> +   (source
> +    (origin
> +     (method git-fetch)
> +     (uri
> +      (git-reference
> +       (url "https://git.drobilla.net/cgit.cgi/omins.lv2.git/")
> +       (commit "058f341053067b69a84d4081107fda5058290ff9")))

Please check out
<https://guix.gnu.org/manual/en/html_node/Version-Numbers.html> on how
to compute version numbers in such cases.

> +   (native-search-paths
> +    (list (search-path-specification
> +           (variable "LV2_PATH")
> +           (files '("lib/lv2")))))

I=E2=80=99m surprised this is here (in the plugin) rather than in the packa=
ge
that loads this plugin.  There are other LV2 plugins doing that though.
Ricardo, WDYT?

> +   (license (list license:gpl2+ license:gpl2+))))

(license license:gpl2+) should be enough.  :-)

Could you send an updated patch?

Thank you, and thanks, Sarah!

Ludo=E2=80=99.




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#49533] [PATCH] gnu: Add omins-lv2.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 01 Sep 2021 21:30:02 +0000
Resent-Message-ID: <handler.49533.B49533.163053177013321 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 49533
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Thorsten Wilms <t_w_@HIDDEN>
Cc: Ricardo Wurmus <rekado@HIDDEN>, 49533 <at> debbugs.gnu.org, Sarah Morgensen <iskarian@HIDDEN>
Received: via spool by 49533-submit <at> debbugs.gnu.org id=B49533.163053177013321
          (code B ref 49533); Wed, 01 Sep 2021 21:30:02 +0000
Received: (at 49533) by debbugs.gnu.org; 1 Sep 2021 21:29:30 +0000
Received: from localhost ([127.0.0.1]:39116 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mLXnW-0003Sl-DY
	for submit <at> debbugs.gnu.org; Wed, 01 Sep 2021 17:29:30 -0400
Received: from eggs.gnu.org ([209.51.188.92]:49984)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1mLXnU-0003SL-Hl
 for 49533 <at> debbugs.gnu.org; Wed, 01 Sep 2021 17:29:29 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:38704)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@HIDDEN>)
 id 1mLXnN-0008Dg-MW; Wed, 01 Sep 2021 17:29:21 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48828 helo=ribbon)
 by fencepost.gnu.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 (envelope-from <ludo@HIDDEN>)
 id 1mLXnM-0007KY-M6; Wed, 01 Sep 2021 17:29:21 -0400
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <86fsw7rnln.fsf@HIDDEN> <20210724194117.8372-1-t_w_@HIDDEN>
 <874kcc28xz.fsf_-_@HIDDEN>
Date: Wed, 01 Sep 2021 23:29:18 +0200
In-Reply-To: <874kcc28xz.fsf_-_@HIDDEN> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 29 Jul 2021 21:53:28 +0200")
Message-ID: <87y28g56j5.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi Thorsten,

Did you have a chance to look into this?

Thanks,
Ludo=E2=80=99.

Ludovic Court=C3=A8s <ludo@HIDDEN> skribis:

> Hi Thorsten,
>
> Thorsten Wilms <t_w_@HIDDEN> skribis:
>
>> * gnu/packages/audio.scm (omins-lv2): New variable.
>
> It LGTM, modulo minor issues:
>
>> +(define-public omins-lv2
>> +  (package
>> +   (name "omins-lv2")
>
> Please consider passing it through ./etc/indent-code.el:
>
>   https://guix.gnu.org/manual/en/html_node/Formatting-Code.html
>
>> +   ;; No release despite being perfectly usable. 0.0.0 seems to be the =
only
>> +   ;; version the author ever specified:
>> +   (version "0.0.0")
>> +   (source
>> +    (origin
>> +     (method git-fetch)
>> +     (uri
>> +      (git-reference
>> +       (url "https://git.drobilla.net/cgit.cgi/omins.lv2.git/")
>> +       (commit "058f341053067b69a84d4081107fda5058290ff9")))
>
> Please check out
> <https://guix.gnu.org/manual/en/html_node/Version-Numbers.html> on how
> to compute version numbers in such cases.
>
>> +   (native-search-paths
>> +    (list (search-path-specification
>> +           (variable "LV2_PATH")
>> +           (files '("lib/lv2")))))
>
> I=E2=80=99m surprised this is here (in the plugin) rather than in the pac=
kage
> that loads this plugin.  There are other LV2 plugins doing that though.
> Ricardo, WDYT?
>
>> +   (license (list license:gpl2+ license:gpl2+))))
>
> (license license:gpl2+) should be enough.  :-)
>
> Could you send an updated patch?
>
> Thank you, and thanks, Sarah!
>
> Ludo=E2=80=99.




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#49533] [PATCH] gnu: Add omins-lv2.
Resent-From: Ricardo Wurmus <rekado@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 02 Sep 2021 07:58:02 +0000
Resent-Message-ID: <handler.49533.B49533.1630569429436 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 49533
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: 49533 <at> debbugs.gnu.org, Thorsten Wilms <t_w_@HIDDEN>, Sarah Morgensen <iskarian@HIDDEN>
Received: via spool by 49533-submit <at> debbugs.gnu.org id=B49533.1630569429436
          (code B ref 49533); Thu, 02 Sep 2021 07:58:02 +0000
Received: (at 49533) by debbugs.gnu.org; 2 Sep 2021 07:57:09 +0000
Received: from localhost ([127.0.0.1]:39645 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mLhav-00006y-HI
	for submit <at> debbugs.gnu.org; Thu, 02 Sep 2021 03:57:09 -0400
Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21102)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rekado@HIDDEN>) id 1mLhat-00006q-HB
 for 49533 <at> debbugs.gnu.org; Thu, 02 Sep 2021 03:57:07 -0400
ARC-Seal: i=1; a=rsa-sha256; t=1630569411; cv=none; 
 d=zohomail.com; s=zohoarc; 
 b=XYfRddF04p7KUaYRossNwSfgcBV9Jw9RgrSusOroLKONlpYmbF1kjfOqD4h23ooBJ1K9Hn7KQoD4r3DnME8ghDcpeux/dcZ5lwSRk6mzO+qhSYij2RdPciSE6YVfz5kKDg6IDyG2mCynGiZRf8G+w+sdm/hPYv4qBGwYBHS4LoQ=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
 s=zohoarc; t=1630569411;
 h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To;
 bh=6HH0YV7AbgZY1vDLP9uPNVG4GMRs8IefNW6c7PH0zgw=; 
 b=gxbhUmWnIQRAF22EHrotFCWRSbBxMgsO4jo6+jEqLRXkx/hgryRTHKjN+aIulbyMTyCU2Wa9ogj5CKYVOo27/vU2HaGmSNo5QflckgN2ax0m+YVRkCOhV5dbvFFc3XM2qrTHuPVPxIdFZ5By9vXyEWntJOoWmGeRRDGpczskJfo=
ARC-Authentication-Results: i=1; mx.zohomail.com;
 dkim=pass  header.i=elephly.net;
 spf=pass  smtp.mailfrom=rekado@HIDDEN;
 dmarc=pass header.from=<rekado@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1630569411; 
 s=zoho; d=elephly.net; i=rekado@HIDDEN;
 h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding;
 bh=6HH0YV7AbgZY1vDLP9uPNVG4GMRs8IefNW6c7PH0zgw=;
 b=EUabiFsLRJcI1f5/5QVek92peT7riSzolfJiSGI+oax6pP6JT33607KPK6hsfDhx
 1Az7ugBuuaSNBVXuH8NMbIW6xcD4a84NcwM9XfVWtJpUg3SwiE7XYX9rL1QnBlmJhLN
 9k8lQIXe+0bzdkA1MpTFc4+qdfgG86VxIjqxpLn4=
Received: from localhost (p54ad490f.dip0.t-ipconnect.de [84.173.73.15]) by
 mx.zohomail.com with SMTPS id 1630569408726718.7353169545539;
 Thu, 2 Sep 2021 00:56:48 -0700 (PDT)
References: <86fsw7rnln.fsf@HIDDEN>
 <20210724194117.8372-1-t_w_@HIDDEN> <874kcc28xz.fsf_-_@HIDDEN>
User-agent: mu4e 1.4.15; emacs 27.2
From: Ricardo Wurmus <rekado@HIDDEN>
In-reply-to: <874kcc28xz.fsf_-_@HIDDEN>
X-URL: https://elephly.net
X-PGP-Key: https://elephly.net/rekado.pubkey
X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
Date: Thu, 02 Sep 2021 09:56:44 +0200
Message-ID: <87bl5b8l6r.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
X-ZohoMailClient: External
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


Ludovic Court=C3=A8s <ludo@HIDDEN> writes:

>> +   (native-search-paths
>> +    (list (search-path-specification
>> +           (variable "LV2_PATH")
>> +           (files '("lib/lv2")))))
>
> I=E2=80=99m surprised this is here (in the plugin) rather than in the=20
> package
> that loads this plugin.  There are other LV2 plugins doing that=20
> though.
> Ricardo, WDYT?

Yes, this looks wrong.

Plugins don=E2=80=99t need to set LV2_PATH; only hosts (such as Ardour,=20
jalv, and others) do.  This must have been an early mistake that=20
has been copied for other plugins.  None of the LV2 hosts that we=20
offer set LV2_PATH.

--=20
Ricardo




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#49533] [PATCH] gnu: Add omins-lv2.
Resent-From: Thorsten Wilms <t_w_@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 02 Sep 2021 08:05:02 +0000
Resent-Message-ID: <handler.49533.B49533.16305698429605 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 49533
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: Ricardo Wurmus <rekado@HIDDEN>, 49533 <at> debbugs.gnu.org, Sarah Morgensen <iskarian@HIDDEN>
Received: via spool by 49533-submit <at> debbugs.gnu.org id=B49533.16305698429605
          (code B ref 49533); Thu, 02 Sep 2021 08:05:02 +0000
Received: (at 49533) by debbugs.gnu.org; 2 Sep 2021 08:04:02 +0000
Received: from localhost ([127.0.0.1]:39671 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mLhha-0002Ur-1u
	for submit <at> debbugs.gnu.org; Thu, 02 Sep 2021 04:04:02 -0400
Received: from mout3.freenet.de ([195.4.92.93]:39248)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=08791000f4=t_w_@HIDDEN>) id 1mLhhY-0002UR-Jy
 for 49533 <at> debbugs.gnu.org; Thu, 02 Sep 2021 04:04:01 -0400
Received: from [195.4.92.120] (helo=sub1.freenet.de)
 by mout3.freenet.de with esmtpa (ID t_w_@HIDDEN) (port 25) (Exim 4.92
 #3) id 1mLhhS-00050F-Rf; Thu, 02 Sep 2021 10:03:54 +0200
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freenet.de; 
 s=mjaymdexmjqk;
 h=Content-Transfer-Encoding:Content-Type:Mime-Version:
 References:In-Reply-To:Message-Id:Subject:Cc:To:From:Date:Sender:Reply-To:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=kJ8oabcyMCrekxVcJvOU9tJn/kir0UvKWeeEdmzOdX4=; b=txXMGbUuxwDMqugitfSHiVKEpt
 lvaYNqldzvdW+cuAMV/8MUVS3edDdBKl+zqe/cQas4ammWOW+3qGyAdsmdQMvcNK1RO1yZ+13Xr8K
 jCxwL8D4cB5brAm69o1LzEnBYRKABoY6szV+oCguodPTEoICNlR7POVsr+YqunKy3EXNMxRqS8j3H
 6K85kPEevPipF/nM3diXadguVtBQ25413V3XjAV72VcAzu2WkismTboPmtKUaaQofU4EUV6RR5Y2/
 3WzWEIdOfInj37xgaKfyATlkqc3DQfmY4IgyM6HqnqEohkVL9Okc4t8SGSncVcGrgdFJNEUo57lka
 j4R+72DA==;
Received: from p200300e4f71242007ad92e3ce9bdb119.dip0.t-ipconnect.de
 ([2003:e4:f712:4200:7ad9:2e3c:e9bd:b119]:34594 helo=charly)
 by sub1.freenet.de with esmtpsa (ID t_w_@HIDDEN)
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (port 465) (Exim 4.92 #3)
 id 1mLhhS-0004wz-Oq; Thu, 02 Sep 2021 10:03:54 +0200
Date: Thu, 2 Sep 2021 10:03:52 +0200
From: Thorsten Wilms <t_w_@HIDDEN>
Message-Id: <20210902100352.f45c5862e26068aea3467248@HIDDEN>
In-Reply-To: <87y28g56j5.fsf_-_@HIDDEN>
References: <86fsw7rnln.fsf@HIDDEN> <20210724194117.8372-1-t_w_@HIDDEN>
 <874kcc28xz.fsf_-_@HIDDEN> <87y28g56j5.fsf_-_@HIDDEN>
X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-unknown-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Originated-At: 2003:e4:f712:4200:7ad9:2e3c:e9bd:b119!34594
X-FNSign: v=2
 s=DCC6832931FA2470F41B491119A80DB0E38CA351474C15D419FA4E174E776B2C
X-Scan-TS: Thu, 02 Sep 2021 10:03:54 +0200
X-Spam-Score: -0.1 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.1 (-)

On Wed, 01 Sep 2021 23:29:18 +0200
Ludovic Courtès <ludo@HIDDEN> wrote:

> Did you have a chance to look into this?

Hi Ludovic, I missed to notice your earlier email. Thanks for it and
this reminder!


> > Please consider passing it through ./etc/indent-code.el:
> >
> >   https://guix.gnu.org/manual/en/html_node/Formatting-Code.html

I assumed Emacs would do the right thing as is. My guix-installed Emacs
does not offer a guix-devel-mode. There’s also no ./etc/indent-code.el
on this foreign distro.


> > Please check out
> > <https://guix.gnu.org/manual/en/html_node/Version-Numbers.html> on
> > how to compute version numbers in such cases.

Done. Assuming the very last example shows the pattern to use, I
suspect that there are a lot of packages that should, but do not use
it. At least in audio.scm.


> >> +   (native-search-paths
> >> +    (list (search-path-specification
> >> +           (variable "LV2_PATH")
> >> +           (files '("lib/lv2")))))
> >
> > I’m surprised this is here (in the plugin) rather than in the
> > package that loads this plugin.  There are other LV2 plugins doing
> > that though. Ricardo, WDYT?

I mean to recall that this was necessary for the first lv2 package I
wrote, but from then on, I may have been cargo-culting. Since my
lilv and sord are still broken, no lv2-host will run. So I can’t even
test this now.


> >> +   (license (list license:gpl2+ license:gpl2+))))
> >
> > (license license:gpl2+) should be enough.  :-)

Sheesh, I did it again!

New patch version follows in separate email.


Thanks!

-- 
Thorsten Wilms <t_w_@HIDDEN>




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#49533] [PATCH v3] gnu: Add omins-lv2.
Resent-From: Thorsten Wilms <t_w_@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 02 Sep 2021 08:58:02 +0000
Resent-Message-ID: <handler.49533.B49533.163057304431286 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 49533
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 49533 <at> debbugs.gnu.org
Cc: Thorsten Wilms <t_w_@HIDDEN>
Received: via spool by 49533-submit <at> debbugs.gnu.org id=B49533.163057304431286
          (code B ref 49533); Thu, 02 Sep 2021 08:58:02 +0000
Received: (at 49533) by debbugs.gnu.org; 2 Sep 2021 08:57:24 +0000
Received: from localhost ([127.0.0.1]:39760 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mLiX8-00088T-AF
	for submit <at> debbugs.gnu.org; Thu, 02 Sep 2021 04:57:24 -0400
Received: from mout0.freenet.de ([195.4.92.90]:54988)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=08791000f4=t_w_@HIDDEN>) id 1mLiX2-00088E-Gz
 for 49533 <at> debbugs.gnu.org; Thu, 02 Sep 2021 04:57:16 -0400
Received: from [195.4.92.120] (helo=sub1.freenet.de)
 by mout0.freenet.de with esmtpa (ID t_w_@HIDDEN) (port 25) (Exim 4.92
 #3) id 1mLiX0-0000GJ-FX
 for 49533 <at> debbugs.gnu.org; Thu, 02 Sep 2021 10:57:10 +0200
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freenet.de; 
 s=mjaymdexmjqk;
 h=Content-Transfer-Encoding:Content-Type:MIME-Version:
 References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=BvZ3dRa/KhReCrJOEz5XW5MU3QpOC+GiUYW1sQ2qlxo=; b=HcP70zUHyI83bGvPsflTbkZcZk
 NAtntcqsNQVQKbvEjx9jRUuhxDECveSnWmkknudk3epbfdFa22AyZ7xP4H9IU28qOofN2O6r3vmcw
 fuUfxSOB8Mb4dIpZVImQN8PTsiYD9DydP3Lp+Rq/egb5XuI1L609gZYBhldMWCLR4TY+hUxY7R62s
 ePYOrgyvvcn2D1bsocXQQWgd4LiRfMX7dJrrtLTnX3SEr9MN5XzoaLrG6Bodb2+KmSCaCnp1z4lJT
 KGfTTLq+kB7MqmjaEUFfOqa28jR0rfuTqmlcA6NCKgyI25AYXYBPQRgIi7bx1n3TFSUPud6CEGqGl
 eonL6hfg==;
Received: from p200300e4f71242007ad92e3ce9bdb119.dip0.t-ipconnect.de
 ([2003:e4:f712:4200:7ad9:2e3c:e9bd:b119]:53930 helo=charly..)
 by sub1.freenet.de with esmtpsa (ID t_w_@HIDDEN)
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (port 465) (Exim 4.92 #3)
 id 1mLiX0-0006U1-D7; Thu, 02 Sep 2021 10:57:10 +0200
From: Thorsten Wilms <t_w_@HIDDEN>
Date: Thu,  2 Sep 2021 10:56:47 +0200
Message-Id: <20210902085647.6272-1-t_w_@HIDDEN>
X-Mailer: git-send-email 2.33.0
In-Reply-To: <87y28g56j5.fsf_-_@HIDDEN>
References: <87y28g56j5.fsf_-_@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Originated-At: 2003:e4:f712:4200:7ad9:2e3c:e9bd:b119!53930
X-FNSign: v=2
 s=79FC24C1710C9F6CF4F9C69BE6DF6AB17DD97717355DE01790D5DCEE4BC94EF8
X-Scan-TS: Thu, 02 Sep 2021 10:57:10 +0200
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/audio.scm (omins-lv2): New variable.
---
 gnu/packages/audio.scm | 33 ++++++++++++++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 80cd521773..d135bfdf3d 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -15,7 +15,7 @@
 ;;; Copyright © 2018 Clément Lassieur <clement@HIDDEN>
 ;;; Copyright © 2018 Brett Gilio <brettg@HIDDEN>
 ;;; Copyright © 2018, 2019 Marius Bakke <mbakke@HIDDEN>
-;;; Copyright © 2018 Thorsten Wilms <t_w_@HIDDEN>
+;;; Copyright © 2018, 2021 Thorsten Wilms <t_w_@HIDDEN>
 ;;; Copyright © 2018 Eric Bavier <bavier@HIDDEN>
 ;;; Copyright © 2018 Brendan Tildesley <mail@HIDDEN>
 ;;; Copyright © 2019, 2021 Pierre Langlois <pierre.langlois@HIDDEN>
@@ -5410,3 +5410,34 @@ device.  There is support for mono and/or stereo and 8 or 16 bit samples.")
      "MDA-LV2 is an LV2 port of the MDA plugins.  It includes effects and a few
 instrument plugins.")
     (license license:gpl3+)))
+
+(define-public omins-lv2
+  (let ((commit "058f341053067b69a84d4081107fda5058290ff9")
+	(revision "1"))
+    (package
+     (name "omins-lv2")
+     ;; No release despite being perfectly usable. 0.0.0 seems to be the only
+     ;; version the author ever specified:
+     (version (git-version "0.0.0" revision commit))
+     (source
+      (origin
+       (method git-fetch)
+       (uri
+	(git-reference
+	 (url "https://git.drobilla.net/cgit.cgi/omins.lv2.git/")
+	 (commit commit)))
+       (file-name (git-file-name name version))
+       (sha256
+	(base32 "01hnx4hhbz3ap3bw15s42q4q1mw1mhdjwygq4550wvjfg6k4ga8w"))))
+     (build-system waf-build-system)
+     (arguments
+      `(#:tests? #f)) ; There are no tests.
+     (inputs
+      `(("lv2" ,lv2)))
+     (native-inputs
+      `(("pkg-config" ,pkg-config)))
+     (home-page "https://git.drobilla.net/cgit.cgi/omins.lv2.git/")
+     (synopsis "LV2 audio plugins for modular synthesis")
+     (description
+      "Omins-lv2 is a small collection of LV2 audio plugins for modular synthesis.")
+     (license license:gpl2+))))
-- 
2.33.0






Last modified: Thu, 2 Sep 2021 09:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.