GNU bug report logs - #49554
28.0.50; [PATCH] dired-number-of-marked-files doesn't work correctly when there are no marked files

Previous Next

Package: emacs;

Reported by: Daniel Martín <mardani29 <at> yahoo.es>

Date: Tue, 13 Jul 2021 20:31:01 UTC

Severity: normal

Tags: patch

Found in version 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49554 in the body.
You can then email your comments to 49554 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#49554; Package emacs. (Tue, 13 Jul 2021 20:31:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Daniel Martín <mardani29 <at> yahoo.es>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 13 Jul 2021 20:31:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Martín <mardani29 <at> yahoo.es>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [PATCH] dired-number-of-marked-files doesn't work
 correctly when there are no marked files
Date: Tue, 13 Jul 2021 22:30:00 +0200

[Message part 1 (text/plain, inline)]
Steps to reproduce the problem:

emacs -Q
Open a directory with files in Dired.
* N

Actual results:

The echo area shows "0 files marked (total size XX)".

After reading the source code, I think it should only show "No marked
files", but there's a syntax mistake in an if expression.  I've attached
a patch to correct the problem.  Thanks.


[0001-Fix-dired-number-of-marked-files-when-there-are-no-m.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#49554; Package emacs. (Tue, 13 Jul 2021 20:41:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Daniel Martín via "Bug reports for GNU Emacs, the Swiss
 army knife of text editors" <bug-gnu-emacs <at> gnu.org>
Cc: 49554 <at> debbugs.gnu.org, Daniel Martín <mardani29 <at> yahoo.es>
Subject: Re: bug#49554: 28.0.50; [PATCH] dired-number-of-marked-files
 doesn't work correctly when there are no marked files
Date: Tue, 13 Jul 2021 22:39:53 +0200

Daniel Martín via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

> After reading the source code, I think it should only show "No marked
> files", but there's a syntax mistake in an if expression.  I've attached
> a patch to correct the problem.  Thanks.

Thanks; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#49554; Package emacs. (Tue, 13 Jul 2021 20:41:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 28.1, send any further explanations to 49554 <at> debbugs.gnu.org and Daniel Martín <mardani29 <at> yahoo.es> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 13 Jul 2021 20:41:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 11 Aug 2021 11:24:10 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 252 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.