Received: (at 49578) by debbugs.gnu.org; 5 Jan 2023 21:29:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 05 16:29:09 2023 Received: from localhost ([127.0.0.1]:53144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pDXnR-0007wD-Ca for submit <at> debbugs.gnu.org; Thu, 05 Jan 2023 16:29:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1pDXnP-0007vs-7H for 49578 <at> debbugs.gnu.org; Thu, 05 Jan 2023 16:29:07 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1pDXnJ-0005OQ-Hw; Thu, 05 Jan 2023 16:29:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=jX+eGV/0s2XTYJRxtE499G0Zf7xVWGuMT5+m65+31Sw=; b=c1CBIIZCoCOF4cxbqv4U 0DqlIGaTyWZpunDVnY7HRrYV0+5/q1xNeum2xsLUgOXbL94S11wD6AImgSCXXL1zgDHbY2hLLIYPP Hu/93CqbGmy3SWpV+fTZCvyD9FhFMRgYDigur6ZoqAeGdEXSxvR95lcSzo8tsSh5Cc++nI7BMoOQ7 O+MYtEblCy7NJRmqnvvXi1/6xtbQZE56QiDElbxBNdt5CoTB0lhug/BzLeMaCIRcIH35ljyvrvbC5 BeRY4BukmsUTg2djEz54jcAeZ0jSHihA4Q1EMVqllTvNJPkNDVDJ/SGsRIf4fQsBbyAM+H3lRO2c6 dko3MgFsC2IrXw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1pDXnH-0001PY-51; Thu, 05 Jan 2023 16:29:01 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: phodina <phodina@HIDDEN> Subject: Re: bug#49578: [PATCH] Add bolt References: <M1akxhPbhdsagfKtQNdUvQ_gr7_am4nX--PrR6Q_xlyvSCkuUoDtFRURxw8xHioONjC36RuHVt-wy18yvV-EeegHIEOUos87NROWijau444=@protonmail.com> <IpWOs4rfABoT7fYcMUB85zS3FRn8ZwpMv_PQzYRjT6aj14ZdfbW8KLgQB9oOJFHKni5PmV5CSNs4h9qbDCpG3DgqGF2btkjbIRCabQV24Zo=@protonmail.com> <86mto4w0xw.fsf@HIDDEN> <T5oh96qaEZJHH-szMIXMWA_dPsLL5PDeHHfSQlyG4-CjQ1ChMNXuTBvaFLPAd15fDw-0YaOB05qr5SrRCAGOg-Su5NeN59RVHeGcfR5C7Vk=@protonmail.com> <rp8SpAlHZIINbm9ZNO_4lI_mK0OlLOQM9EdTQt8Zzz_9c5mpXm_xvGC8gpNjRMDew1MOpECQp6y5MpJWgEk7buLEMmBQleiH1NycK7uKAys=@protonmail.com> Date: Thu, 05 Jan 2023 22:28:57 +0100 In-Reply-To: <rp8SpAlHZIINbm9ZNO_4lI_mK0OlLOQM9EdTQt8Zzz_9c5mpXm_xvGC8gpNjRMDew1MOpECQp6y5MpJWgEk7buLEMmBQleiH1NycK7uKAys=@protonmail.com> (phodina@HIDDEN's message of "Sun, 14 Aug 2022 22:00:32 +0000") Message-ID: <87eds83c2u.fsf_-_@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49578 Cc: Sarah Morgensen <iskarian@HIDDEN>, 49578 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi, Just noticed an issue: phodina <phodina@HIDDEN> skribis: > + (($ <bolt-configuration> package) > + (with-imported-modules (source-module-closure > + '((gnu build shepherd))) > + (shepherd-service > + (documentation "Thunderbolt daemon") > + (provision '(thunderbolt)) > + (requirement '(networking)) > + (modules '((gnu build shepherd))) > + (start #~(make-forkexec-constructor/container > + (list #$(file-append package "/libexec/boltd")) =E2=80=98make-forkexec-constructor/container=E2=80=99 is deprecated in favo= r of the facilities in (guix least-authority). However, running boltd in a container might prevent it from accessing useful files or devices under /dev, /sys, or whatever. I recommend checking whether boltd can actually run in a container; you can strace it to get an idea of the files it needs to access. It needs to run as root anyway so perhaps running it in a container is not that important. Ludo=E2=80=99.
guix-patches@HIDDEN:bug#49578; Package guix-patches.
Full text available.
Received: (at 49578) by debbugs.gnu.org; 14 Dec 2022 11:23:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 14 06:23:04 2022
Received: from localhost ([127.0.0.1]:38425 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1p5Pqq-0002BW-A6
for submit <at> debbugs.gnu.org; Wed, 14 Dec 2022 06:23:04 -0500
Received: from eggs.gnu.org ([209.51.188.92]:55970)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ludo@HIDDEN>) id 1p5Pqo-0002Au-Jn
for 49578 <at> debbugs.gnu.org; Wed, 14 Dec 2022 06:23:03 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
id 1p5Pqh-0001eI-Kn; Wed, 14 Dec 2022 06:22:55 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
From; bh=Lp3RNzfjA08PtGHTN3dB4Z6bJrnMnUbYmWDAQ26k4Ms=; b=A+wsJLFCp5Z7y3mXYf+5
h+Gef8AnGSkHGfEjq2KtxmdiQjJETl5KHiRj1S4mCIQ60NW7Me8sLKkQXwG8eiBrIJ3beOXnq8823
1+bst/HCvD9yXzxmyJ3Z8DtQEqGWyK2Tak4Ys05+MdmT0xOyMZFm545YY6R/67XMfkjNtj/sIKmc/
6jjSrRSBzG5a51rFdVhcwK2ouxa/EQ8DjVJcNYMmq+7Xn2Of9w+OmlMFiWoCqMN5hA/uc3/3xYUC+
p/g0UbgGQl0TGxJBHdIuLH8HH7dXa4eL5WQn/WN89+LD6BW6lUpgVcePeKiCDdHYLwkOJXXVzti+f
/bHmZr795JsfKA==;
Received: from eduroam-111172.grenet.fr ([130.190.111.172] helo=ribbon)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
id 1p5Pqc-0003F5-5M; Wed, 14 Dec 2022 06:22:55 -0500
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: phodina <phodina@HIDDEN>
Subject: Re: bug#49578: [PATCH] Add bolt
References: <M1akxhPbhdsagfKtQNdUvQ_gr7_am4nX--PrR6Q_xlyvSCkuUoDtFRURxw8xHioONjC36RuHVt-wy18yvV-EeegHIEOUos87NROWijau444=@protonmail.com>
<IpWOs4rfABoT7fYcMUB85zS3FRn8ZwpMv_PQzYRjT6aj14ZdfbW8KLgQB9oOJFHKni5PmV5CSNs4h9qbDCpG3DgqGF2btkjbIRCabQV24Zo=@protonmail.com>
<86mto4w0xw.fsf@HIDDEN>
<T5oh96qaEZJHH-szMIXMWA_dPsLL5PDeHHfSQlyG4-CjQ1ChMNXuTBvaFLPAd15fDw-0YaOB05qr5SrRCAGOg-Su5NeN59RVHeGcfR5C7Vk=@protonmail.com>
<rp8SpAlHZIINbm9ZNO_4lI_mK0OlLOQM9EdTQt8Zzz_9c5mpXm_xvGC8gpNjRMDew1MOpECQp6y5MpJWgEk7buLEMmBQleiH1NycK7uKAys=@protonmail.com>
Date: Wed, 14 Dec 2022 12:22:48 +0100
In-Reply-To: <rp8SpAlHZIINbm9ZNO_4lI_mK0OlLOQM9EdTQt8Zzz_9c5mpXm_xvGC8gpNjRMDew1MOpECQp6y5MpJWgEk7buLEMmBQleiH1NycK7uKAys=@protonmail.com>
(phodina@HIDDEN's message of "Sun, 14 Aug 2022 22:00:32
+0000")
Message-ID: <874jtytek7.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 49578
Cc: Sarah Morgensen <iskarian@HIDDEN>, 49578 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Hi,
Thanks a lot, Sarah, for the review work. Somehow it eventually fell
through the cracks but it=E2=80=99s never too late. :-)
phodina <phodina@HIDDEN> skribis:
> From 538eeedf7ee64f98b17507ea11d38512525ef29f Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina@HIDDEN>
> Date: Sun, 18 Jul 2021 12:11:55 +0200
> Subject: [PATCH v4 1/2] gnu: Add bolt.
>
> * gnu/packages/linux.scm (bolt): New variable.
LGTM! I went ahead and applied it.
> From e054c89f9964686670e7716c820ca9ebb9f41543 Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina@HIDDEN>
> Date: Sat, 18 Sep 2021 13:11:18 +0200
> Subject: [PATCH v4 2/2] services: Add a service for bolt.
>
> * gnu/services/linux.scm (bolt-service-type)
> (bolt-shepherd-service, bolt-dbus-service)
> (bolt-configuration, bolt-configuration?): New procedures.
[...]
> +(define-record-type* <bolt-configuration>
> + bolt-configuration make-bolt-configuration bolt-configuration?
> + (package bolt-configuration-package ; package
> + (default bolt)))
> +
> +(define bolt-shepherd-service
> + (match-lambda
> + (($ <bolt-configuration> package)
Just call =E2=80=98bolt-configuration-package=E2=80=99 instead of using =E2=
=80=98match=E2=80=99 here.
> + (with-imported-modules (source-module-closure
> + '((gnu build shepherd)))
> + (shepherd-service
> + (documentation "Thunderbolt daemon")
> + (provision '(thunderbolt))
> + (requirement '(networking))
> + (modules '((gnu build shepherd)))
> + (start #~(make-forkexec-constructor/container
> + (list #$(file-append package "/libexec/boltd"))
> + ))
Please move the parens to the previous line. :-)
> + (stop #~(make-kill-destructor)))))))
> +
> +(define %bolt-activation
> + #~(begin
> + (use-modules (guix build utils))
> + (mkdir-p "/var/lib/boltd")))
> +
> +(define (bolt-dbus-service config)
> + (list (wrapped-dbus-service (bolt-configuration-bolt config)
> + "libexec/boltd"
> + `(("BOLT_CONF_FILE_NAME"
> + '("share/dbus-1/interfaces/org.freedesktop.bolt.xml"))))))
> +
> +(define %bolt-accounts
> + (list (user-group (name "boltd") (system? #t))
> + (user-account
> + (name "boltd")
> + (group "boltd")
> + (system? #t)
> + (comment "Boltd daemon user")
> + (home-directory "/var/empty")
> + (shell "/run/current-system/profile/sbin/nologin"))))
This is creating accounts, but =E2=80=98boltd=E2=80=99 is started as root. =
Is that
expected? Does =E2=80=98boltd=E2=80=99 setuids by itself? If so, please a=
dd a comment
above the =E2=80=98make-forkexec-constructor=E2=80=99 call.
> +(define bolt-udev-rule
> + (match-lambda
> + (($ <bolt-configuration> package)
Same comment as above.
> +(define bolt-service-type
> + (service-type
> + (name 'boltd)
> + (description
> + "Thunderbolt daemon")
Please write full sentences here, giving enough context to make =E2=80=98gu=
ix
system search=E2=80=99 useful.
> + (extensions
> + (list (service-extension udev-service-type
> + (compose list bolt-udev-rule))
> + (service-extension activation-service-type
> + (const %bolt-activation))
> + (service-extension dbus-root-service-type
> + (compose list bolt-configuration-package))
> + ; bolt-dbus-service)
Maybe remove this line?
One last thing: please document it in =E2=80=98doc/guix.texi=E2=80=99. In =
particular,
make sure to add a paragraph that gives a bit of context andq a
configuration example.
Could you send an updated patch?
Thanks,
Ludo=E2=80=99.
guix-patches@HIDDEN:bug#49578; Package guix-patches.
Full text available.Received: (at 49578) by debbugs.gnu.org; 14 Aug 2022 22:00:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 14 18:00:55 2022 Received: from localhost ([127.0.0.1]:40013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oNLfC-0005aF-E8 for submit <at> debbugs.gnu.org; Sun, 14 Aug 2022 18:00:55 -0400 Received: from mail-40133.protonmail.ch ([185.70.40.133]:62533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <phodina@HIDDEN>) id 1oNLf6-0005Zx-LF for 49578 <at> debbugs.gnu.org; Sun, 14 Aug 2022 18:00:52 -0400 Date: Sun, 14 Aug 2022 22:00:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1660514441; x=1660773641; bh=0dpdhIOIA/iLrgfNLyDwOYRZRubsnOJqe1/ed8S6ggk=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=AWmmQ+vvAP0Oe3ltDxH2+BxskcjqS+pb0RUxIY7xXPXXh7GcU294/ouk7NlPgXD2S XhAltVb3DPj1+qBp4/9AePymrO/rVvkVaDhg/Z9rnBarj0nG/XL6N2IQzmEfoXGiEd JDRDkHkOP0W4SeC5Fz0a9TZfdYIDWpLE0MJzR6/MFwW5PE4b4M0Gum1lf232wzE/F3 hGaitKXMYOoAFyv1LX1lxd18Tm4cl03E6uCDlRjXfTuNLeltym85SzaV8UvLymScGP IOnr1Tk4/GnPPA+1ygYQngHmBVAthNZaMNeq9cH9wzAy/kyy6cGeUzReL9UOQpQfv3 yJJmAK6OEASzw== To: Sarah Morgensen <iskarian@HIDDEN> From: phodina <phodina@HIDDEN> Subject: Re: [bug#49578] [PATCH v4] gnu: Add bolt. Message-ID: <rp8SpAlHZIINbm9ZNO_4lI_mK0OlLOQM9EdTQt8Zzz_9c5mpXm_xvGC8gpNjRMDew1MOpECQp6y5MpJWgEk7buLEMmBQleiH1NycK7uKAys=@protonmail.com> In-Reply-To: <T5oh96qaEZJHH-szMIXMWA_dPsLL5PDeHHfSQlyG4-CjQ1ChMNXuTBvaFLPAd15fDw-0YaOB05qr5SrRCAGOg-Su5NeN59RVHeGcfR5C7Vk=@protonmail.com> References: <M1akxhPbhdsagfKtQNdUvQ_gr7_am4nX--PrR6Q_xlyvSCkuUoDtFRURxw8xHioONjC36RuHVt-wy18yvV-EeegHIEOUos87NROWijau444=@protonmail.com> <IpWOs4rfABoT7fYcMUB85zS3FRn8ZwpMv_PQzYRjT6aj14ZdfbW8KLgQB9oOJFHKni5PmV5CSNs4h9qbDCpG3DgqGF2btkjbIRCabQV24Zo=@protonmail.com> <86mto4w0xw.fsf@HIDDEN> <T5oh96qaEZJHH-szMIXMWA_dPsLL5PDeHHfSQlyG4-CjQ1ChMNXuTBvaFLPAd15fDw-0YaOB05qr5SrRCAGOg-Su5NeN59RVHeGcfR5C7Vk=@protonmail.com> Feedback-ID: 14143818:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_PBSgCvR7UJSWeMhJJJALIzoyCnPjSVCkVrjIw9MuPM" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Sarah, here's updated patch with your tips. David, the way I test new packages is either by running: [1] guix shell --check --pure -D guix Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (phodina[at]protonmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record X-Debbugs-Envelope-To: 49578 Cc: 49578 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: phodina <phodina@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 1.0 (+) This is a multi-part message in MIME format. --b1_PBSgCvR7UJSWeMhJJJALIzoyCnPjSVCkVrjIw9MuPM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Sarah, here's updated patch with your tips. David, the way I test new packages is either by running: [1] guix shell --check --pure -D guix or=20 [2] guix build -L <load_path> [1] https://guix.gnu.org/manual/en/html_node/Invoking-guix-environment.html [2] https://guix.gnu.org/manual/en/html_node/Common-Build-Options.html ---- Petr --b1_PBSgCvR7UJSWeMhJJJALIzoyCnPjSVCkVrjIw9MuPM Content-Type: text/x-patch; name=v4-0001-gnu-Add-bolt.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=v4-0001-gnu-Add-bolt.patch RnJvbSA1MzhlZWVkZjdlZTY0Zjk4YjE3NTA3ZWExMWQzODUxMjUyNWVmMjlmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRyIEhvZGluYSA8cGhvZGluYUBwcm90b25tYWlsLmNvbT4K RGF0ZTogU3VuLCAxOCBKdWwgMjAyMSAxMjoxMTo1NSArMDIwMApTdWJqZWN0OiBbUEFUQ0ggdjQg MS8yXSBnbnU6IEFkZCBib2x0LgoKKiBnbnUvcGFja2FnZXMvbGludXguc2NtIChib2x0KTogTmV3 IHZhcmlhYmxlLgoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9saW51eC5zY20gYi9nbnUvcGFj a2FnZXMvbGludXguc2NtCmluZGV4IGQ3ZDM3M2E5MmYuLmMxZjRjOTljYmYgMTAwNjQ0Ci0tLSBh L2dudS9wYWNrYWdlcy9saW51eC5zY20KKysrIGIvZ251L3BhY2thZ2VzL2xpbnV4LnNjbQpAQCAt MTM2LDYgKzEzNiw3IEBAIChkZWZpbmUtbW9kdWxlIChnbnUgcGFja2FnZXMgbGludXgpCiAgICM6 dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHBlcmwpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2th Z2VzIHBjaXV0aWxzKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBwa2ctY29uZmlnKQor ICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBwb2xraXQpCiAgICM6dXNlLW1vZHVsZSAoZ251 IHBhY2thZ2VzIHBvcHQpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHB1bHNlYXVkaW8p CiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHB5dGhvbikKQEAgLTI3MDIsNiArMjcwMyw1 NiBAQCAoZGVmaW5lLXB1YmxpYyBpcHRhYmxlcwogQm90aCBjb21tYW5kcyBhcmUgdGFyZ2V0ZWQg YXQgc3lzdGVtIGFkbWluaXN0cmF0b3JzLiIpCiAgICAgKGxpY2Vuc2UgbGljZW5zZTpncGwyKykp KQogCisoZGVmaW5lLXB1YmxpYyBib2x0CisgIChwYWNrYWdlCisgICAgKG5hbWUgImJvbHQiKQor ICAgICh2ZXJzaW9uICIwLjkuMiIpCisgICAgKHNvdXJjZSAob3JpZ2luCisgICAgICAgICAgICAg IChtZXRob2QgZ2l0LWZldGNoKQorICAgICAgICAgICAgICAodXJpIChnaXQtcmVmZXJlbmNlCisg ICAgICAgICAgICAgICAgICAgICh1cmwgImh0dHBzOi8vZ2l0bGFiLmZyZWVkZXNrdG9wLm9yZy9i b2x0L2JvbHQiKQorICAgICAgICAgICAgICAgICAgICAoY29tbWl0IHZlcnNpb24pKSkKKyAgICAg ICAgICAgICAgKGZpbGUtbmFtZSAoZ2l0LWZpbGUtbmFtZSBuYW1lIHZlcnNpb24pKQorICAgICAg ICAgICAgICAoc2hhMjU2CisgICAgICAgICAgICAgICAoYmFzZTMyCisgICAgICAgICAgICAgICAg IjFoNDhxbXF4aGpxOWd4djVnZjc4Y3FtNXdhZG1uaHZjOWJrZDAyenlhNzdyaDNwZjZ5M3IiKSkp KQorICAgIChidWlsZC1zeXN0ZW0gbWVzb24tYnVpbGQtc3lzdGVtKQorICAgIChhcmd1bWVudHMK KyAgICAgKGxpc3QgIzpjb25maWd1cmUtZmxhZ3MgJyhsaXN0ICItLWxvY2Fsc3RhdGVkaXI9L3Zh ciIpCisgICAgICAgICAgICM6Z2xpYi1vci1ndGs/ICN0IDtUbyB3cmFwIGJpbmFyaWVzIGFuZC9v ciBjb21waWxlIHNjaGVtYXMKKyAgICAgICAgICAgIzpwaGFzZXMgI34obW9kaWZ5LXBoYXNlcyAl c3RhbmRhcmQtcGhhc2VzCisgICAgICAgICAgICAgICAgICAgICAgICAoYWRkLWFmdGVyICd1bnBh Y2sgJ3JlcGxhY2UtZGlyZWN0b3JpZXMKKyAgICAgICAgICAgICAgICAgICAgICAgICAgKGxhbWJk YSogKCM6a2V5IG91dHB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgIChzdWJzdGl0dXRlKiAibWVzb24uYnVpbGQiCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAoKCJ1ZGV2LmdldF9wa2djb25maWdfdmFyaWFibGUuLnVkZXZkaXIuLiIpCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN0cmluZy1hcHBlbmQgIiciCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIyRvdXRwdXQgIi9saWIvdWRl diciKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN1YnN0aXR1dGUqICJzY3JpcHRz L21lc29uLWluc3RhbGwuc2giCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoKCJta2Rp ci4qIikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiIikpKSkKKyAgICAgICAgICAg ICAgICAgICAgICAgIChhZGQtYmVmb3JlICdpbnN0YWxsICduby1wb2xraXQtbWFnaWMKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgKGxhbWJkYSogKCM6a2V5IG91dHB1dHMgIzphbGxvdy1vdGhl ci1rZXlzKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzZXRlbnYgIlBLRVhFQ19VSUQi ICJzb21ldGhpbmciKSkpKSkpCisgICAgKG5hdGl2ZS1pbnB1dHMgKGxpc3QgcGtnLWNvbmZpZwor ICAgICAgICAgICAgICAgICAgICAgICAgIGAoLGdsaWIgImJpbiIpIHB5dGhvbiBhc2NpaWRvYyB1 bW9ja2RldikpCisgICAgKGlucHV0cyAobGlzdCBldWRldiBkYnVzIHBvbGtpdCkpCisgICAgKHN5 bm9wc2lzICJUaHVuZGVyYm9sdCAzIGRldmljZSBtYW5hZ2VyIikKKyAgICAoZGVzY3JpcHRpb24K KyAgICAgIlRoaXMgcGFja2FnZSBwcm92aWRlcyBAY29tbWFuZHtib2x0ZH0sIGEgdXNlcnNwYWNl IGRhZW1vbgorZm9yIFRodW5kZXJib2x0IGRldmljZXMsIGFuZCBAY29tbWFuZHtib2x0Y3RsfSwg YSBjb21tYW5kLWxpbmUgdXRpbGl0eSBmb3IKK21hbmFnaW5nIHRob3NlIGRldmljZXMuCisKK1Ro ZSBkYWVtb24gQGNvbW1hbmR7Ym9sdGR9IGV4cG9zZXMgZGV2aWNlcyB2aWEgRC1CdXMgdG8gY2xp ZW50cy4gIEl0IGFsc28KK3N0b3JlcyBhIGRhdGFiYXNlIG9mIHByZXZpb3VzbHkgYXV0aG9yaXpl ZCBkZXZpY2VzIGFuZCB3aWxsLCBkZXBlbmRpbmcgb24gdGhlCitwb2xpY3kgc2V0IGZvciB0aGUg aW5kaXZpZHVhbCBkZXZpY2VzLCBhdXRvbWF0aWNhbGx5IGF1dGhvcml6ZSBuZXdseSBjb25uZWN0 ZWQKK2RldmljZXMgd2l0aG91dCB1c2VyIGludGVyYWN0aW9uLgorCitUaGUgY29tbWFuZC1saW5l IHV0aWxpdHkgQGNvbW1hbmR7Ym9sdGN0bH0gbWFuYWdlcyBUaHVuZGVyYm9sdCBkZXZpY2VzIHZp YQorQGNvbW1hbmR7Ym9sdGR9LiAgSXQgY2FuIGxpc3QgZGV2aWNlcywgbW9uaXRvciBjaGFuZ2Vz LCBhbmQgaW5pdGlhdGUKK2F1dGhvcml6YXRpb24gb2YgZGV2aWNlcy4iKQorICAgIChob21lLXBh Z2UgImh0dHBzOi8vZ2l0bGFiLmZyZWVkZXNrdG9wLm9yZy9ib2x0L2JvbHQiKQorICAgIChsaWNl bnNlIGxpY2Vuc2U6Z3BsMispKSkKKwogKGRlZmluZS1wdWJsaWMgaml0dGVyZW50cm9weS1ybmdk CiAgIChwYWNrYWdlCiAgICAgKG5hbWUgImppdHRlcmVudHJvcHktcm5nZCIpCi0tIAoyLjM3LjAK Cg== --b1_PBSgCvR7UJSWeMhJJJALIzoyCnPjSVCkVrjIw9MuPM Content-Type: text/x-patch; name=v4-0002-services-Add-a-service-for-bolt.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=v4-0002-services-Add-a-service-for-bolt.patch RnJvbSBlMDU0Yzg5Zjk5NjQ2ODY2NzBlNzcxNmM4MjBjYTllYmI5ZjQxNTQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRyIEhvZGluYSA8cGhvZGluYUBwcm90b25tYWlsLmNvbT4K RGF0ZTogU2F0LCAxOCBTZXAgMjAyMSAxMzoxMToxOCArMDIwMApTdWJqZWN0OiBbUEFUQ0ggdjQg Mi8yXSBzZXJ2aWNlczogQWRkIGEgc2VydmljZSBmb3IgYm9sdC4KCiogZ251L3NlcnZpY2VzL2xp bnV4LnNjbSAoYm9sdC1zZXJ2aWNlLXR5cGUpCihib2x0LXNoZXBoZXJkLXNlcnZpY2UsIGJvbHQt ZGJ1cy1zZXJ2aWNlKQooYm9sdC1jb25maWd1cmF0aW9uLCBib2x0LWNvbmZpZ3VyYXRpb24/KTog TmV3IHByb2NlZHVyZXMuCgpkaWZmIC0tZ2l0IGEvZ251L3NlcnZpY2VzL2xpbnV4LnNjbSBiL2du dS9zZXJ2aWNlcy9saW51eC5zY20KaW5kZXggNjBlMjA5M2UxZC4uMzdkY2QxNGY5NyAxMDA2NDQK LS0tIGEvZ251L3NlcnZpY2VzL2xpbnV4LnNjbQorKysgYi9nbnUvc2VydmljZXMvbGludXguc2Nt CkBAIC01LDYgKzUsNyBAQAogOzs7IENvcHlyaWdodCDCqSAyMDIxIHJhaWQ1YXRlbXlob21ld29y ayA8cmFpZDVhdGVteWhvbWV3b3JrQHByb3Rvbm1haWwuY29tPgogOzs7IENvcHlyaWdodCDCqSAy MDIxIEIuIFdpbHNvbiA8ZWxhZXh1b3RlZUB3aWxzb25iLmNvbT4KIDs7OyBDb3B5cmlnaHQgwqkg MjAyMiBKb3NzZWxpbiBQb2lyZXQgPGRldkBqcG9pcmV0Lnh5ej4KKzs7OyBDb3B5cmlnaHQgwqkg MjAyMS0yMDIyIFBldHIgSG9kaW5hIDxwaG9kaW5hQHByb3Rvbm1haWwuY29tPgogOzs7CiA7Ozsg VGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTI5LDE1ICszMCwyMSBAQCAo ZGVmaW5lLW1vZHVsZSAoZ251IHNlcnZpY2VzIGxpbnV4KQogICAjOnVzZS1tb2R1bGUgKGd1aXgg aTE4bikKICAgIzp1c2UtbW9kdWxlIChndWl4IHVpKQogICAjOnVzZS1tb2R1bGUgKGdudSBzZXJ2 aWNlcykKKyAgIzp1c2UtbW9kdWxlIChnbnUgc2VydmljZXMgZGJ1cykKICAgIzp1c2UtbW9kdWxl IChnbnUgc2VydmljZXMgYmFzZSkKICAgIzp1c2UtbW9kdWxlIChnbnUgc2VydmljZXMgc2hlcGhl cmQpCisgICM6dXNlLW1vZHVsZSAoZ251IHN5c3RlbSBzaGFkb3cpCiAgICM6dXNlLW1vZHVsZSAo Z251IHBhY2thZ2VzIGxpbnV4KQogICAjOnVzZS1tb2R1bGUgKHNyZmkgc3JmaS0xKQogICAjOnVz ZS1tb2R1bGUgKHNyZmkgc3JmaS0yNikKICAgIzp1c2UtbW9kdWxlIChzcmZpIHNyZmktMzQpCiAg ICM6dXNlLW1vZHVsZSAoc3JmaSBzcmZpLTM1KQogICAjOnVzZS1tb2R1bGUgKGljZS05IG1hdGNo KQotICAjOmV4cG9ydCAoZWFybHlvb20tY29uZmlndXJhdGlvbgorICAjOmV4cG9ydCAoYm9sdC1j b25maWd1cmF0aW9uCisgICAgICAgICAgICBib2x0LWNvbmZpZ3VyYXRpb24/CisgICAgICAgICAg ICBib2x0LXNlcnZpY2UtdHlwZQorCisgICAgICAgICAgICBlYXJseW9vbS1jb25maWd1cmF0aW9u CiAgICAgICAgICAgICBlYXJseW9vbS1jb25maWd1cmF0aW9uPwogICAgICAgICAgICAgZWFybHlv b20tY29uZmlndXJhdGlvbi1lYXJseW9vbQogICAgICAgICAgICAgZWFybHlvb20tY29uZmlndXJh dGlvbi1taW5pbXVtLWF2YWlsYWJsZS1tZW1vcnkKQEAgLTY1LDYgKzcyLDc2IEBAIChkZWZpbmUt bW9kdWxlIChnbnUgc2VydmljZXMgbGludXgpCiAgICAgICAgICAgICB6cmFtLWRldmljZS1jb25m aWd1cmF0aW9uLXByaW9yaXR5CiAgICAgICAgICAgICB6cmFtLWRldmljZS1zZXJ2aWNlLXR5cGUp KQogCisMCis7OzsKKzs7OyBUaHVuZGVyYm9sdCBkYWVtb24uCis7OzsKKworKGRlZmluZS1yZWNv cmQtdHlwZSogPGJvbHQtY29uZmlndXJhdGlvbj4KKyAgYm9sdC1jb25maWd1cmF0aW9uIG1ha2Ut Ym9sdC1jb25maWd1cmF0aW9uIGJvbHQtY29uZmlndXJhdGlvbj8KKyAgKHBhY2thZ2UgYm9sdC1j b25maWd1cmF0aW9uLXBhY2thZ2UgOyBwYWNrYWdlCisgICAgICAgICAgIChkZWZhdWx0IGJvbHQp KSkKKworKGRlZmluZSBib2x0LXNoZXBoZXJkLXNlcnZpY2UKKyAgKG1hdGNoLWxhbWJkYQorICAg ICgoJCA8Ym9sdC1jb25maWd1cmF0aW9uPiBwYWNrYWdlKQorICAgICAod2l0aC1pbXBvcnRlZC1t b2R1bGVzIChzb3VyY2UtbW9kdWxlLWNsb3N1cmUKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgJygoZ251IGJ1aWxkIHNoZXBoZXJkKSkpCisgICAgICAgKHNoZXBoZXJkLXNlcnZpY2UKKyAg ICAgICAgKGRvY3VtZW50YXRpb24gIlRodW5kZXJib2x0IGRhZW1vbiIpCisgICAgICAgIChwcm92 aXNpb24gJyh0aHVuZGVyYm9sdCkpCisgICAgICAgIChyZXF1aXJlbWVudCAnKG5ldHdvcmtpbmcp KQorICAgICAgICAobW9kdWxlcyAnKChnbnUgYnVpbGQgc2hlcGhlcmQpKSkKKyAgICAgICAgKHN0 YXJ0ICN+KG1ha2UtZm9ya2V4ZWMtY29uc3RydWN0b3IvY29udGFpbmVyCisgICAgICAgICAgICAg ICAgICAobGlzdCAjJChmaWxlLWFwcGVuZCBwYWNrYWdlICIvbGliZXhlYy9ib2x0ZCIpKQorCQkg ICkpCisgICAgICAgIChzdG9wICN+KG1ha2Uta2lsbC1kZXN0cnVjdG9yKSkpKSkpKQorCisoZGVm aW5lICVib2x0LWFjdGl2YXRpb24KKyAgI34oYmVnaW4KKyAgICAgICh1c2UtbW9kdWxlcyAoZ3Vp eCBidWlsZCB1dGlscykpCisgICAgICAobWtkaXItcCAiL3Zhci9saWIvYm9sdGQiKSkpCisKKyhk ZWZpbmUgKGJvbHQtZGJ1cy1zZXJ2aWNlIGNvbmZpZykKKyAgKGxpc3QgKHdyYXBwZWQtZGJ1cy1z ZXJ2aWNlIChib2x0LWNvbmZpZ3VyYXRpb24tYm9sdCBjb25maWcpCisJCQkgICAgICAibGliZXhl Yy9ib2x0ZCIKKwkJCSAgICAgIGAoKCJCT0xUX0NPTkZfRklMRV9OQU1FIgorCQkJCSAnKCJzaGFy ZS9kYnVzLTEvaW50ZXJmYWNlcy9vcmcuZnJlZWRlc2t0b3AuYm9sdC54bWwiKSkpKSkpCisKKyhk ZWZpbmUgJWJvbHQtYWNjb3VudHMKKyAobGlzdCAodXNlci1ncm91cCAobmFtZSAiYm9sdGQiKSAo c3lzdGVtPyAjdCkpCisgICAgICAgKHVzZXItYWNjb3VudAorCSAobmFtZSAiYm9sdGQiKQorCSAo Z3JvdXAgImJvbHRkIikKKwkgKHN5c3RlbT8gI3QpCisJIChjb21tZW50ICJCb2x0ZCBkYWVtb24g dXNlciIpCisJIChob21lLWRpcmVjdG9yeSAiL3Zhci9lbXB0eSIpCisJIChzaGVsbCAiL3J1bi9j dXJyZW50LXN5c3RlbS9wcm9maWxlL3NiaW4vbm9sb2dpbiIpKSkpCisKKyhkZWZpbmUgYm9sdC11 ZGV2LXJ1bGUKKyAgKG1hdGNoLWxhbWJkYQorICAgICgoJCA8Ym9sdC1jb25maWd1cmF0aW9uPiBw YWNrYWdlKQorICAoZmlsZS0+dWRldi1ydWxlICI5MC1ib2x0LnJ1bGVzIiAoZmlsZS1hcHBlbmQg cGFja2FnZSAiL2xpYi91ZGV2L3J1bGVzLmQvOTAtYm9sdC5ydWxlcyIpKSkpKQorCisoZGVmaW5l IGJvbHQtc2VydmljZS10eXBlCisgIChzZXJ2aWNlLXR5cGUKKyAgIChuYW1lICdib2x0ZCkKKyAg IChkZXNjcmlwdGlvbgorICAgICJUaHVuZGVyYm9sdCBkYWVtb24iKQorICAgKGV4dGVuc2lvbnMK KyAgICAobGlzdCAoc2VydmljZS1leHRlbnNpb24gdWRldi1zZXJ2aWNlLXR5cGUKKwkJCSAgICAg KGNvbXBvc2UgbGlzdCBib2x0LXVkZXYtcnVsZSkpCisJICAoc2VydmljZS1leHRlbnNpb24gYWN0 aXZhdGlvbi1zZXJ2aWNlLXR5cGUKKwkJCSAgICAgKGNvbnN0ICVib2x0LWFjdGl2YXRpb24pKQor CSAgKHNlcnZpY2UtZXh0ZW5zaW9uIGRidXMtcm9vdC1zZXJ2aWNlLXR5cGUKKwkgIChjb21wb3Nl IGxpc3QgYm9sdC1jb25maWd1cmF0aW9uLXBhY2thZ2UpKQorCTsJCSAgICAgYm9sdC1kYnVzLXNl cnZpY2UpCisJICAoc2VydmljZS1leHRlbnNpb24gYWNjb3VudC1zZXJ2aWNlLXR5cGUKKwkJCSAg ICAgKGNvbnN0ICVib2x0LWFjY291bnRzKSkKKyAgICAgICAgICAoc2VydmljZS1leHRlbnNpb24g c2hlcGhlcmQtcm9vdC1zZXJ2aWNlLXR5cGUKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KGNvbXBvc2UgbGlzdCBib2x0LXNoZXBoZXJkLXNlcnZpY2UpKSkpCisgICAoZGVmYXVsdC12YWx1 ZSAoYm9sdC1jb25maWd1cmF0aW9uKSkpKQorCiAMCiA7OzsKIDs7OyBFYXJseSBPT00gZGFlbW9u LgotLSAKMi4zNy4wCgo= --b1_PBSgCvR7UJSWeMhJJJALIzoyCnPjSVCkVrjIw9MuPM--
guix-patches@HIDDEN:bug#49578; Package guix-patches.
Full text available.Received: (at 49578) by debbugs.gnu.org; 2 Feb 2022 16:19:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 02 11:19:21 2022 Received: from localhost ([127.0.0.1]:53164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nFILp-00071j-0Z for submit <at> debbugs.gnu.org; Wed, 02 Feb 2022 11:19:21 -0500 Received: from mail-il1-f180.google.com ([209.85.166.180]:39451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <aionfork@HIDDEN>) id 1nFILm-00071V-HE for 49578 <at> debbugs.gnu.org; Wed, 02 Feb 2022 11:19:19 -0500 Received: by mail-il1-f180.google.com with SMTP id z7so17475158ilb.6 for <49578 <at> debbugs.gnu.org>; Wed, 02 Feb 2022 08:19:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=pIb2+GRAnQK764jk5y6J98NNfUqyPl13kGGogIaOl9o=; b=a8nDtys012w7izi01TrAchCzEu4oe3jW7mMgXeEs7Mw41qhz9fqDTpTYbj5R15mHgB 1g4pOtP/Xzt9iwgq2Y+2Cs7XnaNu31616RAExG8IzlZJbPgIKYRxTEW8G5yKWaIg2BKM YK7k8uN5f8DW4eQCEeHxdLDJImb9i98dnwKdJBXPD7WxCXE8qJKdPcx50Aonj4FYskIR sRSTIuuMJUCt048/BEktQYmWnu6D4Ks/UDJAmG/571WvBRSPjAL8k4e7vq+MQrvSRfWl tq90oXs5sblYG6rjNmDufq0Va/fP7RzXQt37/3n22N24OHJhDvwIXRS5vycZlz81TmAa Q+8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=pIb2+GRAnQK764jk5y6J98NNfUqyPl13kGGogIaOl9o=; b=rAe4LgGgSEwnxky46QKia/TeRJYNqmAJhyZl3BVa3gF6xhC5o6EYgZV9cpGvwzu8gU DWETlzfUyco+dwS05Ivm47MGIaQNIQjl1bA17mM52aq+PKGBjQ62Gt8eZY+/RLebi1fo szEKYm/PGPiPNd9oUJwJrxqHGM0SqcxkppVSLeLdFplIjGslMkcgP8dyqx0iCkR86FSb RJa21zFLwOs468vsM2/yYK+sxC46/IWEw7hWpJRf3nYeesX99vG2YObIzm8PXHDpHgwO gLsL/1J+E/gWT5Lf03C6ofiU8QqRabb2xMoe1Z9a6VefkMxVjo0FXUKVOBuD6p5rABjj Rtvg== X-Gm-Message-State: AOAM530xf+G/nTkQ5Ok7mDtYjFTG3wgSjcbuyPAFyLl6zP2DmivgAJ6z SuYfbYpe/2Z+c8yl8/oXQEi82HDFUdepTv6h/7lU6kk0 X-Google-Smtp-Source: ABdhPJykmLo4a08DKydnO6Kq6llBYprYUxOcYeuZgA6NDqgwPhczaMAfSmdqRTS1mqIKtwtTi09y01XZBKCuk6jYF0E= X-Received: by 2002:a05:6e02:1ca4:: with SMTP id x4mr17340220ill.262.1643818752681; Wed, 02 Feb 2022 08:19:12 -0800 (PST) MIME-Version: 1.0 References: <CAA_WgJXf0sWMbZZTg2avrGFYBj1_7LunsL9=qETFnYNyK1-jFA@HIDDEN> In-Reply-To: <CAA_WgJXf0sWMbZZTg2avrGFYBj1_7LunsL9=qETFnYNyK1-jFA@HIDDEN> From: David Conner <aionfork@HIDDEN> Date: Wed, 2 Feb 2022 11:19:01 -0500 Message-ID: <CAA_WgJX8FYe6r9c12ZxjJjVzPV87PnBUzzbJ0o0DfyQi=y3Ofw@HIDDEN> Subject: Re: [PATCH] Add bolt To: 49578 <at> debbugs.gnu.org Content-Type: multipart/alternative; boundary="000000000000d42a7405d70b604e" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49578 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000d42a7405d70b604e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I am ready to test this. I finally reconfigured my system last night, but I have some questions about patching guix and testing. The guix I would reconfigure in order to test this would be =E2=80=98master= =E2=80=99 with the patch applied. I think I should be alright applying the patch (I am noob). If it doesn=E2=80=99t apply right, I can figure it out, but then I= =E2=80=99ll need to update the patch right? Is git capable of doing this? Or should I use a tool like ediff/patchwork? I have the guix checked out with Google repo via https://github.com/ectorepo/guix. This pulls down the latest copy of everything on savannah under the guix project. 2022=E5=B9=B41=E6=9C=8822=E6=97=A5(=E5=9C=9F) =E5=8D=88=E5=89=8D1:55 David = Conner <aionfork@HIDDEN>: > I have a late 2013 Macbook Pro with two Thunderbolt 2 ports. > > They work if the TB device is inserted on boot, but after you disconnect = a > device, it no longer functions when you reconnect it. It show that the > kernel recognizes the device in `dmesg` and that the PCIe port is > registered in `lspci -k` But the device is not found in `nmcli dev status= `. > The device I'm testing is an Apple Ethernet adapter. > > I am still in the learning phase where I'm trying to reconfigure my > machine, but I have the guix repo cloned and I'm planning on contributing > patches to packages on other channels. I will hopefully be in the positio= n > where I can test this soon. > --000000000000d42a7405d70b604e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto">I am ready to test this. I finally reconfigured my system= last night, but I have some questions about patching guix and testing.</di= v><div dir=3D"auto"><br></div><div dir=3D"auto">The guix I would reconfigur= e in order to test this would be =E2=80=98master=E2=80=99 with the patch ap= plied. I think I should be alright applying the patch (I am noob). If it do= esn=E2=80=99t apply right, I can figure it out, but then I=E2=80=99ll need = to update the patch right?=C2=A0</div><div dir=3D"auto"><br></div><div dir= =3D"auto">Is git capable of doing this?=C2=A0</div><div dir=3D"auto"><br></= div><div dir=3D"auto">Or should I use a tool like ediff/patchwork?<br></div= ><div dir=3D"auto"><br></div><div dir=3D"auto">I have the guix checked out = with Google repo via <a href=3D"https://github.com/ectorepo/guix">https://g= ithub.com/ectorepo/guix</a>. This pulls down the latest copy of everything = on savannah under the guix project.</div><div><br><div class=3D"gmail_quote= "><div dir=3D"ltr" class=3D"gmail_attr">2022=E5=B9=B41=E6=9C=8822=E6=97=A5(= =E5=9C=9F) =E5=8D=88=E5=89=8D1:55 David Conner <<a href=3D"mailto:aionfo= rk@HIDDEN">aionfork@HIDDEN</a>>:<br></div><blockquote class=3D"gma= il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-le= ft-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div di= r=3D"ltr">I have a late 2013 Macbook Pro with two Thunderbolt 2 ports. <br>= <br>They work if the TB device is inserted on boot, but after you disconnec= t a device, it no longer functions when you reconnect it. It show that the = kernel recognizes the device in `dmesg` and=C2=A0 that the PCIe port is reg= istered in `lspci -k` But the device is not found in `nmcli dev status`. Th= e device I'm testing is an Apple Ethernet adapter.=C2=A0<br><br>I am st= ill in the learning phase where I'm trying to reconfigure my machine, b= ut I have the=C2=A0guix repo cloned and I'm planning on contributing pa= tches to packages on other channels. I will hopefully be in the position wh= ere I can test this soon.</div> </blockquote></div></div> --000000000000d42a7405d70b604e--
guix-patches@HIDDEN:bug#49578; Package guix-patches.
Full text available.Received: (at 49578) by debbugs.gnu.org; 22 Jan 2022 08:18:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 22 03:18:43 2022 Received: from localhost ([127.0.0.1]:35670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nBBbe-0001nd-Lg for submit <at> debbugs.gnu.org; Sat, 22 Jan 2022 03:18:42 -0500 Received: from mail-io1-f53.google.com ([209.85.166.53]:45745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <aionfork@HIDDEN>) id 1nBAJn-0008Dt-KV for 49578 <at> debbugs.gnu.org; Sat, 22 Jan 2022 01:56:11 -0500 Received: by mail-io1-f53.google.com with SMTP id s11so13279532ioe.12 for <49578 <at> debbugs.gnu.org>; Fri, 21 Jan 2022 22:56:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=til9LTj7ksDsGD/xvp2lGIUMebs94QwMF/Unvebj3uU=; b=C5WBoc92fryNl5H9SFJYmVLl+DYGyj54y8gk4lPRy5nHd+FjeNctspYodJaf1eU/ZX nHscoYVpAM1v1YdDTQpVm3rTy01p+/PKPL2/iA9FbZ/u/xnXn+CSx2mNXeb9Oau1q2PK S2psHq93w02eiueTVZRjAev8L3VujUs83ZTHfGRbwMTz8QRYlExoKoIfVGyvBAk/49T1 /nTAvXwZcbfaGMxuBk43wkDpDtvBVRYicX7ZXh/ASh7VmXi7Wmb4ROEQh6P5hWDCTqFK NlGKVUAq8kSL2RdGXIFmP9J5MvrdBAr9FACzoiHSyjrELwLs9QFG4lRbu2dakiCBIpXf +XjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=til9LTj7ksDsGD/xvp2lGIUMebs94QwMF/Unvebj3uU=; b=d051TR+0MzgdeziTmUd051SQpS5iRFz3gUA50MlcyClNOwflXJtxFCRTLUIgSY8eFL WqoXyxvVQkiQ7sUTZzQYi7P95KYkqCJ8w0VlK62emOYKbGxEU05Lu2yB7qMwZoz/yEy+ LwzpHBpDnsz/lV8EW8tIYat6OS0tyNYMWaQB6qyT7xQBbT6+bF6Bdmqux841rOaF4PbI GXeFWO1n8XT2FhLimIocPnDBOY3Zs6H4IFScX0tvTKd5nD38E5PuFnteOtgHP4bYKjyu VXqwpmuMh67Fj+N02mHZCqMTYcRmvnkSqvfKJC73DK4lxvsBOByeboX+fzsyVPTN3Mtx jrGw== X-Gm-Message-State: AOAM530uJ1b6JRGoWM1XODvq10K8h2Hc6N93v4iPIi9EtWz1gJO7tty6 Q7X372MLwA68yzGp8AXoX9XFOZRNu6Sm6ya9D9xGwF1b X-Google-Smtp-Source: ABdhPJy8EcGJRu8OvFiRRjLAFLNJuiDt5+5lJVmzUFEIRyiDU3jzu3nIhJOamvyjKkaUYMD7LDqrpL7HsYxT1gn0HyM= X-Received: by 2002:a05:6638:c6:: with SMTP id w6mr3219023jao.135.1642834565585; Fri, 21 Jan 2022 22:56:05 -0800 (PST) MIME-Version: 1.0 From: David Conner <aionfork@HIDDEN> Date: Sat, 22 Jan 2022 01:55:55 -0500 Message-ID: <CAA_WgJXf0sWMbZZTg2avrGFYBj1_7LunsL9=qETFnYNyK1-jFA@HIDDEN> Subject: [PATCH] Add bolt To: 49578 <at> debbugs.gnu.org Content-Type: multipart/alternative; boundary="000000000000b4df4905d6263a2f" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49578 X-Mailman-Approved-At: Sat, 22 Jan 2022 03:18:41 -0500 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000b4df4905d6263a2f Content-Type: text/plain; charset="UTF-8" I have a late 2013 Macbook Pro with two Thunderbolt 2 ports. They work if the TB device is inserted on boot, but after you disconnect a device, it no longer functions when you reconnect it. It show that the kernel recognizes the device in `dmesg` and that the PCIe port is registered in `lspci -k` But the device is not found in `nmcli dev status`. The device I'm testing is an Apple Ethernet adapter. I am still in the learning phase where I'm trying to reconfigure my machine, but I have the guix repo cloned and I'm planning on contributing patches to packages on other channels. I will hopefully be in the position where I can test this soon. --000000000000b4df4905d6263a2f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">I have a late 2013 Macbook Pro with two Thunderbolt 2 port= s. <br><br>They work if the TB device is inserted on boot, but after you di= sconnect a device, it no longer functions when you reconnect it. It show th= at the kernel recognizes the device in `dmesg` and=C2=A0 that the PCIe port= is registered in `lspci -k` But the device is not found in `nmcli dev stat= us`. The device I'm testing is an Apple Ethernet adapter.=C2=A0<br><br>= I am still in the learning phase where I'm trying to reconfigure my mac= hine, but I have the=C2=A0guix repo cloned and I'm planning on contribu= ting patches to packages on other channels. I will hopefully be in the posi= tion where I can test this soon.</div> --000000000000b4df4905d6263a2f--
guix-patches@HIDDEN:bug#49578; Package guix-patches.
Full text available.
Received: (at 49578) by debbugs.gnu.org; 5 Nov 2021 08:39:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 05 04:39:18 2021
Received: from localhost ([127.0.0.1]:44793 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1miukn-0002kN-O6
for submit <at> debbugs.gnu.org; Fri, 05 Nov 2021 04:39:18 -0400
Received: from mail-40131.protonmail.ch ([185.70.40.131]:10984)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <phodina@HIDDEN>) id 1miuki-0002k3-FO
for 49578 <at> debbugs.gnu.org; Fri, 05 Nov 2021 04:39:16 -0400
Date: Fri, 05 Nov 2021 08:39:00 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail; t=1636101541;
bh=IE1/pQ2XlbxiHtK3ecXWLSw0PyNUNSUf70QEcTlSZz8=;
h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From;
b=fjxWDfGYbGpedh4XTlzrb78mKSQEQQA0Ilm32e+0UAn7Fw5o0QE565hg8QqdoqBB7
ydGQH+6k6Yxat6HqcNCOH+OwimT3TTtVD/CUDx48EsAsiDengLDL82quHatsV7ugtA
AbSEFNGFw+oUFeIjCDDCv3kNVsBBplfDOP4fIGi0=
To: Sarah Morgensen <iskarian@HIDDEN>
From: phodina <phodina@HIDDEN>
Subject: Re: [bug#49578] [PATCH v3 1/2] gnu: Add bolt.
Message-ID: <T5oh96qaEZJHH-szMIXMWA_dPsLL5PDeHHfSQlyG4-CjQ1ChMNXuTBvaFLPAd15fDw-0YaOB05qr5SrRCAGOg-Su5NeN59RVHeGcfR5C7Vk=@protonmail.com>
In-Reply-To: <86mto4w0xw.fsf@HIDDEN>
References: <M1akxhPbhdsagfKtQNdUvQ_gr7_am4nX--PrR6Q_xlyvSCkuUoDtFRURxw8xHioONjC36RuHVt-wy18yvV-EeegHIEOUos87NROWijau444=@protonmail.com>
<IpWOs4rfABoT7fYcMUB85zS3FRn8ZwpMv_PQzYRjT6aj14ZdfbW8KLgQB9oOJFHKni5PmV5CSNs4h9qbDCpG3DgqGF2btkjbIRCabQV24Zo=@protonmail.com>
<86mto4w0xw.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no
autolearn=disabled version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
mailout.protonmail.ch
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 49578
Cc: 49578 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: phodina <phodina@HIDDEN>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi,
=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me=
ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90
On Thursday, September 23rd, 2021 at 3:11 AM, Sarah Morgensen <iskarian@mgs=
n.dev> wrote:
> Hello Petr,
>
> Thanks for the updated patch :)
>
> I don't have any experiences with services, so I can't comment on the
>
> second patch in this series, and I don't have a Thunderbolt controller
>
> or devices, so I can't test the actual program, but other than the
>
> commit message/synopsis/description this package LGTM.
Thanks Sarah for the review and tips on packaging.
>
> phodina phodina@HIDDEN writes:
>
> > - gnu/packages/linux.scm: (bolt): New variable.
>
> ^ no ":"
>
>
> > - (synopsis "Userspace system daemon for Thunderbolt")
>
> Consider this instead (taken from their repository tagline, more
>
> understandable to more users):
>
> (synopsis "Thunderbolt 3 device manager")
>
> > - (description "Userspace daemon @code{boltd} exposes devices via D-B=
us to clients.
> >
> > +It stores database of previously authorized devices and depending
> >
> > +on the policy set for the individual devices, automatically author=
ize newly
> >
> > +connected devices without user interaction. It also adapts its beh=
aivour when
> >
> > +iommu support is detected.
> >
> > +Command line utility 'boltctl' can be used to manage thundebolt de=
vices.
> >
> > +It can list devices, monitor changes and initiate authorization of=
device.")
>
> Consider this instead:
>
> (description "This package provides @command{boltd}, a userspace daemon
>
> for Thunderbolt devices, and @command{boltctl}, a command-line utility fo=
r
>
> managing those devices.
>
> The daemon @command{boltd} exposes devices via D-Bus to clients. It also
>
> stores a database of previously authorized devices and will, depending on=
the
>
> policy set for the individual devices, automatically authorize newly conn=
ected
>
> devices without user interaction.
>
> The command-line utility @command{boltctl} manages Thunderbolt devices vi=
a
>
> @command{boltd}. It can list devices, monitor changes, and initiate
>
> authorization of devices.")
>
> > - (home-page "https://gitlab.freedesktop.org/bolt/bolt")
> > - (license license:gpl2+)))
> >
> > (define-public jitterentropy-rngd
> >
> > (package
> >
> > (name "jitterentropy-rngd")
> > -----------------------------------------------------------------------=
-
> >
> > 2.32.0
>
> With those changes, or similar:
>
> - Package review checklist (WIP)
>
> Lack of a check is not proof of noncompliance.
>
> 1. [X] Package builds (guix build package)
>
> [X] x86_64 [ ] aarch64 [ ] armhf [ ] powerpc64le
>
> [ ] i686 [ ] i586 [ ] mips64le
> 2. [X] Build is reproducible (guix build --rounds=3Dn package)
> 3. [X] Tests enabled (if available) or disabled with in-source comment
> 4. [X] No extraneous dependencies (guix size package)
> 5. [X] No unnecessary pre-built binaries/blobs
> 6. [X] Dependencies unvendored when available in Guix
> 7. [X] Cross-compile friendly (cc-for-target, patches with inputs)
> 8. [X] License matches source
> 9. [X] No problematic lints (guix lint package)
> 10. [X] Formatting follows guidelines
> - [X] Lines wrap at 80 characters
> - [X] Indentation passes etc/indent-code.el
> - [X] Two spaces used between sentences
>
> For new packages:
> 11. [X] Source url is robust
> - mirror:// used with url-fetch when possible
> - No auto-generated archives from source repo (prefer cloning)
> 12. [X] Synopsis is short, descriptive, and meaningful to a wide audienc=
e
> 13. [X] Description is objective, takes 5-10 lines, uses full sentences,
>
> and provides the information users need to decide whether the
>
> software fits their needs.
>
> There are lints for CVEs, but they are for the Bolt CMS, not this
>
> project.
>
> --
>
> Sarah
Is there somebody who has Thunderbolt on their machine and could test this =
patch?
Petr
guix-patches@HIDDEN:bug#49578; Package guix-patches.
Full text available.
Received: (at 49578) by debbugs.gnu.org; 23 Sep 2021 01:11:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 22 21:11:31 2021
Received: from localhost ([127.0.0.1]:52237 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mTDGt-0006wB-AW
for submit <at> debbugs.gnu.org; Wed, 22 Sep 2021 21:11:31 -0400
Received: from out1.migadu.com ([91.121.223.63]:61552)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <iskarian@HIDDEN>) id 1mTDGp-0006vw-Uc
for 49578 <at> debbugs.gnu.org; Wed, 22 Sep 2021 21:11:29 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1;
t=1632359485;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=WLUeFHlDYgwtV2VW1qAAdldSbiPgSsi2XDbwp5dyMZM=;
b=AgG3PS6WrQR8/o9j5E7ysfQqNyCsvnMLfLyf1vH8eaxJU3b38xG+a7D3iszBc9k3BkgloW
EOra7bpRo84VygLF1zyHhDvcgSCAJjPzlCr7T2edL8TCrMnHQbQ37O1IEEoeIaH8zXLw30
ocER1XdlfoaMYVJUJmUlCybBh6+eSo4=
From: Sarah Morgensen <iskarian@HIDDEN>
To: phodina <phodina@HIDDEN>
Subject: Re: [bug#49578] [PATCH v3 1/2] gnu: Add bolt.
References: <M1akxhPbhdsagfKtQNdUvQ_gr7_am4nX--PrR6Q_xlyvSCkuUoDtFRURxw8xHioONjC36RuHVt-wy18yvV-EeegHIEOUos87NROWijau444=@protonmail.com>
<IpWOs4rfABoT7fYcMUB85zS3FRn8ZwpMv_PQzYRjT6aj14ZdfbW8KLgQB9oOJFHKni5PmV5CSNs4h9qbDCpG3DgqGF2btkjbIRCabQV24Zo=@protonmail.com>
Date: Wed, 22 Sep 2021 18:11:23 -0700
In-Reply-To: <IpWOs4rfABoT7fYcMUB85zS3FRn8ZwpMv_PQzYRjT6aj14ZdfbW8KLgQB9oOJFHKni5PmV5CSNs4h9qbDCpG3DgqGF2btkjbIRCabQV24Zo=@protonmail.com>
(phodina@HIDDEN's message of "Sat, 18 Sep 2021 11:20:38 +0000 (4
days, 12 hours, 42 minutes ago)")
Message-ID: <86mto4w0xw.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: iskarian@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 49578
Cc: 49578 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Hello Petr,
Thanks for the updated patch :)
I don't have any experiences with services, so I can't comment on the
second patch in this series, and I don't have a Thunderbolt controller
or devices, so I can't test the actual program, but other than the
commit message/synopsis/description this package LGTM.
phodina <phodina@HIDDEN> writes:
> * gnu/packages/linux.scm: (bolt): New variable.
^ no ":"
> + (synopsis "Userspace system daemon for Thunderbolt")
Consider this instead (taken from their repository tagline, more
understandable to more users):
(synopsis "Thunderbolt 3 device manager")
> + (description "Userspace daemon @code{boltd} exposes devices via D-Bus to clients.
> +It stores database of previously authorized devices and depending
> +on the policy set for the individual devices, automatically authorize newly
> +connected devices without user interaction. It also adapts its behaivour when
> +iommu support is detected.
> +Command line utility 'boltctl' can be used to manage thundebolt devices.
> +It can list devices, monitor changes and initiate authorization of device.")
Consider this instead:
(description "This package provides @command{boltd}, a userspace daemon
for Thunderbolt devices, and @command{boltctl}, a command-line utility for
managing those devices.
The daemon @command{boltd} exposes devices via D-Bus to clients. It also
stores a database of previously authorized devices and will, depending on the
policy set for the individual devices, automatically authorize newly connected
devices without user interaction.
The command-line utility @command{boltctl} manages Thunderbolt devices via
@command{boltd}. It can list devices, monitor changes, and initiate
authorization of devices.")
> + (home-page "https://gitlab.freedesktop.org/bolt/bolt")
> + (license license:gpl2+)))
> +
> (define-public jitterentropy-rngd
> (package
> (name "jitterentropy-rngd")
> --
> 2.32.0
With those changes, or similar:
* Package review checklist (WIP)
Lack of a check is not proof of noncompliance.
1. [X] Package builds (guix build package)
[X] x86_64 [ ] aarch64 [ ] armhf [ ] powerpc64le
[ ] i686 [ ] i586 [ ] mips64le
2. [X] Build is reproducible (guix build --rounds=n package)
3. [X] Tests enabled (if available) or disabled with in-source comment
4. [X] No extraneous dependencies (guix size package)
5. [X] No unnecessary pre-built binaries/blobs
6. [X] Dependencies unvendored when available in Guix
7. [X] Cross-compile friendly (cc-for-target, patches with inputs)
8. [X] License matches source
9. [X] No problematic lints (guix lint package)
10. [X] Formatting follows guidelines
- [X] Lines wrap at 80 characters
- [X] Indentation passes etc/indent-code.el
- [X] Two spaces used between sentences
For new packages:
1. [X] Source url is robust
* mirror:// used with url-fetch when possible
* No auto-generated archives from source repo (prefer cloning)
2. [X] Synopsis is short, descriptive, and meaningful to a wide audience
3. [X] Description is objective, takes 5-10 lines, uses full sentences,
and provides the information users need to decide whether the
software fits their needs.
There are lints for CVEs, but they are for the Bolt CMS, not this
project.
--
Sarah
guix-patches@HIDDEN:bug#49578; Package guix-patches.
Full text available.
Received: (at 49578) by debbugs.gnu.org; 18 Sep 2021 11:21:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 18 07:21:50 2021
Received: from localhost ([127.0.0.1]:33721 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mRYPm-0002G2-3V
for submit <at> debbugs.gnu.org; Sat, 18 Sep 2021 07:21:50 -0400
Received: from mail-40134.protonmail.ch ([185.70.40.134]:24888)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <phodina@HIDDEN>) id 1mRYPi-0002Fn-Oo
for 49578 <at> debbugs.gnu.org; Sat, 18 Sep 2021 07:21:48 -0400
Date: Sat, 18 Sep 2021 11:21:34 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail; t=1631964096;
bh=oE0vEhHG58+QeC/+X28zaw2nVFzLSeU+kI4vldvyXfg=;
h=Date:To:From:Cc:Reply-To:Subject:From;
b=rx6r3negT5aaYkv/0uDSVtzkf2NSXuzKECUK3tkHQ381JCYTNEQa0VZ0E1xPDOkjS
+nM+1JF04NBgFAdGJgZ8LHu6qFWlfoa9sgq5RvNZHxqYFY/QWVzWD/9R4Enk1t9SFI
j3ZN2AYdb2lBF96vkI8rYx8GER6aSKrUbFADUJQc=
To: Sarah Morgensen <iskarian@HIDDEN>
From: phodina <phodina@HIDDEN>
Subject: [PATCH v3 2/2] services: Add a service for bolt.
Message-ID: <7hJPvaldH4Bh7rtXByW9GPmxh-s8a1TCz9icV0mkcF6MLy5zRWlgrcruWWbl2KcenTOrIsL89cDh36eBRLrjKa6y53p8a8weWTQpSenjCHE=@protonmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no
autolearn=disabled version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
mailout.protonmail.ch
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 49578
Cc: 49578 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: phodina <phodina@HIDDEN>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
* gnu/services/linux.scm (bolt-service-type)
(bolt-shepherd-service, bolt-dbus-service)
(bolt-configuration, bolt-configuration?): New procedures.
diff --git a/gnu/services/linux.scm b/gnu/services/linux.scm
index 2eb02ac5a3..dc26f285bf 100644
--- a/gnu/services/linux.scm
+++ b/gnu/services/linux.scm
@@ -4,6 +4,7 @@
;;; Copyright =C2=A9 2020 Efraim Flashner <efraim@HIDDEN>
;;; Copyright =C2=A9 2021 raid5atemyhomework <raid5atemyhomework@protonmai=
l.com>
;;; Copyright =C2=A9 2021 B. Wilson <elaexuotee@HIDDEN>
+;;; Copyright =C2=A9 2021 Petr Hodina <phodina@HIDDEN>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -24,7 +25,9 @@
#:use-module (guix gexp)
#:use-module (guix records)
#:use-module (guix modules)
+ #:use-module (gnu system shadow)
#:use-module (gnu services)
+ #:use-module (gnu services dbus)
#:use-module (gnu services base)
#:use-module (gnu services shepherd)
#:use-module (gnu packages linux)
@@ -33,7 +36,11 @@
#:use-module (srfi srfi-34)
#:use-module (srfi srfi-35)
#:use-module (ice-9 match)
- #:export (earlyoom-configuration
+ #:export (bolt-configuration
+ bolt-configuration?
+ bolt-service-type
+
+ earlyoom-configuration
earlyoom-configuration?
earlyoom-configuration-earlyoom
earlyoom-configuration-minimum-available-memory
@@ -61,6 +68,76 @@
zram-device-configuration-priority
zram-device-service-type))
+
+;;;
+;;; Thunderbolt daemon.
+;;;
+
+(define-record-type* <bolt-configuration>
+ bolt-configuration make-bolt-configuration bolt-configuration?
+ (package bolt-configuration-package ; package
+ (default bolt)))
+
+(define bolt-shepherd-service
+ (match-lambda
+ (($ <bolt-configuration> package)
+ (with-imported-modules (source-module-closure
+ '((gnu build shepherd)))
+ (shepherd-service
+ (documentation "Thunderbolt daemon")
+ (provision '(thunderbolt))
+ (requirement '(networking))
+ (modules '((gnu build shepherd)))
+ (start #~(make-forkexec-constructor/container
+ (list #$(file-append package "/libexec/boltd"))
+=09=09 ))
+ (stop #~(make-kill-destructor)))))))
+
+(define %bolt-activation
+ #~(begin
+ (use-modules (guix build utils))
+ (mkdir-p "/var/lib/boltd")))
+
+(define (bolt-dbus-service config)
+ (list (wrapped-dbus-service (bolt-configuration-bolt config)
+=09=09=09 "libexec/boltd"
+=09=09=09 `(("BOLT_CONF_FILE_NAME"
+=09=09=09=09 '("share/dbus-1/interfaces/org.freedesktop.bolt.xml"))))))
+
+(define %bolt-accounts
+ (list (user-group (name "boltd") (system? #t))
+ (user-account
+=09 (name "boltd")
+=09 (group "boltd")
+=09 (system? #t)
+=09 (comment "Boltd daemon user")
+=09 (home-directory "/var/empty")
+=09 (shell "/run/current-system/profile/sbin/nologin"))))
+
+(define bolt-udev-rule
+ (match-lambda
+ (($ <bolt-configuration> package)
+ (file->udev-rule "90-bolt.rules" (file-append package "/lib/udev/rules.d=
/90-bolt.rules")))))
+
+(define bolt-service-type
+ (service-type
+ (name 'boltd)
+ (description
+ "Thunderbolt daemon")
+ (extensions
+ (list (service-extension udev-service-type
+=09=09=09 (compose list bolt-udev-rule))
+=09 (service-extension activation-service-type
+=09=09=09 (const %bolt-activation))
+=09 (service-extension dbus-root-service-type
+=09 (compose list bolt-configuration-package))
+=09;=09=09 bolt-dbus-service)
+=09 (service-extension account-service-type
+=09=09=09 (const %bolt-accounts))
+ (service-extension shepherd-root-service-type
+ (compose list bolt-shepherd-service))))
+ (default-value (bolt-configuration))))
+
;;;
;;; Early OOM daemon.
--
2.32.0
guix-patches@HIDDEN:bug#49578; Package guix-patches.
Full text available.
Received: (at 49578) by debbugs.gnu.org; 18 Sep 2021 11:20:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 18 07:20:56 2021
Received: from localhost ([127.0.0.1]:33717 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mRYOt-0002ED-Lg
for submit <at> debbugs.gnu.org; Sat, 18 Sep 2021 07:20:55 -0400
Received: from mail-40131.protonmail.ch ([185.70.40.131]:48156)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <phodina@HIDDEN>) id 1mRYOr-0002Dy-Eh
for 49578 <at> debbugs.gnu.org; Sat, 18 Sep 2021 07:20:54 -0400
Date: Sat, 18 Sep 2021 11:20:38 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail; t=1631964042;
bh=FH0szmAH2G3rc73F72xakI7yO4JGE6NvN7XvVcvm3zs=;
h=Date:To:From:Cc:Reply-To:Subject:From;
b=Je8qgKbsriqYNboHQcceMAVBxFzBvn4g0p/Xi3R1twPzFik6JSxAKFKAP4XFy01lq
2Ns1Sd5pliyy3112/aR48gQ8Ptl/CLlaNsLy7dvqokcjHZxKa3Us3Mt8QDiQy8Q3Y+
gS/IxRpYhdElD6heTv+ydbAPAr2urKLXrSE0WrMw=
To: Sarah Morgensen <iskarian@HIDDEN>
From: phodina <phodina@HIDDEN>
Subject: [PATCH v3 1/2] gnu: Add bolt.
Message-ID: <IpWOs4rfABoT7fYcMUB85zS3FRn8ZwpMv_PQzYRjT6aj14ZdfbW8KLgQB9oOJFHKni5PmV5CSNs4h9qbDCpG3DgqGF2btkjbIRCabQV24Zo=@protonmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no
autolearn=disabled version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
mailout.protonmail.ch
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 49578
Cc: 49578 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: phodina <phodina@HIDDEN>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
* gnu/packages/linux.scm: (bolt): New variable.
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 46c9f817a8..3ec896bba6 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -121,6 +121,7 @@
#:use-module (gnu packages perl)
#:use-module (gnu packages pciutils)
#:use-module (gnu packages pkg-config)
+ #:use-module (gnu packages polkit)
#:use-module (gnu packages popt)
#:use-module (gnu packages pulseaudio)
#:use-module (gnu packages python)
@@ -2655,6 +2656,56 @@ IPv6 packet filter.
Both commands are targeted at system administrators.")
(license license:gpl2+)))
+(define-public bolt
+ (package
+ (name "bolt")
+ (version "0.9.1")
+ (source (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://gitlab.freedesktop.org/bolt/bolt")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1phgp8fs0dlj74kbkqlvfniwc32daz47b3pvsxlfxqzyrp77xrfm"))))
+ (build-system meson-build-system)
+ (arguments
+ `(#:configure-flags (list "--localstatedir=3D/var")
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'replace-directories
+ (lambda* (#:key outputs #:allow-other-keys)
+ (substitute* "meson.build"
+ (("udev.get_pkgconfig_variable..udevdir..")
+ (string-append "'" (assoc-ref %outputs "out") "/lib/udev'"=
)))
+ (substitute* "meson.build"
+ ((".*scripts/meson-install.sh.*") ""))))
+ (add-before 'install 'no-polkit-magic
+ (lambda* (#:key outputs #:allow-other-keys)
+ ;; Meson =E2=80=98magically=E2=80=99 invokes pkexec, which fa=
ils (not setuid).
+ (setenv "PKEXEC_UID" "something"))))))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)
+ ("glib:bin" ,glib "bin")
+ ("asciidoc" ,asciidoc)
+ ("umockdev" ,umockdev)))
+ (inputs
+ `(("eudev" ,eudev)
+ ("dbus" ,dbus)
+ ("polkit" ,polkit)))
+ (synopsis "Userspace system daemon for Thunderbolt")
+ (description "Userspace daemon @code{boltd} exposes devices via D-Bus =
to clients.
+It stores database of previously authorized devices and depending
+on the policy set for the individual devices, automatically authorize newl=
y
+connected devices without user interaction. It also adapts its behaivour =
when
+iommu support is detected.
+Command line utility 'boltctl' can be used to manage thundebolt devices.
+It can list devices, monitor changes and initiate authorization of device.=
")
+ (home-page "https://gitlab.freedesktop.org/bolt/bolt")
+ (license license:gpl2+)))
+
(define-public jitterentropy-rngd
(package
(name "jitterentropy-rngd")
--
2.32.0
guix-patches@HIDDEN:bug#49578; Package guix-patches.
Full text available.Received: (at 49578) by debbugs.gnu.org; 22 Jul 2021 20:02:11 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 22 16:02:11 2021 Received: from localhost ([127.0.0.1]:41691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1m6etW-000294-Va for submit <at> debbugs.gnu.org; Thu, 22 Jul 2021 16:02:11 -0400 Received: from out1.migadu.com ([91.121.223.63]:43195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <iskarian@HIDDEN>) id 1m6etT-00025k-S1 for 49578 <at> debbugs.gnu.org; Thu, 22 Jul 2021 16:02:09 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1626984126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hgKubk9hZTGkxqU4T65hVjmWoR4hE+bbLm3+K69ecY4=; b=j/0VieFRwnWuEsUCPqwG09TBP3uDzqEQWASRJVm/1OBcLu2XWfuw5L4L2Z3lZCM7ZGqYLK q9x7oppfr/X5Ln6PLD8cbjUeVkW3pxWc2C2cfKjIGsRUJriRFWPTHxu7hFyhu6Qorj0+s6 728esRyRK7QEC/LgfO5jhUJ9rH3jneA= From: Sarah Morgensen <iskarian@HIDDEN> To: phodina <phodina@HIDDEN> Subject: Re: bug#49578: [PATCH] Add bolt References: <M1akxhPbhdsagfKtQNdUvQ_gr7_am4nX--PrR6Q_xlyvSCkuUoDtFRURxw8xHioONjC36RuHVt-wy18yvV-EeegHIEOUos87NROWijau444=@protonmail.com> <86o8avrua2.fsf@HIDDEN> <1aJRSz6qFjmFhYY0CBesLTTG0pCFP3k4W0lONoiRV7XP6fDy07As2nMW1DicJXJws8O3IXC-qZLar49bOBNy1FD_I3kNTHUqNRUcNMMtXRo=@protonmail.com> <hLPvIp8Fqu0eBUVfaBG6dhJJdV3oS0fHf_nVr-sCJZ2iUd1-oHiCvVx6kw42JIupQa187HFlrCeCYh-ZdSzE-UOa1NmhZBgZBMUoDwL1R1Q=@protonmail.com> Date: Thu, 22 Jul 2021 13:02:02 -0700 In-Reply-To: <hLPvIp8Fqu0eBUVfaBG6dhJJdV3oS0fHf_nVr-sCJZ2iUd1-oHiCvVx6kw42JIupQa187HFlrCeCYh-ZdSzE-UOa1NmhZBgZBMUoDwL1R1Q=@protonmail.com> (phodina@HIDDEN's message of "Thu, 22 Jul 2021 11:36:53 +0000") Message-ID: <86bl6urubp.fsf_-_@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49578 Cc: 49578 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Hi, phodina <phodina@HIDDEN> writes: > Also would you have recommendation on how to create a service for the daemon boltd? > > Currently it's a good step to have it packaged, but without a running service it's little bit pointless. > > There is probably something similar that I can check, learn how the services work and modify it for the thunderbolt case. I'm assuming you mean a service to run on Guix System, yes? There is a section in the manual on this https://guix.gnu.org/manual/en/html_node/Defining-Services.html which has a couple examples. You'll probably want to make a shepherd service (shepherd is Guix System's services manager). You can also read the code for existing services in gnu/services/*.scm. I'm not very familiar with services so unfortunately I can't point you at any similar ones. Best of luck! -- Sarah
guix-patches@HIDDEN:bug#49578; Package guix-patches.
Full text available.Received: (at 49578) by debbugs.gnu.org; 22 Jul 2021 11:37:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 22 07:37:03 2021 Received: from localhost ([127.0.0.1]:39485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1m6X0h-0008Bu-C4 for submit <at> debbugs.gnu.org; Thu, 22 Jul 2021 07:37:03 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:28029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <phodina@HIDDEN>) id 1m6X0e-0008BP-TX for 49578 <at> debbugs.gnu.org; Thu, 22 Jul 2021 07:37:02 -0400 Date: Thu, 22 Jul 2021 11:36:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1626953814; bh=LtJr1ed0kzI1VuhS1JqdzTewfhRbAPBIGpTidh7IOfA=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=RlsqYLYkjTaY8SooNqfci0LYVGohLs39oP12+9shyFB4rJDKPmFQqJse9XBBufufz yn7KXOwGdNIopJdOp76FKskH+XWO1F619h2F8FvftXj9KW6hqb+b1h4Zii6N2BU2wL YndgA09YiNci3Y2NPt/kPpees39Isr7c12rJ/e10= To: Sarah Morgensen <iskarian@HIDDEN> From: phodina <phodina@HIDDEN> Subject: Re: bug#49578: [PATCH] Add bolt Message-ID: <hLPvIp8Fqu0eBUVfaBG6dhJJdV3oS0fHf_nVr-sCJZ2iUd1-oHiCvVx6kw42JIupQa187HFlrCeCYh-ZdSzE-UOa1NmhZBgZBMUoDwL1R1Q=@protonmail.com> In-Reply-To: <1aJRSz6qFjmFhYY0CBesLTTG0pCFP3k4W0lONoiRV7XP6fDy07As2nMW1DicJXJws8O3IXC-qZLar49bOBNy1FD_I3kNTHUqNRUcNMMtXRo=@protonmail.com> References: <M1akxhPbhdsagfKtQNdUvQ_gr7_am4nX--PrR6Q_xlyvSCkuUoDtFRURxw8xHioONjC36RuHVt-wy18yvV-EeegHIEOUos87NROWijau444=@protonmail.com> <86o8avrua2.fsf@HIDDEN> <1aJRSz6qFjmFhYY0CBesLTTG0pCFP3k4W0lONoiRV7XP6fDy07As2nMW1DicJXJws8O3IXC-qZLar49bOBNy1FD_I3kNTHUqNRUcNMMtXRo=@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49578 Cc: 49578 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: phodina <phodina@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Also would you have recommendation on how to create a service for the daemo= n boltd? Currently it's a good step to have it packaged, but without a running servi= ce it's little bit pointless. There is probably something similar that I can check, learn how the service= s work and modify it for the thunderbolt case.
guix-patches@HIDDEN:bug#49578; Package guix-patches.
Full text available.
Received: (at 49578) by debbugs.gnu.org; 22 Jul 2021 11:32:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 22 07:32:34 2021
Received: from localhost ([127.0.0.1]:39481 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1m6WwL-00080F-Gr
for submit <at> debbugs.gnu.org; Thu, 22 Jul 2021 07:32:33 -0400
Received: from mail-4322.protonmail.ch ([185.70.43.22]:27275)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <phodina@HIDDEN>) id 1m6WwI-0007tL-8s
for 49578 <at> debbugs.gnu.org; Thu, 22 Jul 2021 07:32:31 -0400
Date: Thu, 22 Jul 2021 11:32:23 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail; t=1626953543;
bh=79lS7ih1IP9M+bwy3uQEfq1yntflwCSPX/2dPHD3n9U=;
h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From;
b=VR1UcVovEZfjfl6XG5asyN0xSS5RXzcR64YmfRDVGHQFufKQ/7tZitfZrCPZwkxYh
CAtyt9vNVdLB0R1A1Edpt4CFYNTlqTRsSdx64UtmzzHRKbgZ6NhzTWPY/v2B1W19P+
2cy0VQ7g2SKs9l2FnVRdkNfBVvvKhVpox29TxYOc=
To: Sarah Morgensen <iskarian@HIDDEN>
From: phodina <phodina@HIDDEN>
Subject: Re: bug#49578: [PATCH] Add bolt
Message-ID: <1aJRSz6qFjmFhYY0CBesLTTG0pCFP3k4W0lONoiRV7XP6fDy07As2nMW1DicJXJws8O3IXC-qZLar49bOBNy1FD_I3kNTHUqNRUcNMMtXRo=@protonmail.com>
In-Reply-To: <86o8avrua2.fsf@HIDDEN>
References: <M1akxhPbhdsagfKtQNdUvQ_gr7_am4nX--PrR6Q_xlyvSCkuUoDtFRURxw8xHioONjC36RuHVt-wy18yvV-EeegHIEOUos87NROWijau444=@protonmail.com>
<86o8avrua2.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no
autolearn=disabled version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
mailout.protonmail.ch
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 49578
Cc: 49578 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: phodina <phodina@HIDDEN>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi Sarah,
Thanks for the suggestions. Fixes:
- polkit in alphabethical order
- line wraping
- /var dir location
- removed #t in phases
- simplified udev rules install
- more useful synopsis
---
index 41902e7785..6050871264 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -119,6 +119,7 @@
#:use-module (gnu packages perl)
#:use-module (gnu packages pciutils)
#:use-module (gnu packages pkg-config)
+ #:use-module (gnu packages polkit)
#:use-module (gnu packages popt)
#:use-module (gnu packages pulseaudio)
#:use-module (gnu packages python)
@@ -2479,6 +2480,59 @@ IPv6 packet filter.
Both commands are targeted at system administrators.")
(license license:gpl2+)))
+(define-public bolt
+ (package
+ (name "bolt")
+ (version "0.9.1")
+ (source (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://gitlab.freedesktop.org/bolt/bolt")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1phgp8fs0dlj74kbkqlvfniwc32daz47b3pvsxlfxqzyrp77xrfm"))))
+ (build-system meson-build-system)
+ (arguments
+ `(#:configure-flags (list "--localstatedir=3D/var")
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'replace-directories
+ (lambda* (#:key outputs #:allow-other-keys)
+ (substitute* "meson.build"
+ (("udev.get_pkgconfig_variable..udevdir..")
+ (string-append "'" (assoc-ref %outputs "out") "/lib/udev'"=
)))
+=09 (substitute* "meson.build"
+ ((".*scripts/meson-install.sh.*") ""))
+=09 ))
+ (add-before 'install 'no-polkit-magic
+ (lambda* (#:key outputs #:allow-other-keys)
+ ;; Meson =E2=80=98magically=E2=80=99 invokes pkexec, which fa=
ils (not setuid).
+ (setenv "PKEXEC_UID" "something")
+ )))))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)
+ ("dbus" ,dbus)
+ ("asciidoc" ,asciidoc)
+ ("umockdev" ,umockdev)))
+ (inputs
+ `(("glib:bin" ,glib "bin")
+ ("eudev" ,eudev)
+ ("polkit" ,polkit)))
+ (synopsis "Userspace system daemon to enable security levels
+for Thunderbolt=E2=84=A2 on GNU/Linux=C2=AE.")
+ (description "Userspace daemon 'boltd' exposes devices via D-Bus to cl=
ients.
+It stores database of previously authorized devices and depending
+on the policy set for the individual devices, auomatically authorize newly
+connected devices without user interaction. It also adapts its behaivour w=
hen
+iommu support is detected.
+Command line utility 'boltctl' can be used to manage thundebolt devices. I=
t can
+list devices, monitor changes and initiate authorization of device.")
+ (home-page "https://gitlab.freedesktop.org/bolt/bolt")
+ (license license:gpl2+)))
+
(define-public jitterentropy-rngd
(package
(name "jitterentropy-rngd")
--
2.31.1
guix-patches@HIDDEN:bug#49578; Package guix-patches.
Full text available.
Received: (at 49578) by debbugs.gnu.org; 22 Jul 2021 01:50:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jul 21 21:50:53 2021
Received: from localhost ([127.0.0.1]:39085 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1m6NrQ-0007aN-QB
for submit <at> debbugs.gnu.org; Wed, 21 Jul 2021 21:50:53 -0400
Received: from out2.migadu.com ([188.165.223.204]:35944)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <iskarian@HIDDEN>) id 1m6NrO-0007aD-5w
for 49578 <at> debbugs.gnu.org; Wed, 21 Jul 2021 21:50:51 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1;
t=1626918647;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=V+6l2A+/xzk7nIF19fPwY8V5Tkd9pXf/d6rJd2habXI=;
b=JHyEOujFNhovZ7r0k8XcRmWC/Lh/AfOP6liueYmle1duG7mtP3xlsh4KKHJnD5u1gC26zk
2g2jxnwRnRpqj9t1hdRjc+w33GjpNJ8VD8RE4Gc/YmrNii59E1E3vjlY2f8ElECyspbV7i
C8H/RsT9LcE/VOSNXvPDpNueC004qpU=
From: Sarah Morgensen <iskarian@HIDDEN>
To: phodina <phodina@HIDDEN>
Subject: Re: bug#49578: [PATCH] Add bolt
References: <M1akxhPbhdsagfKtQNdUvQ_gr7_am4nX--PrR6Q_xlyvSCkuUoDtFRURxw8xHioONjC36RuHVt-wy18yvV-EeegHIEOUos87NROWijau444=@protonmail.com>
Date: Wed, 21 Jul 2021 18:50:45 -0700
In-Reply-To: <M1akxhPbhdsagfKtQNdUvQ_gr7_am4nX--PrR6Q_xlyvSCkuUoDtFRURxw8xHioONjC36RuHVt-wy18yvV-EeegHIEOUos87NROWijau444=@protonmail.com>
(phodina@HIDDEN's message of "Thu, 15 Jul 2021 16:46:01 +0000")
Message-ID: <86o8avrua2.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: iskarian@HIDDEN
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 49578
Cc: 49578 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hello,
Thanks for the patch. It's always good to see new contributors around
here! I have a few suggestions for your patch.
phodina <phodina@HIDDEN> writes:
> ---
> index 4b57bc1f24..d07ee33a7e 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -123,6 +123,7 @@
> #:use-module (gnu packages pulseaudio)
> #:use-module (gnu packages python)
> #:use-module (gnu packages python-xyz)
> + #:use-module (gnu packages polkit)
> #:use-module (gnu packages readline)
> #:use-module (gnu packages rrdtool)
> #:use-module (gnu packages samba)
> @@ -2479,6 +2480,52 @@ IPv6 packet filter.
> Both commands are targeted at system administrators.")
> (license license:gpl2+)))
>
> +(define-public bolt
> + (package
> + (name "bolt")
> + (version "0.9.1")
> + (source (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://gitlab.freedesktop.org/bolt/bolt")
> + (commit version)))
> + (sha256
> + (base32
> + "1phgp8fs0dlj74kbkqlvfniwc32daz47b3pvsxlfxqzyrp77xrfm"))=
))
> + (build-system meson-build-system)
> + (arguments
> + `(#:configure-flags (list (string-append "--localstatedir=3D" (asso=
c-ref %outputs "out") "/var"))
Are you sure this shouldn't be "--localstatedir=3D/var"? As it is, it
refers to the read-only directory /gnu/store/...-bolt-0.9.1/var.
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'fix-udev-rules-directory
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + (mkdir-p (string-append out "/lib/udev/rules.d"))
^ I think this is not necessary...
> + (substitute* "meson.build"
> + (("udev.get_pkgconfig_variable..udevdir..")
> + (string-append "'" out "/lib'")))#t)))
...with this change: ^ /lib/udev
> + (add-before 'install 'no-polkit-magic
> + (lambda* (#:key outputs #:allow-other-keys)
> + ;; Meson =E2=80=98magically=E2=80=99 invokes pkexec, which =
fails (not setuid).
> + (setenv "PKEXEC_UID" "something")
> + #t)))))
^ Phases no longer need to end with #t, so you can omit thi=
s.
> + (native-inputs `(("pkg-config" ,pkg-config) ("dbus" ,dbus) ("asciido=
c" ,asciidoc) ("umockdev" ,umockdev)))
Please wrap lines at 80 characters, and in the special case of package
inputs like here, each input should get its own line, like:
(native-inputs
`(("pkg-config" ,pkg-config)
("dbus" ,dbus)
("asciidoc" ,asciidoc)
("umockdev" ,umockdev)))
> + (inputs `(("glib:bin" ,glib "bin") ("eudev" ,eudev) ("polkit" ,polki=
t)))
> + (synopsis "Userspace system daemon to enable security levels for Thu=
nderbolt=E2=84=A2
> +on GNU/Linux=C2=AE.")
> + (description "Thunderbolt=E2=84=A2 is the brand name of a hardware i=
nterface developed by
> +Intel=C2=AE that allows the connection of external peripherals to a
> +computer.
> +Devices connected via Thunderbolt can be DMA masters and thus read
> +system memory without interference of the operating system (or even
> +the CPU). Version 3 of the interface introduced 5 different security
> +levels, in order to mitigate the aforementioned security risk that
> +connected devices pose to the system. The security level is set by the
> +system firmware.")
> + (home-page "https://gitlab.freedesktop.org/bolt/bolt")
> + (license license:gpl2+)))
> +
> (define-public jitterentropy-rngd
> (package
> (name "jitterentropy-rngd")
> --
> 2.31.1
--
Sarah
guix-patches@HIDDEN:bug#49578; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 15 Jul 2021 16:46:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 15 12:46:13 2021
Received: from localhost ([127.0.0.1]:49573 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1m44V2-00051A-T9
for submit <at> debbugs.gnu.org; Thu, 15 Jul 2021 12:46:13 -0400
Received: from lists.gnu.org ([209.51.188.17]:55806)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <phodina@HIDDEN>) id 1m44V0-000512-Dy
for submit <at> debbugs.gnu.org; Thu, 15 Jul 2021 12:46:11 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:55322)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <phodina@HIDDEN>)
id 1m44Uz-00006x-Rn
for guix-patches@HIDDEN; Thu, 15 Jul 2021 12:46:10 -0400
Received: from mail-4316.protonmail.ch ([185.70.43.16]:38147)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <phodina@HIDDEN>)
id 1m44Ux-0005aW-77
for guix-patches@HIDDEN; Thu, 15 Jul 2021 12:46:09 -0400
Date: Thu, 15 Jul 2021 16:46:01 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail; t=1626367563;
bh=VPlR1mh65XfbwPZ/EUEAYwEUbyjgYfBe4wZ25pB1MD0=;
h=Date:To:From:Reply-To:Subject:From;
b=KYylTmXxkmncIluOWLIuqNKTouV4TfFwo04vADoo6JZgN2SvTi0jNNgqybTzhOpwE
YVHZjI/carLdnh5+gdscTEFznS7K/PstpeHmVZP+Gl/V/+KvGI3Zu2ojvbaJ9YBUNZ
EY/HWdi1vhlK7LhxUDlgGldkNs/l61Y+tzVvHc18=
To: "guix-patches@HIDDEN" <guix-patches@HIDDEN>
From: phodina <phodina@HIDDEN>
Subject: [PATCH] Add bolt
Message-ID: <M1akxhPbhdsagfKtQNdUvQ_gr7_am4nX--PrR6Q_xlyvSCkuUoDtFRURxw8xHioONjC36RuHVt-wy18yvV-EeegHIEOUos87NROWijau444=@protonmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no
autolearn=disabled version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
mailout.protonmail.ch
Received-SPF: pass client-ip=185.70.43.16; envelope-from=phodina@HIDDEN;
helo=mail-4316.protonmail.ch
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.6 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: phodina <phodina@HIDDEN>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)
---
index 4b57bc1f24..d07ee33a7e 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -123,6 +123,7 @@
#:use-module (gnu packages pulseaudio)
#:use-module (gnu packages python)
#:use-module (gnu packages python-xyz)
+ #:use-module (gnu packages polkit)
#:use-module (gnu packages readline)
#:use-module (gnu packages rrdtool)
#:use-module (gnu packages samba)
@@ -2479,6 +2480,52 @@ IPv6 packet filter.
Both commands are targeted at system administrators.")
(license license:gpl2+)))
+(define-public bolt
+ (package
+ (name "bolt")
+ (version "0.9.1")
+ (source (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://gitlab.freedesktop.org/bolt/bolt")
+ (commit version)))
+ (sha256
+ (base32
+ "1phgp8fs0dlj74kbkqlvfniwc32daz47b3pvsxlfxqzyrp77xrfm"))))
+ (build-system meson-build-system)
+ (arguments
+ `(#:configure-flags (list (string-append "--localstatedir=3D" (assoc-=
ref %outputs "out") "/var"))
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'fix-udev-rules-directory
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((out (assoc-ref outputs "out")))
+ (mkdir-p (string-append out "/lib/udev/rules.d"))
+ (substitute* "meson.build"
+ (("udev.get_pkgconfig_variable..udevdir..")
+ (string-append "'" out "/lib'")))#t)))
+ (add-before 'install 'no-polkit-magic
+ (lambda* (#:key outputs #:allow-other-keys)
+ ;; Meson =E2=80=98magically=E2=80=99 invokes pkexec, which fa=
ils (not setuid).
+ (setenv "PKEXEC_UID" "something")
+ #t)))))
+ (native-inputs `(("pkg-config" ,pkg-config) ("dbus" ,dbus) ("asciidoc"=
,asciidoc) ("umockdev" ,umockdev)))
+ (inputs `(("glib:bin" ,glib "bin") ("eudev" ,eudev) ("polkit" ,polkit)=
))
+ (synopsis "Userspace system daemon to enable security levels for Thund=
erbolt=E2=84=A2
+on GNU/Linux=C2=AE.")
+ (description "Thunderbolt=E2=84=A2 is the brand name of a hardware int=
erface developed by
+Intel=C2=AE that allows the connection of external peripherals to a
+computer.
+Devices connected via Thunderbolt can be DMA masters and thus read
+system memory without interference of the operating system (or even
+the CPU). Version 3 of the interface introduced 5 different security
+levels, in order to mitigate the aforementioned security risk that
+connected devices pose to the system. The security level is set by the
+system firmware.")
+ (home-page "https://gitlab.freedesktop.org/bolt/bolt")
+ (license license:gpl2+)))
+
(define-public jitterentropy-rngd
(package
(name "jitterentropy-rngd")
--
2.31.1
phodina <phodina@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#49578; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.