GNU bug report logs - #49583
[PATH] gnu: Add transmission-remote-gtk.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49583 in the body.
You can then email your comments to 49583 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Justin Veilleux <justun1011 <at> gmail.com>
To: bug-guix <at> gnu.org
Subject: [PATH] gnu: Add transmission-remote-gtk.
Date: Thu, 15 Jul 2021 14:31:08 -0400

[Message part 1 (text/plain, inline)]

[Message part 2 (text/html, inline)]

[file.patch (text/x-patch, attachment)]

Message #8 received at 49583 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Justin Veilleux <justun1011 <at> gmail.com>
Cc: 49583 <at> debbugs.gnu.org
Subject: Re: bug#49583: [PATH] gnu: Add transmission-remote-gtk.
Date: Thu, 15 Jul 2021 16:56:27 -0400

On Thu, Jul 15, 2021 at 02:31:08PM -0400, Justin Veilleux wrote:
> From 426aa9bd6b758628249df7c0925179ce39054f29 Mon Sep 17 00:00:00 2001
> From: terramorpha <terramorpha <at> cock.li>
> Date: Thu, 15 Jul 2021 14:27:35 -0400
> Subject: [PATCH] gnu: Add transmission-remote-gtk.
> 
> * gnu/packages/bittorrent.scm (transmission-remote-gtk): New variable.

Thanks! Overall looks good.

I ran `guix lint` on it and got these warnings which should be addressed:

/home/leo/work/guix/gnu/packages/bittorrent.scm:165:5: transmission-remote-gtk <at> 1.4.1: 'gettext' should probably be a native input
/home/leo/work/guix/gnu/packages/bittorrent.scm:161:0: transmission-remote-gtk <at> 1.4.1: parentheses feel lonely, move to the previous or next line
/home/leo/work/guix/gnu/packages/bittorrent.scm:170:14: transmission-remote-gtk <at> 1.4.1: synopsis should start with an upper-case letter or digit
/home/leo/work/guix/gnu/packages/bittorrent.scm:170:14: transmission-remote-gtk <at> 1.4.1: no article allowed at the beginning of the synopsis

> +    (arguments
> +     `(#:tests? #f ; the tests fail
> +                ))

We need more of an explanation for why the tests should be disabled. Did
you look into the failure and try to determine if it represents some
real problems?

Message #11 received at 49583 <at> debbugs.gnu.org (full text, mbox):

From: Justin Veilleux <justun1011 <at> gmail.com>
To: 49583 <at> debbugs.gnu.org
Cc: leo <at> famulari.name
Subject: [PATCH v2]
Date: Fri, 16 Jul 2021 12:01:41 -0400

[Message part 1 (text/plain, inline)]

I addressed the problems the previous patch had.

About the tests, the reason they fail is because (IIUC) an age rating tag
in some manifest.xml file is missing.

[Message part 2 (text/html, inline)]

[file.patch (text/x-patch, attachment)]

Message #16 received at 49583-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Justin Veilleux <justun1011 <at> gmail.com>
Cc: 49583-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2]
Date: Fri, 16 Jul 2021 23:55:06 -0400

On Fri, Jul 16, 2021 at 12:01:41PM -0400, Justin Veilleux wrote:
> I addressed the problems the previous patch had.

Thanks!

> About the tests, the reason they fail is because (IIUC) an age rating tag
> in some manifest.xml file is missing.

Okay. I found the upstream bug report:

https://github.com/transmission-remote-gtk/transmission-remote-gtk/issues/95

I cherry-picked the bug fix, added it to your patch, and pushed as
9cb35c02164d929fcb8929e7f454df215df8cf25 after making some cosmetic
changes to the package definition. Also, I changed the license to "GPL 2
or later" since the primary source files include the "or later" clause
in their license headers.

Thanks again!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.