GNU bug report logs - #49592
28.0.50; lisp-current-defun-name and non-standard defuns

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Michael Heerdegen <michael_heerdegen@HIDDEN>; dated Fri, 16 Jul 2021 02:55:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
Removed tag(s) moreinfo. Request was from Lars Ingebrigtsen <larsi@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 49592 <at> debbugs.gnu.org:


Received: (at 49592) by debbugs.gnu.org; 24 Aug 2022 10:23:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 24 06:23:51 2022
Received: from localhost ([127.0.0.1]:45705 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oQnY6-0006Gk-Ta
	for submit <at> debbugs.gnu.org; Wed, 24 Aug 2022 06:23:51 -0400
Received: from quimby.gnus.org ([95.216.78.240]:48016)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1oQnY4-0006GY-Hu
 for 49592 <at> debbugs.gnu.org; Wed, 24 Aug 2022 06:23:49 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References:
 In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=0YThYGvpDWiCMu9Gl107VlLaY92bB9ZWgtbCGhpKn8s=; b=lqP4mjPRFfEl3/XFcnCq0MaiiA
 V6EUEzs8km/qhRd9x/eyLVrKAFBpjJ9kmPNWkrijA0PEABzLq7pn+x1/OetPjltkl4gp8tZzM6fc0
 Agp1+mkfE84mSOonjFXEMuP+4AXA/HmRHx1vXckf2sFATGpvWxhrXU1/Nm3m06AIckTI=;
Received: from [84.212.220.105] (helo=joga)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1oQnXw-0004Ki-LR; Wed, 24 Aug 2022 12:23:42 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Subject: Re: bug#49592: 28.0.50; lisp-current-defun-name and non-standard
 defuns
In-Reply-To: <87bksain4m.fsf@HIDDEN> (Michael Heerdegen's message of "Wed, 24
 Aug 2022 00:57:45 +0200")
References: <878s279dfi.fsf@HIDDEN> <87edxwezs5.fsf@HIDDEN>
 <87wnbnigm4.fsf@HIDDEN> <87fsiac38p.fsf@HIDDEN>
 <87mtci1az5.fsf@HIDDEN> <874jyp7el4.fsf@HIDDEN>
 <87k07krehq.fsf@HIDDEN> <87sfm6zzjj.fsf@HIDDEN>
 <87h72mjhav.fsf@HIDDEN> <87wnbhxwnp.fsf@HIDDEN>
 <87pmh658th.fsf@HIDDEN> <87a689pkm4.fsf@HIDDEN>
 <87bksbtfug.fsf@HIDDEN> <87bksain4m.fsf@HIDDEN>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj
 SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUfWT/brS2Abn3g
 zrX///8fLI/6AAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YIGAoHLjcUeFAAAAFxSURBVDjLdZSJtcQg
 CEWVaUBjA4oNROm/t8/iku0zc+ZErjwQyTg3zAdwcLi3efnJb/+Hawh9w6i+8gr3h62CLeGZAi1w
 BbA+6ArxkO0rwM8d7Au3zNPCjygR1UbnA1Qa1iE/QJvAItoTNO1QLwXZfWCeUq35KIAIay1X0PVE
 vVPH2lK9AK0KsddOLe0IMtCZEMWDw+6AM/SOnJz1zL0BIYMSBohLiiWQqzpVKvFhBuAkRKXXc+ZI
 s6ph+ae1rnL/NWmTdiuIpMQg7rYn/jCopG3Il/vgYgIC8hcWaPM+0GFmGTAlaDOJRGRw+Lpzbgo7
 4QYaJ6cTlKDLloNUics8IYMwyCtC9gtgIU4jYyxXm6xai1CVzJt5ENU/gVQ7cmipqdmYQUaZ4rw7
 IrPZudHaa8t9KClc1qlXsA64BlyGL+5x57fD20oqLAEuIF5e0v3s3QDewpZWvD/oqaJVO/caL8Pv
 4iXDPTa8wNdfzf1kn+APysxK5VK9dhMAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDgtMjRUMTA6
 MDc6NDYrMDA6MDCzKa94AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA4LTI0VDEwOjA3OjQ2KzAw
 OjAwwnQXxAAAAABJRU5ErkJggg==
X-Now-Playing: The Flying Lizards's _The Flying Lizards_: "Summertime Blues
 (12" version)"
Date: Wed, 24 Aug 2022 12:23:36 +0200
Message-ID: <87fshmos7r.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  Michael Heerdegen <michael_heerdegen@HIDDEN> writes: > Is
 that because of `make-obsolete-variable's (indent defun) spec? (And > is that
 even appropriate?) > > Did you see examples where the edebug spec based
 mechanism you added > failed? Or maybe only t [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 49592
Cc: 49592 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Michael Heerdegen <michael_heerdegen@HIDDEN> writes:

> Is that because of `make-obsolete-variable's (indent defun) spec?  (And
> is that even appropriate?)
>
> Did you see examples where the edebug spec based mechanism you added
> failed?  Or maybe only this part:
>
>   (and (eq (get symbol 'lisp-indent-function) 'defun)
>        (get 'defun 'edebug-form-spec))
>
> was inappropriate?

The problem wasn't just with this function -- it turns out that we have
quite a few things that are used as top-level defining constructs that
aren't marked in any special way.  The old heuristics (i.e., "just use
the second bit in the form") handle these correctly.

But that means that I have no ideas for a practical way to fix the issue
this was supposed to fix -- i.e., top-level

(progn
  ;; 
  (foo-bar)
  ...)

and such.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#49592; Package emacs. Full text available.

Message received at 49592 <at> debbugs.gnu.org:


Received: (at 49592) by debbugs.gnu.org; 23 Aug 2022 22:57:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 23 18:57:55 2022
Received: from localhost ([127.0.0.1]:45234 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oQcqJ-00057e-23
	for submit <at> debbugs.gnu.org; Tue, 23 Aug 2022 18:57:55 -0400
Received: from mout.web.de ([217.72.192.78]:35235)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1oQcqG-00057Q-Dp
 for 49592 <at> debbugs.gnu.org; Tue, 23 Aug 2022 18:57:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
 s=dbaedf251592; t=1661295466;
 bh=YxD6CbF7niGjACMUAIK6eeWxitz1ovicHEqe0S+LdQA=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date;
 b=g32X5gIO2w0wArE3r7pdPsLy6mBrF17kqSctmH+EPVBNl7+dMK9ytn6tK3ED0ynar
 4qyDQAaraR57WQ23sBV2H8MFyT+tVbGfT72UubNgQ7d12JbtOQNTn310zrJQnDrDRq
 AayzZM5wB6X08pSfYeixos2tzm8YL7gamSFV0xMs=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb105
 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MovjQ-1pEoxY062g-00qN41; Wed, 24
 Aug 2022 00:57:46 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: Re: bug#49592: 28.0.50; lisp-current-defun-name and non-standard
 defuns
In-Reply-To: <87bksbtfug.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Tue,
 23 Aug 2022 12:27:19 +0200")
References: <878s279dfi.fsf@HIDDEN> <87edxwezs5.fsf@HIDDEN>
 <87wnbnigm4.fsf@HIDDEN> <87fsiac38p.fsf@HIDDEN>
 <87mtci1az5.fsf@HIDDEN> <874jyp7el4.fsf@HIDDEN>
 <87k07krehq.fsf@HIDDEN> <87sfm6zzjj.fsf@HIDDEN>
 <87h72mjhav.fsf@HIDDEN> <87wnbhxwnp.fsf@HIDDEN>
 <87pmh658th.fsf@HIDDEN> <87a689pkm4.fsf@HIDDEN>
 <87bksbtfug.fsf@HIDDEN>
Date: Wed, 24 Aug 2022 00:57:45 +0200
Message-ID: <87bksain4m.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:yTGoV3384Ry+NhCbxMcMb5FRZfjZyQ36ruL9vEsrYSmdv7R7ra1
 UpKwaPTnzfIsJzhopdL7P+6I0OTzggzHnmQw63Ac+EAUKioWuXX5Zz5iXH2XDJCDGD9+UFU
 Gzk6upLikYh4lonUKJd6rMLIYsvvGAggrYPFJj/LcaD6yJYvGgKktRfAsKdzvbslDyVKljG
 IPHWImwJQyvpULn2J1MeA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:y/If+Nin5OQ=:OhTZ1NA0Ml8ewTQ3vJKz1I
 T/UJuBHV36gGkep0XRf84hB6dbhyILJHiXbbkf/obujrTGx0fCx3lDw3h1U5REL+o8pFnutMK
 8U4VPKrUgNrgb0ibC1ujQ4OrxBZiw3MLvZK6DuCkX9ImNuz4vL5fESv2cSyEQqYSRYLg2PEvy
 X6nRn4OzB+iPU6w9hJRWmb9krH4Uqywg2X4qLme0WRS0rYxcK+eaKj86797QbdtEZitiXH/U1
 JdjkVXHbkVjBk4lEwfSt343CsN/L67dFjEXU+ZSFhtWZlxPi6p8gTzDwKxTTy7Xxh/+yx3ey3
 tBwRLy8jb0k0FMDP09YB6QXP0DsHh1v8pHMbyd0+SJzPpmWvpEdbamBRw/aK0fsq5Ip/NZCQj
 0YKpGpQ4kFzaBvlhUmzQJHptHqz3+n+64gyaZWHVCVlDVI5HyLi1jBgO4hqDn4X85SPH2lV+8
 PMpzhEjhmrHqW7pypVx8ksaFV3zyKJncS69iTqCAqetyCb/pJpKbzDEckQiyD+AMUobTymcp7
 Xxp51fTBLxmGxl87hDoawj3GkVND9eNatEXoPuJPEkqn+K7ccyqFPKAW3WY4Pi3qaA0ekoGBA
 Yz2+DOzawhIN8D6J2vNfuIajiWR4FNrXZkdUPf0hcL0gXmzcwh/L/kJ+h/lI4V5lmdko4rIRP
 +9pJtx3KzB4K5m+AhckPGoWr5Eyvd2ErhF3O4A/tu2Fm2XyoV+9JhdSNVDa5Ibod5Ucc0P1Rq
 jX94WEmHi7y772sx7+aNFe5cfyLwkOmuYdMo3abaYsL5Jbd9KTBPTK+d4zUS4DfIBgsc5hE2Y
 Ibh1hrmj1mlMfBff0o0/u2TJWdP9PB+GoDJXJVjY1LfP4jEXL/eF6K0+LVuxwOTou/zxM10TH
 rOmAchi3sLL5BTnI8idzFp53j/WsURQrwX69T8vvmsh79PRKqa0GX7TFz8nJB9oKSmaGfvL0d
 KxTvejR5GaMOU/K8LH81UWNoBVqH6/Y2e9P5CZccDJ3w7F0+PniuDQgDbwSu25ktGWwou/4aa
 L+tJkn16SC/grqDswyPcaRaGiDmd9C+1zDw9/glwUn37K7iJqYRu6VHy5OLDYBTCxqvjry4Rn
 OypP9DkC7zy1Vy2eOwO5u1BWyXth9ggJ2PcSvuGpDbss6ydDXMNQEfQ5g==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 49592
Cc: 49592 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Lars Ingebrigtsen <larsi@HIDDEN> writes:

> 2022-08-23  Lars Ingebrigtsen  <larsi@HIDDEN>
>
> 	* lisp/emacs-lisp/lisp-mode.el (lisp-current-defun-name): Revert
> 	back to the old version before bug#49592.  The new approach just
> 	doesn't work well enough -- we don't really have the data to know
> 	that, say, `make-obsolete-variable' is about the second symbol and
> 	not the first.

Is that because of `make-obsolete-variable's (indent defun) spec?  (And
is that even appropriate?)

Did you see examples where the edebug spec based mechanism you added
failed?  Or maybe only this part:

  (and (eq (get symbol 'lisp-indent-function) 'defun)
       (get 'defun 'edebug-form-spec))

was inappropriate?

Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#49592; Package emacs. Full text available.

Message received at 49592 <at> debbugs.gnu.org:


Received: (at 49592) by debbugs.gnu.org; 23 Aug 2022 10:27:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 23 06:27:30 2022
Received: from localhost ([127.0.0.1]:42711 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oQR85-0008S9-Sj
	for submit <at> debbugs.gnu.org; Tue, 23 Aug 2022 06:27:30 -0400
Received: from quimby.gnus.org ([95.216.78.240]:37004)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1oQR83-0008Rv-W0
 for 49592 <at> debbugs.gnu.org; Tue, 23 Aug 2022 06:27:28 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References:
 In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=ACfeLT9xmtBs9cohQb/fmq9iZVaupxzqXx1I9JhU2f0=; b=jPMGn5QBhlVthvkWxpNzY5gEk8
 6sztBn0VYN7moGvEj3Xof3mDMpVX94RcTjqn1hwORbJOIOKUfRpHP8geHO+ov0GsBPCYgOcHF55qw
 oP7UejswWNlOanHxu2hbM+k10OetRzNV2CQPT9DzUn2IlSiVGgqwfLDwdv98QiXfaVko=;
Received: from [84.212.220.105] (helo=joga)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1oQR7v-0007QN-Vf; Tue, 23 Aug 2022 12:27:22 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Subject: Re: bug#49592: 28.0.50; lisp-current-defun-name and non-standard
 defuns
In-Reply-To: <87a689pkm4.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Fri,
 12 Aug 2022 17:06:11 +0200")
References: <878s279dfi.fsf@HIDDEN> <87edxwezs5.fsf@HIDDEN>
 <87wnbnigm4.fsf@HIDDEN> <87fsiac38p.fsf@HIDDEN>
 <87mtci1az5.fsf@HIDDEN> <874jyp7el4.fsf@HIDDEN>
 <87k07krehq.fsf@HIDDEN> <87sfm6zzjj.fsf@HIDDEN>
 <87h72mjhav.fsf@HIDDEN> <87wnbhxwnp.fsf@HIDDEN>
 <87pmh658th.fsf@HIDDEN> <87a689pkm4.fsf@HIDDEN>
X-Now-Playing: David Allred's _Smells Like Everyone's Watching_: "Your Way"
Date: Tue, 23 Aug 2022 12:27:19 +0200
Message-ID: <87bksbtfug.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  I've now reverted these changes, because they just don't work
 well enough. As I said in the commit message: 2022-08-23 Lars Ingebrigtsen
 <larsi@HIDDEN> * lisp/emacs-lisp/lisp-mode.el (lisp-current-defun-name):
 Revert back to the old version before bug#49592. The new approach just doesn't
 work well enough -- we don't really have the data to know that [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 49592
Cc: 49592 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

I've now reverted these changes, because they just don't work well
enough.  As I said in the commit message:

2022-08-23  Lars Ingebrigtsen  <larsi@HIDDEN>

	* lisp/emacs-lisp/lisp-mode.el (lisp-current-defun-name): Revert
	back to the old version before bug#49592.  The new approach just
	doesn't work well enough -- we don't really have the data to know
	that, say, `make-obsolete-variable' is about the second symbol and
	not the first.

So another approach is needed here.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#49592; Package emacs. Full text available.
bug No longer marked as fixed in versions 29.1 and reopened. Request was from Debbugs Internal Request <help-debbugs@HIDDEN> to internal_control <at> debbugs.gnu.org. Full text available.

Message received at 49592 <at> debbugs.gnu.org:


Received: (at 49592) by debbugs.gnu.org; 12 Aug 2022 15:06:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 12 11:06:21 2022
Received: from localhost ([127.0.0.1]:58581 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oMWEv-0005g6-FH
	for submit <at> debbugs.gnu.org; Fri, 12 Aug 2022 11:06:21 -0400
Received: from quimby.gnus.org ([95.216.78.240]:55582)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1oMWEt-0005ft-P8
 for 49592 <at> debbugs.gnu.org; Fri, 12 Aug 2022 11:06:20 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References:
 In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=br8uUkkxpyliQXJbcjXkw93/35uOSJ5DRaPSnTyJ5Sg=; b=dIo5TIUkJsI4v7P8QhaL6GtsKe
 FXaAB9vVABNebjFXHVvt2/h3MWFTyiQANbWo6MT+nwMKHFEuFUfKSNsZbxxHhopcSQhbcJytoAE6P
 5saeTtsWwaeGCbwIm66FsrNYjUw0L8WtXpTJEaPFcBRu0DbKVpdBSg9t0iTEEP2TmVw4=;
Received: from [84.212.220.105] (helo=joga)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1oMWEl-0006FZ-P3; Fri, 12 Aug 2022 17:06:13 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Subject: Re: bug#49592: 28.0.50; lisp-current-defun-name and non-standard
 defuns
In-Reply-To: <87pmh658th.fsf@HIDDEN> (Michael Heerdegen's message of "Fri, 12
 Aug 2022 07:28:58 +0200")
References: <878s279dfi.fsf@HIDDEN> <87edxwezs5.fsf@HIDDEN>
 <87wnbnigm4.fsf@HIDDEN> <87fsiac38p.fsf@HIDDEN>
 <87mtci1az5.fsf@HIDDEN> <874jyp7el4.fsf@HIDDEN>
 <87k07krehq.fsf@HIDDEN> <87sfm6zzjj.fsf@HIDDEN>
 <87h72mjhav.fsf@HIDDEN> <87wnbhxwnp.fsf@HIDDEN>
 <87pmh658th.fsf@HIDDEN>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj
 SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXLtaDx6+OIXEnM
 qU7////Dgg/GAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YIDA04O9gjYMoAAAHCSURBVDjLZZQN0q4g
 CIVRN4C1AS9ugGT/e/sOouU712aq8Qnk5xARU00ifTz1ZxFx4yxYjYnSAZhankBuo9NCqY25b1jP
 6UrJt3M3G13rJW3aJyowGCoDFjKBTPCP/DHScmWHK+u5w0KG/R6CELlImwbyc3hJbBHUkN4OIO0W
 gSubQZ/A1xAk6s8DRHYe+Lx/AOHazInsQcE+0N2Rr24PPP4PSEyzpNcXIZp1TB9ZHgBnzAC2jvcy
 hkEKiwOcJTHrq6ASILHbwBWqbWVbmBEntNUBOqG3vcAUZSVeoJYD8JsHPN8OFqFVK7ymeiMX/6S/
 hGqxB28WxwOof+hgplNH9/wHAsT1BPB1ywQdgoHJAS4L0KdYNATnt2yrjtguAZBoZbQLH8e+A16H
 F7p8MzSnrjuegLvefSluJU8+BsSqvLfI78kLSTiKNG1QzDitfmiqmsoGRd9GoQKGsFy7RlZWq2im
 M2i1qmh5legFkLx7mPaIQE44K7cSmRMdYvBS9VWSYh/wKK5t8QmIZleuFsMgIaCYcxdkbk2WtFL1
 PwQuqAVVX5KT2CdHmJes3qQ5JPapPfojlJu/7oLsGcR4YIF9qv4DhcN+HZa5VD0AAAAldEVYdGRh
 dGU6Y3JlYXRlADIwMjItMDgtMTJUMTM6NTY6NTkrMDA6MDCqn0bdAAAAJXRFWHRkYXRlOm1vZGlm
 eQAyMDIyLTA4LTEyVDEzOjU2OjU5KzAwOjAw28L+YQAAAABJRU5ErkJggg==
X-Now-Playing: Joni Mitchell's _Joni Mitchell_: "The Dawntreader"
Date: Fri, 12 Aug 2022 17:06:11 +0200
Message-ID: <87a689pkm4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Michael Heerdegen <michael_heerdegen@HIDDEN> writes: > Have
 you checked how other major modes handle this case? > > Would also be
 interesting
 if they also all use > `add-log-current-defun-function' or if
 `which-func-functions' are also > used. I would n [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 49592
Cc: 49592 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Michael Heerdegen <michael_heerdegen@HIDDEN> writes:

> Have you checked how other major modes handle this case?
>
> Would also be interesting if they also all use
> `add-log-current-defun-function' or if `which-func-functions' are also
> used.  I would not want to special-case Elisp if not necessary.

The only in-tree mode that sets `which-func-functions' is python.el, so
I guess all other modes punt to `add-log-current-defun-function'.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#49592; Package emacs. Full text available.

Message received at 49592 <at> debbugs.gnu.org:


Received: (at 49592) by debbugs.gnu.org; 12 Aug 2022 05:29:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 12 01:29:13 2022
Received: from localhost ([127.0.0.1]:55394 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oMNEO-0006TF-TC
	for submit <at> debbugs.gnu.org; Fri, 12 Aug 2022 01:29:13 -0400
Received: from mout.web.de ([212.227.15.4]:60459)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1oMNEK-0006Sy-47
 for 49592 <at> debbugs.gnu.org; Fri, 12 Aug 2022 01:29:11 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
 s=dbaedf251592; t=1660282139;
 bh=FgaPEAmqWgOeYc9/aU2G77fbGc5BY1bdXWMzVAS08zw=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date;
 b=A7zwHNFT5pPdUVLT2yvlWaefhG72MTdfW07UA9feZXepSoOZ0d0u7axRDezi4tPdL
 wHqQXjE21D+be7TW5QgkjMhmRr/ptnPB9V39miM5Y1DkAm785mA83h86KKnzUNo/Fh
 AivkDKvmQhTV4QldC4gOO8ZA1J65GmxpADkMyuD4=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb006
 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N30ZN-1nNMl42XlN-012ypC; Fri, 12
 Aug 2022 07:28:59 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: Re: bug#49592: 28.0.50; lisp-current-defun-name and non-standard
 defuns
In-Reply-To: <87wnbhxwnp.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Tue,
 09 Aug 2022 17:29:46 +0200")
References: <878s279dfi.fsf@HIDDEN> <87edxwezs5.fsf@HIDDEN>
 <87wnbnigm4.fsf@HIDDEN> <87fsiac38p.fsf@HIDDEN>
 <87mtci1az5.fsf@HIDDEN> <874jyp7el4.fsf@HIDDEN>
 <87k07krehq.fsf@HIDDEN> <87sfm6zzjj.fsf@HIDDEN>
 <87h72mjhav.fsf@HIDDEN> <87wnbhxwnp.fsf@HIDDEN>
Date: Fri, 12 Aug 2022 07:28:58 +0200
Message-ID: <87pmh658th.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:JAsrhrRpKlAtpAscKOUgHA8Oi67RPWxLBq3Berkf+W6ky7RidlB
 k54ejjpoxaM8TBYb7xAX2RCK6w5wGvdD5/bLCKb+pduT7UdFHz/pCHZO6jZ1hz9YzmSf+W4
 knSmB7HR4j9dmpjJaGrNuPByP0pGgypER7BkTR8YF/f7vrnCUwT0ticq0dMS9LRYBPHeI8F
 xHA8TsD5jhu8YfM3cFz6w==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:e4gUc7+RfgE=:W4eLkNbuzDTSN/sRYuyHnm
 7YM/nPYgk+DYjHZ7zyeCTyc2yA+WcqmWYhy3rWJXhmX2u3wY7wBhfTtt/EVtGUqJfndK1+MP2
 OO6UlWQuP3Oq1k7P8nem6oNHtLwN/PmbStg9sNTOeDe54RNFetRMbYEIK7rZaegYtLxIqkcVv
 /1Vtn2NEIFpfvJYFXdgSFWgV4RYJ5duPw/H/cf3PZC3+mVDht3te6j6ZK+iQmEz4EndYo4qvO
 ciCnNeWV3uPapkGFlkJHBhE323PX8rUMKZSChW/ZqaYZfMdoR+d9czucAtOkAsXYN4CBZABJW
 vZBxNFKCGwxxuIp8YuIKFFF1xac33splSzvkQTOpV/+Qsab1EST5awl1/iuMZEGZzkjCpzwWp
 v9JOu8hwFKFLjwPC6eJ9kXMcIsZ9d5AACLrtdQ/klWS/AD3QDucYWtHMV6HeamREp3jbcUmrw
 Do0X7aVxfRkzqtycgOwn1Z9VLWJSKyjHkVLpIodVZz1meJN8ib/BaSRZEIkk7lVLW6TnuNcw3
 X2meai1v4/CxkIbiE+KBR1vDGasMBtQqTv5qXGll5psAyYg3ndRgJJllGezYJJCRKry8XhurH
 JAjE7UTDwBc4icY19R+hkewmsTvyQMYOFLdoeogkuSDtVcect1kN0IGfXrEEH3xoJwRKTDEqe
 B8DzzvfhqRPVT4QCzEl/f3+f4v5nRu1ZnTPLyDqp6X1Iq4Ld5UUQOzjPGbP7ZmZtb8Asb4nX+
 xQy4SGtUslciO1HeifLnMFceLvFGQYP8Y8tTs+ZDfZko3O5fsxw1pRzMlrWj+MMqjWne1iJhl
 AmR1rx4nw7KNCePqXyQcDIcJJdc9IAZPpB9Ql4sInWbo6ppfsdd1gxvWTul4Koxmfih0thw8y
 0gFrq4Krv4qzGv/8/pHdQpuEUisgmUWDTe5PanN8ZamD2xe6JDgG1/hL+p60OgbBUjXNq94LH
 DBDC5f/9AJ4BFqGmjIi3QZEDoyitj2p/ghAlAPJgYtoXmG+lfj0uHnSa52RjFfwN1lKjfDHW9
 NhMkUsRYVzJvo+1eC63LqVTL1imbCjICCJIx55SAz46YEIDYrCxnLYcvAMPART+Bi1WW+BELg
 RtyuNPy1BytTCsWc2rORs6ViC+hpQw4DKT2wH5pD2nrVE6nh+dilzf22Q==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 49592
Cc: 49592 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Lars Ingebrigtsen <larsi@HIDDEN> writes:

> > For which-func display in the mode-line I'd find "(progn ...)" nice,
> > but I guess that would not be suitable for the "add-log" case.
>
> Ah, I'd forgotten -- yes, that'd look better, but we'd have to rearrange
> the calling sequence a bit since, as you say, we don't want that in the
> add-log case.
>
> Or perhaps we could add a hack like adding a text property to the string
> to let which-func know that it should wrap the result in "( ...)"?

Have you checked how other major modes handle this case?

Would also be interesting if they also all use
`add-log-current-defun-function' or if `which-func-functions' are also
used.  I would not want to special-case Elisp if not necessary.

Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#49592; Package emacs. Full text available.

Message received at 49592 <at> debbugs.gnu.org:


Received: (at 49592) by debbugs.gnu.org; 9 Aug 2022 15:30:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 09 11:30:02 2022
Received: from localhost ([127.0.0.1]:44502 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oLRBC-00046S-8l
	for submit <at> debbugs.gnu.org; Tue, 09 Aug 2022 11:30:02 -0400
Received: from quimby.gnus.org ([95.216.78.240]:51004)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1oLRB8-00045m-Cl
 for 49592 <at> debbugs.gnu.org; Tue, 09 Aug 2022 11:30:00 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References:
 In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=4S/KRdLUOuTK/qpLDcsT0PZ7J/l4/WWJRoTHu3H9nxI=; b=ZSiv8l8LCLZsKBu5U2RYIRICEh
 GhGCkUSaxWo0gQ62sbNTe4eo8StgTKyAyBPta9fCbPLPpt8ajazXQqnvjsDxSO7rqFmtd/dXC6NM5
 97GuQPgellbD42oln5FdCW8n+ke48eqO0q2YUoEgSoVrrzeZy0lt/SP6qd8WLlfD12mk=;
Received: from [84.212.220.105] (helo=joga)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1oLRAz-0004QH-TD; Tue, 09 Aug 2022 17:29:51 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Subject: Re: bug#49592: 28.0.50; lisp-current-defun-name and non-standard
 defuns
In-Reply-To: <87h72mjhav.fsf@HIDDEN> (Michael Heerdegen's message of "Tue, 09
 Aug 2022 04:12:56 +0200")
References: <878s279dfi.fsf@HIDDEN> <87edxwezs5.fsf@HIDDEN>
 <87wnbnigm4.fsf@HIDDEN> <87fsiac38p.fsf@HIDDEN>
 <87mtci1az5.fsf@HIDDEN> <874jyp7el4.fsf@HIDDEN>
 <87k07krehq.fsf@HIDDEN> <87sfm6zzjj.fsf@HIDDEN>
 <87h72mjhav.fsf@HIDDEN>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj
 SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEX8+/y2o6ldW1rb
 0dXPX4b///+y5XS/AAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YICQ44MQ1ux78AAAHBSURBVDjLtVTb
 laswDJQiCrDsBng0IFsUAMf0X9OOCZuYm9zP1SEfMJZGGo1D9CfBX78+8BhJ+ATCiY3fgByo2D/V
 A3EyM1ej2AMygrkSTWIy31LUR9obXvlOzzaRoiJv+c5LFC0X96GRy28HPEltKFpaibLEV2sxHJjM
 ChklXrSbxThMtDNtvETrlBFAMezCW7HU3l7sU+srs5sS+fH7eXaaw+AkD3CstlbXdAJlMTKpYtlY
 DlTy+WorN61cRreJjRxV34PPSFaGvBKnTo/dcppdBiQvqYPkgLA5VZGqoQn6LMUpnUngzmBQKKXT
 s/6CpGyCRWGYwwBcOxFdmpIecm5H1/pWN+UgOM4koskr9e0KBaYglPt222qqj2zKWxvQr21MIB5q
 sWIPWw06zM+NKAYxEXEWxxHU4uVlhfZbSbYIDd+bxQuHYtUM5uld4pNHX2RT22lZOwPFwEuzTEGu
 Uy0vM5xrZpNIBu8K9SZ1OCpnt4IRqaeJcG6kIciYbxcBjQdUGLZmuB6AOZutOcFst2vg5wUEv94Z
 niwNK/QR8/N+2gdgFxN9ifsfgCPEz7gUdTc8pIisZ1x2Uk3a/PWf+AFwKzpmpW/YlQAAACV0RVh0
 ZGF0ZTpjcmVhdGUAMjAyMi0wOC0wOVQxNDo1Njo0OSswMDowMMY7oOUAAAAldEVYdGRhdGU6bW9k
 aWZ5ADIwMjItMDgtMDlUMTQ6NTY6NDkrMDA6MDC3ZhhZAAAAAElFTkSuQmCC
X-Now-Playing: Barbara Morgenstern's _Nicht Muss_: "Reset"
Date: Tue, 09 Aug 2022 17:29:46 +0200
Message-ID: <87wnbhxwnp.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Michael Heerdegen <michael_heerdegen@HIDDEN> writes: > Should
 we make the "fall back: display the name of the first symbol > after opening
 paren" case look different from the standard case? > > For which-func display
 in the mode-line I'd find "(progn .. [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 49592
Cc: 49592 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Michael Heerdegen <michael_heerdegen@HIDDEN> writes:

> Should we make the "fall back: display the name of the first symbol
> after opening paren" case look different from the standard case?
>
> For which-func display in the mode-line I'd find "(progn ...)" nice,
> but I guess that would not be suitable for the "add-log" case.

Ah, I'd forgotten -- yes, that'd look better, but we'd have to rearrange
the calling sequence a bit since, as you say, we don't want that in the
add-log case.

Or perhaps we could add a hack like adding a text property to the string
to let which-func know that it should wrap the result in "( ...)"?





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#49592; Package emacs. Full text available.

Message received at 49592 <at> debbugs.gnu.org:


Received: (at 49592) by debbugs.gnu.org; 9 Aug 2022 02:13:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Aug 08 22:13:08 2022
Received: from localhost ([127.0.0.1]:42189 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oLEk0-0008G7-8x
	for submit <at> debbugs.gnu.org; Mon, 08 Aug 2022 22:13:08 -0400
Received: from mout.web.de ([212.227.15.14]:58323)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1oLEjw-0008FY-E9
 for 49592 <at> debbugs.gnu.org; Mon, 08 Aug 2022 22:13:06 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
 s=dbaedf251592; t=1660011178;
 bh=nnozZ8Y4lnrnihD+w4CnPLEz/FJ59X9cOJpA0xZ9wSg=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date;
 b=gwsoAdViEoDVJucUNCL51SS7vSYMKc4X2aN7IGmoFc+btUlZ+q2nWApMlAdI2mabx
 p46I6R4U+WjIJkPbW/YgiF+lio94B60p6ODWMPmkDHarHLq+FH9Ef9xgpvlctW5Bok
 iigqth181J26wTqLaT1yr7T9neXL6VgWIF/5JaUo=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb005
 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MREzA-1o0I7347kq-00NNvK; Tue, 09
 Aug 2022 04:12:58 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: Re: bug#49592: 28.0.50; lisp-current-defun-name and non-standard
 defuns
In-Reply-To: <87sfm6zzjj.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Mon,
 08 Aug 2022 14:32:16 +0200")
References: <878s279dfi.fsf@HIDDEN> <87edxwezs5.fsf@HIDDEN>
 <87wnbnigm4.fsf@HIDDEN> <87fsiac38p.fsf@HIDDEN>
 <87mtci1az5.fsf@HIDDEN> <874jyp7el4.fsf@HIDDEN>
 <87k07krehq.fsf@HIDDEN> <87sfm6zzjj.fsf@HIDDEN>
Date: Tue, 09 Aug 2022 04:12:56 +0200
Message-ID: <87h72mjhav.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:BWuyaMfWJnUN1J6pP30OoX+Ud4xeiL9cYPrjwQK2hJDFgMNUXnz
 Sd9bYCl5YWdE55gXKYyD1yKvJG+5r/7YX+kUU9QThhpn0MLW0C8gsby9vR1FPO4fDtLrGFe
 WRvIX61dqHfEtWNncENtEYvnpZTVURZ2ydg51+UsHphksx8rcSuUbUhNwRhOYtRsh2qzYjg
 itdKcx6yrmW14nZ0jjKJg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:qoI7peXKynw=:u8UgBqbkAu6Nfv2aIe9C/V
 XH22pb82Pp/G0dx8ZmoWZjK+70Cwups8232XW0YvHHq46hYbRG7tQ8G7uOG3aPINRXlWofhl2
 pX9e1TFhkwllCmhwlH7SawpEymMGTwkDobWk4GjCf/VPHinRzUaoOMC9hVD/Q49LyFKd5aNnk
 yFSByKzBivzamLi41oXa03GI1pk31qWeGHpDc3A+6ICQkLuuJMI1po31T8sf5ZFP5ZNkQB9Us
 jPUs/c7HC8I9EAWZLPvtBM91x0WS0fCpRxT0vz3Mr0CtNHt8aqoqYn13ETOjWbgp9f3JYROzF
 OnaI7STd2x33imqtWbUcPEul5i9C66u5HftHsf/lYMbTCXJHtGB2V77ct8ePIP6zXXM2iCWMP
 cvs0EN9ZdYyTNwERhHn+DxAifhtpSK/+giOMm/MoCqYEwN/HdSdWzSSPTfKhszyRDS472p5YI
 45A5+/8wdGoWV5/geQtys5y6bikvU+xjEWNUVMHs1YQwN34KgHGYmke8Ibip9yiQsyCj/RZ0R
 ttmtAx2zcW0Bv+wrjt4XFskd9gOtD94pybUCqD1lrze+Eom4sXrp5gIqSU6z4DeI3MKIlBz2q
 KI/P2JGk/n1s9v38hAsOyb9nbacNvlSr3gQz41+zfNy4w7E1gWp9cFf2GMaCWeDJM2ucmdk4m
 BnAG3HhqP/Ni1A3Vm+Q8sPBqgEgR7iGMbVpFHOxyYUahOcCI4LCvBr5DTBHfCDNQK/5Gy0rtU
 aFe4Q/a6sAr6MFCWhQev6QPe+2vjyz5fgMEiIj6ZCAlzSKboUGG3r0iwepZuuq8wwCdPylXk9
 4pE3jqaTnAJhTstym/lSap3ORrUMpC/JJi6MRKE2YFpy06QtmOZ2uUrb8BIkx+Z6ONIk284/Y
 EDfXmzHZYlOpYfZut2LLTy+LbvUbp0STfq7+/n6VidxHCEDNeR/Teh98dbXz0ISfCjfxHsNd2
 jmYs+K6a40epWrJA1Z+2D39aeIVfUC84pGTI3HUDcEZs0uOJettDLnZZDglbBrQyngeTsIV+e
 orLfXg2sH5Py7It9dfsx2FGQSM0H9yVkp0GS5RL9czRYXoWij729mt8xvOHB5yc86cBdBcGYZ
 rq9HMm1f0MBeu7VABDupJqD5IB3Rw0N3+TdQEg9Hb4ytCy3HHpiYfPSMw==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 49592
Cc: 49592 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Lars Ingebrigtsen <larsi@HIDDEN> writes:

> Now done in Emacs 29.

Thx.

> (And feel free to adjust more if I've forgotten something.)

(I just fixed the edebug-spec -> t case which error'ed.)

Should we make the "fall back: display the name of the first symbol
after opening paren" case look different from the standard case?

For which-func display in the mode-line I'd find "(progn ...)" nice,
but I guess that would not be suitable for the "add-log" case.

Michael.





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#49592; Package emacs. Full text available.
bug marked as fixed in version 29.1, send any further explanations to 49592 <at> debbugs.gnu.org and Michael Heerdegen <michael_heerdegen@HIDDEN> Request was from Lars Ingebrigtsen <larsi@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 49592 <at> debbugs.gnu.org:


Received: (at 49592) by debbugs.gnu.org; 8 Aug 2022 12:32:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Aug 08 08:32:29 2022
Received: from localhost ([127.0.0.1]:39408 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oL1vp-0000IK-1Z
	for submit <at> debbugs.gnu.org; Mon, 08 Aug 2022 08:32:29 -0400
Received: from quimby.gnus.org ([95.216.78.240]:39592)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1oL1vm-0000I3-8o
 for 49592 <at> debbugs.gnu.org; Mon, 08 Aug 2022 08:32:28 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References:
 In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=6E7veZlVKnHorRouK9mLbp4gv3A9sxlKWSm8PQSyAn8=; b=H8pyU6TmGQ2xGwnzJlSv2Hg8sE
 +hKJkX0gbRHvAbJ8f9oXgy0utM/ORAgeReg81aKDPnzj7/aRX+x3SrqRY0F77xm/UO/CVFOiMKZLP
 Ezrd3QQvEyUUloyhBa6FZeX3Ajy2nF5te5so5EC9msoER8s2VBIdF1tKr+6z6Fif4HXk=;
Received: from [84.212.220.105] (helo=joga)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1oL1vd-0000WR-Lf; Mon, 08 Aug 2022 14:32:19 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Subject: Re: bug#49592: 28.0.50; lisp-current-defun-name and non-standard
 defuns
In-Reply-To: <87k07krehq.fsf@HIDDEN> (Michael Heerdegen's message of "Sun, 07
 Aug 2022 04:09:37 +0200")
References: <878s279dfi.fsf@HIDDEN> <87edxwezs5.fsf@HIDDEN>
 <87wnbnigm4.fsf@HIDDEN> <87fsiac38p.fsf@HIDDEN>
 <87mtci1az5.fsf@HIDDEN> <874jyp7el4.fsf@HIDDEN>
 <87k07krehq.fsf@HIDDEN>
X-Now-Playing: Michael Rother's _Deutsche Elektronische Music 4 (1)_:
 "Flammende Herzen"
Date: Mon, 08 Aug 2022 14:32:16 +0200
Message-ID: <87sfm6zzjj.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Michael Heerdegen <michael_heerdegen@HIDDEN> writes: > agreed
 to everything. Now done in Emacs 29. (And feel free to adjust more if I've
 forgotten something.) 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 49592
Cc: 49592 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Michael Heerdegen <michael_heerdegen@HIDDEN> writes:

> agreed to everything.

Now done in Emacs 29.  (And feel free to adjust more if I've forgotten
something.)





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#49592; Package emacs. Full text available.

Message received at 49592 <at> debbugs.gnu.org:


Received: (at 49592) by debbugs.gnu.org; 7 Aug 2022 02:09:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 06 22:09:47 2022
Received: from localhost ([127.0.0.1]:35724 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oKVje-00072h-VT
	for submit <at> debbugs.gnu.org; Sat, 06 Aug 2022 22:09:47 -0400
Received: from mout.web.de ([212.227.15.4]:49037)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1oKVjc-00072S-DE
 for 49592 <at> debbugs.gnu.org; Sat, 06 Aug 2022 22:09:44 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
 s=dbaedf251592; t=1659838178;
 bh=I/r5cKmAt1nfc1Fbzuj9qCx9QpB2TOwDcsBWwRkf5zQ=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date;
 b=PwAX8zjYeBsGP1SD+G2BY0AIZkx8QIqUve2apy5StNbmah8kh5MeR1zHsUfunwyYW
 UKgNHVIXZA2E+Cw5d4V+sCoDNrBttPLxrqkshkJmMfM45oILfVWnqGf1qck8HkHg4s
 XE/CgGHtaUqkMIDgYP/fZDFU49zY/8PO6ifCN//w=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb006
 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Mmhnu-1nb1pU2qj0-00jvVG; Sun, 07
 Aug 2022 04:09:38 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: Re: bug#49592: 28.0.50; lisp-current-defun-name and non-standard
 defuns
In-Reply-To: <874jyp7el4.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Sat,
 06 Aug 2022 14:15:35 +0200")
References: <878s279dfi.fsf@HIDDEN> <87edxwezs5.fsf@HIDDEN>
 <87wnbnigm4.fsf@HIDDEN> <87fsiac38p.fsf@HIDDEN>
 <87mtci1az5.fsf@HIDDEN> <874jyp7el4.fsf@HIDDEN>
Date: Sun, 07 Aug 2022 04:09:37 +0200
Message-ID: <87k07krehq.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:WyWZj2FKLhWeVJgQ0UxMX1RdAuNYhkDK3aZK0uw/8aKsdLcfN49
 51rjO8Db2e/zhY/H1Yne/wbiOlySjaoKpcs9JDZJxkePoOqNRbfPMWJ3Zh0hBns7x73q8ff
 FJgp1vdgYyDXVd2bCVJTQVHDjbgrrGMktvnlfTsDGq4e+lwN4gvIjCLOBSCODhr8ujvFqKj
 Q8CObE+K5QRO4gK+l4D/w==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:CwXMZb8Z2/I=:1lf1PJzwc0DEPsYR98j0ia
 ei6BT3PpI1cwNt9BAm4AnpNMZTIbtcC+FNRx1G2tAr8imbUzGJy47VQLfaKYaskeK4Ae04obS
 1GXsevqe6AfFbJvAQXM9CyyLoL5ZnhoF46+x2CwowkP96MPPeAb8asv9b+N7jZMyzm6BcKtIA
 hv4qTscO8VSqQUXU0ZgzZ3kFW73qK1n/rw3tzC95G2RnPksASuIdzomQ8Y+/nPEJ+f9ecX32K
 Hb17dD+ncNBmmExugxBMnx/2K5x/sDVXb4WL4LNeUT/vOFmnqlFyH+B6iuDpSAzMy/64E9Wx5
 oS4FlotmlAVUDCKdPneQi4sTQtrpqvCPCgRc3qz0Y6lRNDgkNzw53PhSqfcD7f+V1uepxc5n0
 +FSfrYc/esVG7VCgxvXamr8k5DSGKDZvB8oarwQXK0PMp8N8Hh4gYR0O78gnmkvVAJSayUF/K
 KcNKbytBkIY5+R4/JefR6jFYtE9TDrIoVLnzr+5i589iMpbNEo/VlvMK+vGs9UuPo2gxX8g4o
 TAFkpL2c7Rhve/LRwt3aTpVS94LltS9lYcy2EXXbajR5GUEM86//lJtx0/9eMJ01BvB4N1dTR
 rkJgf5TtsLRDKtBrub4ZyzAGhrz+hpjSY7RC0t05GHw7ZH8VsZR0+qoywkIDNYoVCcz36os8e
 UnJpDig8zsNcse/Qtd5YhouYQHFuv6frdlc2QGjXKkQ+eFXTMKB2NMFSr/Su9NBlyGPk1nVSm
 2vSZbcLGURZcq/zomSYLRRnLHgUpJ45y7GHybESAHHRXZLJAsLDwliODIb1qTU4i2OJkvxrBG
 /Wruj7RinWNQoDN3gF8vRG6xQiy1Npa1g+tNV0J7vWYdJz5QUUrFp4t+w9qYr7vIkB9yC+dOo
 mDf/DuFay4OBcQCGJhfZw2tf1FqUHhVBg5Tt0hS4J3HV47d5rJzJ0oxRqcZKkJctONO3nHh+C
 6VdXLh8B2gN8/BHaIjW+lBcBmMskv7iq0ewCLfn+yp0Iu9gh/iK+y5QxTLxCWnaSXtOUdm7dn
 Bz2ef4Q+Q1mt7u6wWUpnwtCbPSbAiSQud2rbnzvJI9ojIKKGUBtorEKQM2C6gU0zJo/oOJodD
 vYA8LeIKAACEY2kUIGaBhj+beaYgAbqkthZiSnRlnX/ONaDVPN9TMJVWA==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 49592
Cc: 49592 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hello Lars,

agreed to everything.

Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#49592; Package emacs. Full text available.

Message received at 49592 <at> debbugs.gnu.org:


Received: (at 49592) by debbugs.gnu.org; 6 Aug 2022 12:15:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 06 08:15:46 2022
Received: from localhost ([127.0.0.1]:32952 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oKIiY-0008Lm-91
	for submit <at> debbugs.gnu.org; Sat, 06 Aug 2022 08:15:46 -0400
Received: from quimby.gnus.org ([95.216.78.240]:46422)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1oKIiX-000855-3Z
 for 49592 <at> debbugs.gnu.org; Sat, 06 Aug 2022 08:15:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References:
 In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=f4ol03L63vhEF9TZ4bX4QfD8ERPcIm5VpqAfp+sc3WY=; b=FlgnJQMSIbBjFdzQQ098jqILEv
 5ohO8AZgEEiCm4Kr/Eo4ik1pHiMd+j/XqzK+LXELPjdmCboOjGigAuscwodZ9cWb0r4mUZiD5XwyM
 wZS1khhfTZa/jNW2JptNByd7DTHze0le/aW3UpPm6LySWAYRft7NNT4obIwsuJyGLJ9k=;
Received: from 2.151.51.97.tmi.telenormobil.no ([2.151.51.97] helo=joga)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1oKIiO-0003gT-SH; Sat, 06 Aug 2022 14:15:38 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Subject: Re: bug#49592: 28.0.50; lisp-current-defun-name and non-standard
 defuns
In-Reply-To: <87mtci1az5.fsf@HIDDEN> (Michael Heerdegen's message of "Sat, 06
 Aug 2022 02:17:50 +0200")
References: <878s279dfi.fsf@HIDDEN> <87edxwezs5.fsf@HIDDEN>
 <87wnbnigm4.fsf@HIDDEN> <87fsiac38p.fsf@HIDDEN>
 <87mtci1az5.fsf@HIDDEN>
Date: Sat, 06 Aug 2022 14:15:35 +0200
Message-ID: <874jyp7el4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Michael Heerdegen <michael_heerdegen@HIDDEN> writes: > Makes
 sense - but I don't know if it's a big win and Edebug specs help > out in
 enough cases (lots of macros don't have one, even in Emacs > itself, e.g.
 `defvar-keymap'). 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 0.0 TVD_RCVD_IP            Message was received from an IP address
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 49592
Cc: 49592 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Michael Heerdegen <michael_heerdegen@HIDDEN> writes:

> Makes sense - but I don't know if it's a big win and Edebug specs help
> out in enough cases (lots of macros don't have one, even in Emacs
> itself, e.g. `defvar-keymap').

I think we should consider those cases to be bugs and fix them.

> Anyway, it wouldn't harm and motivate people even more to write Edebug
> specs.

Yes, that'd be a nice side effect.

> Or do you intent to give up the heuristic of using the first
> argument completely?  I don't think that would be a good idea.

No, if there's no (usable) edebug spec, we should fall back to that
heuristic, I think.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#49592; Package emacs. Full text available.

Message received at 49592 <at> debbugs.gnu.org:


Received: (at 49592) by debbugs.gnu.org; 6 Aug 2022 00:18:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 05 20:18:03 2022
Received: from localhost ([127.0.0.1]:60737 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oK7Vz-0000Z4-9H
	for submit <at> debbugs.gnu.org; Fri, 05 Aug 2022 20:18:03 -0400
Received: from mout.web.de ([212.227.15.14]:47005)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1oK7Vt-0000YS-Tg
 for 49592 <at> debbugs.gnu.org; Fri, 05 Aug 2022 20:18:01 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
 s=dbaedf251592; t=1659745071;
 bh=1iNfakOOMy4elyMnnAifbV/Z0FK8/9lhVCvpk1R/aDc=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date;
 b=StT4J9Bwx5IsApo7kY5JsXYVTlYGdW3JN+QLmgzWQpxfCiKeGDdB9uNeZHUI6WeP6
 YIqTZzfv+Mm41EvurCkXVTl5PlI6lOhdH5dXvc1QIIYyLLqWr5CWDC0qwYkNQyAdRH
 XFXm8Ee+Z4saEdmxMlvoPdeDRDqtcuwwa6VSXGk8=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb005
 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MyNwm-1nULq722eq-00yyKh; Sat, 06
 Aug 2022 02:17:51 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: Re: bug#49592: 28.0.50; lisp-current-defun-name and non-standard
 defuns
In-Reply-To: <87fsiac38p.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Fri,
 05 Aug 2022 13:57:10 +0200")
References: <878s279dfi.fsf@HIDDEN> <87edxwezs5.fsf@HIDDEN>
 <87wnbnigm4.fsf@HIDDEN> <87fsiac38p.fsf@HIDDEN>
Date: Sat, 06 Aug 2022 02:17:50 +0200
Message-ID: <87mtci1az5.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:MxkqtdYk3BL7xNPR1jVosnsi9wV+lLi5lxnoe062QdyyV3oaWUm
 vqmEJk8AOcBuCvk0BsVMAeXHd2ZKGhRX4YbO0OONKNFys52zjgE6HHgLsBImRN26JHYtndp
 h5y9zgOnHEV/Iuq/JvMcdTx2KaIEj3nXCAn3kxKS0+rHG2sV/R6L1RNl7NOrt7acXoBaTKk
 uLQjoinhEaCVbdq9cnqJQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:mvZeFz9YVoU=:M+UpMObGdoNb1RRfWMXwQM
 6tkiVEzrVKPOApSqCVIFsfhmZeFO7mjab6XiwxoPVq59joZxqu+Kv8RF/pFj92ojtbAcyDXxT
 9i5oX3yyn7q1PmC3fDRL+LRT+QY3J6z2wn3Qp8NDavAJMnNWXJzWxUoQvlvVHY41TWPKbKM+D
 Ul3lA3yhwa/rsuW1Royy2tFx0gowq+8lmmbpYS1e4Ree8plEecOL33ef9rIIcryONIL6BCWh6
 Cic/rwMCEB/nvi5AvdyZ/MqO9hN4HOTExp7b4l7BENEnHh2JOMNShVyY5mr5nt0OOuweqUEOb
 tf42xD9ybeHhArGYZ4wnLy2DXZoLiECB/DsSPSeTdrANIhzzSSkR7CTZtB/5JMvKnhoq/HdgK
 TkgA+wIXgHpdiQ/djuo9FnM+9uSJ+N6un+PK2/GwRNeTl/1KqLdV8LF3IAk5I6G6nZVjaF57K
 b/zuTx9oGIXKC40wfqlzz+4Vs81j3P8kAed/MT+7Lonlp26oKoQVTiZGzk1g0ulSFnfxN8tUT
 Q6+zF5hYsk2fqt/Fj1CtgPXDOLqFMD220OR8Gd8wtJrAqwbNfrYWvok0FPuvSXnJQfrWKW58e
 CE2Hxvfb1eLW7+gsaOBwvnrHc1SG4s5BTDxs0jZQ+zrm2DpZS1RJ0l20pPQ7F5qpXsO8W91hj
 OAAom3ay39wHi3dSg8v2VZQbrQrSm88eO9JJ3IJN/U9z794+H2d/XD2dO4aOPBI8YQQyy+ARg
 rPfV1Z3ioWRAVD8ukSXrxoGojaUPQyTEsI2gM/4o31RI/aHQ7853vVa8JUHpM27s6+G0QnvhR
 odeVTMrHX5NbQKrPwFxRQ4fO2EBe8MgD7sE5i25zN7yFLUl4UUzP8o5h6+d3yH0r62f57N30K
 0GqSx5VmWRC1iJBM58sKJ00Nbk0eCwshMs9pFX7+wrohePsAx90CQiHQGDEh376lAL47iEY3o
 cuj9ElSvBX86dQ2S441hxLXAow13CkhN7qq/+D93jLwXDnCun4z3FnvXzo4L97Gp0XEzE2gT0
 KxaLfUbI4SE662+dL3ozrCFGMstE5tRbqKQlphUS7Z3cLuu/a8fTYyL4GaHKJ0BRLSNYITIFF
 018g6uPpCL/PiDTOi/QykPBY5bMDsYbG9QWwaR3xS80kEQIv3KVx4iJNw==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 49592
Cc: 49592 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Lars Ingebrigtsen <larsi@HIDDEN> writes:

> > I don't follow - edebug-spec of what, in the above case?
>
> I was suggesting that we could use the edebug spec (instead of
> heuristics) if it exists,

You want to find out the correct NAME of the thing being defined by
looking up the edebug-spec of the current top-level form instead of
simply assuming that the NAME is just the first argument of the call?

Makes sense - but I don't know if it's a big win and Edebug specs help
out in enough cases (lots of macros don't have one, even in Emacs
itself, e.g. `defvar-keymap').

Anyway, it wouldn't harm and motivate people even more to write Edebug
specs.  Or do you intent to give up the heuristic of using the first
argument completely?  I don't think that would be a good idea.  Because
this heuristic works very well in practice IME.  AFAIR, most of the
time, or every time, when I saw the heuristic of
`lisp-current-defun-name' failed, the top-level expression was not a
defining form (like in my example) and `lisp-current-defun-name'
returned the complete sexp - and treating this case specially would
already give quite good results I think.

Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#49592; Package emacs. Full text available.

Message received at 49592 <at> debbugs.gnu.org:


Received: (at 49592) by debbugs.gnu.org; 5 Aug 2022 11:57:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 05 07:57:19 2022
Received: from localhost ([127.0.0.1]:56443 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oJvx9-0005QZ-Kz
	for submit <at> debbugs.gnu.org; Fri, 05 Aug 2022 07:57:19 -0400
Received: from quimby.gnus.org ([95.216.78.240]:34890)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1oJvx8-0005QM-Lz
 for 49592 <at> debbugs.gnu.org; Fri, 05 Aug 2022 07:57:19 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References:
 In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=btaiW4ITgtx7PuftG11ESvsHpmh9MH7f42K/7CYV3U4=; b=Eb7Gime9RzLk39IWs5BDXK5oT8
 USadG3LHh5UoQr/n1GLXDSanYQVdk6zaph//isRegZQDX7xD4vnjvIrqfckTU5M94si2l6G+oGy7r
 ZhVPfB5ys9qhk7rbo4Uz7NNneag7fLXxo68E/Wwpf5p7OYF5Y+TaCLibQMf0jV4i+uJ0=;
Received: from [84.212.220.105] (helo=joga)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1oJvx0-000122-Ik; Fri, 05 Aug 2022 13:57:12 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Subject: Re: bug#49592: 28.0.50; lisp-current-defun-name and non-standard
 defuns
In-Reply-To: <87wnbnigm4.fsf@HIDDEN> (Michael Heerdegen's message of "Fri, 05
 Aug 2022 04:11:47 +0200")
References: <878s279dfi.fsf@HIDDEN> <87edxwezs5.fsf@HIDDEN>
 <87wnbnigm4.fsf@HIDDEN>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj
 SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEX6+vvS0dTd3eGi
 oaS+vcExMDAgHh9eXl9+foA/PT7////viaxHAAAAAWJLR0QKaND0VgAAAAd0SU1FB+YIBQsuNC2B
 +7QAAAGpSURBVDjLtZNLTuQwEIYdwwFiJwewq5HY0hRShh3pDINYgpSOWI96ejtRgkxOwAFQhHJb
 yq80dLMAaeZfZOHPfz1SZcb+vRKQXEj4BEiphTgEWmopQWixDzjdl+Izy/9VgkEXKTtJla3El7Co
 15s/pM221M/llQW+6KOhnsaa1GdFx33xzlBM02TP67YyqHYpru3ZekOfrmgMMIg9XrswpAZN3fMk
 BVBqdngw1J3KgXMF78A0micCIBTnUuxAYyZjhm2vcwuc45evCC+HcfPSCzED5zApOx5fMWtLqYDG
 Eh2tvXKTskX704E8gG1s6xQvgICO4Hcc4y0ugaRlAHfxP99U0gIIjvV9dFSoKZSCbB9knXahyhBq
 BrACmxyW+znOSw6K70Cs6rhFZoHG2EcARy+PlDrRAuM8QoMLg4I6j2Aa1389yLrEdijyCOpGkgdk
 JvWPTuocA6BV6BXj+ZVmIsGVqAIwBB7O/JadpLqs8LmbQd2cu3Wit4NojPFgsKN6MIjFMqEwxUfg
 J7+q3PkBeO0zG+gAuHAzSKjTKDcmeoryiy8Ivg2+pjee+49Hiyd05QAAACV0RVh0ZGF0ZTpjcmVh
 dGUAMjAyMi0wOC0wNVQxMTo0Njo1MiswMDowMHMVS5oAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjIt
 MDgtMDVUMTE6NDY6NTIrMDA6MDACSPMmAAAAAElFTkSuQmCC
X-Now-Playing: Keith Jarrett's _The =?utf-8?Q?K=C3=B6ln?= Concert_: "Part I"
Date: Fri, 05 Aug 2022 13:57:10 +0200
Message-ID: <87fsiac38p.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Michael Heerdegen <michael_heerdegen@HIDDEN> writes: > Isn't
 "defun" synonymous with "top-level-form" in such cases > (e.g.
 `end-of-defun')? Yes, I guess. 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 49592
Cc: 49592 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Michael Heerdegen <michael_heerdegen@HIDDEN> writes:

> Isn't "defun" synonymous with "top-level-form" in such cases
> (e.g. `end-of-defun')?

Yes, I guess.

>>  But this is also used by add-log, so perhaps
>> which-func should just use something completely different and more
>> strict.  I.e., skip back to the top-level form, and then use the edebug
>> spec to pick out the name?
>
> I don't follow - edebug-spec of what, in the above case?

I was suggesting that we could use the edebug spec (instead of
heuristics) if it exists, and otherwise fall back on something simple,
like just showing "(<first top-level symbol> ...)" if there is no edebug
spec with a `name' in it.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#49592; Package emacs. Full text available.

Message received at 49592 <at> debbugs.gnu.org:


Received: (at 49592) by debbugs.gnu.org; 5 Aug 2022 03:01:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 04 23:01:47 2022
Received: from localhost ([127.0.0.1]:55565 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oJnat-0007S4-8K
	for submit <at> debbugs.gnu.org; Thu, 04 Aug 2022 23:01:47 -0400
Received: from mout.web.de ([217.72.192.78]:33949)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1oJnao-0007Rn-J4
 for 49592 <at> debbugs.gnu.org; Thu, 04 Aug 2022 23:01:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
 s=dbaedf251592; t=1659668496;
 bh=eBognLVa1C+igUAQS/OcuftKeBrM51YtTfvbKTlTMhE=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date;
 b=WBhUKykO91RcNlazIbA3XiSnWjjP9lWh5w1T5HiTgif+0JZbEf719abG2eQctcIl0
 rHL7YrXaLrg8F4qMWbyHkp8VE5lnb+QX6ZDyw8f5gfObq1suL0Yg3+CmFlxzFnnZAT
 yC+/9mNN9jdLraFb1I/EvQ+H5yn7DDQfqQdSp0No=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb106
 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MwjJo-1nVh8s0Y9a-00y5gK; Fri, 05
 Aug 2022 05:01:36 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: Re: bug#49592: 28.0.50; lisp-current-defun-name and non-standard
 defuns
In-Reply-To: <87wnbnigm4.fsf@HIDDEN> (Michael Heerdegen's message of "Fri, 05
 Aug 2022 04:11:47 +0200")
References: <878s279dfi.fsf@HIDDEN> <87edxwezs5.fsf@HIDDEN>
 <87wnbnigm4.fsf@HIDDEN>
Date: Fri, 05 Aug 2022 05:01:35 +0200
Message-ID: <87sfmbieb4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:nxeKPznMLE8yB8f6jfoxZND87kE30xqvQLbK9aew1u4lQjEZLrJ
 tXtHhEFqwiYkNV45Uy7DXB03w+VTYdqMSVZe/YhNM+2WawXsswPHGEVxYXc6qJMTK2v4Nay
 f0Wy9bnjEbikB9qOMV/gCmusGGFWnDCQmRQEOfTWzQ6Bjm8hA8f9vf5tkPo0x6cjEU+8S/J
 CXYzoHS2UzvrM6IAZvIJg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:sNyMJBoR8V4=:BqhCUR2bWCTV6TVmW52+N3
 eqiGj2/lh8/avl5S6NzrCiHvPHSV7S0tYMfn6Q72bUIuAgKCATR5p4S28HAWOv+Ol36dTke/r
 sY0I/cVabqk8f6vDwvnZRo45pB55DxZ75iDEGmlzyttYTvc627hgzn7+vMMp+hnf5jVvLgEBA
 MRUXjnq2N786Pmn+QKvztkBO3u6dLiZ65AA2mXXL+CDJ3pBN+JOs5HovwtfV7SzuVfwNdU5iB
 Hg60GUqbX+AaAP7YILTH0LhNXfLDE8TPPpT43ZwNvXJQY/3dJ1pIIr+OfbxcwEOsedWIN7Ior
 vzter7u14wDSdck6Eme69YPRkmKORdyPoQ0RNujqGeXP9QpG5J3ZdAIBZO8Crgh665BEALbOX
 ZdAAV+1GuIWJFycfhrKlgLXpqjdAsEsLCxshueIt458Qv+ev/Us5XMwOwMdrd8VVCawCEhNHZ
 ybQZ162XMcY1CXhz7v3Lv27hI0ipVV75g5KgLgDyWVtOgiALhJCW8+hqp+oXjDMlsecBphWj9
 3BjwDqMq5P1OyD9Q4VcxoQXB6ZZjddiY2kgBT0UmNEGxgHxD3GmVWfV46ygX+PB1fNxxioLRv
 A8h6TIPpLvLBrRxBheVYBKj/vGpdw6qU5cddHriyyouCbce0T5A65GSfD+56H5hEjKq3BGINq
 G1iSOjmRCfgcttty/MYN4eBXHBNquenK5ChV7LRp8BvGJ0tJmx9/dgd8to8e3uNVLzhHkdi58
 U/ZJDEFHO2HizxJiMMk5cmzI/vmwVA+zrZ5W2H5PBlNCvzZ+ITwVZpXwV2zxwEZR64wuMq8my
 OwCoroxGbnlEYO3fTybQg7wC3MuKfosgUeNPtElDVVH8EacngKGM7wK2eYa7KoPAxIwaoRFxS
 isJzPm/ukz9xOaHY8bSpSO5uq689jPTZ0iJNYw7tTHjC48PdOPSVw0UctPklMUAWknnYmYTHg
 mdgQukbpToWLMTHBgLVOSeMHadp6qsr3rl8DIP73Xm8ScQyDnRaT7DdjSgp9aNnczRnVD1CeZ
 1E9WOI4qN8Bq0LK1RUQ1sYBHfONvfd7BwQUXY7d+1HuHh6c/OZIEYtWAs97hXTu31yYumE7XA
 hH+ftifcGKn+UeQTFQZpzLp/vI3cZIdVl+XcRwGoWIwulpeOPgKxP7IXw==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 49592
Cc: 49592 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Michael Heerdegen <michael_heerdegen@HIDDEN> writes:

> Isn't "defun" synonymous with "top-level-form" in such cases
> (e.g. `end-of-defun')?

`add-log-current-defun-function' tells "[...] should return the
function's name as a string, or nil if point is outside a function." -
but here "function" is also meta language - for something like
"(top-level) defining form" probably.

But I don't use add-log.  In my which-function example, returning nil is
better than the current behavior.  `which-function-mode' is for
orientation, so saying "(progn ...)" would also make sense to me and
provide a bit more help than staying silent.

Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#49592; Package emacs. Full text available.

Message received at 49592 <at> debbugs.gnu.org:


Received: (at 49592) by debbugs.gnu.org; 5 Aug 2022 02:12:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 04 22:12:04 2022
Received: from localhost ([127.0.0.1]:55503 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oJmom-00067e-A3
	for submit <at> debbugs.gnu.org; Thu, 04 Aug 2022 22:12:04 -0400
Received: from mout.web.de ([217.72.192.78]:59145)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1oJmoh-000677-Jp
 for 49592 <at> debbugs.gnu.org; Thu, 04 Aug 2022 22:12:03 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
 s=dbaedf251592; t=1659665510;
 bh=zQZ1GPusZZudm+o23l6vVa6eo7fiSCasn30c4lbRBxY=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date;
 b=CJYNb43aPPGoZbs02IFycFVAVnAJUR9D7y9WoGxJwlb49DsQkwmUBhcz87B0hMXoN
 bi1CEpkJ6vVZTdTRFUxMBx67KLvTxGEZcS0nyk6xZiRnFh/XLUSKVClvNWJdbEt8V0
 XJKECL/Txz6RXHCCUKKwyHMb0qqa1wR9ZRSpHpVA=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb105
 [213.165.67.124]) with ESMTPSA (Nemesis) id 1Melf5-1njtlT1Og1-00aXdP; Fri, 05
 Aug 2022 04:11:50 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: Re: bug#49592: 28.0.50; lisp-current-defun-name and non-standard
 defuns
In-Reply-To: <87edxwezs5.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Thu,
 04 Aug 2022 18:31:22 +0200")
References: <878s279dfi.fsf@HIDDEN> <87edxwezs5.fsf@HIDDEN>
Date: Fri, 05 Aug 2022 04:11:47 +0200
Message-ID: <87wnbnigm4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:W2DvBQ7KokIgZKDajaf+KOMMdtL8k8DIeLplY7jnfzLFNyY+5c+
 ypd0xbfdNbQcDjzuS/oCWUameFCsyWf1J7vf/CjCDVbSEV83lisGOoCWT+pTy4/5lrqJlYi
 SxtjuVk5pVD9aY5ZQ78h07qpL2yqszrtTxkh3JCqKGizsG8q1K6ay23S7G5BGAk97js9OJ6
 GEyOmc+ZawK3CTdqZWjpA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:q9p8ffdMZqw=:+BLPYw01GuaKo9ed80Ys2d
 gxEXflESo/c3LPYk5x27JXEGfPxGR/pt0kGLLt7TMWQD6PAbUGVyW6+XVldBe//32InZdoRWs
 SlMk+A6uP4p+MNigyRUIZMqhO4JjNnVGAQqKz/daJq9/OE6quXqw3SEdlpmqLvkv+HDBV4iti
 SdSIjzf0PVT3OdCSTJDFOkFq+WGx2kpdvesV8eDc/qQAoY7mree91cprn9mZLzBoPGWjnRQ9U
 hF+Cl8oI/oxVZK9FDHL4g9M3e5urYocTyzHoTqYC1RwdYlsP62cngeXvFK7ZFgm+ntAOAqHgV
 HL9KDlFY9dpaNwJwrZmZZS/AJf3YC03L0btsFJptjQO1bQ2lWx+DgS/ap0ZO4S0PhRsDX9Ut+
 LqsEBjWs/f6Df98l9j0XRehuMCB+jQjnclJfVOEQZwXythP2w53JREunN+0BLJD//HfI3L36P
 IihOt856T+wuNVznRNOpKMoBPHEb7sPPi7sal6qOzSd8kkIubnvmUc5knsSUyLkmznGxhq1oO
 VdqC9tNSmK49YYQkpuTrdl3MkD5ypituPh1UX6sHLHRH1gqVVb5Ez87Hj3SshvT1+p7jOVkJl
 VaPNmttSZrNw0zNVW6Unw7PoI86aO8KaKqJJpZ3RaJFyO28P488b/4h2chJ7/YLUYEayzLzg2
 fsOboMHNHN7FXGO+ppLhH6UHT0568P4ox0K6DDPYZaAgmMnmWpbxZ2nE8LgcsEbjYEWatTfY5
 SPcwbm/9SqaxjB1GQeKD3qVB+4vrLlrNM3SUeGAd2EVcbEhumS/eXd1Dopa0/R8KATAR14AIV
 1IG3KNv1UcfIaA0EfHC0bNVlZLc2LysWn+VzytWFvcOhn3Ha0du7eXGGhhZijR4JJ1TRYW23n
 I03O1Esu7wxhVm4cI4tttm4vHbHTAUniFjREjBmAf1fnQnwuiBXx4tvuXWJZZrYkFHo5lLxjf
 R1Ka8gQ3VT1gN5Sazw4R01CGhdz+KHly0Jxj7k0lioBFLvEKNGPR9FhYw9lzuWW6G4DwQqn8o
 U9nFUP991PiZTVnvMdGLmvkoprCK+bHgqJ51Q8TF8s4/p7Cg8kp8pNv+L8NetlYSfgIme1Vqf
 0nZ5SHcwbLYADtbsw6er30uWHoSpQaGNLm2+h9udiKTu95zuHTtXluHZA==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 49592
Cc: 49592 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Lars Ingebrigtsen <larsi@HIDDEN> writes:

> > (progn
> >   ;; comment
> >   ;; about that
> >   (define-key ...)
> >   )
> >
> > With `which-function-mode' enabled, more or less the complete expression
> > is shown in the mode-line (with newlines escaped) when moving into the
> > expression.

> This function is documented as:
>
> (defun lisp-current-defun-name ()
>   "Return the name of the defun at point, or nil."
>
> There is no defun at point in this situation, so perhaps it would make
> sense to return nil here?

Isn't "defun" synonymous with "top-level-form" in such cases
(e.g. `end-of-defun')?

>  But this is also used by add-log, so perhaps
> which-func should just use something completely different and more
> strict.  I.e., skip back to the top-level form, and then use the edebug
> spec to pick out the name?

I don't follow - edebug-spec of what, in the above case?

Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#49592; Package emacs. Full text available.
Added tag(s) moreinfo. Request was from Lars Ingebrigtsen <larsi@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 49592 <at> debbugs.gnu.org:


Received: (at 49592) by debbugs.gnu.org; 4 Aug 2022 16:31:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 04 12:31:35 2022
Received: from localhost ([127.0.0.1]:54498 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oJdl0-0000vc-Nt
	for submit <at> debbugs.gnu.org; Thu, 04 Aug 2022 12:31:34 -0400
Received: from quimby.gnus.org ([95.216.78.240]:54050)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1oJdkz-0000vO-30
 for 49592 <at> debbugs.gnu.org; Thu, 04 Aug 2022 12:31:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References:
 In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=16xbZTeQXyGk5mD0PBYzyK/3ufDwV1Mhz89RPcJZnpU=; b=VgoJT6kRW6zncXWmGmJWEFPHdp
 ci4m15ns0F9r4ASwvOaXUicXk/qe+dBnb4pJAjKJpeAzuk8crtB12VMaT/7/ZGkb2J92VBVqv5R80
 lCCHtzoGziGkR49mIRQpxf+Ss6APJyMoY4DUOnkpJcMz7XhQP8Yuh0VZqWunOb5CzK+U=;
Received: from [84.212.220.105] (helo=joga)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1oJdkp-0000B4-Et; Thu, 04 Aug 2022 18:31:26 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Subject: Re: bug#49592: 28.0.50; lisp-current-defun-name and non-standard
 defuns
In-Reply-To: <878s279dfi.fsf@HIDDEN> (Michael Heerdegen's message of "Fri, 16
 Jul 2021 04:53:53 +0200")
References: <878s279dfi.fsf@HIDDEN>
X-Now-Playing: Devadip Carlos Santana and Turiya Alice Coltrane's
 _Illuminations_: "Illuminations"
Date: Thu, 04 Aug 2022 18:31:22 +0200
Message-ID: <87edxwezs5.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Michael Heerdegen <michael_heerdegen@HIDDEN> writes: >
 consider
 a top-level expression like this (you might want to insert this > snipped
 into *scratch* for testing): > > (progn > ; ; comment > ; ;
 about that > (define-key ...) > ) > > With `which-functio [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 49592
Cc: 49592 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Michael Heerdegen <michael_heerdegen@HIDDEN> writes:

> consider a top-level expression like this (you might want to insert this
> snipped into *scratch* for testing):
>
> (progn
>   ;; comment
>   ;; about that
>   (define-key ...)
>   )
>
> With `which-function-mode' enabled, more or less the complete expression
> is shown in the mode-line (with newlines escaped) when moving into the
> expression.
>
> The reason: `lisp-current-defun-name' doesn't check for whether the
> second subexpression of a top-level expression is still on the same line
> - it just returns a string including everything (i.e. all comments) in
> between.

This function is documented as:

(defun lisp-current-defun-name ()
  "Return the name of the defun at point, or nil."

There is no defun at point in this situation, so perhaps it would make
sense to return nil here?  But this is also used by add-log, so perhaps
which-func should just use something completely different and more
strict.  I.e., skip back to the top-level form, and then use the edebug
spec to pick out the name?





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#49592; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 16 Jul 2021 02:54:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 15 22:54:13 2021
Received: from localhost ([127.0.0.1]:50190 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1m4DzO-0007qD-VL
	for submit <at> debbugs.gnu.org; Thu, 15 Jul 2021 22:54:13 -0400
Received: from lists.gnu.org ([209.51.188.17]:47088)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1m4DzC-0007pe-Vk
 for submit <at> debbugs.gnu.org; Thu, 15 Jul 2021 22:54:09 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:52114)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <michael_heerdegen@HIDDEN>)
 id 1m4DzC-0001l6-Hc
 for bug-gnu-emacs@HIDDEN; Thu, 15 Jul 2021 22:53:58 -0400
Received: from mout.web.de ([212.227.17.12]:47299)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <michael_heerdegen@HIDDEN>)
 id 1m4Dz9-0006rM-WF
 for bug-gnu-emacs@HIDDEN; Thu, 15 Jul 2021 22:53:58 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
 s=dbaedf251592; t=1626404034;
 bh=hDrkip+q27BX3Anytg6zYIBh/mHvW8vB9z8z/huZDCY=;
 h=X-UI-Sender-Class:From:To:Subject:Date;
 b=cgRyL+qlb59BzoQAGmf/q2nkCSosOLmGZqXr57BGnmbGuQ40WhstXwuUVJItC3UQm
 dqF17F+Sg2osciBv+tpHpsKPMUt1UtHI9xu8D46r/URfME1Yx8kU00tDxrkc8ZyBWM
 FsDDsQurQeN/5PrrH3P+LYs5PUPb8AYajcVIOsTo=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from drachen.dragon ([88.66.201.45]) by smtp.web.de (mrweb102
 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LbrUu-1lN9PR3ME0-00jIgk for
 <bug-gnu-emacs@HIDDEN>; Fri, 16 Jul 2021 04:53:53 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 28.0.50; lisp-current-defun-name and non-standard defuns
Date: Fri, 16 Jul 2021 04:53:53 +0200
Message-ID: <878s279dfi.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:SB8WKdkXigbnf5pmZLDTjbFAaa15lQ5ROVrhLT3B8iYo5L1b9+V
 7+yLlo8EZlpI30lAqaMxML3JLc5ZWyDu9JdCGuK5YQtv3gPBRNlILqw0x6nop/FkYvKGjnF
 ZF77zHDtU0KA+5SKMOcefSkadjcKeM58zUkqJttheLgDyyfvCSGVLAmIXBmh3Q7e5OLb3Pd
 H2qH1ysbdUfUemkjFdr8A==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:eYLl3rEyG8s=:KqKwXnI7stuIt/A/tP6UcV
 zTAPQsJFdqZSH5jvjuTabeydEClGxhvdTY/YPys09xNgFLUsNLhwkeQaVqYfglc/V6iqucF0W
 PDEGRmaPXgdh35pTcSPdT5Mo3BCCuUDjRk6CYHqNY864sqiLmU77TN945GNJ8WYlrEwWXbpjw
 So61G8joozND1KM/XICDsTEHmX/0s8IUaPaRQ+Ht9YrZpDhZv/87FxwVilmRKLa968ENKS0AQ
 wSrJ+32kJKAVowZM2g+0YS/+rhVAXrBg/PFAjN1A2RlQ/PUdvumKD7SHYBzGsLGZQNkds726S
 WkdXPnj03qPd2In0XFbcjOOlOLApcW/7N48UQyDt4R7nnk7gIwVDr8NIvW/2uZtAvHDKCZF6O
 /4Dl51+m3BUldZiCwjjLQ6NOffVsakETg84L8vjY0PfFhF58olQTGJOauFV581nsouS2SPey6
 xoiNHky87cb6HMTq0EWdMi46BuYXkLSecAygrTFFLyzRpRb1PuQfKEBHjnJzOs+hO4bbEBa2P
 R2PUk4wV4+l6TfvzkVCQ8Y49l8nV5f21lBtM52xWmJsGuIv9P3CHMcZBkU2yC66foqxyxnzzS
 t5X8SwkX0ZUIFJvb59sI7HtIrXexdCYORFKUIgCCuOy26gWIjRH4ISIgrc9q5oAT3sAmNF1WX
 fiWwMn457XeAGe1w9geDmbvMCzAXkBVhGfuFCcrtGfhGm0XKsdkP0Rc6NbHon3DBW07DF60WO
 NeiR14WR4wFVri1U6Ig1AECxZ6CffqDfsuacfv5sjLJ3F2v/N9UIAeJtFd6PVmGX6C1H29FVO
 JFqNyTy8vaVqN3V1j0SnWXqxYHS8kBcsmQwIGYBO/27IOSNikeh9fp2+hnLNm/oDu+6kaYJzz
 JYHJ1TquIEdUjDJ1/YW7vhBauiHd0sl6k+CzI8YLolkIZQvJurydEC3iCuPL9DC9qmDxjMApG
 2qsmnVT1kc2buzvw6gCluMOlx1Sap540KldFxaz6hOyByLoYOUEMXVYtCoKafyG33eS/m8BNg
 rko1vec23alnmOUGSub5CKH5LCAVx0TJeyXVx/dpmP+nf2a21c5RUoGZFjJIZOAkuKzd/f9Gv
 Pwprkg9k5yT99LzeNtum9m4RgvnpY/Am6CIzfV+pPswQKqAt8LKiq72hQ==
Received-SPF: pass client-ip=212.227.17.12;
 envelope-from=michael_heerdegen@HIDDEN; helo=mout.web.de
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)


Hello,

consider a top-level expression like this (you might want to insert this
snipped into *scratch* for testing):

(progn
  ;; comment
  ;; about that
  (define-key ...)
  )

With `which-function-mode' enabled, more or less the complete expression
is shown in the mode-line (with newlines escaped) when moving into the
expression.

The reason: `lisp-current-defun-name' doesn't check for whether the
second subexpression of a top-level expression is still on the same line
- it just returns a string including everything (i.e. all comments) in
between.

Dunno what the best fix is.  In the above case returning something like
"(progn ...)" would be best, since the second subexpression is not even
a name (a symbol).


TIA,

Michael.


In GNU Emacs 28.0.50 (build 38, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0)
 of 2021-07-16 built on drachen
Repository revision: c5d6d45b48b2a4799ad1d27a2e7551113801b097
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12010000
System Description: Debian GNU/Linux bullseye/sid

Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP
SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB





Acknowledgement sent to Michael Heerdegen <michael_heerdegen@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#49592; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sat, 24 Sep 2022 15:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.