GNU logs - #49620, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#49620] [PATCH 2/2] Add pirate-get
Resent-From: phodina <phodina@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 18 Jul 2021 11:38:01 +0000
Resent-Message-ID: <handler.49620.B.162660825630736 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 49620 <at> debbugs.gnu.org
Reply-To: phodina <phodina@HIDDEN>
Date: Sun, 18 Jul 2021 11:37:24 +0000
From: phodina <phodina@HIDDEN>
Message-ID: <Ko2gpHllZIoGR5jyOu1v0rgJSa-DpfJZ6aJK1EYq0ooMcI3D_kkBPw-k86vgqdMe2py1XWJ1Mo00o-mv-9ayQwsdqhWY2gqXAkokz0iSTjQ=@protonmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=185.70.40.136;
 envelope-from=phodina@HIDDEN; helo=mail-40136.protonmail.ch
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

And the pirate-get definition itself

---
index 40b93c4b30..eaf521090c 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -1778,6 +1778,33 @@ helpers.")
 appealing ASCII table format")
     (license license:bsd3)))

+(define-public python-pirate-get
+  (package
+    (name "python-pirate-get")
+    (version "0.4.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "pirate-get" version))
+        (sha256
+          (base32
+            "07s5ss9dxccx1mip7pyga1fagywkqchxmzz55ng47ac9053ffxkq"))))
+    (build-system python-build-system)
+    (propagated-inputs
+      `(("python-colorama" ,python-colorama)
+        ("python-pyperclip" ,python-pyperclip)
+        ("python-veryprettytable"
+         ,python-veryprettytable)))
+    (home-page
+      "https://github.com/vikstrous/pirate-get")
+    (synopsis
+      "A command line interface for The Pirate Bay")
+    (description
+      "pirate-get is a convenient command line tool (inspired by APT)
+to speed up your trip to the Pirate Bay and get your completely legal
+torrents more quickly.")
+    (license license:gpl3)))
+
 (define-public python2-humanfriendly
   (let ((base (package-with-python2
                 (strip-python2-variant python-humanfriendly))))
--
2.31.1

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: phodina <phodina@HIDDEN>
Subject: bug#49620: Acknowledgement ([PATCH 2/2] Add pirate-get)
Message-ID: <handler.49620.B.162660825630736.ack <at> debbugs.gnu.org>
References: <Ko2gpHllZIoGR5jyOu1v0rgJSa-DpfJZ6aJK1EYq0ooMcI3D_kkBPw-k86vgqdMe2py1XWJ1Mo00o-mv-9ayQwsdqhWY2gqXAkokz0iSTjQ=@protonmail.com>
X-Gnu-PR-Message: ack 49620
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 49620 <at> debbugs.gnu.org
Date: Sun, 18 Jul 2021 11:38:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 49620 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
49620: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D49620
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 21 Jul 2021 02:53:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 20 22:53:46 2021
Received: from localhost ([127.0.0.1]:35866 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1m62Mk-00050W-1g
	for submit <at> debbugs.gnu.org; Tue, 20 Jul 2021 22:53:46 -0400
Received: from out0.migadu.com ([94.23.1.103]:33887)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <iskarian@HIDDEN>)
 id 1m62Mg-00050E-Eg; Tue, 20 Jul 2021 22:53:43 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1;
 t=1626836020;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=P6p1rMNlUc3Bpbdbr2Hp+cJdLEMYUyKiYB1flDMDsQ0=;
 b=d835on4oexQqeUkYnXmVy3D9tGq4VjF+uMA2aEBFmO3EblG1upjtwQZIbYqFytyY4cW+5q
 pkB+he4Tuixx/oFRPgw25uDh5scaDAdmmDThbvxS5ZXWD6L9oGXR5nezUk6bd8ZeLddkqT
 vKtb+ttnZ2M4dV6A7T6oBVVj0CU+O7s=
From: Sarah Morgensen <iskarian@HIDDEN>
To: phodina <phodina@HIDDEN>
Subject: Re: bug#49619: [PATCH 1/2] Add pirate-get
References: <JuV3kXY4ae-0f4PzOqwU4h0_Vh24XCQbm0P3uWqIKZ_-_7hOqSjxqsSHPpVdGA1OPcVRuyq0GT5UNjV_a8ZrDHuaZmNbh81jQzI644BmQR8=@protonmail.com>
Date: Tue, 20 Jul 2021 19:53:37 -0700
In-Reply-To: <JuV3kXY4ae-0f4PzOqwU4h0_Vh24XCQbm0P3uWqIKZ_-_7hOqSjxqsSHPpVdGA1OPcVRuyq0GT5UNjV_a8ZrDHuaZmNbh81jQzI644BmQR8=@protonmail.com>
 (phodina@HIDDEN's message of "Sun, 18 Jul 2021 11:36:02 +0000")
Message-ID: <86bl6wtm1a.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: iskarian@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: control
Cc: 49619 <at> debbugs.gnu.org, control <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

merge 49619 49620
thanks

Hello,

Thanks for the patch. Please note that when submitting patchsets, only
the first patch should be sent to guix-patches@HIDDEN; the rest should
be sent to the generated bug number, in this case 49619 <at> debbugs.gnu.org,
in reply to the first email. You can find information about contributing
at:

  https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

I also have a few suggestions so your patch can be accepted.

phodina <phodina@HIDDEN> writes:

> Add pkg veryprettytable as a dependency for pkg pirate-get
>
> ---

Commit messages should follow the ChangeLog format; see the commit
history for examples. For example, this commit message would look like:

--8<---------------cut here---------------start------------->8---
gnu: Add python-veryprettytable.

* gnu/packages/python-xyz.scm (python-veryprettytable): New variable.
--8<---------------cut here---------------end--------------->8---

> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index d8c3fbec07..40b93c4b30 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -1754,6 +1754,30 @@ helpers.")
>      (properties `((python2-variant . ,(delay python2-humanfriendly))))
>      (license license:expat)))
>
> +(define-public python-veryprettytable
> +  (package
> +    (name "python-veryprettytable")
> +    (version "0.8.1")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "veryprettytable" version))
> +        (sha256
> +          (base32
> +            "1k1rifz8x6qcicmx2is9vgxcj0qb2f5pvzrp7zhmvbmci3yack3f"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +      `(("python-colorama" ,python-colorama)
> +        ("python-termcolor" ,python-termcolor)))
> +    (home-page
> +      "https://github.com/smeggingsmegger/VeryPrettyTable")
> +    (synopsis
> +      "A visually appealing ASCII table output format")

Avoid starting synopses and descriptions with articles. "Visually
appealing..." would be fine.

> +    (description
> +      "A simple Python library for easily displaying tabular data in a visually
> +appealing ASCII table format")

Descriptions typically start: "VeryPrettyTable is a simple..."

The description for pirate-get should probably start "Pirate-get is
a..." or "@code{pirate-get} is a..."

> +    (license license:bsd3)))

This should be license:bsd-3.

> +
>  (define-public python2-humanfriendly
>    (let ((base (package-with-python2
>                  (strip-python2-variant python-humanfriendly))))
> --
> 2.31.1

You should also add your copyright at the top of the file, below all the
others.

Please use `--reroll-count=` when generating revised patchsets and
`--to=49169 <at> debbugs.gnu.org --in-reply-to=<original patch's Message-ID>`
when sending.

--
Sarah

Last modified: Wed, 21 Jul 2021 03:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.