GNU bug report logs - #49626
Why mouse-1 is not allowed on button links?

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49626 in the body.
You can then email your comments to 49626 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Why mouse-1 is not allowed on button links?
Date: Mon, 19 Jul 2021 01:38:13 +0300

Tried to click mouse-1 on the button links in the 'dictionary' buffers
(from the built-in package lisp/net/dictionary.el),
but it does nothing, unlike mouse-2.  Should this patch be applied?
I'm asking because I'm not sure about its side effects to other packages.

diff --git a/lisp/button.el b/lisp/button.el
index 69d70540c0..74dfb5d541 100644
--- a/lisp/button.el
+++ b/lisp/button.el
@@ -61,6 +61,7 @@ button-map
     ;; might get converted to ^M when building loaddefs.el
     (define-key map [(control ?m)] 'push-button)
     (define-key map [mouse-2] 'push-button)
+    (define-key map [follow-link] 'mouse-face)
     ;; FIXME: You'd think that for keymaps coming from text-properties on the
     ;; mode-line or header-line, the `mode-line' or `header-line' prefix
     ;; shouldn't be necessary!

Message #8 received at 49626 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 49626 <at> debbugs.gnu.org
Subject: Re: bug#49626: Why mouse-1 is not allowed on button links?
Date: Mon, 19 Jul 2021 15:51:38 +0200

Juri Linkov <juri <at> linkov.net> writes:

> Tried to click mouse-1 on the button links in the 'dictionary' buffers
> (from the built-in package lisp/net/dictionary.el),
> but it does nothing, unlike mouse-2.  Should this patch be applied?
> I'm asking because I'm not sure about its side effects to other packages.

I think it should be applied -- I think mouse-1 should work as
documented in all packages?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 49626 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 49626 <at> debbugs.gnu.org
Subject: Re: bug#49626: Why mouse-1 is not allowed on button links?
Date: Tue, 20 Jul 2021 22:53:28 +0300

tags 49626 fixed
close 49626 28.0.50
quit

>> Tried to click mouse-1 on the button links in the 'dictionary' buffers
>> (from the built-in package lisp/net/dictionary.el),
>> but it does nothing, unlike mouse-2.  Should this patch be applied?
>> I'm asking because I'm not sure about its side effects to other packages.
>
> I think it should be applied -- I think mouse-1 should work as
> documented in all packages?

So now applied.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.