GNU bug report logs - #49665
28.0.50; Failing autorevert tests on Cygwin

Previous Next

Package: emacs;

Reported by: Ken Brown <kbrown <at> cornell.edu>

Date: Tue, 20 Jul 2021 16:33:02 UTC

Severity: normal

Found in version 28.0.50

Fixed in version 28.1

Done: Michael Albinus <Michael.Albinus <at> gmx.de>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49665 in the body.
You can then email your comments to 49665 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to Michael.Albinus <at> gmx.de, bug-gnu-emacs <at> gnu.org:
bug#49665; Package emacs. (Tue, 20 Jul 2021 16:33:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ken Brown <kbrown <at> cornell.edu>:
New bug report received and forwarded. Copy sent to Michael.Albinus <at> gmx.de, bug-gnu-emacs <at> gnu.org. (Tue, 20 Jul 2021 16:33:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Failing autorevert tests on Cygwin
Date: Tue, 20 Jul 2021 12:26:51 -0400
Some of the autorevert tests fail on Cygwin.  The precise tests that
fail aren't the same in every run, but here's the result of the most
recent run on my 64-bit Cygwin system:

Ran 8 tests, 3 results as expected, 5 unexpected (2021-07-20 11:28:04-0400, 
9.783866 sec)

5 unexpected results:
   FAILED  auto-revert-test00-auto-revert-mode
   FAILED  auto-revert-test01-auto-revert-several-files
   FAILED  auto-revert-test02-auto-revert-deleted-file
   FAILED  auto-revert-test05-global-notify
   FAILED  auto-revert-test07-auto-revert-several-buffers

And here's the result of the most recent run on my 32-bit Cygwin system:

Ran 8 tests, 4 results as expected, 4 unexpected (2021-07-20 11:35:17-0400, 
19.531540 sec)

4 unexpected results:
   FAILED  auto-revert-test00-auto-revert-mode
   FAILED  auto-revert-test01-auto-revert-several-files
   FAILED  auto-revert-test02-auto-revert-deleted-file
   FAILED  auto-revert-test05-global-notify

I also see occasional failures of
auto-revert-test03-auto-revert-tail-mode on both architectures.

test02 and test05 have apparently been failing for a long time, but I
didn't notice it prior to commit fe16248b77, because all tests were
tagged as expensive before then and so weren't run by 'make check'.  The
(sporadic) failures of test00, test01, and test03 started with that
commit, so they are almost certainly due to timing issues.  I'm not sure
about test07, which wasn't added until later.  All I know is that it
always fails on 64-bit and occasionally fails on 32-bit.  This makes me
guess that it's also a timing issue, but I suppose there could be some
other bug that's specific to 64-bit.

I'm not interested in spending a lot of time on this (or asking anyone
else to spend time on it), because I've never seen a Cygwin user
complain about auto-revert mode.  (Maybe no one uses it because it's
slow.)  But I would like to stop seeing the test failures.

Here's one possibility: Skip test02 and test05 on Cygwin, with a FIXME
comment indicating that they've been failing for a long time and we
don't know why.  Tag test00, test01, and test03 as expensive on Cygwin,
since we would have to make the tests much slower in order for them to
pass.  I'm not sure about test07.

Other suggestions?

Thanks.

Ken

In GNU Emacs 28.0.50 (build 4, x86_64-pc-cygwin, GTK+ Version 3.22.28, cairo 
version 1.17.4)
 of 2021-07-20 built on moufang2
Repository revision: 61c1522ddedc45d85804ff2786bd301e9b487b32
Repository branch: master
Windowing system distributor 'The Cygwin/X Project', version 11.0.12012000
Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBOTF LIBXML2 M17N_FLT MODULES NOTIFY GFILENOTIFY PDUMPER PNG
RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#49665; Package emacs. (Tue, 20 Jul 2021 17:38:02 GMT) Full text and rfc822 format available.

Message #8 received at 49665 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <Michael.Albinus <at> gmx.de>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 49665 <at> debbugs.gnu.org
Subject: Re: bug#49665: 28.0.50; Failing autorevert tests on Cygwin
Date: Tue, 20 Jul 2021 19:37:16 +0200
Ken Brown <kbrown <at> cornell.edu> writes:

Hi Ken,

> Some of the autorevert tests fail on Cygwin.  The precise tests that
> fail aren't the same in every run, but here's the result of the most
> recent run on my 64-bit Cygwin system:

[...]

> I'm not interested in spending a lot of time on this (or asking anyone
> else to spend time on it), because I've never seen a Cygwin user
> complain about auto-revert mode.  (Maybe no one uses it because it's
> slow.)  But I would like to stop seeing the test failures.
>
> Here's one possibility: Skip test02 and test05 on Cygwin, with a FIXME
> comment indicating that they've been failing for a long time and we
> don't know why.  Tag test00, test01, and test03 as expensive on Cygwin,
> since we would have to make the tests much slower in order for them to
> pass.  I'm not sure about test07.
>
> Other suggestions?

We have the tag :unstable for such tests. You might tag all tests you're
not interested in. Something like this after the docstring:

     :tags (when (eq system-type 'cygwin) '(:unstable))

Perhaps also a comment.

If you could provide me a recent Emacs 28 for cygwin, I could try to
check what's up.

> Thanks.
>
> Ken

Best regards, Michael.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#49665; Package emacs. (Tue, 20 Jul 2021 20:17:01 GMT) Full text and rfc822 format available.

Message #11 received at 49665 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Michael Albinus <Michael.Albinus <at> gmx.de>
Cc: 49665 <at> debbugs.gnu.org
Subject: Re: bug#49665: 28.0.50; Failing autorevert tests on Cygwin
Date: Tue, 20 Jul 2021 16:15:58 -0400
On 7/20/2021 1:37 PM, Michael Albinus wrote:

Hi Michael,

> We have the tag :unstable for such tests. You might tag all tests you're
> not interested in. Something like this after the docstring:
> 
>       :tags (when (eq system-type 'cygwin) '(:unstable))
> 
> Perhaps also a comment.

Good idea.  I'll do this after you've had a chance to look at it.

> If you could provide me a recent Emacs 28 for cygwin, I could try to
> check what's up.

Here they are:

64-bit: https://paste.c-net.org/ToughenTheory

32-bit: https://paste.c-net.org/ChewsAtomic

I've built them --with-x=no to reduce the number of dependent libraries.  But 
you'll still probably need a fairly up-to-date Cygwin installation to run them.

Thanks for taking a look.

Ken




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#49665; Package emacs. (Tue, 20 Jul 2021 21:24:02 GMT) Full text and rfc822 format available.

Message #14 received at 49665 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <Michael.Albinus <at> gmx.de>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 49665 <at> debbugs.gnu.org
Subject: Re: bug#49665: 28.0.50; Failing autorevert tests on Cygwin
Date: Tue, 20 Jul 2021 23:23:23 +0200
Ken Brown <kbrown <at> cornell.edu> writes:

> Hi Michael,

Hi Ken,

>> We have the tag :unstable for such tests. You might tag all tests you're
>> not interested in. Something like this after the docstring:
>>       :tags (when (eq system-type 'cygwin) '(:unstable))
>> Perhaps also a comment.
>
> Good idea.  I'll do this after you've had a chance to look at it.

Will do. Next days are busy, so I cannot promise to be fast.

>> If you could provide me a recent Emacs 28 for cygwin, I could try to
>> check what's up.
>
> Here they are:
>
> 64-bit: https://paste.c-net.org/ToughenTheory
>
> 32-bit: https://paste.c-net.org/ChewsAtomic
>
> I've built them --with-x=no to reduce the number of dependent
> libraries.  But you'll still probably need a fairly up-to-date Cygwin
> installation to run them.
>
> Thanks for taking a look.

Thanks. I run a Windows 10 VM just for Emacs test purposes. No problem
to update Cygwin there.

> Ken

Best regards, Michael.




Reply sent to Michael Albinus <Michael.Albinus <at> gmx.de>:
You have taken responsibility. (Tue, 27 Jul 2021 17:49:02 GMT) Full text and rfc822 format available.

Notification sent to Ken Brown <kbrown <at> cornell.edu>:
bug acknowledged by developer. (Tue, 27 Jul 2021 17:49:02 GMT) Full text and rfc822 format available.

Message #19 received at 49665-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <Michael.Albinus <at> gmx.de>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 49665-done <at> debbugs.gnu.org
Subject: Re: bug#49665: 28.0.50; Failing autorevert tests on Cygwin
Date: Tue, 27 Jul 2021 19:47:53 +0200
Version: 28.1

Michael Albinus <Michael.Albinus <at> gmx.de> writes:

Hi Ken,

>>> We have the tag :unstable for such tests. You might tag all tests you're
>>> not interested in. Something like this after the docstring:
>>>       :tags (when (eq system-type 'cygwin) '(:unstable))
>>> Perhaps also a comment.
>>
>> Good idea.  I'll do this after you've had a chance to look at it.
>
> Will do. Next days are busy, so I cannot promise to be fast.

Finally, I've decided to compile Emacs myself on Cygwin, this allows me
to go forth and back between git revisions.

I could reproduce the problem, but I have no clear view yet what to do
with timings. So I've pushed a change to master which declares all tests
as :unstable on Cygwin, as discussed.

I'm closing this bug, but (as time permits) I'll try to do better. No
promise, and there's not too much spare time, but I hate it if code
written by me doesn't work.

>> Ken

Best regards, Michael.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#49665; Package emacs. (Wed, 28 Jul 2021 11:50:02 GMT) Full text and rfc822 format available.

Message #22 received at 49665-done <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Michael Albinus <Michael.Albinus <at> gmx.de>
Cc: 49665-done <at> debbugs.gnu.org
Subject: Re: bug#49665: 28.0.50; Failing autorevert tests on Cygwin
Date: Wed, 28 Jul 2021 07:48:51 -0400
On 7/27/2021 1:47 PM, Michael Albinus wrote:
> I'm closing this bug, but (as time permits) I'll try to do better. No
> promise, and there's not too much spare time, but I hate it if code
> written by me doesn't work.

Thanks, Michael, and thanks for looking at this.

Ken




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 26 Aug 2021 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 215 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.