GNU bug report logs - #49667
28.0.50; Byte-compilation warning in buffer-tests.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49667 in the body.
You can then email your comments to 49667 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Byte-compilation warning in buffer-tests.el
Date: Tue, 20 Jul 2021 21:29:54 +0300

  $ make src/buffer-tests
  make[1]: Entering directory `/d/gnu/git/emacs/trunk/test'
    ELC      src/buffer-tests.elc

  In toplevel form:
  src/buffer-tests.el:1359:14: Warning: Empty let body

?????

In GNU Emacs 28.0.50 (build 1554, i686-pc-mingw32)
 of 2021-07-20 built on HOME-C4E4A596F7
Repository revision: f9d74408148e50eb287d6bf784cddbdc239d9669
Repository branch: master
Windowing system distributor 'Microsoft Corp.', version 5.1.2600
System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600)

Configured using:
 'configure -C --prefix=/d/usr --with-wide-int --with-modules
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3''

Configured features:
ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY
W32NOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS XPM
ZLIB

Important settings:
  value of $LANG: ENU
  locale-coding-system: cp1255

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win
w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty
make-network-process emacs)

Memory information:
((conses 16 56703 10329)
 (symbols 48 7784 1)
 (strings 16 21903 1722)
 (string-bytes 1 634098)
 (vectors 16 12509)
 (vector-slots 8 166646 8009)
 (floats 8 23 106)
 (intervals 40 265 0)
 (buffers 888 10))

Message #8 received at 49667 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 49667 <at> debbugs.gnu.org
Subject: Re: bug#49667: 28.0.50; Byte-compilation warning in buffer-tests.el
Date: Tue, 20 Jul 2021 22:22:52 +0200

Am Di., 20. Juli 2021 um 20:31 Uhr schrieb Eli Zaretskii <eliz <at> gnu.org>:
>
>
>   $ make src/buffer-tests
>   make[1]: Entering directory `/d/gnu/git/emacs/trunk/test'
>     ELC      src/buffer-tests.elc
>
>   In toplevel form:
>   src/buffer-tests.el:1359:14: Warning: Empty let body
>


Pretty sure this comes from the empty (with-output-to-string) body
there. Adding an (ignore) form to the empty body fixes it for me.

Message #11 received at 49667 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 49667 <at> debbugs.gnu.org
Subject: Re: bug#49667: 28.0.50; Byte-compilation warning in buffer-tests.el
Date: Wed, 21 Jul 2021 13:20:09 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>   $ make src/buffer-tests
>   make[1]: Entering directory `/d/gnu/git/emacs/trunk/test'
>     ELC      src/buffer-tests.elc
>
>   In toplevel form:
>   src/buffer-tests.el:1359:14: Warning: Empty let body

I thought we didn't care about compilation warnings in tests?  If we do,
we have quite a bit to tweak.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #14 received at 49667 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 49667 <at> debbugs.gnu.org
Subject: Re: bug#49667: 28.0.50; Byte-compilation warning in buffer-tests.el
Date: Wed, 21 Jul 2021 16:42:38 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: 49667 <at> debbugs.gnu.org
> Date: Wed, 21 Jul 2021 13:20:09 +0200
> 
> >   $ make src/buffer-tests
> >   make[1]: Entering directory `/d/gnu/git/emacs/trunk/test'
> >     ELC      src/buffer-tests.elc
> >
> >   In toplevel form:
> >   src/buffer-tests.el:1359:14: Warning: Empty let body
> 
> I thought we didn't care about compilation warnings in tests?

Are these necessary, or could they be trivially fixed?

Message #17 received at 49667 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 49667 <at> debbugs.gnu.org
Subject: Re: bug#49667: 28.0.50; Byte-compilation warning in buffer-tests.el
Date: Wed, 21 Jul 2021 15:52:34 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> Are these necessary, or could they be trivially fixed?

It can be trivially fixed by just adding something in the body.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #22 received at 49667-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 49667-done <at> debbugs.gnu.org
Subject: Re: bug#49667: 28.0.50; Byte-compilation warning in buffer-tests.el
Date: Thu, 22 Jul 2021 12:15:54 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: 49667 <at> debbugs.gnu.org
> Date: Wed, 21 Jul 2021 15:52:34 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Are these necessary, or could they be trivially fixed?
> 
> It can be trivially fixed by just adding something in the body.

Done, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.