GNU bug report logs - #49668
[PATCH 1/2] gnu: emacs-org-roam: Update to 2.0.0.

Previous Next

Package: guix-patches;

Reported by: Vinicius Monego <monego <at> posteo.net>

Date: Tue, 20 Jul 2021 19:33:01 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49668 in the body.
You can then email your comments to 49668 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#49668; Package guix-patches. (Tue, 20 Jul 2021 19:33:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Vinicius Monego <monego <at> posteo.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 20 Jul 2021 19:33:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 1/2] gnu: emacs-org-roam: Update to 2.0.0.
Date: Tue, 20 Jul 2021 19:31:29 +0000
* gnu/packages/emacs-xyz.scm (emacs-org-roam): Update to 2.0.0.
[propagated-inputs]: Add emacs-magit.
---
 gnu/packages/emacs-xyz.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 41608d71e0..8b188a1d3e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27846,7 +27846,7 @@ snippets for Emacs.")
 (define-public emacs-org-roam
   (package
     (name "emacs-org-roam")
-    (version "1.2.4")
+    (version "2.0.0")
     (source
      (origin
        (method git-fetch)
@@ -27855,7 +27855,7 @@ snippets for Emacs.")
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "10jrnjq65lpg1x8d7lqc537yai9m6pdnfbzwr87fcyv6f8yii8xn"))))
+        (base32 "0mslrdgd41czay3w7znz4qsv1h0p3zqfsq6bkyxmxfyd2w5z82zf"))))
     (build-system emacs-build-system)
     (arguments
      `(#:phases
@@ -27878,6 +27878,7 @@ snippets for Emacs.")
         `(("emacs-dash" ,emacs-dash)
           ("emacs-emacsql-sqlite3" ,emacs-emacsql-sqlite3)
           ("emacs-f" ,emacs-f)
+          ("emacs-magit" ,emacs-magit)
           ("emacs-org" ,emacs-org)
           ("emacs-s" ,emacs-s)))
        (home-page "https://github.com/org-roam/org-roam/")
-- 
2.30.2





Information forwarded to guix-patches <at> gnu.org:
bug#49668; Package guix-patches. (Tue, 20 Jul 2021 19:34:01 GMT) Full text and rfc822 format available.

Message #8 received at 49668 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 49668 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 2/2] gnu: emacs-org-roam-bibtex: Update to 0.6.0.
Date: Tue, 20 Jul 2021 19:33:11 +0000
* gnu/packages/emacs-xyz.scm (emacs-org-roam-bibtex): Update to 0.6.0.
---
 gnu/packages/emacs-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8b188a1d3e..d3be38d065 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27893,7 +27893,7 @@ personal wiki.")
 (define-public emacs-org-roam-bibtex
   (package
     (name "emacs-org-roam-bibtex")
-    (version "0.6.0-pre.2")
+    (version "0.6.0")
     (source
      (origin
        (method git-fetch)
@@ -27902,7 +27902,7 @@ personal wiki.")
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0cjj7lx73qg4yw84r3b8fqhp5r74bzi57nvnvbvbck4i33ywqwx5"))))
+        (base32 "04vc2w7x2lyamp0qa1y274smsf9x2qxr1igrpz9f4y5ha5332px5"))))
     (build-system emacs-build-system)
     (propagated-inputs
      `(("emacs-helm-bibtex" ,emacs-helm-bibtex)
-- 
2.30.2





Information forwarded to guix-patches <at> gnu.org:
bug#49668; Package guix-patches. (Tue, 20 Jul 2021 19:54:02 GMT) Full text and rfc822 format available.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 49668 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#49668] [PATCH 1/2] gnu: emacs-org-roam: Update to 2.0.0.
Date: Tue, 20 Jul 2021 20:53:20 +0100
[Message part 1 (text/plain, inline)]
Hi Vinicius,

Vinicius Monego writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-roam): Update to 2.0.0.
> [propagated-inputs]: Add emacs-magit.

Given the v1 -> v2 migration requires a manual process, it might be a
good idea to keep a v1 package for users that may want to stay on it for
a little bit longer, what do you think? The author has kept a
https://github.com/org-roam/org-roam-v1 repository for this effect.

Otherwise I tested the update and it looks good to me! I was able to
migrate successfully, but I don't have that many notes.

Thanks,
Pierre
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#49668; Package guix-patches. (Tue, 20 Jul 2021 19:54:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#49668; Package guix-patches. (Wed, 21 Jul 2021 15:00:02 GMT) Full text and rfc822 format available.

Message #17 received at 49668 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: Pierre Langlois <pierre.langlois <at> gmx.com>
Cc: 49668 <at> debbugs.gnu.org
Subject: Re: [bug#49668] [PATCH 1/2] gnu: emacs-org-roam: Update to 2.0.0.
Date: Wed, 21 Jul 2021 14:58:04 +0000
Hi Pierre,

Em ter, 2021-07-20 às 20:53 +0100, Pierre Langlois escreveu:
> Given the v1 -> v2 migration requires a manual process, it might be a
> good idea to keep a v1 package for users that may want to stay on it
> for
> a little bit longer, what do you think? The author has kept a
> https://github.com/org-roam/org-roam-v1 repository for this effect.

The description of that repository says "No longer actively maintained.
" and the README recommends the migration. That is my main concern,
introducing a package that we know for a fact that is unmaintained and
don't have a schedule for removal. It feels more like a use case for a
custom channel.

Another option is to hold this update until 2.0.1 after v2 is more
widely used, though Guix users who wish to migrate now would have to
update manually in that case.

I will wait for more feedback on this.

Vinicius





Information forwarded to guix-patches <at> gnu.org:
bug#49668; Package guix-patches. (Wed, 21 Jul 2021 16:03:02 GMT) Full text and rfc822 format available.

Message #20 received at 49668 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 49668 <at> debbugs.gnu.org, Pierre Langlois <pierre.langlois <at> gmx.com>
Subject: Re: [bug#49668] [PATCH 1/2] gnu: emacs-org-roam: Update to 2.0.0.
Date: Wed, 21 Jul 2021 17:01:59 +0100
[Message part 1 (text/plain, inline)]
Hi Vinicius,

Vinicius Monego writes:

> Hi Pierre,
>
> Em ter, 2021-07-20 às 20:53 +0100, Pierre Langlois escreveu:
>> Given the v1 -> v2 migration requires a manual process, it might be a
>> good idea to keep a v1 package for users that may want to stay on it
>> for
>> a little bit longer, what do you think? The author has kept a
>> https://github.com/org-roam/org-roam-v1 repository for this effect.
>
> The description of that repository says "No longer actively maintained.
> " and the README recommends the migration. That is my main concern,
> introducing a package that we know for a fact that is unmaintained and
> don't have a schedule for removal. It feels more like a use case for a
> custom channel.

That's a fair point, we might forget to ever remove the old v1 package
:-). I don't have a strong opinion given I was able to migrate myself
without any trouble, there was many posts in the community about the
migration that made me feel we might want to be cautious.

But thinking about it more now, emacs makes it easy to install packages
manually, so if one really needs to stay on v1 for a bit, they can
always do it outside of Guix.

So you can consider my mind changed on this matter :-).

Thanks,
Pierre
[signature.asc (application/pgp-signature, inline)]

Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Tue, 27 Jul 2021 17:12:02 GMT) Full text and rfc822 format available.

Notification sent to Vinicius Monego <monego <at> posteo.net>:
bug acknowledged by developer. (Tue, 27 Jul 2021 17:12:02 GMT) Full text and rfc822 format available.

Message #25 received at 49668-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 49668-done <at> debbugs.gnu.org
Subject: Re: [bug#49668] [PATCH 1/2] gnu: emacs-org-roam: Update to 2.0.0.
Date: Tue, 27 Jul 2021 19:11:21 +0200
Hello,

Vinicius Monego <monego <at> posteo.net> writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-roam): Update to 2.0.0.
> [propagated-inputs]: Add emacs-magit.

Applied both patches. Thank you.

Regards,
-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 25 Aug 2021 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 216 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.