GNU bug report logs - #49687
[PATCH] Add mode-line-compact variable to Customize

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49687 in the body.
You can then email your comments to 49687 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Illia Ostapyshyn <ilya.ostapyshyn <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add mode-line-compact variable to Customize
Date: Thu, 22 Jul 2021 00:45:56 +0300

[Message part 1 (text/plain, inline)]

This patch adds mode-line-compact to customize group mode-line so it can be
easily discovered and set through easy customization interface.

[0001-lisp-cus-start.el-Add-mode-line-compact-to-Customize.patch (application/octet-stream, attachment)]

Message #8 received at 49687 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Illia Ostapyshyn <ilya.ostapyshyn <at> gmail.com>
Cc: 49687 <at> debbugs.gnu.org
Subject: Re: bug#49687: [PATCH] Add mode-line-compact variable to Customize
Date: Wed, 21 Jul 2021 23:54:07 +0200

Illia Ostapyshyn <ilya.ostapyshyn <at> gmail.com> writes:

> This patch adds mode-line-compact to customize group mode-line so it can be
> easily discovered and set through easy customization interface.

Thanks; applied to Emacs 28.

This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?

Message #13 received at 49687 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: ilya.ostapyshyn <at> gmail.com, 49687 <at> debbugs.gnu.org
Subject: Re: bug#49687: [PATCH] Add mode-line-compact variable to Customize
Date: Thu, 22 Jul 2021 10:26:03 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Wed, 21 Jul 2021 23:54:07 +0200
> Cc: 49687 <at> debbugs.gnu.org
> 
> Illia Ostapyshyn <ilya.ostapyshyn <at> gmail.com> writes:
> 
> > This patch adds mode-line-compact to customize group mode-line so it can be
> > easily discovered and set through easy customization interface.
> 
> Thanks; applied to Emacs 28.

IMO, showing the values in parentheses makes the description
potentially confusing.  E.g., for this description:

  "Only if wider than window (long)"

I needed to stare at it for some time before I realized that the
"(long)" part shows the underlying Lisp value.

AFAIK, we don't normally show values in parentheses like that.  Why is
it a good idea in this case (or at all)?

Message #16 received at 49687 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: ilya.ostapyshyn <at> gmail.com, 49687 <at> debbugs.gnu.org
Subject: Re: bug#49687: [PATCH] Add mode-line-compact variable to Customize
Date: Thu, 22 Jul 2021 14:15:59 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> AFAIK, we don't normally show values in parentheses like that.  Why is
> it a good idea in this case (or at all)?

It's not -- but quite a few of the options defined in that file do this,
so it was probably just patterned on that.

I've now removed the lisp values from those strings of all the user
options defined in that form.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #19 received at 49687 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: ilya.ostapyshyn <at> gmail.com, 49687 <at> debbugs.gnu.org
Subject: Re: bug#49687: [PATCH] Add mode-line-compact variable to Customize
Date: Thu, 22 Jul 2021 15:18:34 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: ilya.ostapyshyn <at> gmail.com,  49687 <at> debbugs.gnu.org
> Date: Thu, 22 Jul 2021 14:15:59 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > AFAIK, we don't normally show values in parentheses like that.  Why is
> > it a good idea in this case (or at all)?
> 
> It's not -- but quite a few of the options defined in that file do this,
> so it was probably just patterned on that.
> 
> I've now removed the lisp values from those strings of all the user
> options defined in that form.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.