GNU bug report logs - #49715
[PATCH] gnu: Add gmic-qt-gimp.

Previous Next

Package: guix-patches;

Reported by: Ivan Gankevich <i.gankevich <at> spbu.ru>

Date: Sat, 24 Jul 2021 08:55:02 UTC

Severity: normal

Tags: patch

Done: Leo Famulari <leo <at> famulari.name>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49715 in the body.
You can then email your comments to 49715 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#49715; Package guix-patches. (Sat, 24 Jul 2021 08:55:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ivan Gankevich <i.gankevich <at> spbu.ru>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 24 Jul 2021 08:55:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Gankevich <i.gankevich <at> spbu.ru>
To: guix-patches <at> gnu.org
Cc: Ivan Gankevich <i.gankevich <at> spbu.ru>
Subject: [PATCH] gnu: Add gmic-qt-gimp.
Date: Sat, 24 Jul 2021 11:51:56 +0300
* gnu/packages/image-processing.scm (gmic-qt-gimp): New variable.
---
 gnu/packages/image-processing.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm
index df77bef192..399ee55c87 100644
--- a/gnu/packages/image-processing.scm
+++ b/gnu/packages/image-processing.scm
@@ -17,6 +17,7 @@
 ;;; Copyright © 2021 Andy Tai <atai <at> atai.org>
 ;;; Copyright © 2021 Ekaitz Zarraga <ekaitz <at> elenq.tech>
 ;;; Copyright © 2021 Paul Garlick <pgarlick <at> tourbillion-technology.com>
+;;; Copyright © 2021 Ivan Gankevich <i.gankevich <at> spbu.ru>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -56,6 +57,7 @@
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages geo)
   #:use-module (gnu packages ghostscript)
+  #:use-module (gnu packages gimp)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
@@ -801,6 +803,25 @@ including 2D color images.")
                               (assoc-ref %build-inputs "gmic") "/lib")))))
     (synopsis "Krita plugin for the G'MIC image processing framework")))
 
+(define-public gmic-qt-gimp
+  (package
+    (inherit gmic-qt)
+    (name "gmic-qt-gimp")
+    (inputs
+      ;; GIMP and its dependencies.
+      `(("gimp" ,gimp)
+        ("gdk-pixbuf" ,gdk-pixbuf)
+        ("cairo" ,cairo)
+        ("gegl" ,gegl)
+        ,@(package-inputs gmic-qt)))
+    (arguments
+      (substitute-keyword-arguments (package-arguments gmic-qt)
+        ((#:configure-flags flags)
+         '(list "-DGMIC_QT_HOST=gimp" "-DENABLE_DYNAMIC_LINKING=ON"
+                (string-append "-DGMIC_LIB_PATH="
+                               (assoc-ref %build-inputs "gmic") "/lib")))))
+    (synopsis "GIMP plugin for the G'MIC image processing framework")))
+
 (define-public nip2
   (package
     (name "nip2")
-- 
2.32.0





Information forwarded to guix-patches <at> gnu.org:
bug#49715; Package guix-patches. (Fri, 22 Oct 2021 14:27:01 GMT) Full text and rfc822 format available.

Message #8 received at 49715 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 49715 <at> debbugs.gnu.org
Cc: Ivan Gankevich <i.gankevich <at> spbu.ru>
Subject: [PATCH] gnu: Add gmic-qt-gimp.
Date: Fri, 22 Oct 2021 14:14:15 +0000
Hi,

> * gnu/packages/image-processing.scm (gmic-qt-gimp): New variable.

I built and tested this patch and can confirm it works. A few nitpicks
that I have:

> +    (inputs
> +      ;; GIMP and its dependencies.
> +      `(("gimp" ,gimp)
> +        ("gdk-pixbuf" ,gdk-pixbuf)
> +        ("cairo" ,cairo)
> +        ("gegl" ,gegl)
> +        ,@(package-inputs gmic-qt)))

Should be one space below inputs. Also the labeled inputs should be
sorted alphabetically. See the gmic-qt package for instance.

> +    (arguments
> +      (substitute-keyword-arguments (package-arguments gmic-qt)
> +        ((#:configure-flags flags)
> +         '(list "-DGMIC_QT_HOST=gimp" "-DENABLE_DYNAMIC_LINKING=ON"
> +                (string-append "-DGMIC_LIB_PATH="
> +                               (assoc-ref %build-inputs "gmic")
> "/lib")))))

Should be one space below arguments (see gmic-qt-krita for instance).

If you're using Emacs, the indentation should be fixed automatically
with M-x indent-sexp or indent-region.

Vinicius





Reply sent to Leo Famulari <leo <at> famulari.name>:
You have taken responsibility. (Fri, 22 Oct 2021 20:33:02 GMT) Full text and rfc822 format available.

Notification sent to Ivan Gankevich <i.gankevich <at> spbu.ru>:
bug acknowledged by developer. (Fri, 22 Oct 2021 20:33:02 GMT) Full text and rfc822 format available.

Message #13 received at 49715-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 49715-done <at> debbugs.gnu.org, Ivan Gankevich <i.gankevich <at> spbu.ru>
Subject: Re: [bug#49715] [PATCH] gnu: Add gmic-qt-gimp.
Date: Fri, 22 Oct 2021 16:32:13 -0400
On Fri, Oct 22, 2021 at 02:14:15PM +0000, Vinicius Monego wrote:
> Hi,
> 
> > * gnu/packages/image-processing.scm (gmic-qt-gimp): New variable.
> 
> I built and tested this patch and can confirm it works. A few nitpicks
> that I have:
> 
> > +    (inputs
> > +      ;; GIMP and its dependencies.
> > +      `(("gimp" ,gimp)
> > +        ("gdk-pixbuf" ,gdk-pixbuf)
> > +        ("cairo" ,cairo)
> > +        ("gegl" ,gegl)
> > +        ,@(package-inputs gmic-qt)))
> 
> Should be one space below inputs. Also the labeled inputs should be
> sorted alphabetically. See the gmic-qt package for instance.
> 
> > +    (arguments
> > +      (substitute-keyword-arguments (package-arguments gmic-qt)
> > +        ((#:configure-flags flags)
> > +         '(list "-DGMIC_QT_HOST=gimp" "-DENABLE_DYNAMIC_LINKING=ON"
> > +                (string-append "-DGMIC_LIB_PATH="
> > +                               (assoc-ref %build-inputs "gmic")
> > "/lib")))))
> 
> Should be one space below arguments (see gmic-qt-krita for instance).
> 
> If you're using Emacs, the indentation should be fixed automatically
> with M-x indent-sexp or indent-region.

Thanks for the patch and the review, everybody!

I made the requested changes and pushed as
41492639e0223dc8fc1a357e1f9537577c055db7




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 20 Nov 2021 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 129 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.