GNU bug report logs - #49725
[PATCH] Unfontify previous location when overwriting bookmark

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49725 in the body.
You can then email your comments to 49725 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher League <league <at> contrapunctus.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Unfontify previous location when overwriting bookmark
Date: Sat, 24 Jul 2021 20:28:41 -0400

[Message part 1 (text/plain, inline)]

This issue with ‘bookmark-fontify’ came up (within a broader
discussion) on the list in May, in particular by Bastien in
+message-id:<8735v0w5fv.fsf <at> bzg.fr>. It's obtrusive with the way
‘org-refile’ and ‘org-capture’ use bookmarks, but still bothersome
outside of org. It's not yet fixed in current master.

To reproduce, make sure ‘bookmark-fontify’ is t (the default in
master) and ‘bookmark-face’ is noticeable (orange background by
default). Then:

    emacs -Q
    ;; Visit any file with >20 lines, e.g.:
    M-x find-library RET bookmark RET
    ;; Set bookmark to current line
    C-x r m RET
    ;; Go elsewhere and overwrite same bookmark:
    C-u C-u C-n
    C-x r m RET

When we set or jump to a bookmark, that line gets fontified in the
buffer. Move down a few lines, and set the bookmark again with the
same name. This will (by default) overwrite the previous location, but
now *both* locations are displayed using bookmark-face. When a
bookmark is deleted with ‘bookmark-delete’ or within
‘bookmark-bmenu-list’ (C-x r l), its location gets unfontified. But
when just overwritten, the font overlay remains.

In the fix, I tried to split and edit the nearby comment for clarity
as well. Feedback welcome, thanks.

CL

[0001-When-bookmark-is-overwritten-unfontify-its-previous-.patch (text/x-patch, attachment)]

Message #8 received at 49725 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Christopher League <league <at> contrapunctus.net>
Cc: 49725 <at> debbugs.gnu.org
Subject: Re: bug#49725: [PATCH] Unfontify previous location when overwriting
 bookmark
Date: Sun, 25 Jul 2021 09:38:33 +0200

Christopher League <league <at> contrapunctus.net> writes:

> In the fix, I tried to split and edit the nearby comment for clarity
> as well. Feedback welcome, thanks.

Thanks; looks good to me (and pushed to Emacs 28).  Does this also fix
the related bug#49645?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 49725 <at> debbugs.gnu.org (full text, mbox):

From: Christopher League <league <at> contrapunctus.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 49725 <at> debbugs.gnu.org
Subject: Re: bug#49725: [PATCH] Unfontify previous location when overwriting
 bookmark
Date: Sun, 25 Jul 2021 10:18:43 -0400

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Thanks; looks good to me (and pushed to Emacs 28). Does this
> also fix the related bug#49645?

Oh, I missed that! Found the discussion from May, but not that
report a few days ago.

I think it must fix that, though Marius describes that the
highlighting gets stuck "when deleting bookmarks", which I think
was working before my patch, which only applies to overwrites.
From what I can tell, the call to ‘bookmark--unfontify’ inside
‘bookmark-delete’ dates to 4 May, in the same commit when
‘bookmark-fontify’ option was introduced.

But maybe he was accumulating bookmarks due to overwrites and
misattributed it. I'll reply on that report to confirm.

CL

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.