Received: (at 49729) by debbugs.gnu.org; 25 Jul 2021 20:45:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 25 16:45:24 2021 Received: from localhost ([127.0.0.1]:49481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1m7l00-0007Di-Ef for submit <at> debbugs.gnu.org; Sun, 25 Jul 2021 16:45:24 -0400 Received: from out0.migadu.com ([94.23.1.103]:24326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <iskarian@HIDDEN>) id 1m7kzy-0007BP-OV for 49729 <at> debbugs.gnu.org; Sun, 25 Jul 2021 16:45:23 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1627245922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HTkL0WJ8o/3GYR+p5MTaYX3UKmxJUvoX0QEwZ93DxKM=; b=czr2uXWC0ov/xVi3rr9ZmACL8iQpDCTto0kOfTBt7ctGw+aKcUR3q6UWv9lbCpwknyOprr NubLuBLI5FdiT98GSnR5NY5f5eqdyfEE0OHMFhVotDMDrxVdi1M3/jbalOxHUeFLk5maYV ael49PEwa8PHgQNLN3JSbyyEBLxrDbo= From: Sarah Morgensen <iskarian@HIDDEN> To: Maxime Devos <maximedevos@HIDDEN> Subject: Re: bug#49729: [PATCH core-updates] build-system/gnu: Make gzip files writable before resetting timestamps. References: <f45aa05904dcb0cb8718be3d32d9bae9807ed8c0.1627193346.git.iskarian@HIDDEN> <4a4d285bafb763b6e6a8c5febc224f178d9a3083.camel@HIDDEN> Date: Sun, 25 Jul 2021 13:45:20 -0700 In-Reply-To: <4a4d285bafb763b6e6a8c5febc224f178d9a3083.camel@HIDDEN> (Maxime Devos's message of "Sun, 25 Jul 2021 17:26:54 +0200") Message-ID: <86a6map1gf.fsf_-_@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49729 Cc: 49729 <at> debbugs.gnu.org, ludo@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Hi, Thanks for taking a look at this. Maxime Devos <maximedevos@HIDDEN> writes: > [CC'ing Ludo because Ludo introduced the 'reset-gzip-timestamps' phase] > Sarah Morgensen schreef op za 24-07-2021 om 23:12 [-0700]: >> guix/build/gnu-build-system.scm (reset-gzip-timestamps): Ensure gzip >> files are writable before resetting their timestamps. >> --- >> Hello Guix, >> >> There have been a number of instances of packages having to add their own phase >> before 'reset-gzip-timestamps to make the gzip files writable--perhaps the gnu >> build system can take care of this itself? WDYT? > > This seems reasonable to me. There are 35 package definions referring to > 'reset-gzip-timestamps', could you follow up with patches removing the phases > for making gzip files writable? Yes, I intend to. Should I send them to this issue #, or separately? (And one commit per package, yes?) -- Sarah
guix-patches@HIDDEN
:bug#49729
; Package guix-patches
.
Full text available.Received: (at 49729) by debbugs.gnu.org; 25 Jul 2021 15:27:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 25 11:27:04 2021 Received: from localhost ([127.0.0.1]:49154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1m7g1w-0007QF-Gb for submit <at> debbugs.gnu.org; Sun, 25 Jul 2021 11:27:04 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:43076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maximedevos@HIDDEN>) id 1m7g1u-0007Pr-Fa for 49729 <at> debbugs.gnu.org; Sun, 25 Jul 2021 11:27:03 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by xavier.telenet-ops.be with bizsmtp id ZTSy2500P0mfAB401TSzQQ; Sun, 25 Jul 2021 17:27:00 +0200 Message-ID: <4a4d285bafb763b6e6a8c5febc224f178d9a3083.camel@HIDDEN> Subject: Re: [bug#49729] [PATCH core-updates] build-system/gnu: Make gzip files writable before resetting timestamps. From: Maxime Devos <maximedevos@HIDDEN> To: Sarah Morgensen <iskarian@HIDDEN>, 49729 <at> debbugs.gnu.org Date: Sun, 25 Jul 2021 17:26:54 +0200 In-Reply-To: <f45aa05904dcb0cb8718be3d32d9bae9807ed8c0.1627193346.git.iskarian@HIDDEN> References: <f45aa05904dcb0cb8718be3d32d9bae9807ed8c0.1627193346.git.iskarian@HIDDEN> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-diOOgIujgp7ooQQa9phN" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1627226820; bh=eME6SPWTJDZxxdMh8jnXhRf5BGQmADCdVbxKW+luzdw=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=hFydarnDDU+Z13qpoB8GclU4vijsEadsOVH3yW/A/m/GOEaPdevDuQTefb4zSo9K1 Zm6H6eCIClEmrc8q7ZNHEJX02NWMsE9+TENyWffHBe8V+g3wYpIx2k0+AsYIjXAfJO WjTbPpzvROPfyuXYCcVcLyVn4BghruBuj3t7iDVvUvoVfOID7aPKatDQOPM3MJG/jg f/l4CAtz6vwfubXdXPpzQsCNras9kR53O3zxuP1gFCUlr99Q2uwUhAA6HiH9ARTd3L 2d1nKv+HROp3w6se8hqQ56OlyX/rPx98IZqxXYKmU8H5KEOP2y51EGCOw8iZ5mJHF+ Vq6731h8s/zag== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49729 Cc: ludo@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) --=-diOOgIujgp7ooQQa9phN Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable [CC'ing Ludo because Ludo introduced the 'reset-gzip-timestamps' phase] Sarah Morgensen schreef op za 24-07-2021 om 23:12 [-0700]: > guix/build/gnu-build-system.scm (reset-gzip-timestamps): Ensure gzip > files are writable before resetting their timestamps. > --- > Hello Guix, >=20 > There have been a number of instances of packages having to add their own= phase > before 'reset-gzip-timestamps to make the gzip files writable--perhaps th= e gnu > build system can take care of this itself? WDYT? This seems reasonable to me. There are 35 package definions referring to 'reset-gzip-timestamps', could you follow up with patches removing the phas= es for making gzip files writable? Greetings, Maxime. --=-diOOgIujgp7ooQQa9phN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYP2CvhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7nGHAP9miEDKAiQV/WaMbi+zOyO6p21B bBSxBHb1yrdbMudOsAEAwA12n2XQ6H9qmlj81hL6897qEs27oxn26sHD4LhMYw0= =y7gm -----END PGP SIGNATURE----- --=-diOOgIujgp7ooQQa9phN--
guix-patches@HIDDEN
:bug#49729
; Package guix-patches
.
Full text available.Received: (at submit) by debbugs.gnu.org; 25 Jul 2021 06:12:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 25 02:12:19 2021 Received: from localhost ([127.0.0.1]:47364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1m7XN4-0007Wq-Qg for submit <at> debbugs.gnu.org; Sun, 25 Jul 2021 02:12:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:54410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <iskarian@HIDDEN>) id 1m7XN1-0007Wf-Em for submit <at> debbugs.gnu.org; Sun, 25 Jul 2021 02:12:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <iskarian@HIDDEN>) id 1m7XN0-0005Ws-UP for guix-patches@HIDDEN; Sun, 25 Jul 2021 02:12:14 -0400 Received: from out1.migadu.com ([2001:41d0:2:863f::]:22534) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <iskarian@HIDDEN>) id 1m7XMw-0003bp-Im for guix-patches@HIDDEN; Sun, 25 Jul 2021 02:12:14 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1627193526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=BUxwaVAnUiyHnTCDo9HkPm7jYEyyZMd8FhPPcEFzJNM=; b=dmCboz3OOMjhuhw0cNVVgNchG/YKR6mWx4cOvZXTJGK1j147rzvooJjMQpew+3tfpolaXW YefJMuut12uRT0L/doazD4YqFwn9CwQAlEtwAqrFrHwzWfSL0SYnZERr9plYh/uiMJa4q5 3CxPwiz7osy86ZNjeNUgIP/Hj/d6gD8= From: Sarah Morgensen <iskarian@HIDDEN> To: guix-patches@HIDDEN Subject: [PATCH core-updates] build-system/gnu: Make gzip files writable before resetting timestamps. Date: Sat, 24 Jul 2021 23:12:04 -0700 Message-Id: <f45aa05904dcb0cb8718be3d32d9bae9807ed8c0.1627193346.git.iskarian@HIDDEN> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@HIDDEN Received-SPF: pass client-ip=2001:41d0:2:863f::; envelope-from=iskarian@HIDDEN; helo=out1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.4 (--) guix/build/gnu-build-system.scm (reset-gzip-timestamps): Ensure gzip files are writable before resetting their timestamps. --- Hello Guix, There have been a number of instances of packages having to add their own phase before 'reset-gzip-timestamps to make the gzip files writable--perhaps the gnu build system can take care of this itself? WDYT? -- Sarah guix/build/gnu-build-system.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/guix/build/gnu-build-system.scm b/guix/build/gnu-build-system.scm index d0f7413268..d84411c090 100644 --- a/guix/build/gnu-build-system.scm +++ b/guix/build/gnu-build-system.scm @@ -598,6 +598,8 @@ and 'man/'. This phase moves directories to the right place if needed." (string-suffix? ".tgz" file)) (gzip-file? file))) #:stat lstat))) + ;; Ensure the files are writable. + (for-each make-file-writable files) (for-each reset-gzip-timestamp files))) (match outputs base-commit: 7bef3be1d318beebaf48ac6daa3140205ba18e98 -- 2.31.1
Sarah Morgensen <iskarian@HIDDEN>
:guix-patches@HIDDEN
.
Full text available.guix-patches@HIDDEN
:bug#49729
; Package guix-patches
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.