GNU bug report logs - #49736
[PATCH] gnu: Add emacs-nasm-mode.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49736 in the body.
You can then email your comments to 49736 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ron Nazarov <noisytoot <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: Ron Nazarov <noisytoot <at> disroot.org>
Subject: [PATCH] gnu: Add emacs-nasm-mode.
Date: Sun, 25 Jul 2021 22:44:40 +0100

* gnu/packages/emacs-xyz.scm (emacs-nasm-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a26a023a2b..83a59ca3a4 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -101,6 +101,7 @@
 ;;; Copyright © 2021 David Dashyan <mail <at> davie.li>
 ;;; Copyright © 2021 Dhruvin Gandhi <contact <at> dhruvin.dev>
 ;;; Copyright © 2021 Matthew James Kraai <kraai <at> ftbfs.org>
+;;; Copyright © 2021 Noisytoot <noisytoot <at> disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -29037,3 +29038,26 @@ Believing} is a ruby gem to evaluate Ruby code, recording the results of each
 line.  This minor mode provides an easy way to run it from Emacs on the
 current region or entire buffer.")
       (license license:gpl3+))))
+
+(define-public emacs-nasm-mode
+  (package
+    (name "emacs-nasm-mode")
+    (version "20190410.342")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://melpa.org/packages/nasm-mode-"
+             version
+             ".el"))
+       (sha256
+        (base32
+         "10js4bdgqgvlhpk3mgq3rjglmkgkxchj1bny16bkl7glw5mqwl8c"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/skeeto/nasm-mode")
+    (synopsis "NASM x86 assembly major mode")
+    (description
+     "@code{nasm-mode} is a major mode for editing NASM x86 assembly programs.
+It includes syntax highlighting, automatic indentation, and imenu integration.
+Unlike Emacs' generic @code{asm-mode}, it understands NASM-specific syntax.")
+    (license license:unlicense)))
-- 
2.32.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Ron Nazarov via Guix-patches via <guix-patches <at> gnu.org>
Cc: 49736 <at> debbugs.gnu.org, Ron Nazarov <noisytoot <at> disroot.org>
Subject: Re: [bug#49736] [PATCH] gnu: Add emacs-nasm-mode.
Date: Tue, 27 Jul 2021 19:43:30 +0200

Hello,

Ron Nazarov via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-nasm-mode): New variable.

Thank you.

> +(define-public emacs-nasm-mode
> +  (package
> +    (name "emacs-nasm-mode")
> +    (version "20190410.342")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://melpa.org/packages/nasm-mode-"
> +             version
> +             ".el"))

Please use Github repository instead of MELPA.  The latter has a strange
versioning scheme, and source is not stable.

> +       (sha256
> +        (base32
> +         "10js4bdgqgvlhpk3mgq3rjglmkgkxchj1bny16bkl7glw5mqwl8c"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/skeeto/nasm-mode")
> +    (synopsis "NASM x86 assembly major mode")
> +    (description
> +     "@code{nasm-mode} is a major mode for editing NASM x86 assembly programs.

I would write NASM mode is ...

> +It includes syntax highlighting, automatic indentation, and imenu integration.
> +Unlike Emacs' generic @code{asm-mode}, it understands NASM-specific syntax.")

ditto: ASM mode.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #14 received at 49736 <at> debbugs.gnu.org (full text, mbox):

From: Ron Nazarov <noisytoot <at> disroot.org>
To: 49736 <at> debbugs.gnu.org
Cc: Ron Nazarov <noisytoot <at> disroot.org>
Subject: [PATCH v2] gnu: Add emacs-nasm-mode.
Date: Wed, 28 Jul 2021 16:35:48 +0100

* gnu/packages/emacs-xyz.scm (emacs-nasm-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d7c317a076..088266e01b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -101,6 +101,7 @@
 ;;; Copyright © 2021 David Dashyan <mail <at> davie.li>
 ;;; Copyright © 2021 Dhruvin Gandhi <contact <at> dhruvin.dev>
 ;;; Copyright © 2021 Matthew James Kraai <kraai <at> ftbfs.org>
+;;; Copyright © 2021 Noisytoot <noisytoot <at> disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -29055,3 +29056,26 @@ Believing} is a ruby gem to evaluate Ruby code, recording the results of each
 line.  This minor mode provides an easy way to run it from Emacs on the
 current region or entire buffer.")
       (license license:gpl3+))))
+
+(define-public emacs-nasm-mode
+  (package
+    (name "emacs-nasm-mode")
+    (version "1.1.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/skeeto/nasm-mode")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1dyc50a1zskx9fqxl2iy2x74f3bkb2ccz908v0aj13rqfqqnns9j"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/skeeto/nasm-mode")
+    (synopsis "NASM x86 assembly major mode")
+    (description
+     "NASM mode is a major mode for editing NASM x86 assembly programs.
+It includes syntax highlighting, automatic indentation, and imenu integration.
+Unlike Emacs' generic ASM mode, it understands NASM-specific syntax.")
+    (license license:unlicense)))
-- 
2.32.0

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Ron Nazarov via Guix-patches via <guix-patches <at> gnu.org>
Cc: 49736-done <at> debbugs.gnu.org, Ron Nazarov <noisytoot <at> disroot.org>
Subject: Re: [bug#49736] [PATCH v2] gnu: Add emacs-nasm-mode.
Date: Thu, 29 Jul 2021 09:42:57 +0200

Hello,

Ron Nazarov via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-nasm-mode): New variable.

Applied. Thank you!

Please note (for future contributions) that adding package definitions
at the very end of a file is prone to merge conflicts. It is better to
use a random location.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.