GNU bug report logs - #49766
[PATCH] gnu: rocksdb: set TEST_TMPDIR for faster test i/o.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49766 in the body.
You can then email your comments to 49766 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ryan Sundberg <ryan <at> arctype.co>
To: guix-patches <at> gnu.org
Cc: Ryan Sundberg <ryan <at> arctype.co>
Subject: [PATCH] gnu: rocksdb: set TEST_TMPDIR for faster test i/o.
Date: Wed, 28 Jul 2021 22:00:26 -0700

The rocksdb test can take an egregious amount of time on a spinning HDD.
This will inherit guixbuild's /tmp mount for the rocksdb testing
directory.

* gnu/packages/databases.scm (rocksdb)[arguments]: set TEST_TMPDIR for
check phase
---
 gnu/packages/databases.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 5de79de955..cd19d14950 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -1395,10 +1395,19 @@ including field and record folding.")))
                (("install: install-static")
                 "install: install-shared")
                (("#!/bin/sh") (string-append "#!" (which "sh"))))
-             #t))
+             #t)) 
          (delete 'configure)
          ;; The default target is only needed for tests and built on demand.
          (delete 'build)
+         (add-before 'check 'mount-tmp
+           ;; Use the provided workspace directory for test files.
+           ;; Otherwise, /tmp is used which is a mount namespace on /gnu/store.
+           ;; This speeds up the build when the host /tmp is a proper tmpfs or
+           ;; other fast filesystem, as opposed to /gnu which may be a HDD.
+           (lambda _
+             (let ((test-dir (string-append (getcwd) "/../test")))
+               (mkdir test-dir)
+               (setenv "TEST_TMPDIR" (canonicalize-path test-dir)))))
          (add-before 'check 'disable-optimizations
            (lambda _
              ;; Prevent the build from passing '-march=native' to the compiler.
@@ -1429,6 +1438,7 @@ including field and record folding.")))
        ("perl" ,perl)
        ("procps" ,procps)
        ("python" ,python-2)
+       ("util-linux" ,util-linux)
        ("which" ,which)))
     (inputs
      `(("bzip2" ,bzip2)
-- 
2.31.1

Message #8 received at 49766 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Sundberg <ryan <at> arctype.co>
To: 49766 <at> debbugs.gnu.org
Subject: [bug#49766] [PATCH] gnu: rocksdb: set TEST_TMPDIR for faster test
 i/o. 
Date: Wed, 28 Jul 2021 22:08:21 -0700

Revised patch

Message #11 received at 49766 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Sundberg <ryan <at> arctype.co>
To: 49766 <at> debbugs.gnu.org
Subject: [bug#49766] [PATCH] gnu: rocksdb: set TEST_TMPDIR for faster test i/o.
Date: Wed, 28 Jul 2021 22:13:06 -0700

Revised patch attached.

Message #14 received at 49766 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Sundberg <ryan <at> arctype.co>
To: 49766 <at> debbugs.gnu.org
Subject: [bug#49766] [PATCH] gnu: rocksdb: set TEST_TMPDIR for faster test i/o.
Date: Wed, 28 Jul 2021 22:17:24 -0700

[Message part 1 (text/plain, inline)]

I give up with git send-email, here is the darn patch file. From
Thunderbird.

[0001-gnu-rocksdb-set-TEST_TMPDIR-for-faster-test-i-o.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #19 received at 49766-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ryan Sundberg <ryan <at> arctype.co>
Cc: 49766-done <at> debbugs.gnu.org
Subject: Re: bug#49766: [PATCH] gnu: rocksdb: set TEST_TMPDIR for faster
 test i/o.
Date: Tue, 10 Aug 2021 17:13:17 +0200

Hi,

Ryan Sundberg <ryan <at> arctype.co> skribis:

> I give up with git send-email, here is the darn patch file. From
> Thunderbird.

:-)

> From 672a5b2f00a095dd1afc3259eca3f14439323e2b Mon Sep 17 00:00:00 2001
> From: Ryan Sundberg <ryan <at> arctype.co>
> Date: Wed, 28 Jul 2021 20:43:14 -0700
> Subject: [PATCH] gnu: rocksdb: set TEST_TMPDIR for faster test i/o.
>
> The rocksdb test can take an egregious amount of time on a spinning HDD.
> This will inherit guixbuild's /tmp mount for the rocksdb testing
> directory.
>
> * gnu/packages/databases.scm (rocksdb)[arguments]: set TEST_TMPDIR for
> check phase

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.