GNU bug report logs - #50006
28.0.50; remove deprecated option erc-send-pre-hook

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50006 in the body.
You can then email your comments to 50006 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; remove deprecated option erc-send-pre-hook
Date: Wed, 11 Aug 2021 07:03:12 -0700

[Message part 1 (text/plain, inline)]

Tags: patch
Severity: minor

I don't actually need this for any of the more delusional mega patches I
currently have on offer [1], so feel free to flat out deny. (However, I
will say that it does unclutter some of the main message-sending
business, which may not be the worst thing ever.)

Note: I guess we should probably double check this doesn't interfere
with any of the ELPA plans that ERC's maintainer has cooking. Thanks.


[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48598
    https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49860


In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4)
 of 2021-08-09 built on localhost
Repository revision: aeec97fae0ccfcc4dc406a5e0e4c0a94b834cac4
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Fedora 34 (Workstation Edition)

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
X11 XDBE XIM XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting system-font-setting font-render-setting
cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 51538 6355)
 (symbols 48 6607 1)
 (strings 32 18255 1368)
 (string-bytes 1 616656)
 (vectors 16 14292)
 (vector-slots 8 185252 10153)
 (floats 8 21 47)
 (intervals 56 205 0)
 (buffers 992 10))

[0001-Remove-deprecated-variable-erc-send-pre-hook.patch (text/x-patch, attachment)]

Message #8 received at 50006 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "J.P." <jp <at> neverwas.me>
Cc: Amin Bandali <bandali <at> gnu.org>, 50006 <at> debbugs.gnu.org
Subject: Re: bug#50006: 28.0.50; remove deprecated option erc-send-pre-hook
Date: Sun, 19 Sep 2021 09:36:07 -0700

"J.P." <jp <at> neverwas.me> writes:

> Tags: patch
> Severity: minor
>
> I don't actually need this for any of the more delusional mega patches I
> currently have on offer [1], so feel free to flat out deny. (However, I
> will say that it does unclutter some of the main message-sending
> business, which may not be the worst thing ever.)
>
> Note: I guess we should probably double check this doesn't interfere
> with any of the ELPA plans that ERC's maintainer has cooking. Thanks.
>
>
> [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48598
>     https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49860

Copying in the ERC maintainer Amin Bandali here.

Amin, could you help review this patch?

Message #11 received at 50006 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Amin Bandali <bandali <at> gnu.org>, 50006 <at> debbugs.gnu.org
Subject: Re: bug#50006: 28.0.50; remove deprecated option erc-send-pre-hook
Date: Sun, 19 Sep 2021 15:54:34 -0700

Stefan Kangas <stefan <at> marxist.se> writes:

> Copying in the ERC maintainer Amin Bandali here.
>
> Amin, could you help review this patch?

Thanks Stefan. I should save y'all the trouble and admit that I rather
brashly submitted this without first taking a moment to get a feel for
how long Emacs retains deprecated items. (Nothing to do with the recent
ELPA proposal, BTW [1]; just sheer ignorance on my part.) So unless I'm
preempted, I'll send a control message in the next 24 or so to shut this
bad boy down. Thanks again.

[1] https://lists.gnu.org/archive/html/emacs-devel/2021-09/msg01384.html

Message #16 received at 50006-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "J.P." <jp <at> neverwas.me>
Cc: Amin Bandali <bandali <at> gnu.org>, 50006-done <at> debbugs.gnu.org
Subject: Re: bug#50006: 28.0.50; remove deprecated option erc-send-pre-hook
Date: Mon, 20 Sep 2021 00:27:27 -0700

"J.P." <jp <at> neverwas.me> writes:

> Thanks Stefan. I should save y'all the trouble and admit that I rather
> brashly submitted this without first taking a moment to get a feel for
> how long Emacs retains deprecated items. (Nothing to do with the recent
> ELPA proposal, BTW [1]; just sheer ignorance on my part.)

Ah, so this only removes some deprecated variables?  Yes, we tend to
leave them for a very long time, up to five major releases.  They are
then generally removed en masse; in Emacs 28 we are removing most things
deprecated in Emacs 23.

In Emacs 29, I expect that we will remove most things deprecated in
Emacs 24.

> So unless I'm preempted, I'll send a control message in the next 24 or
> so to shut this bad boy down. Thanks again.

You can just add "-close" to the email address of the bug number to
close it, as in "50006-done <at> debbugs.gnu.org".

I did that now, mostly so that we don't forget about it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.