GNU bug report logs - #50007
28.0.50; normalize logic surrounding erc-server-reconnecting

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50007 in the body.
You can then email your comments to 50007 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; normalize logic surrounding erc-server-reconnecting
Date: Wed, 11 Aug 2021 07:12:52 -0700

[Message part 1 (text/plain, inline)]

Tags: patch

Knowing when we're reconnecting and having that logic be as sane and
straightforward as possible is (IMO) a critical component of unraveling
the buffer-association game I've been trying to drag everyone into.

The existing approach is troublesome because it's basically inscrutable
in the sense of being too difficult to sit down and reason through once
session identities enter the fray (at least for a simpleton like me).
And though the solution I'm proposing may seem underwhelming, it wasn't
just intuited out of thin air but rather discovered with the backing of
behavioral tests like the ones included in these patches [1]. Thanks.


[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48598
    https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49860


In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4)
 of 2021-08-09 built on localhost
Repository revision: aeec97fae0ccfcc4dc406a5e0e4c0a94b834cac4
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Fedora 34 (Workstation Edition)

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
X11 XDBE XIM XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting system-font-setting font-render-setting
cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 51538 6355)
 (symbols 48 6607 1)
 (strings 32 18255 1368)
 (string-bytes 1 616656)
 (vectors 16 14292)
 (vector-slots 8 185252 10153)
 (floats 8 21 47)
 (intervals 56 205 0)
 (buffers 992 10))

[0001-Normalize-usage-of-variable-erc-server-reconnecting.patch (text/x-patch, attachment)]

Message #8 received at 50007 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "J.P." <jp <at> neverwas.me>
Cc: Amin Bandali <bandali <at> gnu.org>, 50007 <at> debbugs.gnu.org
Subject: Re: bug#50007: 28.0.50;
 normalize logic surrounding erc-server-reconnecting
Date: Sun, 19 Sep 2021 09:36:14 -0700

"J.P." <jp <at> neverwas.me> writes:

> Tags: patch
>
> Knowing when we're reconnecting and having that logic be as sane and
> straightforward as possible is (IMO) a critical component of unraveling
> the buffer-association game I've been trying to drag everyone into.
>
> The existing approach is troublesome because it's basically inscrutable
> in the sense of being too difficult to sit down and reason through once
> session identities enter the fray (at least for a simpleton like me).
> And though the solution I'm proposing may seem underwhelming, it wasn't
> just intuited out of thin air but rather discovered with the backing of
> behavioral tests like the ones included in these patches [1]. Thanks.
>
>
> [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48598
>     https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49860

Copying in the ERC maintainer Amin Bandali here.

Amin, could you help review this patch?

Message #11 received at 50007 <at> debbugs.gnu.org (full text, mbox):

From: Amin Bandali <bandali <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 50007 <at> debbugs.gnu.org, "J.P." <jp <at> neverwas.me>
Subject: Re: bug#50007: 28.0.50; normalize logic surrounding
 erc-server-reconnecting
Date: Wed, 22 Sep 2021 00:37:32 -0400

Hi Stefan, all,

Stefan Kangas writes:

> "J.P." <jp <at> neverwas.me> writes:
>
>> Tags: patch
>>
>> Knowing when we're reconnecting and having that logic be as sane and
>> straightforward as possible is (IMO) a critical component of unraveling
>> the buffer-association game I've been trying to drag everyone into.
>>
>> The existing approach is troublesome because it's basically inscrutable
>> in the sense of being too difficult to sit down and reason through once
>> session identities enter the fray (at least for a simpleton like me).
>> And though the solution I'm proposing may seem underwhelming, it wasn't
>> just intuited out of thin air but rather discovered with the backing of
>> behavioral tests like the ones included in these patches [1]. Thanks.
>>
>>
>> [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48598
>>     https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49860
>
> Copying in the ERC maintainer Amin Bandali here.
>
> Amin, could you help review this patch?

I will review this patch -- and the other two you tagged me on -- but
most likely not before emacs-28 is cut: per J.P.[0] the tests covering
these three patches live in another, rather large, patch and I would
prefer to leave the merging of these to after the other large patch is
reviewed and merged (which may not be until a few more weeks).

[0]: https://lists.gnu.org/r/emacs-erc/2021-09/msg00004.html

Of course if you're volunteering to help test/review the large
patch(es) and these three that would be very welcome. :)

Message #14 received at 50007 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "J.P." <jp <at> neverwas.me>
Cc: 50007 <at> debbugs.gnu.org, Amin Bandali <mab <at> gnu.org>
Subject: Re: bug#50007: 28.0.50; normalize logic surrounding
 erc-server-reconnecting
Date: Sat, 06 Nov 2021 03:16:26 +0100

"J.P." <jp <at> neverwas.me> writes:

> Subject: [PATCH] Normalize usage of variable erc-server-reconnecting

I think I managed to follow the logic of this change, and it doesn't
seem to regress anything after a bit of testing, so I've pushed it to
Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #19 received at 50007 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 50007 <at> debbugs.gnu.org, Amin Bandali <mab <at> gnu.org>
Subject: Re: bug#50007: 28.0.50; normalize logic surrounding
 erc-server-reconnecting
Date: Sat, 06 Nov 2021 01:49:00 -0700

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> "J.P." <jp <at> neverwas.me> writes:
>
>> Subject: [PATCH] Normalize usage of variable erc-server-reconnecting
>
> I think I managed to follow the logic of this change, and it doesn't
> seem to regress anything after a bit of testing, so I've pushed it to
> Emacs 29.

Thanks Lars. As you may recall, I'm quite slow, often in more ways than
one. And that certainly applies here. Turns out I've been sitting on
slightly revised versions of both this and

  bug#50008: 28.0.50; ERC sends empty lines with user input

which you also recently added. For some reason (not sloth/dimwittedness,
I assure you), I only updated the versions of these patches living in
#48598 but neglected to follow suit with these two threads. So with much
contrition, I've isolated the differences and attached them here.

The updates to this bug attempt to preserve a couple API elements I
ditched/clobbered in what's already been installed (in the unlikely
event some poor sap or bot actually depended on them). This is mainly an
effort to embrace the spirit of being more responsible with and
accountable for my changes, something I've been slow to pick up on from
the great bandali. That said, I totally understand if you'd rather I
learn to live with my mistakes as well.

The minor changes to the other, "empty lines" patch just involve another
instance of superfluous newlines, this time generated from the function
`erc-cmd-default'. Thanks again and sorry for the disturbance.

[0001-Deprecate-instead-of-redefine-erc-server-reconnectin.patch (text/x-patch, attachment)]

[0002-Don-t-send-empty-lines-for-unknown-commands-in-ERC.patch (text/x-patch, attachment)]

Message #22 received at 50007 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "J.P." <jp <at> neverwas.me>
Cc: 50007 <at> debbugs.gnu.org, Amin Bandali <mab <at> gnu.org>
Subject: Re: bug#50007: 28.0.50; normalize logic surrounding
 erc-server-reconnecting
Date: Sat, 06 Nov 2021 19:13:25 +0100

"J.P." <jp <at> neverwas.me> writes:

> Thanks Lars. As you may recall, I'm quite slow, often in more ways than
> one. And that certainly applies here. Turns out I've been sitting on
> slightly revised versions of both this and
>
>   bug#50008: 28.0.50; ERC sends empty lines with user input

Thanks; I've now applied the updated patches, too.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #25 received at 50007 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 50007 <at> debbugs.gnu.org, Amin Bandali <mab <at> gnu.org>
Subject: Re: bug#50007: 28.0.50; normalize logic surrounding
 erc-server-reconnecting
Date: Sat, 06 Nov 2021 15:02:24 -0700

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Thanks; I've now applied the updated patches, too.

Oh, terrific! Much obliged, as always.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.