GNU bug report logs - #50008
28.0.50; ERC sends empty lines with user input

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50008 in the body.
You can then email your comments to 50008 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; ERC sends empty lines with user input
Date: Wed, 11 Aug 2021 07:15:00 -0700

[Message part 1 (text/plain, inline)]

Tags: patch

Hi, this one may take some seeing to believe. For proof, set up a local
server or proxy (I can help with this) or fire up and tweak the
behavioral tests included with these bugs [1] or ask a network oper
friend to check their logs (they'll already know immediately if you
mention ERC).

BTW, the included unit tests may require a quick refresher on the
relevant portions of the codebase. Happy to make a mess of explaining
the specifics. Thanks.


[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48598
    https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49860


In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4)
 of 2021-08-09 built on localhost
Repository revision: aeec97fae0ccfcc4dc406a5e0e4c0a94b834cac4
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Fedora 34 (Workstation Edition)

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
X11 XDBE XIM XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting system-font-setting font-render-setting
cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 51538 6355)
 (symbols 48 6607 1)
 (strings 32 18255 1368)
 (string-bytes 1 616656)
 (vectors 16 14292)
 (vector-slots 8 185252 10153)
 (floats 8 21 47)
 (intervals 56 205 0)
 (buffers 992 10))

[0001-Don-t-send-empty-lines-for-implicit-targets-in-ERC.patch (text/x-patch, attachment)]

Message #8 received at 50008 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "J.P." <jp <at> neverwas.me>
Cc: 50008 <at> debbugs.gnu.org, Amin Bandali <bandali <at> gnu.org>
Subject: Re: bug#50008: 28.0.50; ERC sends empty lines with user input
Date: Sun, 19 Sep 2021 09:36:39 -0700

"J.P." <jp <at> neverwas.me> writes:

> Tags: patch
>
> Hi, this one may take some seeing to believe. For proof, set up a local
> server or proxy (I can help with this) or fire up and tweak the
> behavioral tests included with these bugs [1] or ask a network oper
> friend to check their logs (they'll already know immediately if you
> mention ERC).
>
> BTW, the included unit tests may require a quick refresher on the
> relevant portions of the codebase. Happy to make a mess of explaining
> the specifics. Thanks.
>
>
> [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48598
>     https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49860

Copying in the ERC maintainer Amin Bandali here.

Amin, could you help review this patch?

Message #11 received at 50008 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "J.P." <jp <at> neverwas.me>
Cc: 50008 <at> debbugs.gnu.org, Amin Bandali <mab <at> gnu.org>
Subject: Re: bug#50008: 28.0.50; ERC sends empty lines with user input
Date: Sat, 06 Nov 2021 03:10:56 +0100

"J.P." <jp <at> neverwas.me> writes:

> Subject: [PATCH] Don't send empty lines for implicit targets in ERC

Makes sense to me, and testing it a bit doesn't seem to show any
regressions, so I've now pushed this to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #20 received at 50008 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 50008 <at> debbugs.gnu.org
Subject: [J.P.] Re: bug#50008: 28.0.50; ERC sends empty lines with user input
Date: Tue, 22 Mar 2022 01:50:41 -0700

[Message part 1 (text/plain, inline)]

Prior attempt was blocked (archived).

-------------------- Start of forwarded message --------------------
From: "J.P." <jp <at> neverwas.me>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 50008 <at> debbugs.gnu.org,  bandali <at> gnu.org, emacs-erc <at> gnu.org
Subject: Re: bug#50008: 28.0.50; ERC sends empty lines with user input
Date: Tue, 22 Mar 2022 01:37:20 -0700

[Message part 2 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> "J.P." <jp <at> neverwas.me> writes:
>
>> Subject: [PATCH] Don't send empty lines for implicit targets in ERC
>
> Makes sense to me, and testing it a bit doesn't seem to show any
> regressions, so I've now pushed this to Emacs 29.

I just noticed a regression that remained hidden all this while
because I failed to call the function realistically in its unit test.
Luckily, this only affects master.

I've attached a fix here just to have something for the record. But I
figure there's little harm in deferring and tossing it in with some
other stuff I'm preparing (in a new bug report) to try and simplify the
input processing situation. Thanks.

[0001-Fix-regression-in-erc-send-input-line.patch (text/x-patch, attachment)]

[Message part 4 (text/plain, inline)]

-------------------- End of forwarded message --------------------

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.