GNU bug report logs - #50065
[PATCH] gnu: Add setroot.

Previous Next

Package: guix-patches;

Reported by: Brice Waegeneire <brice <at> waegenei.re>

Date: Sun, 15 Aug 2021 06:47:01 UTC

Severity: normal

Tags: patch

Done: Brice Waegeneire <brice <at> waegenei.re>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50065 in the body.
You can then email your comments to 50065 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#50065; Package guix-patches. (Sun, 15 Aug 2021 06:47:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Brice Waegeneire <brice <at> waegenei.re>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 15 Aug 2021 06:47:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add setroot.
Date: Sun, 15 Aug 2021 08:46:36 +0200
* gnu/packages/xorg.scm (setroot): New variable.
---
 gnu/packages/xorg.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index 6f9633985e..505af87512 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -6925,3 +6925,36 @@ an existing user-specified one, writes a cookie to it, and then starts the
 the server and cleaning up before returning the exit status of the command.")
     (license (list license:x11                    ; the script
                    license:gpl2+))))              ; the man page
+
+(define-public setroot
+  (package
+    (name "setroot")
+    (version "2.0.2")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/ttzhou/setroot")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32 "0w95828v0splk7bj5kfacp4pq6wxpyamvyjmahyvn5hc3ycq21mq"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:make-flags
+       (list (string-append "DESTDIR=" (assoc-ref %outputs "out"))
+             "PREFIX="
+             "xinerama=1")
+       #:tests? #f                      ; no tests
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure))))
+    (inputs
+     `(("imlib2" ,imlib2)
+       ("libx11" ,libx11)
+       ("libxinerama" ,libxinerama)))
+    (home-page "https://github.com/ttzhou/setroot")
+    (synopsis "Simple X background setter inspired by imlibsetroot and feh")
+    (description "Setroot is a lightweight X background setter with feh's
+syntax without it's image viewing capabilities.  It supports multiple monitors
+and can restore previously set wallpapers and options.")
+    (license license:gpl3+)))

base-commit: e0feacfbad410ecb2f11e7ee86f18482c7413b3f
-- 
2.32.0





Information forwarded to guix-patches <at> gnu.org:
bug#50065; Package guix-patches. (Tue, 31 Aug 2021 14:05:01 GMT) Full text and rfc822 format available.

Message #8 received at 50065 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 50065 <at> debbugs.gnu.org
Subject: Re: bug#50065: [PATCH] gnu: Add setroot.
Date: Tue, 31 Aug 2021 16:04:22 +0200
Hello Brice,

> +    (source (origin

You should put origin on the next line to respect the 78 columns limit.

> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/ttzhou/setroot")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32 "0w95828v0splk7bj5kfacp4pq6wxpyamvyjmahyvn5hc3ycq21mq"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:make-flags
> +       (list (string-append "DESTDIR=" (assoc-ref %outputs "out"))
> +             "PREFIX="
> +             "xinerama=1")

The Makefile seems to hardcode CC to gcc which probably breaks
cross-compilation.

> +syntax without it's image viewing capabilities.  It supports multiple monitors
                    ^
                    its?

Thanks,

Mathieu




Information forwarded to guix-patches <at> gnu.org:
bug#50065; Package guix-patches. (Tue, 31 Aug 2021 20:08:02 GMT) Full text and rfc822 format available.

Message #11 received at 50065 <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: othacehe <at> gnu.org
Cc: 50065 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: Add setroot.
Date: Tue, 31 Aug 2021 22:06:57 +0200
* gnu/packages/xorg.scm (setroot): New variable.
---
 gnu/packages/xorg.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

Thank you for the review Mathieu.  I fixed the three issues you pointed out.

diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index 6f9633985e..cae0fb3f73 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -6925,3 +6925,38 @@ an existing user-specified one, writes a cookie to it, and then starts the
 the server and cleaning up before returning the exit status of the command.")
     (license (list license:x11                    ; the script
                    license:gpl2+))))              ; the man page
+
+(define-public setroot
+  (package
+    (name "setroot")
+    (version "2.0.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ttzhou/setroot")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0w95828v0splk7bj5kfacp4pq6wxpyamvyjmahyvn5hc3ycq21mq"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:make-flags
+       (list (string-append "CC=" ,(cc-for-target))
+             (string-append "DESTDIR=" (assoc-ref %outputs "out"))
+             "PREFIX="
+             "xinerama=1")
+       #:tests? #f                       ; no tests
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure))))
+    (inputs
+     `(("imlib2" ,imlib2)
+       ("libx11" ,libx11)
+       ("libxinerama" ,libxinerama)))
+    (home-page "https://github.com/ttzhou/setroot")
+    (synopsis "Simple X background setter inspired by imlibsetroot and feh")
+    (description "Setroot is a lightweight X background setter with feh's
+syntax without its image viewing capabilities.  It supports multiple monitors
+and can restore previously set wallpapers and options.")
+    (license license:gpl3+)))
-- 
2.33.0





Information forwarded to guix-patches <at> gnu.org:
bug#50065; Package guix-patches. (Wed, 01 Sep 2021 06:54:02 GMT) Full text and rfc822 format available.

Message #14 received at 50065 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 50065 <at> debbugs.gnu.org
Subject: Re: bug#50065: [PATCH] gnu: Add setroot.
Date: Wed, 01 Sep 2021 08:53:47 +0200
Hey Brice,

> * gnu/packages/xorg.scm (setroot): New variable.

Looks fine, feel free to proceed :).

Mathieu




Reply sent to Brice Waegeneire <brice <at> waegenei.re>:
You have taken responsibility. (Sat, 04 Sep 2021 07:34:02 GMT) Full text and rfc822 format available.

Notification sent to Brice Waegeneire <brice <at> waegenei.re>:
bug acknowledged by developer. (Sat, 04 Sep 2021 07:34:02 GMT) Full text and rfc822 format available.

Message #19 received at 50065-done <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 50065-done <at> debbugs.gnu.org
Subject: Re: bug#50065: [PATCH] gnu: Add setroot.
Date: Sat, 04 Sep 2021 09:32:54 +0200
Mathieu Othacehe <othacehe <at> gnu.org> writes:

> Looks fine, feel free to proceed :).

Pushed as 2226d5b9590840f6fdc0d5c03b14c9d050435c4e. Thank you for the review
Mathieu.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 02 Oct 2021 11:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 179 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.