GNU bug report logs - #50076
[PATCH 0/1] Add python-flask-debugtoolbar.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50076 in the body.
You can then email your comments to 50076 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: guix-patches <at> gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>
Subject: [PATCH 0/1] Add python-flask-debugtoolbar.
Date: Mon, 16 Aug 2021 12:47:22 +0300

Hi. Find attach a patch that adds python-flask-debugtoolbar to GUIX.

BonfaceKilz (1):
  gnu: Add python-flask-debugtoolbar.

 gnu/packages/python-web.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

-- 
2.31.1

Message #8 received at 50076 <at> debbugs.gnu.org (full text, mbox):

From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: 50076 <at> debbugs.gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>
Subject: [PATCH 1/1] gnu: Add python-flask-debugtoolbar.
Date: Mon, 16 Aug 2021 12:50:59 +0300

* gnu/packages/python-web.scm (python-flask-debugtoolbar): New variable.
---
 gnu/packages/python-web.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 32b4aa4bf0..c8f0ab3940 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -3005,6 +3005,32 @@ and Jinja2 template engine.  It is called a micro framework because it does not
 presume or force a developer to use a particular tool or library.")
     (license license:bsd-3)))
 
+(define-public python-flask-debugtoolbar
+  (package
+  (name "python-flask-debugtoolbar")
+  (version "0.11.0")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (pypi-uri "Flask-DebugToolbar" version))
+      (sha256
+        (base32
+          "1d5asdnk8bmh6m46pzg3i7677cjgdm9mlm3wcpk19q7dak9pjkiw"))))
+  (build-system python-build-system)
+  (propagated-inputs
+    `(("python-blinker" ,python-blinker)
+      ("python-flask" ,python-flask)
+      ("python-itsdangerous" ,python-itsdangerous)
+      ("python-werkzeug" ,python-werkzeug)))
+  (home-page
+   "https://flask-debugtoolbar.readthedocs.io/")
+  (synopsis
+    "A toolbar overlay for debugging Flask applications.")
+  (description
+    "This extension adds a toolbar overlay to Flask applications containing
+useful information for debugging.")
+  (license license:bsd-3)))
+
 (define-public python-flask-wtf
   (package
     (name "python-flask-wtf")
-- 
2.31.1

Message #11 received at 50076 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: BonfaceKilz <me <at> bonfacemunyoki.com>
Cc: 50076 <at> debbugs.gnu.org
Subject: Re: [bug#50076] [PATCH 1/1] gnu: Add python-flask-debugtoolbar.
Date: Tue, 24 Aug 2021 02:23:03 +0530

[Message part 1 (text/plain, inline)]

Hi Bonface,

Thanks for contributing! :-) Some feedback follows.

1. Please add a copyright header.
2. Could you try packaging the tests? I think tests use
pytest. Currently, no tests are run during the check phase.

> +  (synopsis
> +    "A toolbar overlay for debugging Flask applications.")

3. Could you remove the article "A" at the beginning, and the period at
the end? Quoting from our manual at "(guix) Synopses and Descriptions":

--8<---------------cut here---------------start------------->8---
   Synopses must start with a capital letter and must not end with a
period.  They must not start with “a” or “the”, which usually does not
bring anything; for instance, prefer “File-frobbing tool” over “A tool
that frobs files”.
--8<---------------cut here---------------end--------------->8---

> +  (description
> +    "This extension adds a toolbar overlay to Flask applications containing
> +useful information for debugging.")

4. Finally, a nitpick: It would be more consistent with the rest of Guix
if the synopsis and description started on the same line instead of on
the next. So, something like this:

--8<---------------cut here---------------start------------->8---
    (description "This extension adds a toolbar overlay to Flask applications
containing useful information for debugging.")
--8<---------------cut here---------------end--------------->8---

Thanks!
Arun

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 50076 <at> debbugs.gnu.org (full text, mbox):

From: Bonface Munyoki K. <me <at> bonfacemunyoki.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 50076 <at> debbugs.gnu.org
Subject: Re: [bug#50076] [PATCH 1/1] gnu: Add python-flask-debugtoolbar.
Date: Fri, 27 Aug 2021 14:14:12 +0300

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> anaandika:

> Hi Bonface,
>
> Thanks for contributing! :-) Some feedback follows.
>
> 1. Please add a copyright header.

Cool. Thanks for the gentle reminder.

> 2. Could you try packaging the tests? I think tests use
> pytest. Currently, no tests are run during the check phase.
>

Cool. I'll try to work out how to do that.

>> +  (synopsis
>> +    "A toolbar overlay for debugging Flask applications.")
>
> 3. Could you remove the article "A" at the beginning, and the period at
> the end? Quoting from our manual at "(guix) Synopses and Descriptions":
>
>    Synopses must start with a capital letter and must not end with a
> period.  They must not start with “a” or “the”, which usually does not
> bring anything; for instance, prefer “File-frobbing tool” over “A tool
> that frobs files”.
>
>
>> +  (description
>> +    "This extension adds a toolbar overlay to Flask applications containing
>> +useful information for debugging.")
>
> 4. Finally, a nitpick: It would be more consistent with the rest of Guix
> if the synopsis and description started on the same line instead of on
> the next. So, something like this:
>
>     (description "This extension adds a toolbar overlay to Flask applications
> containing useful information for debugging.")
>

Much thanks for the above suggestions! I'll work
on this and submit a revised patch over the
weekend.

-- 
Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 50076 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Bonface M. K." <bonfacemunyoki <at> gmail.com>, 50076 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: Re: [PATCH 0/1] Add python-flask-debugtoolbar.
Date: Fri, 19 May 2023 04:50:33 +0000

Hi Bonz,

Are you still interested in picking this issue up again?

The only problem I see with this package is that it vendors 63 javascript files including dependencies like jquery.

Hi Arun, is this a non issue for upstream guix or what should we do here?

What is our current policy regarding jquery?

all best,

jgart

Message #20 received at 50076 <at> debbugs.gnu.org (full text, mbox):

From: Munyoki Kilyungi <bonfacemunyoki <at> gmail.com>
To: jgart <jgart <at> dismail.de>, 50076 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: Re: [PATCH 0/1] Add python-flask-debugtoolbar.
Date: Mon, 22 May 2023 10:28:15 +0300

[Message part 1 (text/plain, inline)]

"jgart" <jgart <at> dismail.de> aliandika:

> Hi Bonz,
>
> Are you still interested in picking this issue up again?
>
Sure no problem.  I'll try looking at this later
tonight (EAT).  Thanks for the follow-up.

> The only problem I see with this package is that it vendors 63 javascript files including dependencies like jquery.
>
> Hi Arun, is this a non issue for upstream guix or what should we do here?
>
> What is our current policy regarding jquery?
>
> all best,
>
> jgart

-- 
(Life is like a pencil that will surely run out,
    but will leave the beautiful writing of life.)
(D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
    (hkp://keys.openpgp.org))

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 50076 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: jgart <jgart <at> dismail.de>, "Bonface M. K." <bonfacemunyoki <at> gmail.com>,
 50076 <at> debbugs.gnu.org
Subject: Re: [PATCH 0/1] Add python-flask-debugtoolbar.
Date: Wed, 24 May 2023 19:07:24 +0100

> The only problem I see with this package is that it vendors 63
> javascript files including dependencies like jquery.
>
> Hi Arun, is this a non issue for upstream guix or what should we do
> here?

As long as these javascript files are actual source and are not minified
source, this should be fine. Minified source is considered to be a
binary. This is the precedent set in packages such as js-mathjax.

Message #26 received at 50076 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 50076 <at> debbugs.gnu.org
Cc: "Bonface Munyoki K." <me <at> bonfacemunyoki.com>,
 Arun Isaac <arunisaac <at> systemreboot.net>, jgart <jgart <at> dismail.de>,
 Munyoki Kilyungi <bonfacemunyoki <at> gmail.com>
Subject: Re: [PATCH 0/1] Add python-flask-debugtoolbar.
Date: Sat, 29 Jun 2024 01:55:29 -0500

Hi all,

This issue is pretty stale by now. Does anyone want to still work on
it?

If not, I recommend for us to close it and reopen when actively working
on it.

WDYT?

all the best,

jgart

Message #31 received at 50076-done <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 50076-done <at> debbugs.gnu.org
Cc: "Bonface Munyoki K." <me <at> bonfacemunyoki.com>,
 Arun Isaac <arunisaac <at> systemreboot.net>, jgart <jgart <at> dismail.de>,
 Munyoki Kilyungi <bonfacemunyoki <at> gmail.com>
Subject: Re: [PATCH 0/1] Add python-flask-debugtoolbar.
Date: Wed, 01 Jan 2025 20:13:57 -0600

> This issue is pretty stale by now. Does anyone want to still work on
> it?
> 
> If not, I recommend for us to close it and reopen when actively working
> on it.

Hi, closing this ticket. Feel free to reopen if you'd like to continue
working on it.
-- 
all the best,
jgart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.