GNU bug report logs - #50104
28.0.50; 'M-o' is bound in diff-mode-map

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50104 in the body.
You can then email your comments to 50104 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Augusto Stoffel <arstoffel <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; 'M-o' is bound in diff-mode-map
Date: Wed, 18 Aug 2021 10:51:24 +0200

'M-o' is bound to 'diff-goto-source' in 'diff-mode-map'.  I guess this
binding should be removed, to be in line with the freeing up of 'M-o'
elsewhere.  Otherwise, a global binding to 'M-o' is overridden in diff
buffers.

Note also that there are several other bindings for that command in diff
buffers: 'RET', 'C-c C-c', etc.

(While we're at this, I'll express my opinion that, apart from leaving
'M-o' reserved for the user to customize, 'other-window' would the only
sensible use for that key.)

Message #8 received at 50104 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Augusto Stoffel <arstoffel <at> gmail.com>
Cc: 50104 <at> debbugs.gnu.org
Subject: Re: bug#50104: 28.0.50; 'M-o' is bound in diff-mode-map
Date: Wed, 18 Aug 2021 19:25:43 +0300

> 'M-o' is bound to 'diff-goto-source' in 'diff-mode-map'.  I guess this
> binding should be removed, to be in line with the freeing up of 'M-o'
> elsewhere.  Otherwise, a global binding to 'M-o' is overridden in diff
> buffers.

The standard key to display a buffer in another window is 'C-o', not 'M-o',
like is used in list-buffers, dired, compilation, grep, occur, etc.,
so maybe diff-mode should use the same.

> Note also that there are several other bindings for that command in diff
> buffers: 'RET', 'C-c C-c', etc.
>
> (While we're at this, I'll express my opinion that, apart from leaving
> 'M-o' reserved for the user to customize, 'other-window' would the only
> sensible use for that key.)

For the long time, the bigger problem was to get rid of remaining 'M-s'
keybindings.  For example, it's impossible to use word search 'M-s M-w'
in log-edit buffers (where 'M-s' is bound to log-edit-comment-search-forward)
and in some other modes.

Message #11 received at 50104 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: Augusto Stoffel <arstoffel <at> gmail.com>, 50104 <at> debbugs.gnu.org
Subject: Re: bug#50104: 28.0.50; 'M-o' is bound in diff-mode-map
Date: Wed, 18 Aug 2021 21:56:26 +0200

On Aug 18 2021, Juri Linkov wrote:

> The standard key to display a buffer in another window is 'C-o', not 'M-o',
> like is used in list-buffers, dired, compilation, grep, occur, etc.,
> so maybe diff-mode should use the same.

diff-mode is for editible buffers, so it should not override C-o.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Message #14 received at 50104 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: 50104 <at> debbugs.gnu.org, Augusto Stoffel <arstoffel <at> gmail.com>,
 Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#50104: 28.0.50; 'M-o' is bound in diff-mode-map
Date: Thu, 19 Aug 2021 18:28:47 +0200

Andreas Schwab <schwab <at> linux-m68k.org> writes:

>> The standard key to display a buffer in another window is 'C-o', not 'M-o',
>> like is used in list-buffers, dired, compilation, grep, occur, etc.,
>> so maybe diff-mode should use the same.
>
> diff-mode is for editible buffers, so it should not override C-o.

Yup.

I grepped through Emacs to see whether other modes also define `M-o'...
and there's a handful that do.  I think it would be pretty annoying to
change these bindings (for users), so I think we should just leave
them as is, even though that means that any new global bindings for
`M-o' are shadowed in those buffers.

I don't think we've guaranteed anything about not using `M-o' for
anything in-tree.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 50104 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: Juri Linkov <juri <at> linkov.net>, Augusto Stoffel <arstoffel <at> gmail.com>,
 50104 <at> debbugs.gnu.org
Subject: Re: bug#50104: 28.0.50; 'M-o' is bound in diff-mode-map
Date: Wed, 25 Aug 2021 17:38:23 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I grepped through Emacs to see whether other modes also define `M-o'...
> and there's a handful that do.  I think it would be pretty annoying to
> change these bindings (for users), so I think we should just leave
> them as is, even though that means that any new global bindings for
> `M-o' are shadowed in those buffers.
>
> I don't think we've guaranteed anything about not using `M-o' for
> anything in-tree.

So I think the conclusion here is that we're not going to change these
`M-o' bindings, and I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.