GNU bug report logs - #50117
[PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50117 in the body.
You can then email your comments to 50117 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: guix-patches <at> gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>, arunisaac <at> systemreboot.net,
 iskarian <at> mgsn.dev
Subject: [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates
Date: Thu, 19 Aug 2021 10:17:09 +0300

Hi all. Find attached the updated package definition of csv diff which addresses the following issues that were kindly pointed out by Sarah:

--8<---------------cut here---------------start------------->8---
Typically end-user Go packages will want inputs/native-inputs rather
than propagated inputs unless the input provides a binary used at
runtime, so user profiles are not cluttered (go-build-system needs
source from all transitive dependencies).  Also, a more friendly name
("csvdiff" is available) might be better for end-user packages like
this.
--8<---------------cut here---------------end--------------->8---


BonfaceKilz (2):
  gnu: go-github-com-aswinkarthik-csvdiff: Rename name to "csvdiff".
  gnu: go-github-com-aswinkarthik-csvdiff: Make inputs native.

 gnu/packages/golang.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.31.1

Message #8 received at 50117 <at> debbugs.gnu.org (full text, mbox):

From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: 50117 <at> debbugs.gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>, arunisaac <at> systemreboot.net,
 iskarian <at> mgsn.dev
Subject: [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates
Date: Thu, 19 Aug 2021 10:21:54 +0300

Hi all. Find attached the updated package definition of csv diff which addresses the following issues that were kindly pointed out by Sarah:

--8<---------------cut here---------------start------------->8---
Typically end-user Go packages will want inputs/native-inputs rather
than propagated inputs unless the input provides a binary used at
runtime, so user profiles are not cluttered (go-build-system needs
source from all transitive dependencies).  Also, a more friendly name
("csvdiff" is available) might be better for end-user packages like
this.
--8<---------------cut here---------------end--------------->8---


BonfaceKilz (2):
  gnu: go-github-com-aswinkarthik-csvdiff: Rename name to "csvdiff".
  gnu: go-github-com-aswinkarthik-csvdiff: Make inputs native.

 gnu/packages/golang.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.31.1

Message #11 received at 50117 <at> debbugs.gnu.org (full text, mbox):

From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: 50117 <at> debbugs.gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>, arunisaac <at> systemreboot.net,
 iskarian <at> mgsn.dev
Subject: [PATCH 1/2] gnu: go-github-com-aswinkarthik-csvdiff: Rename name to
 "csvdiff".
Date: Thu, 19 Aug 2021 10:21:55 +0300

* gnu/packages/golang.scm (go-github-com-aswinkarthik-csvdiff)[name]: Rename
to "csvdiff" which is more user-friendly.
---
 gnu/packages/golang.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 72579d6bd2..8a8830a6f6 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8424,7 +8424,7 @@ non-cryptographic hash algorithm, working at speeds close to RAM limits.")
 
 (define-public go-github-com-aswinkarthik-csvdiff
   (package
-    (name "go-github-com-aswinkarthik-csvdiff")
+    (name "csvdiff")
     (version "1.4.0")
     (source
       (origin
-- 
2.31.1

Message #14 received at 50117 <at> debbugs.gnu.org (full text, mbox):

From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: 50117 <at> debbugs.gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>, arunisaac <at> systemreboot.net,
 iskarian <at> mgsn.dev
Subject: [PATCH 2/2] gnu: go-github-com-aswinkarthik-csvdiff: Make inputs
 native.
Date: Thu, 19 Aug 2021 10:21:56 +0300

* gnu/packages/golang.scm (go-github-com-aswinkarthik-csvdiff)
[propagated-inputs]: Make these inputs native. Typically end-user Go packages
will want inputs/native-inputs rather than propagated inputs unless the input
provides a binary used at runtime, so user profiles are not
cluttered (go-build-system needs source from all transitive dependencies).
---
 gnu/packages/golang.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 8a8830a6f6..7b151a03e3 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8439,7 +8439,7 @@ non-cryptographic hash algorithm, working at speeds close to RAM limits.")
     (build-system go-build-system)
     (arguments
      '(#:import-path "github.com/aswinkarthik/csvdiff"))
-    (propagated-inputs
+    (native-inputs
      `(("go-golang-org-x-sys" ,go-golang-org-x-sys)
        ("go-github-com-stretchr-testify" ,go-github-com-stretchr-testify)
        ("go-github-com-spf13-cobra" ,go-github-com-spf13-cobra)
-- 
2.31.1

Message #17 received at 50117 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: BonfaceKilz <me <at> bonfacemunyoki.com>, 50117 <at> debbugs.gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>, iskarian <at> mgsn.dev
Subject: Re: [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates
Date: Fri, 20 Aug 2021 01:17:39 +0530

[Message part 1 (text/plain, inline)]

Hi Bonface,

Thanks for the patches! Some feedback follows.

1. I think we can combine the two commits into one since this is
logically just a single change.

2. We should retain the old package as a deprecated package. We should
add something like the snippet below.

--8<---------------cut here---------------start------------->8---
(define-public go-github-com-aswinkarthik-csvdiff
  (deprecated-package "go-github-com-aswinkarthik-csvdiff" csvdiff))
--8<---------------cut here---------------end--------------->8---

>  (define-public go-github-com-aswinkarthik-csvdiff

3. We should rename the variable name as well.

>    (package
> -    (name "go-github-com-aswinkarthik-csvdiff")
> +    (name "csvdiff")

3. We should also move the package to some file other than
golang.scm. How about textutils.scm?

Thank you for your patience! :-)
Arun

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 50117 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: BonfaceKilz <me <at> bonfacemunyoki.com>, 50117 <at> debbugs.gnu.org
Cc: iskarian <at> mgsn.dev
Subject: Re: [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff
 package updates
Date: Thu, 09 Dec 2021 16:05:36 +0530

[Message part 1 (text/plain, inline)]

Hi Bonface,

Any progress on this? Just a gentle ping.

Thanks,
Arun

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 50117 <at> debbugs.gnu.org (full text, mbox):

From: Bonface M. K <me <at> bonfacemunyoki.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>, 50117 <at> debbugs.gnu.org
Cc: iskarian <at> mgsn.dev
Subject: Re: [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff
 package updates
Date: Thu, 09 Dec 2021 17:02:01 +0300

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> anaandika:

> Hi Bonface,
>
> Any progress on this? Just a gentle ping.
>
> Thanks,
> Arun

Hi!  Lemme have a look at this once my classes are
done.  Somehow this got lost in my To-Do tasks!
Thanks for the reminder.

-- 
Bonface M. K.
D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.gnupg.net)
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 50117 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: "Bonface M. K" <me <at> bonfacemunyoki.com>, 50117 <at> debbugs.gnu.org
Cc: iskarian <at> mgsn.dev
Subject: Re: [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff
 package updates
Date: Fri, 10 Dec 2021 09:00:19 +0530

[Message part 1 (text/plain, inline)]

> Hi!  Lemme have a look at this once my classes are done.  Somehow this
> got lost in my To-Do tasks!  Thanks for the reminder.

Sure, Bonface, thanks!

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 50117 <at> debbugs.gnu.org (full text, mbox):

From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: 50117 <at> debbugs.gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>, arunisaac <at> systemreboot.net
Subject: [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates
Date: Fri, 10 Dec 2021 14:17:51 +0300

Hi all!  Find below updated patches from a review from a while back.  @Arun, I
have moved csvdiff to textutils(it makes more semantic sense).  I see no need
of defining it as a deprecated-package since there's no package dependent on
it ATM.  Let me know if I need to change anything.  Thanks for being patient
with this!

BonfaceKilz (1):
  gnu: Move csvdiff to (gnu packages textutils).

 gnu/packages/golang.scm    | 44 ------------------------------------
 gnu/packages/textutils.scm | 46 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 44 deletions(-)

-- 
2.31.1

Message #32 received at 50117 <at> debbugs.gnu.org (full text, mbox):

From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: 50117 <at> debbugs.gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>, arunisaac <at> systemreboot.net
Subject: [PATCH 1/1] gnu: Move csvdiff to (gnu packages textutils).
Date: Fri, 10 Dec 2021 14:17:52 +0300

See <http://issues.guix.gnu.org/50117>.

* gnu/packages/golang.scm (go-github-com-aswinkarthik-csvdiff): Move from here
* gnu/packages/textutils (go-github-com-aswinkarthik-csvdiff): to here.
---
 gnu/packages/golang.scm    | 44 ------------------------------------
 gnu/packages/textutils.scm | 46 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 44 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index d555a92579..49c124a415 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8788,50 +8788,6 @@ zero round-trip encryption, and other advanced features.")
 non-cryptographic hash algorithm, working at speeds close to RAM limits.")
     (license license:asl2.0)))
 
-(define-public go-github-com-aswinkarthik-csvdiff
-  (package
-    (name "go-github-com-aswinkarthik-csvdiff")
-    (version "1.4.0")
-    (source
-      (origin
-        (method git-fetch)
-        (uri (git-reference
-               (url "https://github.com/aswinkarthik/csvdiff")
-               (commit (string-append "v" version))))
-        (file-name (git-file-name name version))
-        (sha256
-         (base32
-          "0cd1ikxsypjqisfnmr7zix3g7x8p892w77086465chyd39gpk97b"))))
-    (build-system go-build-system)
-    (arguments
-     '(#:import-path "github.com/aswinkarthik/csvdiff"))
-    (propagated-inputs
-     `(("go-golang-org-x-sys" ,go-golang-org-x-sys)
-       ("go-github-com-stretchr-testify" ,go-github-com-stretchr-testify)
-       ("go-github-com-spf13-cobra" ,go-github-com-spf13-cobra)
-       ("go-github-com-spf13-afero" ,go-github-com-spf13-afero)
-       ("go-github-com-spaolacci-murmur3" ,go-github-com-spaolacci-murmur3)
-       ("go-github-com-mattn-go-colorable" ,go-github-com-mattn-go-colorable)
-       ("go-github-com-fatih-color" ,go-github-com-fatih-color)
-       ("go-github-com-cespare-xxhash" ,go-github-com-cespare-xxhash)
-       ("go-github-com-oneofone-xxhash" ,go-github-com-oneofone-xxhash)))
-    (home-page "https://github.com/aswinkarthik/csvdiff")
-    (synopsis "Fast diff tool for comparing CSV files")
-    (description "@code{csvdiff} is a diff tool to compute changes between two
-CSV files.  It can compare CSV files with a million records in under 2
-seconds.  It is specifically suited for comparing CSV files dumped from
-database tables.  GNU Diff is orders of magnitude faster for comparing line by
-line.  @code{csvdiff} supports
-
-@itemize
-@item Selective comparison of fields in a row
-@item Specifying group of columns as primary-key to uniquely identify a row
-@item Ignoring columns
-@item Several output formats including colored git style output or
-JSON for post-processing
-@end itemize")
-    (license license:expat)))
-
 (define-public go-gopkg-in-djherbis-times-v1
   (package
     (name "go-gopkg-in-djherbis-times-v1")
diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm
index 7e7293ac16..9a8b9ae1e8 100644
--- a/gnu/packages/textutils.scm
+++ b/gnu/packages/textutils.scm
@@ -22,6 +22,7 @@
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2021 Jean-Baptiste Volatier <jbv <at> pm.me>
 ;;; Copyright © 2021 Simon Tournier <zimon.toutoune <at> gmail.com>
+;;; Copyright © 2021 Bonface Munyoki Kilyungi <me <at> bonfacemunyoki.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -64,6 +65,7 @@
   #:use-module (gnu packages python)
   #:use-module (gnu packages python-build)
   #:use-module (gnu packages python-xyz)
+  #:use-module (gnu packages syncthing)
   #:use-module (gnu packages readline)
   #:use-module (gnu packages ruby)
   #:use-module (gnu packages slang)
@@ -1347,3 +1349,47 @@ languages such as HTML, Markdown, Asciidoc, and reStructuredText.  The community
 around it also has a list of style guides implemented with Vale in
 @url{https://github.com/errata-ai/styles, their styles repo}.")
     (license license:expat)))
+
+(define-public go-github-com-aswinkarthik-csvdiff
+  (package
+    (name "csvdiff")
+    (version "1.4.0")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/aswinkarthik/csvdiff")
+               (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+         (base32
+          "0cd1ikxsypjqisfnmr7zix3g7x8p892w77086465chyd39gpk97b"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/aswinkarthik/csvdiff"))
+    (propagated-inputs
+     `(("go-golang-org-x-sys" ,go-golang-org-x-sys)
+       ("go-github-com-stretchr-testify" ,go-github-com-stretchr-testify)
+       ("go-github-com-spf13-cobra" ,go-github-com-spf13-cobra)
+       ("go-github-com-spf13-afero" ,go-github-com-spf13-afero)
+       ("go-github-com-spaolacci-murmur3" ,go-github-com-spaolacci-murmur3)
+       ("go-github-com-mattn-go-colorable" ,go-github-com-mattn-go-colorable)
+       ("go-github-com-fatih-color" ,go-github-com-fatih-color)
+       ("go-github-com-cespare-xxhash" ,go-github-com-cespare-xxhash)
+       ("go-github-com-oneofone-xxhash" ,go-github-com-oneofone-xxhash)))
+    (home-page "https://github.com/aswinkarthik/csvdiff")
+    (synopsis "Fast diff tool for comparing CSV files")
+    (description "@code{csvdiff} is a diff tool to compute changes between two
+CSV files.  It can compare CSV files with a million records in under 2
+seconds.  It is specifically suited for comparing CSV files dumped from
+database tables.  GNU Diff is orders of magnitude faster for comparing line by
+line.  @code{csvdiff} supports
+
+@itemize
+@item Selective comparison of fields in a row
+@item Specifying group of columns as primary-key to uniquely identify a row
+@item Ignoring columns
+@item Several output formats including colored git style output or
+JSON for post-processing
+@end itemize")
+    (license license:expat)))
-- 
2.31.1

Message #35 received at 50117 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: BonfaceKilz <me <at> bonfacemunyoki.com>
Cc: 50117 <at> debbugs.gnu.org
Subject: Re: [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates
Date: Mon, 13 Dec 2021 11:38:01 +0530

[Message part 1 (text/plain, inline)]

Hi Bonface,

> Hi all!  Find below updated patches from a review from a while back.  @Arun, I
> have moved csvdiff to textutils(it makes more semantic sense).

Sounds good.

> I see no need of defining it as a deprecated-package since there's no
> package dependent on it ATM.

Users might have installed csvdiff into their profiles. So, I think we
still need to define a deprecated-package. Could you send an updated
patchset?

Thanks!
Arun

[signature.asc (application/pgp-signature, inline)]

Message #38 received at 50117 <at> debbugs.gnu.org (full text, mbox):

From: Bonface M. K <me <at> bonfacemunyoki.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 50117 <at> debbugs.gnu.org
Subject: Re: [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates
Date: Mon, 13 Dec 2021 09:50:01 +0300

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> anaandika:

> Hi Bonface,
>
>> Hi all!  Find below updated patches from a review from a while back.  @Arun, I
>> have moved csvdiff to textutils(it makes more semantic sense).
>
> Sounds good.
>
>> I see no need of defining it as a deprecated-package since there's no
>> package dependent on it ATM.
>
> Users might have installed csvdiff into their profiles. So, I think we
> still need to define a deprecated-package. Could you send an updated
> patchset?
>

Sure.  Let me do that later during the day...

> Thanks!
> Arun

-- 
Bonface M. K.
D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.gnupg.net)
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz

[signature.asc (application/pgp-signature, inline)]

Message #41 received at 50117 <at> debbugs.gnu.org (full text, mbox):

From: Bonface M. K <me <at> bonfacemunyoki.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 50117 <at> debbugs.gnu.org
Subject: Re: [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates
Date: Mon, 13 Dec 2021 23:51:33 +0300

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> anaandika:

> Hi Bonface,
>
>> Hi all!  Find below updated patches from a review from a while back.  @Arun, I
>> have moved csvdiff to textutils(it makes more semantic sense).
>
> Sounds good.
>
>> I see no need of defining it as a deprecated-package since there's no
>> package dependent on it ATM.
>
> Users might have installed csvdiff into their profiles. So, I think we
> still need to define a deprecated-package. Could you send an updated
> patchset?

Yup.  This makes sense.  Find attached a new patch
that adds an alias for the deprecated package.
Let me know if this is okay :)

[0001-gnu-Move-csvdiff-to-gnu-packages-textutils.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Bonface M. K.
D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.gnupg.net)
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz

[signature.asc (application/pgp-signature, inline)]

Message #46 received at 50117-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: "Bonface M. K" <me <at> bonfacemunyoki.com>
Cc: 50117-done <at> debbugs.gnu.org
Subject: Re: [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates
Date: Mon, 20 Dec 2021 11:05:19 +0530

[Message part 1 (text/plain, inline)]

Hi Bonface,

I have applied the patch on master with a few changes. Most
significantly, I moved the deprecated alias from
gnu/packages/textutils.scm to gnu/packages/golang.scm since golang.scm
is where the original package was.

Thanks,
Arun

[signature.asc (application/pgp-signature, inline)]

Message #49 received at 50117-done <at> debbugs.gnu.org (full text, mbox):

From: Bonface M. K <me <at> bonfacemunyoki.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 50117-done <at> debbugs.gnu.org
Subject: Re: [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates
Date: Tue, 21 Dec 2021 15:29:12 +0300

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> anaandika:

> Hi Bonface,
>
> I have applied the patch on master with a few changes. Most
> significantly, I moved the deprecated alias from
> gnu/packages/textutils.scm to gnu/packages/golang.scm since golang.scm
> is where the original package was.

Thanks!

-- 
Bonface M. K.
D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.gnupg.net)
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.