GNU bug report logs - #50160
28.0.50; Wrong NSToolbarItem identifier

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50160 in the body.
You can then email your comments to 50160 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: tsuucat <tsuucat <at> icloud.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Wrong NSToolbarItem identifier
Date: Sun, 22 Aug 2021 11:32:05 +0900

Emacs version: 28.0.50
window system: ns

EmacsToolbar now uses [img hash] as NSToolbarItem’s identifier
(see addDisplayItemWithImage in src/nsmenu.m).

This is not good because this causes conflict.
For example, “close” icon is used as `kill-this-buffer' by default but
isearch-tool-bar-map uses “close” icon as `isearch-cancel’.
addDisplayItemWithImage reuses NSToolbarItem which has same 
identifier so when in isearch “close” icon on toolbar doesn’t work.

I’m not a Objective-C expert so I don’t know what value should be set
as correct identifier... 🙇

--
tsuucat

Message #8 received at 50160 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: tsuucat <tsuucat <at> icloud.com>
Cc: 50160 <at> debbugs.gnu.org
Subject: Re: bug#50160: 28.0.50; Wrong NSToolbarItem identifier
Date: Sun, 22 Aug 2021 21:09:35 +0100

On Sun, Aug 22, 2021 at 11:32:05AM +0900, tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote:
> Emacs version: 28.0.50
> window system: ns
> 
> EmacsToolbar now uses [img hash] as NSToolbarItem’s identifier
> (see addDisplayItemWithImage in src/nsmenu.m).
> 
> This is not good because this causes conflict.
> For example, “close” icon is used as `kill-this-buffer' by default but
> isearch-tool-bar-map uses “close” icon as `isearch-cancel’.
> addDisplayItemWithImage reuses NSToolbarItem which has same 
> identifier so when in isearch “close” icon on toolbar doesn’t work.

Ah, hmm... Perhaps we should append the label text to the hash or
something?

-- 
Alan Third

Message #11 received at 50160 <at> debbugs.gnu.org (full text, mbox):

From: tsuucat <tsuucat <at> icloud.com>
To: Alan Third <alan <at> idiocy.org>
Cc: 50160 <at> debbugs.gnu.org
Subject: Re: bug#50160: 28.0.50; Wrong NSToolbarItem identifier
Date: Fri, 10 Sep 2021 02:33:40 +0900

> Ah, hmm... Perhaps we should append the label text to the hash or
> something?

I tried to append the label text to the hash. Most items fixed. But 
isearch.el uses “undo” icon and “Undo” label for isearch-delete-char item
so the tool-tip is wrong…
It is hard to set correct identifier because anyone can create toolbar items 
dynamically in Emacs lisp.

I noticed the current toolbaritem problem only matters label and tool-tip.
Executed commands are not wrong.

--
tsuucat

Message #14 received at 50160 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: tsuucat <tsuucat <at> icloud.com>
Cc: 50160 <at> debbugs.gnu.org
Subject: Re: bug#50160: 28.0.50; Wrong NSToolbarItem identifier
Date: Thu, 9 Sep 2021 21:59:28 +0100

On Fri, Sep 10, 2021 at 02:33:40AM +0900, tsuucat wrote:
> 
> > Ah, hmm... Perhaps we should append the label text to the hash or
> > something?
> 
> I tried to append the label text to the hash. Most items fixed. But 
> isearch.el uses “undo” icon and “Undo” label for isearch-delete-char item
> so the tool-tip is wrong…
> It is hard to set correct identifier because anyone can create toolbar items 
> dynamically in Emacs lisp.
> 
> I noticed the current toolbaritem problem only matters label and tool-tip.
> Executed commands are not wrong.

I suppose we could concatenate the hashes of all the values that might
matter.

Alternatively maybe we just don't cache the toolbar items? I don't
know if that's worth investigating. My experience with some other
areas of the NS port is that there's a lot of caching and things going
on that doesn't seem to actually save us anything, but the toolbar can
be refreshed very often in the right circumstances, so it may be best
to keep the cache.
-- 
Alan Third

Message #17 received at 50160 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: tsuucat <tsuucat <at> icloud.com>, 50160 <at> debbugs.gnu.org
Subject: Re: bug#50160: 28.0.50; Wrong NSToolbarItem identifier
Date: Wed, 22 Dec 2021 20:50:42 +0000

On Thu, Sep 09, 2021 at 09:59:28PM +0100, Alan Third wrote:
> On Fri, Sep 10, 2021 at 02:33:40AM +0900, tsuucat wrote:
> > 
> > > Ah, hmm... Perhaps we should append the label text to the hash or
> > > something?
> > 
> > I tried to append the label text to the hash. Most items fixed. But 
> > isearch.el uses “undo” icon and “Undo” label for isearch-delete-char item
> > so the tool-tip is wrong…
> > It is hard to set correct identifier because anyone can create toolbar items 
> > dynamically in Emacs lisp.
> > 
> > I noticed the current toolbaritem problem only matters label and tool-tip.
> > Executed commands are not wrong.
> 
> I suppose we could concatenate the hashes of all the values that might
> matter.

I've pushed a change to master that (I hope) does this.
-- 
Alan Third

Message #20 received at 50160 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Alan Third <alan <at> idiocy.org>
Cc: 50160 <at> debbugs.gnu.org, tsuucat <tsuucat <at> icloud.com>
Subject: Re: bug#50160: 28.0.50; Wrong NSToolbarItem identifier
Date: Mon, 22 Aug 2022 15:54:41 +0200

Alan Third <alan <at> idiocy.org> writes:

> I've pushed a change to master that (I hope) does this.

This was half a year ago, but the bug report was left open, so I'm
closing it now.

If Alan's change didn't fix the problem, please respond to the debbugs
address and we'll reopen.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.