GNU bug report logs - #50194
28.0.50; tabulated-list-print (with non-nil UPDATE argument) doesn't clean up excess entries

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50194 in the body.
You can then email your comments to 50194 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Shitikanth <shitikanth1 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; tabulated-list-print (with non-nil UPDATE argument) doesn't
 clean up excess entries
Date: Wed, 25 Aug 2021 00:25:00 +0530

(tabulated-list-print nil t) does not seem to clean up excess remaining
entries/lines if the number of tabulated-list-entries has decreased.

Demo:
    (defun demo-generate-entries (n)
        (mapcar (lambda (i)
                  (list i (vector (format "title %s" i))))
                (number-sequence 1 n)))

    (let ((buf (get-buffer-create "*demo*")))
      (with-current-buffer buf
        (tabulated-list-mode)
        (setq tabulated-list-format '[("title" 70 t)])
        (setq tabulated-list-sort-key '("title"))
        (setq tabulated-list-entries (demo-generate-entries 8))
        (tabulated-list-print)
        (pop-to-buffer buf)
        (setq tabulated-list-entries (demo-generate-entries 4))
        (tabulated-list-print nil t)
        ))

Expected behaviour:
At the end, *demo* buffer should show only 4 entries.

Observed behaviour:
*demo* buffer still holds 8 entries, still showing 4 entries that are
now removed from tabulated-list-entries.

Message #8 received at 50194 <at> debbugs.gnu.org (full text, mbox):

From: Shitikanth <shitikanth1 <at> gmail.com>
To: 50194 <at> debbugs.gnu.org
Subject: Re: bug#50194: 28.0.50; tabulated-list-print (with non-nil UPDATE
 argument) doesn't clean up excess entries
Date: Wed, 25 Aug 2021 00:43:11 +0530

[Message part 1 (text/plain, inline)]

Proposed fix.

On Wed, 25 Aug 2021 at 00:26, Shitikanth <shitikanth1 <at> gmail.com> wrote:
>
> (tabulated-list-print nil t) does not seem to clean up excess remaining
> entries/lines if the number of tabulated-list-entries has decreased.
>
> Demo:
>     (defun demo-generate-entries (n)
>         (mapcar (lambda (i)
>                   (list i (vector (format "title %s" i))))
>                 (number-sequence 1 n)))
>
>     (let ((buf (get-buffer-create "*demo*")))
>       (with-current-buffer buf
>         (tabulated-list-mode)
>         (setq tabulated-list-format '[("title" 70 t)])
>         (setq tabulated-list-sort-key '("title"))
>         (setq tabulated-list-entries (demo-generate-entries 8))
>         (tabulated-list-print)
>         (pop-to-buffer buf)
>         (setq tabulated-list-entries (demo-generate-entries 4))
>         (tabulated-list-print nil t)
>         ))
>
> Expected behaviour:
> At the end, *demo* buffer should show only 4 entries.
>
> Observed behaviour:
> *demo* buffer still holds 8 entries, still showing 4 entries that are
> now removed from tabulated-list-entries.
>
>
>

[0001-tabulated-list-print-delete-excess-lines-bug-50194.patch (application/octet-stream, attachment)]

Message #11 received at 50194 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Shitikanth <shitikanth1 <at> gmail.com>
Cc: 50194 <at> debbugs.gnu.org
Subject: Re: bug#50194: 28.0.50; tabulated-list-print (with non-nil UPDATE
 argument) doesn't clean up excess entries
Date: Wed, 25 Aug 2021 13:35:03 +0200

Shitikanth <shitikanth1 <at> gmail.com> writes:

> Proposed fix.

Makes sense to me; applied to Emacs 28.

This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.