GNU bug report logs - #50229
[PATCH] gnu: Add genie

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50229 in the body.
You can then email your comments to 50229 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <lichengtai <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add genie
Date: Fri, 27 Aug 2021 10:29:12 -0700

* gnu/packages/build-tools.scm (genie): New variable
---
 gnu/packages/build-tools.scm | 37 ++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/build-tools.scm b/gnu/packages/build-tools.scm
index d2fb9e05df..456d9583bc 100644
--- a/gnu/packages/build-tools.scm
+++ b/gnu/packages/build-tools.scm
@@ -14,6 +14,7 @@
 ;;; Copyright © 2020 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2021 qblade <qblade <at> protonmail.com>
 ;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2021 Andy Tai <atai <at> atai.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -584,3 +585,39 @@ Build has features such as:
 @item Extensible language/compiler framework.
 @end itemize")
     (license license:gpl2+)))
+
+(define-public genie
+  (let ((commit "5fecb127855ee069df345f20d17fea78220fee93")
+        (revision "0"))
+    (package
+        (name "genie")
+        (version
+          (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/bkaradzic/genie")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "1fl00w4v2wigl2fypvnpzmny2x4f0adb7ncsn4a6w7gwxfxvl51j"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:phases
+          (modify-phases %standard-phases
+          (delete 'configure)
+          (replace 'install
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((outdir (assoc-ref outputs "out")))
+               (install-file "bin/linux/genie" (string-append outdir "/bin")))
+               #t)))
+         #:tests? #f)) ;; no tests
+      (home-page "https://github.com/bkaradzic/GENie")
+      (synopsis  "project generator tool")
+      (description "GENie (pronounced as Jenny) is project generator tool.
+It automagically generates project from Lua script,
+making applying the same settings for multiple projects easy..")
+      (license license:bsd-3))))
-- 
2.33.0

Message #10 received at 50229 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <lichengtai <at> gmail.com>
To: 50229 <at> debbugs.gnu.org
Subject: Re: bug#50229: Acknowledgement ([PATCH] gnu: Add genie)
Date: Sat, 28 Aug 2021 20:19:35 -0700

regarding genie: it is a build system used by bgfx and some other
projects in game and related area, so needs to make it in guix first
for these packages to use when included in guix

Message #13 received at 50229 <at> debbugs.gnu.org (full text, mbox):

From: Sarah Morgensen <iskarian <at> mgsn.dev>
To: Andy Tai <lichengtai <at> gmail.com>
Cc: 50229 <at> debbugs.gnu.org
Subject: Re: [bug#50229] [PATCH] gnu: Add genie
Date: Mon, 30 Aug 2021 21:56:54 -0700

Hi,

Thanks for the patch.  Just a couple quick notes:

Andy Tai <lichengtai <at> gmail.com> writes:

> * gnu/packages/build-tools.scm (genie): New variable
> ---
>  gnu/packages/build-tools.scm | 37 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>
> diff --git a/gnu/packages/build-tools.scm b/gnu/packages/build-tools.scm
> index d2fb9e05df..456d9583bc 100644
> --- a/gnu/packages/build-tools.scm
> +++ b/gnu/packages/build-tools.scm
> @@ -14,6 +14,7 @@
>  ;;; Copyright © 2020 Efraim Flashner <efraim <at> flashner.co.il>
>  ;;; Copyright © 2021 qblade <qblade <at> protonmail.com>
>  ;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> +;;; Copyright © 2021 Andy Tai <atai <at> atai.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -584,3 +585,39 @@ Build has features such as:
>  @item Extensible language/compiler framework.
>  @end itemize")
>      (license license:gpl2+)))
> +
> +(define-public genie
> +  (let ((commit "5fecb127855ee069df345f20d17fea78220fee93")
> +        (revision "0"))
> +    (package
> +        (name "genie")
> +        (version
> +          (git-version "0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri
> +          (git-reference
> +           (url "https://github.com/bkaradzic/genie")
> +           (commit commit)))

It looks like genie bundles lua 5.3.0, can this be removed since we have
a lua 5.3 package?

> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> +           "1fl00w4v2wigl2fypvnpzmny2x4f0adb7ncsn4a6w7gwxfxvl51j"))))
> +      (build-system gnu-build-system)
> +      (arguments
> +       `(#:phases
> +          (modify-phases %standard-phases
> +          (delete 'configure)

Does CC need to be set to support cross-compilation like in premake4? (I
haven't tested either way.)

> +          (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((outdir (assoc-ref outputs "out")))
> +               (install-file "bin/linux/genie" (string-append outdir "/bin")))
> +               #t)))
> +         #:tests? #f)) ;; no tests

There's a 'tests' folder in the source, so is this true? :)

> +      (home-page "https://github.com/bkaradzic/GENie")
> +      (synopsis  "project generator tool")
> +      (description "GENie (pronounced as Jenny) is project generator tool.
                              ^ pronounced "Jenny"

> +It automagically generates project from Lua script,

Looking at the project description, perhaps "project files" or "project
build scripts" would be more clear?  As well as specifying the different
systems (Makefile, ...) it supports.

> +making applying the same settings for multiple projects easy..")
                                                  extra period ^

> +      (license license:bsd-3))))

According to LICENSE, the majority of the project is under BSD-3, but
inspect.lua and profiler.lua are expat.

--
Sarah

Message #16 received at 50229 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <lichengtai <at> gmail.com>
To: Sarah Morgensen <iskarian <at> mgsn.dev>
Cc: 50229 <at> debbugs.gnu.org
Subject: Re: [bug#50229] [PATCH] gnu: Add genie
Date: Wed, 1 Sep 2021 18:02:21 -0700

I will take a look of the comments. Thanks

Message #19 received at 50229 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Sarah Morgensen <iskarian <at> mgsn.dev>, 50229 <at> debbugs.gnu.org
Subject: Re: [bug#50229] [PATCH] gnu: Add genie
Date: Sat, 4 Sep 2021 21:23:55 -0700

[Message part 1 (text/plain, inline)]

On Mon, Aug 30, 2021 at 9:56 PM Sarah Morgensen <iskarian <at> mgsn.dev> wrote:
> It looks like genie bundles lua 5.3.0, can this be removed since we have
> a lua 5.3 package?

comments added explaining why Lua is not a native input at this time.

>
> Does CC need to be set to support cross-compilation like in premake4? (I
> haven't tested either way.)

added as in premake4

> There's a 'tests' folder in the source, so is this true? :)
>

The test folder was from premake4 and as is does not work for genie.
Added comment about this.
>
> Looking at the project description, perhaps "project files" or "project
> build scripts" would be more clear?  As well as specifying the different
> systems (Makefile, ...) it supports.
>

description updated per suggestion

> > +making applying the same settings for multiple projects easy..")
>                                                   extra period ^
>

removed
> > +      (license license:bsd-3))))
>
> According to LICENSE, the majority of the project is under BSD-3, but
> inspect.lua and profiler.lua are expat.
>

license list updated and commented as above.

> --
> Sarah

[0001-gnu-Add-genie.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.