GNU bug report logs - #50255
[PATCH] Finish renaming with-nativecomp to with-native-compilation

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50255 in the body.
You can then email your comments to 50255 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clément Pit-Claudel <clement.pitclaudel <at> live.com>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] Finish renaming with-nativecomp to with-native-compilation
Date: Sun, 29 Aug 2021 12:44:05 -0400

[Message part 1 (text/plain, inline)]

Hi Andrea, hi all,

There seems to be a few places where the rename from with-nativecomp to with-native-compilation was missed; I've attached a patch.  

All of them were in messages, which explains why they weren't caught; but one of them is in an EMBA file, which is more surprising, since I would have expected it to cause issues (?)  Are these tests actually working right now?

Clément.

[0001-Change-with-nativecomp-to-with-native-compilation-in.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #8 received at 50255 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Clément Pit-Claudel <clement.pitclaudel <at> live.com>
Cc: 50255 <at> debbugs.gnu.org, Andrea Corallo <akrl <at> sdf.org>
Subject: Re: [PATCH] Finish renaming with-nativecomp to with-native-compilation
Date: Sun, 29 Aug 2021 18:46:39 +0100

On Sun, Aug 29, 2021 at 12:44:05PM -0400, Clément Pit-Claudel wrote:
> 
> All of them were in messages, which explains why they weren't
> caught; but one of them is in an EMBA file, which is more
> surprising, since I would have expected it to cause issues (?) Are
> these tests actually working right now?

Emba's builds have been broken for quite a while.

https://lists.nongnu.org/archive/html/emacs-build-automation/2021-06/msg00001.html

-- 
Alan Third

Message #11 received at 50255 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Clément Pit-Claudel <clement.pitclaudel <at> live.com>
Cc: 50255 <at> debbugs.gnu.org, Andrea Corallo <akrl <at> sdf.org>
Subject: Re: bug#50255: [PATCH] Finish renaming with-nativecomp to
 with-native-compilation
Date: Sun, 29 Aug 2021 21:15:32 +0200

Clément Pit-Claudel <clement.pitclaudel <at> live.com> writes:

> There seems to be a few places where the rename from with-nativecomp
> to with-native-compilation was missed; I've attached a patch.

Thanks; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #16 received at 50255 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Clément Pit-Claudel <clement.pitclaudel <at> live.com>
Cc: 50255 <at> debbugs.gnu.org
Subject: Re: bug#50255: [PATCH] Finish renaming with-nativecomp to
 with-native-compilation
Date: Mon, 30 Aug 2021 09:39:26 +0000

Clément Pit-Claudel <clement.pitclaudel <at> live.com> writes:

> Hi Andrea, hi all,
>
> There seems to be a few places where the rename from with-nativecomp to with-native-compilation was missed; I've attached a patch.  

Hi Clément, thanks for the patch form me as well.

Andrea

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.