GNU bug report logs - #50275
[PATCH 1/4] gnu: Add go-github-com-gdamore-tcell-v2.

Previous Next

Package: guix-patches;

Reported by: jgart <jgart <at> dismail.de>

Date: Mon, 30 Aug 2021 16:42:02 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50275 in the body.
You can then email your comments to 50275 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#50275; Package guix-patches. (Mon, 30 Aug 2021 16:42:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to jgart <jgart <at> dismail.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 30 Aug 2021 16:42:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: Brice Waegeneire <brice <at> waegenei.re>,
 Arun Isaac <arunisaac <at> systemreboot.net>, Guix Together <jgart <at> dismail.de>,
 Julien Lepiller <julien <at> lepiller.eu>
Subject: [PATCH 1/4] gnu: Add go-github-com-gdamore-tcell-v2.
Date: Mon, 30 Aug 2021 12:40:38 -0400
From: Guix Together <jgart <at> dismail.de>

* gnu/packages/golang.scm (go-github-com-gdamore-tcell-v2): New variable.

Co-authored-by: Arun Isaac <arunisaac <at> systemreboot.net>
Co-authored-by: Brice Waegeneire <brice <at> waegenei.re>
Co-authored-by: jgart <jgart <at> dismail.de>
Co-authored-by: Julien Lepiller <julien <at> lepiller.eu>
---
 gnu/packages/golang.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 72579d6bd2..f52343345b 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -5257,6 +5257,38 @@ formatting.  It also favors portability, and includes support for all POSIX
 systems.")
       (license license:expat))))
 
+(define-public go-github-com-gdamore-tcell-v2
+    (package
+      (inherit go-github-com-gdamore-tcell)
+      (name "go-github-com-gdamore-tcell")
+      (version "2.3.1")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/gdamore/tcell")
+               (commit (string-append "v" version))))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "0ypbl5080q9sd3irad8mv7zlg4242i8pmg5xyhbyq95kymwibaid"))))
+      (arguments
+       `(#:import-path "github.com/gdamore/tcell/v2"
+         #:phases
+         (modify-phases %standard-phases
+           (add-before 'reset-gzip-timestamps 'make-files-writable
+             (lambda* (#:key outputs #:allow-other-keys)
+               ;; Make sure .gz files are writable so that the
+               ;; 'reset-gzip-timestamps' phase can do its work.
+               (let ((out (assoc-ref outputs "out")))
+                 (for-each make-file-writable
+                           (find-files out "\\.gz$"))
+                 #t))))))
+      (propagated-inputs
+       `(("go-golang-org-x-term" ,go-golang-org-x-term)
+         ("go-golang-org-x-sys" ,go-golang-org-x-sys)
+         ,@(package-inputs go-github-com-gdamore-tcell)))))
+
 (define-public go-github-com-mattn-go-shellwords
   (let ((commit "2444a32a19f450fabaa0bb3e96a703f15d9a97d2")
         (version "1.0.5")
-- 
2.33.0





Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Mon, 30 Aug 2021 18:58:01 GMT) Full text and rfc822 format available.

Notification sent to jgart <jgart <at> dismail.de>:
bug acknowledged by developer. (Mon, 30 Aug 2021 18:58:02 GMT) Full text and rfc822 format available.

Message #10 received at 50275-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: jgart <jgart <at> dismail.de>
Cc: Brice Waegeneire <brice <at> waegenei.re>,
 Arun Isaac <arunisaac <at> systemreboot.net>, 50275-done <at> debbugs.gnu.org,
 Julien Lepiller <julien <at> lepiller.eu>
Subject: Re: bug#50275: [PATCH 1/4] gnu: Add go-github-com-gdamore-tcell-v2.
Date: Mon, 30 Aug 2021 14:57:30 -0400
Hello!

jgart <jgart <at> dismail.de> writes:

> From: Guix Together <jgart <at> dismail.de>
>
> * gnu/packages/golang.scm (go-github-com-gdamore-tcell-v2): New variable.
>
> Co-authored-by: Arun Isaac <arunisaac <at> systemreboot.net>
> Co-authored-by: Brice Waegeneire <brice <at> waegenei.re>
> Co-authored-by: jgart <jgart <at> dismail.de>
> Co-authored-by: Julien Lepiller <julien <at> lepiller.eu>

This is awesome!

> ---
>  gnu/packages/golang.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index 72579d6bd2..f52343345b 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -5257,6 +5257,38 @@ formatting.  It also favors portability, and includes support for all POSIX
>  systems.")
>        (license license:expat))))
>  
> +(define-public go-github-com-gdamore-tcell-v2
> +    (package
> +      (inherit go-github-com-gdamore-tcell)
> +      (name "go-github-com-gdamore-tcell")
> +      (version "2.3.1")
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/gdamore/tcell")
> +               (commit (string-append "v" version))))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> +           "0ypbl5080q9sd3irad8mv7zlg4242i8pmg5xyhbyq95kymwibaid"))))
> +      (arguments
> +       `(#:import-path "github.com/gdamore/tcell/v2"
> +         #:phases
> +         (modify-phases %standard-phases
> +           (add-before 'reset-gzip-timestamps 'make-files-writable
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               ;; Make sure .gz files are writable so that the
> +               ;; 'reset-gzip-timestamps' phase can do its work.
> +               (let ((out (assoc-ref outputs "out")))
> +                 (for-each make-file-writable
> +                           (find-files out "\\.gz$"))
> +                 #t))))))

Note that you can preemptively start loosing the trailing #t; the
warning will vanish after the guix-core-updates-frozen branch is merged
into master.

> +      (propagated-inputs
> +       `(("go-golang-org-x-term" ,go-golang-org-x-term)
> +         ("go-golang-org-x-sys" ,go-golang-org-x-sys)
> +         ,@(package-inputs go-github-com-gdamore-tcell)))))
> +
>  (define-public go-github-com-mattn-go-shellwords
>    (let ((commit "2444a32a19f450fabaa0bb3e96a703f15d9a97d2")
>          (version "1.0.5")

LGTM.  I fixed the license of the parent package (it should have been
Apache 2.0) and pushed as cc71a54e9f900e905192f794c7bc5346c445e651.

Closing.

Maxim




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 28 Sep 2021 11:24:10 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 182 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.