GNU bug report logs - #50281
[RFC PATCH] build/jami-service: Fix range ends in account-fingerprint-rx.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50281 in the body.
You can then email your comments to 50281 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Cc: Maxime Devos <maximedevos <at> telenet.be>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: [RFC PATCH] build/jami-service: Fix range ends in
 account-fingerprint-rx.
Date: Mon, 30 Aug 2021 19:39:35 +0200

This broke compilation of Guix with guile <at> 3.0.2 with:

  In procedure make-regexp: Invalid range end

The fix is to replace [0-9A-f] with [0-9A-Fa-f].
TODO: were both uppercase and lowercase intended, or
only one of the two?

* gnu/build/jami-service.scm
  (account-fingerprint-rx): Correct regexp.
---
 gnu/build/jami-service.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/build/jami-service.scm b/gnu/build/jami-service.scm
index d44e87387d..ddfc8cf937 100644
--- a/gnu/build/jami-service.scm
+++ b/gnu/build/jami-service.scm
@@ -96,7 +96,7 @@ before each retry."
                  (list key value)))
               alist))
 
-(define account-fingerprint-rx (make-regexp "[0-9A-f]{40}"))
+(define account-fingerprint-rx (make-regexp "[0-9A-Fa-f]{40}"))
 
 (define (account-fingerprint? val)
   "A Jami account fingerprint is 40 characters long and only contains
-- 
2.33.0

Message #10 received at 50281-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 50281-done <at> debbugs.gnu.org
Subject: Re: bug#50281: [RFC PATCH] build/jami-service: Fix range ends in
 account-fingerprint-rx.
Date: Mon, 30 Aug 2021 14:26:11 -0400

Hi Maxime,

Maxime Devos <maximedevos <at> telenet.be> writes:

> This broke compilation of Guix with guile <at> 3.0.2 with:
>
>   In procedure make-regexp: Invalid range end

Uh, good catch!  Makes me curious to know what was changed in 3.0.7!

> The fix is to replace [0-9A-f] with [0-9A-Fa-f].
> TODO: were both uppercase and lowercase intended, or
> only one of the two?

Yes, Jami does not care about the case of the Jami account fingerprint
(IIRC).  I've now edited out the TODO.

> * gnu/build/jami-service.scm
>   (account-fingerprint-rx): Correct regexp.
> ---
>  gnu/build/jami-service.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/build/jami-service.scm b/gnu/build/jami-service.scm
> index d44e87387d..ddfc8cf937 100644
> --- a/gnu/build/jami-service.scm
> +++ b/gnu/build/jami-service.scm
> @@ -96,7 +96,7 @@ before each retry."
>                   (list key value)))
>                alist))
>  
> -(define account-fingerprint-rx (make-regexp "[0-9A-f]{40}"))
> +(define account-fingerprint-rx (make-regexp "[0-9A-Fa-f]{40}"))
>  
>  (define (account-fingerprint? val)
>    "A Jami account fingerprint is 40 characters long and only contains

And pushed as a3bfe953d2.

Thank you!

Closing,

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.