GNU bug report logs - #50299
The check-tests-true lint check is incorrect for Emacs packages

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 31 Aug 2021 15:25:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 31 11:25:56 2021
Received: from localhost ([127.0.0.1]:35190 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mL5e8-0003PZ-D2
	for submit <at> debbugs.gnu.org; Tue, 31 Aug 2021 11:25:56 -0400
Received: from lists.gnu.org ([209.51.188.17]:49670)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1mL5e7-0003PS-8d
 for submit <at> debbugs.gnu.org; Tue, 31 Aug 2021 11:25:55 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:55108)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1mL5e7-0000QM-1m
 for bug-guix@HIDDEN; Tue, 31 Aug 2021 11:25:55 -0400
Received: from mail-qt1-x829.google.com ([2607:f8b0:4864:20::829]:45040)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1mL5e4-0003UB-DD
 for bug-guix@HIDDEN; Tue, 31 Aug 2021 11:25:53 -0400
Received: by mail-qt1-x829.google.com with SMTP id r21so14922036qtw.11
 for <bug-guix@HIDDEN>; Tue, 31 Aug 2021 08:25:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:mime-version;
 bh=GueJQrR4b6OlUJi3KAeDoX/bwUaGk4Qn9lUbz383Z5c=;
 b=d8iyplBYrnWeRZDCMxj2oyeHc7uiIS9coETuJXv66gjV+ghu8ulL/LRoxAdOQ65645
 3f3+gwlN/Yz98YmIEQQIfz20Pg23e4E4qjgkYkILqs1WyUk2TYD5G6tXJtjgfOOQfIyW
 6gWtDoP/3pyrG9leml6LshxiejOT5LEhkpmyPHbW2FnBZr2Dp6LEp9iYbGwaPoBDEbqp
 dnmQVtlQRS02wWHgbt1WZh/tdR8d49iheFI9RQXbm6d5N6CatNDj83M4CBWuRBhBQHPD
 QQ02779+kl79HM9rz3+Pwg1K60mi62Mz4TYoooFTIiMD6MhFU/u6GXIbITW7aF5aFUmo
 SfxA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version;
 bh=GueJQrR4b6OlUJi3KAeDoX/bwUaGk4Qn9lUbz383Z5c=;
 b=Y9aLOpkYPqLNQGogS2D5SlGS/tHDrUWqZdXUumsUaeYGr41MqsmH3C/79gAwoqOoQK
 R58y9endRvXCRFw8iztFj1FKUlayMwaQUnyMwaz97AO9nGWlYa2YvHaSsmoY0MqvKPZb
 atgoMSdKu9rGQne6gbhTzlwwQFe5qxbGsKqt28p9hzP5WoO6uQYIqw11W4kXXYKrlyQP
 UufXxM07k/oY6fx52LXZ9OIehhwpFM6xll63KSxWZwa8xl+Q6lSXxQCe27qHnVHTExD4
 2lCrWcO5PIx9Ba6SwLThFn1pyg38AZwhSN5hvOtcaU4onXRHXO/wNjVWqlSaJA1BSCtk
 3zgA==
X-Gm-Message-State: AOAM533MfqTnSOrY0vi9pc9or0uZVq0ViXcV8E+BjSl/LFf1Zu7sRcIQ
 sAOm+I8+AoJPYdDvZJfFKZI=
X-Google-Smtp-Source: ABdhPJynhlfkFe9OpAATmVaGz2AReCPGT+ExMvWYIXTMA7ktuyluKN17nvv6Yl23m828SeyPz3CZPg==
X-Received: by 2002:ac8:5e46:: with SMTP id i6mr3318208qtx.33.1630423548393;
 Tue, 31 Aug 2021 08:25:48 -0700 (PDT)
Received: from hurd (dsl-153-61.b2b2c.ca. [66.158.153.61])
 by smtp.gmail.com with ESMTPSA id n20sm14096250qkk.135.2021.08.31.08.25.44
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 31 Aug 2021 08:25:48 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: bug-guix <bug-guix@HIDDEN>
Subject: The check-tests-true lint check is incorrect for Emacs packages
Date: Tue, 31 Aug 2021 11:25:35 -0400
Message-ID: <87mtoxiqkw.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2607:f8b0:4864:20::829;
 envelope-from=maxim.cournoyer@HIDDEN; helo=mail-qt1-x829.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
Cc: Maxime Devos <maximedevos@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Hi,

The emacs-build-system has its #:tests? argument set to #f by default,
which means users must explicitly specify its value as #t to enable test
suites.

The check-tests-true lint check seems to ignore this and goes on to
recommend, for example:

--8<---------------cut here---------------start------------->8---
gnu/packages/emacs-xyz.scm:15998:7: emacs-groovy-modes@HIDDEN: #:tests? must not be explicitly set to #t
--8<---------------cut here---------------end--------------->8---

which is wrong.

Thanks,

Maxim