GNU bug report logs - #50303
Add interlinks to docstrings of inverse abbrev

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50303 in the body.
You can then email your comments to 50303 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Add interlinks to docstrings of inverse abbrev
Date: Tue, 31 Aug 2021 19:45:32 +0300

[abbrev-docstrings.patch (text/x-diff, inline)]

diff --git a/lisp/abbrev.el b/lisp/abbrev.el
index 54783db2c3..0d754cc9cf 100644
--- a/lisp/abbrev.el
+++ b/lisp/abbrev.el
@@ -287,6 +287,7 @@ add-mode-abbrev
 or zero means the region is the expansion.
 A negative argument means to undefine the specified abbrev.
 Reads the abbreviation in the minibuffer.
+You can also use the opposite command `inverse-add-mode-abbrev'.
 
 Don't use this function in a Lisp program; use `define-abbrev' instead."
   (interactive "p")
@@ -303,6 +304,7 @@ add-global-abbrev
 expansion; or zero means the region is the expansion.
 A negative argument means to undefine the specified abbrev.
 This command uses the minibuffer to read the abbreviation.
+You can also use the opposite command `inverse-add-global-abbrev'.
 
 Don't use this function in a Lisp program; use `define-abbrev' instead."
   (interactive "p")
@@ -330,7 +332,8 @@ inverse-add-mode-abbrev
   "Define last word before point as a mode-specific abbrev.
 With prefix argument N, defines the Nth word before point.
 This command uses the minibuffer to read the expansion.
-Expands the abbreviation after defining it."
+Expands the abbreviation after defining it.
+You can also use the opposite command `add-mode-abbrev'."
   (interactive "p")
   (inverse-add-abbrev
    (if only-global-abbrevs
@@ -343,7 +346,8 @@ inverse-add-global-abbrev
   "Define last word before point as a global (mode-independent) abbrev.
 With prefix argument N, defines the Nth word before point.
 This command uses the minibuffer to read the expansion.
-Expands the abbreviation after defining it."
+Expands the abbreviation after defining it.
+You can also use the opposite command `add-global-abbrev'."
   (interactive "p")
   (inverse-add-abbrev global-abbrev-table "Global" n))
 

Message #8 received at 50303 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 50303 <at> debbugs.gnu.org
Subject: Re: bug#50303: Add interlinks to docstrings of inverse abbrev
Date: Tue, 31 Aug 2021 20:40:27 +0300

> From: Juri Linkov <juri <at> linkov.net>
> Date: Tue, 31 Aug 2021 19:45:32 +0300
> 
> diff --git a/lisp/abbrev.el b/lisp/abbrev.el
> index 54783db2c3..0d754cc9cf 100644
> --- a/lisp/abbrev.el
> +++ b/lisp/abbrev.el
> @@ -287,6 +287,7 @@ add-mode-abbrev
>  or zero means the region is the expansion.
>  A negative argument means to undefine the specified abbrev.
>  Reads the abbreviation in the minibuffer.
> +You can also use the opposite command `inverse-add-mode-abbrev'.

Thanks, but I think "you can also use" is not the best text here.  It
could be interpreted to mean that the other command does something
similar, which is not true, and contradicts the "opposite" part.
This makes the text confusing.

How about saying explicitly what that command does.  For example:

  To define expansion for the word at point, use `inverse-add-mode-abbrev'.

And similarly for the other doc strings.

Message #11 received at 50303 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 50303 <at> debbugs.gnu.org
Subject: Re: bug#50303: Add interlinks to docstrings of inverse abbrev
Date: Tue, 31 Aug 2021 21:11:05 +0300

[Message part 1 (text/plain, inline)]

>> @@ -287,6 +287,7 @@ add-mode-abbrev
>> +You can also use the opposite command `inverse-add-mode-abbrev'.
>
> Thanks, but I think "you can also use" is not the best text here.  It
> could be interpreted to mean that the other command does something
> similar, which is not true, and contradicts the "opposite" part.
> This makes the text confusing.
>
> How about saying explicitly what that command does.  For example:
>
>   To define expansion for the word at point, use `inverse-add-mode-abbrev'.
>
> And similarly for the other doc strings.

The intention was to indicate that these are opposite commands.
A good explanation is in (info "(emacs) Defining Abbrevs"):

     ‘C-x a i g’ (‘inverse-add-global-abbrev’) and ‘C-x a i l’
  (‘inverse-add-mode-abbrev’) perform the opposite task: if the abbrev
  text is already in the buffer, you use these commands to define an
  abbrev by specifying the expansion in the minibuffer.  These commands
  will expand the abbrev text used for the definition.

Also to reduce confusion, to explicitly mention what another command does:

1. the abbrev is in the buffer, read the expansion from the minibuffer
2. the expansion is in the buffer, read the abbrev from the minibuffer

So maybe this patch is better:

[abbrev-docstrings-2.patch (text/x-diff, inline)]

diff --git a/lisp/abbrev.el b/lisp/abbrev.el
index 54783db2c3..74c9a49b3b 100644
--- a/lisp/abbrev.el
+++ b/lisp/abbrev.el
@@ -288,6 +288,9 @@ add-mode-abbrev
 A negative argument means to undefine the specified abbrev.
 Reads the abbreviation in the minibuffer.
 
+Instead of this, to read the expansion in the minibuffer
+for the abbreviation at point, use `inverse-add-mode-abbrev'.
+
 Don't use this function in a Lisp program; use `define-abbrev' instead."
   (interactive "p")
   (add-abbrev
@@ -304,6 +307,9 @@ add-global-abbrev
 A negative argument means to undefine the specified abbrev.
 This command uses the minibuffer to read the abbreviation.
 
+Instead of this, to read the expansion in the minibuffer
+for the abbreviation at point, use `inverse-add-global-abbrev'.
+
 Don't use this function in a Lisp program; use `define-abbrev' instead."
   (interactive "p")
   (add-abbrev global-abbrev-table "Global" arg))
@@ -330,7 +336,10 @@ inverse-add-mode-abbrev
   "Define last word before point as a mode-specific abbrev.
 With prefix argument N, defines the Nth word before point.
 This command uses the minibuffer to read the expansion.
-Expands the abbreviation after defining it."
+Expands the abbreviation after defining it.
+
+Instead of this, to read the abbreviation in the minibuffer
+for the expansion at point, use `add-mode-abbrev'."
   (interactive "p")
   (inverse-add-abbrev
    (if only-global-abbrevs
@@ -343,7 +352,10 @@ inverse-add-global-abbrev
   "Define last word before point as a global (mode-independent) abbrev.
 With prefix argument N, defines the Nth word before point.
 This command uses the minibuffer to read the expansion.
-Expands the abbreviation after defining it."
+Expands the abbreviation after defining it.
+
+Instead of this, to read the abbreviation in the minibuffer
+for the expansion at point, use `add-global-abbrev'."
   (interactive "p")
   (inverse-add-abbrev global-abbrev-table "Global" n))
 

Message #14 received at 50303 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 50303 <at> debbugs.gnu.org
Subject: Re: bug#50303: Add interlinks to docstrings of inverse abbrev
Date: Tue, 31 Aug 2021 22:03:04 +0300

> From: Juri Linkov <juri <at> linkov.net>
> Cc: 50303 <at> debbugs.gnu.org
> Date: Tue, 31 Aug 2021 21:11:05 +0300
> 
> >> +You can also use the opposite command `inverse-add-mode-abbrev'.
> >
> > Thanks, but I think "you can also use" is not the best text here.  It
> > could be interpreted to mean that the other command does something
> > similar, which is not true, and contradicts the "opposite" part.
> > This makes the text confusing.
> >
> > How about saying explicitly what that command does.  For example:
> >
> >   To define expansion for the word at point, use `inverse-add-mode-abbrev'.
> >
> > And similarly for the other doc strings.
> 
> The intention was to indicate that these are opposite commands.

I understand.  But "opposite" is not well-defined in this case (it
could be a command that UN-defines an abbrev, for instance), and
therefore requires a long explanation:

> A good explanation is in (info "(emacs) Defining Abbrevs"):
> 
>      ‘C-x a i g’ (‘inverse-add-global-abbrev’) and ‘C-x a i l’
>   (‘inverse-add-mode-abbrev’) perform the opposite task: if the abbrev
>   text is already in the buffer, you use these commands to define an
>   abbrev by specifying the expansion in the minibuffer.  These commands
>   will expand the abbrev text used for the definition.
> 
> Also to reduce confusion, to explicitly mention what another command does:
> 
> 1. the abbrev is in the buffer, read the expansion from the minibuffer
> 2. the expansion is in the buffer, read the abbrev from the minibuffer
> 
> So maybe this patch is better:

If you like what the manual says, why not say in the doc string what
the manual says, or some simple variant of that?  I doubt that you'll
be able to come up with a significantly shorter description that is
still clear enough.

Thanks.

Message #19 received at 50303 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 50303 <at> debbugs.gnu.org
Subject: Re: bug#50303: Add interlinks to docstrings of inverse abbrev
Date: Wed, 01 Sep 2021 18:37:13 +0300

[Message part 1 (text/plain, inline)]

>> A good explanation is in (info "(emacs) Defining Abbrevs"):
>>
>>      ‘C-x a i g’ (‘inverse-add-global-abbrev’) and ‘C-x a i l’
>>   (‘inverse-add-mode-abbrev’) perform the opposite task: if the abbrev
>>   text is already in the buffer, you use these commands to define an
>>   abbrev by specifying the expansion in the minibuffer.  These commands
>>   will expand the abbrev text used for the definition.
>
> If you like what the manual says, why not say in the doc string what
> the manual says, or some simple variant of that?  I doubt that you'll
> be able to come up with a significantly shorter description that is
> still clear enough.

So here it uses the text copied from the manual:

[abbrev-docstrings-3.patch (text/x-diff, inline)]

diff --git a/lisp/abbrev.el b/lisp/abbrev.el
index 54783db2c3..5b3804a006 100644
--- a/lisp/abbrev.el
+++ b/lisp/abbrev.el
@@ -288,6 +288,10 @@ add-mode-abbrev
 A negative argument means to undefine the specified abbrev.
 Reads the abbreviation in the minibuffer.
 
+`inverse-add-mode-abbrev' performs the opposite task: if the abbrev
+text is already in the buffer, use this command to define an abbrev
+by specifying the expansion in the minibuffer.
+
 Don't use this function in a Lisp program; use `define-abbrev' instead."
   (interactive "p")
   (add-abbrev
@@ -304,6 +308,10 @@ add-global-abbrev
 A negative argument means to undefine the specified abbrev.
 This command uses the minibuffer to read the abbreviation.
 
+`inverse-add-global-abbrev' performs the opposite task: if the abbrev
+text is already in the buffer, use this command to define an abbrev
+by specifying the expansion in the minibuffer.
+
 Don't use this function in a Lisp program; use `define-abbrev' instead."
   (interactive "p")
   (add-abbrev global-abbrev-table "Global" arg))
@@ -330,7 +338,11 @@ inverse-add-mode-abbrev
   "Define last word before point as a mode-specific abbrev.
 With prefix argument N, defines the Nth word before point.
 This command uses the minibuffer to read the expansion.
-Expands the abbreviation after defining it."
+Expands the abbreviation after defining it.
+
+`add-mode-abbrev' performs the opposite task: if the expansion
+is already in the buffer, use this command to define an abbrev
+by specifying the abbrev in the minibuffer."
   (interactive "p")
   (inverse-add-abbrev
    (if only-global-abbrevs
@@ -343,7 +355,11 @@ inverse-add-global-abbrev
   "Define last word before point as a global (mode-independent) abbrev.
 With prefix argument N, defines the Nth word before point.
 This command uses the minibuffer to read the expansion.
-Expands the abbreviation after defining it."
+Expands the abbreviation after defining it.
+
+`add-global-abbrev' performs the opposite task: if the expansion
+is already in the buffer, use this command to define an abbrev
+by specifying the abbrev in the minibuffer."
   (interactive "p")
   (inverse-add-abbrev global-abbrev-table "Global" n))
 

Message #22 received at 50303 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 50303 <at> debbugs.gnu.org
Subject: Re: bug#50303: Add interlinks to docstrings of inverse abbrev
Date: Wed, 01 Sep 2021 19:08:40 +0300

> From: Juri Linkov <juri <at> linkov.net>
> Cc: 50303 <at> debbugs.gnu.org
> Date: Wed, 01 Sep 2021 18:37:13 +0300
> 
> > If you like what the manual says, why not say in the doc string what
> > the manual says, or some simple variant of that?  I doubt that you'll
> > be able to come up with a significantly shorter description that is
> > still clear enough.
> 
> So here it uses the text copied from the manual:

Thanks, I think this is very good, but I'd like to suggest a minor
stylistic improvement:

> +`inverse-add-mode-abbrev' performs the opposite task: if the abbrev

I would begin this by saying

  See also `inverse-add-mode-abbrev', which performs the opposite
  task: ...

Message #25 received at 50303 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 50303 <at> debbugs.gnu.org
Subject: Re: bug#50303: Add interlinks to docstrings of inverse abbrev
Date: Thu, 02 Sep 2021 20:35:05 +0300

tags 50303 fixed
close 50303 28.0.50
quit

>> > If you like what the manual says, why not say in the doc string what
>> > the manual says, or some simple variant of that?  I doubt that you'll
>> > be able to come up with a significantly shorter description that is
>> > still clear enough.
>> 
>> So here it uses the text copied from the manual:
>
> Thanks, I think this is very good, but I'd like to suggest a minor
> stylistic improvement:
>
>> +`inverse-add-mode-abbrev' performs the opposite task: if the abbrev
>
> I would begin this by saying
>
>   See also `inverse-add-mode-abbrev', which performs the opposite
>   task: ...

Now pushed with this text.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.