GNU bug report logs - #50320
28.0.50; Recent changes cause functions in sh-script-mode to be indented incorrectly

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50320 in the body.
You can then email your comments to 50320 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Diego <dieggsy <at> pm.me>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 28.0.50;
 Recent changes cause functions in sh-script-mode to be indented
 incorrectly
Date: Wed, 01 Sep 2021 04:15:12 +0000

I'm not quite sure when this behavior was introduced, but I suspect commits 4bb70549 or 6392bc37a may be responsible:

With emacs built from git on commit 03dcceeee if I have a function, say:

myecho () {
    echo "foo"
}

And I call M-x indent-region on it, it gets indented to:

myecho () {
echo "foo"
}

Which I don't think is the correct indentation for functions in shell scripts.

Diego

Message #8 received at 50320 <at> debbugs.gnu.org (full text, mbox):

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: 50320 <at> debbugs.gnu.org
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, Diego <dieggsy <at> pm.me>
Subject: Re: bug#50320: 28.0.50; Recent changes cause functions in
 sh-script-mode to be indented incorrectly
Date: Thu, 02 Sep 2021 08:16:22 +0200

Diego via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs <at> gnu.org> writes:

> I'm not quite sure when this behavior was introduced, but I suspect
> commits 4bb70549 or 6392bc37a may be responsible:

Seems to be 6392bc37a; reverting it makes your test case pass again.

As things stand, I don't know enough about SMIE to understand what the
correct fix is.  A plain revert might be the best immediate action,
unless someone knowledgeable enough can reconcile my commit with Diego's
example.

Message #11 received at 50320 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
Cc: Diego <dieggsy <at> pm.me>, 50320 <at> debbugs.gnu.org
Subject: Re: bug#50320: 28.0.50; Recent changes cause functions in
 sh-script-mode to be indented incorrectly
Date: Thu, 02 Sep 2021 08:44:54 +0200

Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:

>> I'm not quite sure when this behavior was introduced, but I suspect
>> commits 4bb70549 or 6392bc37a may be responsible:
>
> Seems to be 6392bc37a; reverting it makes your test case pass again.

I've now reverted the change and added a test.

> As things stand, I don't know enough about SMIE to understand what the
> correct fix is.  A plain revert might be the best immediate action,
> unless someone knowledgeable enough can reconcile my commit with Diego's
> example.

My understanding of SMIE is ... pretty vague.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #16 received at 50320 <at> debbugs.gnu.org (full text, mbox):

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Diego <dieggsy <at> pm.me>, 50320 <at> debbugs.gnu.org
Subject: Re: bug#50320: 28.0.50; Recent changes cause functions in
 sh-script-mode to be indented incorrectly
Date: Thu, 02 Sep 2021 09:54:05 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I've now reverted the change and added a test.

Thanks!

> My understanding of SMIE is ... pretty vague.  :-)

I'll push (info "(elisp) SMIE") to the top of the stack on my
nightstand, then :)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.