GNU bug report logs - #50325
[PATCH] gnu: Add fatrace.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50325 in the body.
You can then email your comments to 50325 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raphaël Mélotte <raphael.melotte <at> mind.be>
To: guix-patches <at> gnu.org
Cc: Raphaël Mélotte <raphael.melotte <at> mind.be>
Subject: [PATCH] gnu: Add fatrace.
Date: Wed,  1 Sep 2021 21:04:36 +0200

* gnu/packages/monitoring.scm (fatrace): New variable.
---
 gnu/packages/monitoring.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/monitoring.scm b/gnu/packages/monitoring.scm
index d2aef0eaab..87df0fa634 100644
--- a/gnu/packages/monitoring.scm
+++ b/gnu/packages/monitoring.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2020 Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
 ;;; Copyright © 2021 Marius Bakke <marius <at> gnu.org>
 ;;; Copyright © 2021 Stefan Reichör <stefan <at> xsteve.at>
+;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte <at> mind.be>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -650,3 +651,30 @@ LAN, if wanted, and clients can switch between multiple hosts on the network.
 Hostscope features a bridge to Influx DB.  So Grafana can be used to visualize
 the recorded data over time.")
     (license license:gpl3+)))
+
+(define-public fatrace
+  (package
+    (name "fatrace")
+    (version "0.16.3")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/martinpitt/fatrace")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1bxz6v1z0icp716jnv3knjyqp8bv6xnkz8gqd8z3g2b6yxj5xff3"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases (modify-phases %standard-phases
+                  (delete 'configure)
+                  ;; there are no tests to execute:
+                  (delete 'check))
+       #:make-flags
+       (list (string-append "CC=" ,(cc-for-target))
+             (string-append "PREFIX=" %output))))
+    (synopsis "File access events monitor")
+    (description "Utility to report system wide file access events.")
+    (home-page "https://github.com/martinpitt/fatrace")
+    (license license:gpl3+)))
-- 
2.32.0

Message #8 received at 50325 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Raphaël Mélotte <raphael.melotte <at> mind.be>,
 50325 <at> debbugs.gnu.org
Cc: Raphaël Mélotte <raphael.melotte <at> mind.be>
Subject: Re: [bug#50325] [PATCH] gnu: Add fatrace.
Date: Wed, 01 Sep 2021 22:10:36 +0200

[Message part 1 (text/plain, inline)]

On Wed, Sep 01 2021, Raphaël Mélotte wrote:

> * gnu/packages/monitoring.scm (fatrace): New variable.
> ---
>  gnu/packages/monitoring.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/monitoring.scm b/gnu/packages/monitoring.scm
> index d2aef0eaab..87df0fa634 100644
> --- a/gnu/packages/monitoring.scm
> +++ b/gnu/packages/monitoring.scm
> @@ -9,6 +9,7 @@
>  ;;; Copyright © 2020 Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
>  ;;; Copyright © 2021 Marius Bakke <marius <at> gnu.org>
>  ;;; Copyright © 2021 Stefan Reichör <stefan <at> xsteve.at>
> +;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte <at> mind.be>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -650,3 +651,30 @@ LAN, if wanted, and clients can switch between multiple hosts on the network.
>  Hostscope features a bridge to Influx DB.  So Grafana can be used to visualize
>  the recorded data over time.")
>      (license license:gpl3+)))
> +
> +(define-public fatrace
> +  (package
> +    (name "fatrace")
> +    (version "0.16.3")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/martinpitt/fatrace")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1bxz6v1z0icp716jnv3knjyqp8bv6xnkz8gqd8z3g2b6yxj5xff3"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases (modify-phases %standard-phases

Nit: The ‘modify-phases’ form is usually on a separate line:

  (arguments
   `(#:phases
     (modify-phases %standard-phases
      ...)))
      
> +                  (delete 'configure)
> +                  ;; there are no tests to execute:
> +                  (delete 'check))

Are you sure about that?  There is a test/ directory in the Git repo.

> +       #:make-flags
> +       (list (string-append "CC=" ,(cc-for-target))
> +             (string-append "PREFIX=" %output))))
> +    (synopsis "File access events monitor")
> +    (description "Utility to report system wide file access events.")

The description should be a complete sentence; maybe (based on the README)

  This package provides a utility to report system wide file access
  events from all running processes.  Its main purpose is to find
  processes which keep waking up the disk unnecessarily and thus prevent
  some power saving.

The package builds fine.  :-)

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 50325 <at> debbugs.gnu.org (full text, mbox):

From: Raphaël Mélotte <raphael.melotte <at> mind.be>
To: Xinglu Chen <public <at> yoctocell.xyz>, 50325 <at> debbugs.gnu.org
Subject: Re: [bug#50325] [PATCH] gnu: Add fatrace.
Date: Wed, 1 Sep 2021 22:34:49 +0200

Thanks for the review!

On 9/1/21 10:10 PM, Xinglu Chen wrote:
> On Wed, Sep 01 2021, Raphaël Mélotte wrote:
> 
>> * gnu/packages/monitoring.scm (fatrace): New variable.
>> ---
>>   gnu/packages/monitoring.scm | 28 ++++++++++++++++++++++++++++
>>   1 file changed, 28 insertions(+)
>>
>> diff --git a/gnu/packages/monitoring.scm b/gnu/packages/monitoring.scm
>> index d2aef0eaab..87df0fa634 100644
>> --- a/gnu/packages/monitoring.scm
>> +++ b/gnu/packages/monitoring.scm
>> @@ -9,6 +9,7 @@
>>   ;;; Copyright © 2020 Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
>>   ;;; Copyright © 2021 Marius Bakke <marius <at> gnu.org>
>>   ;;; Copyright © 2021 Stefan Reichör <stefan <at> xsteve.at>
>> +;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte <at> mind.be>
>>   ;;;
>>   ;;; This file is part of GNU Guix.
>>   ;;;
>> @@ -650,3 +651,30 @@ LAN, if wanted, and clients can switch between multiple hosts on the network.
>>   Hostscope features a bridge to Influx DB.  So Grafana can be used to visualize
>>   the recorded data over time.")
>>       (license license:gpl3+)))
>> +
>> +(define-public fatrace
>> +  (package
>> +    (name "fatrace")
>> +    (version "0.16.3")
>> +    (source (origin
>> +              (method git-fetch)
>> +              (uri (git-reference
>> +                    (url "https://github.com/martinpitt/fatrace")
>> +                    (commit version)))
>> +              (file-name (git-file-name name version))
>> +              (sha256
>> +               (base32
>> +                "1bxz6v1z0icp716jnv3knjyqp8bv6xnkz8gqd8z3g2b6yxj5xff3"))))
>> +    (build-system gnu-build-system)
>> +    (arguments
>> +     `(#:phases (modify-phases %standard-phases
> 
> Nit: The ‘modify-phases’ form is usually on a separate line:
> 
>    (arguments
>     `(#:phases
>       (modify-phases %standard-phases
>        ...)))
>        

Ok, I'll change it.

>> +                  (delete 'configure)
>> +                  ;; there are no tests to execute:
>> +                  (delete 'check))
> 
> Are you sure about that?  There is a test/ directory in the Git repo.

Indeed, the comment is incorrect.
That said the tests need to run as root, have no make target, and need write 
access to /etc so I think we can't run them anyway (at least not as-is).

> 
>> +       #:make-flags
>> +       (list (string-append "CC=" ,(cc-for-target))
>> +             (string-append "PREFIX=" %output))))
>> +    (synopsis "File access events monitor")
>> +    (description "Utility to report system wide file access events.")
> 
> The description should be a complete sentence; maybe (based on the README)
> 
>    This package provides a utility to report system wide file access
>    events from all running processes.  Its main purpose is to find
>    processes which keep waking up the disk unnecessarily and thus prevent
>    some power saving.
> 

Ok, I'll update it.

Message #14 received at 50325 <at> debbugs.gnu.org (full text, mbox):

From: Raphaël Mélotte <raphael.melotte <at> mind.be>
To: 50325 <at> debbugs.gnu.org
Cc: Raphaël Mélotte <raphael.melotte <at> mind.be>
Subject: [PATCH v2] gnu: Add fatrace.
Date: Wed,  1 Sep 2021 22:43:35 +0200

* gnu/packages/monitoring.scm (fatrace): New variable.
---
Changes v1 -> v2 (all suggested by Xinglu Chen):
  - put modify-phases on its own line.
  - update the description.
  - fix the comment for the check phase.

 gnu/packages/monitoring.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/monitoring.scm b/gnu/packages/monitoring.scm
index d2aef0eaab..46dea5eeb8 100644
--- a/gnu/packages/monitoring.scm
+++ b/gnu/packages/monitoring.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2020 Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
 ;;; Copyright © 2021 Marius Bakke <marius <at> gnu.org>
 ;;; Copyright © 2021 Stefan Reichör <stefan <at> xsteve.at>
+;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte <at> mind.be>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -650,3 +651,35 @@ LAN, if wanted, and clients can switch between multiple hosts on the network.
 Hostscope features a bridge to Influx DB.  So Grafana can be used to visualize
 the recorded data over time.")
     (license license:gpl3+)))
+
+(define-public fatrace
+  (package
+    (name "fatrace")
+    (version "0.16.3")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/martinpitt/fatrace")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1bxz6v1z0icp716jnv3knjyqp8bv6xnkz8gqd8z3g2b6yxj5xff3"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         ;; tests need root to run as root,
+         ;; and there is no make target for them:
+         (delete 'check))
+       #:make-flags
+       (list (string-append "CC=" ,(cc-for-target))
+             (string-append "PREFIX=" %output))))
+    (synopsis "File access events monitor")
+    (description "This package provides a utility to report system wide file
+access events from all running processes.  Its main purpose is to find
+processes which keep waking up the disk unnecessarily and thus prevent some
+power saving.")
+    (home-page "https://github.com/martinpitt/fatrace")
+    (license license:gpl3+)))
-- 
2.32.0

Message #17 received at 50325 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Raphaël Mélotte <raphael.melotte <at> mind.be>,
 50325 <at> debbugs.gnu.org
Cc: Raphaël Mélotte <raphael.melotte <at> mind.be>
Subject: Re: [bug#50325] [PATCH v2] gnu: Add fatrace.
Date: Thu, 02 Sep 2021 22:02:45 +0200

[Message part 1 (text/plain, inline)]

On Wed, Sep 01 2021, Raphaël Mélotte wrote:

> * gnu/packages/monitoring.scm (fatrace): New variable.
> ---
> Changes v1 -> v2 (all suggested by Xinglu Chen):
>   - put modify-phases on its own line.
>   - update the description.
>   - fix the comment for the check phase.

LGTM!  I don’t have commit access though.

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 50325-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Raphaël Mélotte <raphael.melotte <at> mind.be>
Cc: 50325-done <at> debbugs.gnu.org, Xinglu Chen <public <at> yoctocell.xyz>
Subject: Re: bug#50325: [PATCH] gnu: Add fatrace.
Date: Fri, 03 Sep 2021 22:17:49 +0200

Hi,

Raphaël Mélotte <raphael.melotte <at> mind.be> skribis:

> * gnu/packages/monitoring.scm (fatrace): New variable.

Applied.

Thank you, and thanks Xinglu for the review!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.