GNU bug report logs - #50341
[PATCH 0/1] emacs-org-roam include extensions

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50341 in the body.
You can then email your comments to 50341 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Collin J. Doering" <collin <at> rekahsoft.ca>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/1] emacs-org-roam include extensions
Date: Thu, 02 Sep 2021 12:27:15 -0400

This resolves issues with the emacs-org-roam packages after the 2.0.0 ->
2.1.0 upgrade. Upstream, some parts of org-roam have been moved to an
extensions directory. This patch also includes these extensions.

In the future, we may want to provide these as a separate output.

Collin J. Doering (1):
  gnu: Update emacs-org-roam to include extensions

 gnu/packages/emacs-xyz.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.33.0

-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca

Message #8 received at 50341 <at> debbugs.gnu.org (full text, mbox):

From: "Collin J. Doering" <collin <at> rekahsoft.ca>
To: 50341 <at> debbugs.gnu.org
Subject: [PATCH 1/1] gnu: Update emacs-org-roam to include extensions
Date: Thu, 02 Sep 2021 12:36:16 -0400

---
 gnu/packages/emacs-xyz.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c106e81fa5..bb6d0b0757 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -28232,7 +28232,8 @@ snippets for Emacs.")
         (base32 "092xn0sqc7b7f6pdf7m6c3giqqbh6fq02mfz8qrg0wmx4ds1isqp"))))
     (build-system emacs-build-system)
     (arguments
-     `(#:phases
+     `(#:include (cons "^extensions/" %default-include)
+       #:phases
        (modify-phases %standard-phases
          (add-after 'install 'install-image
            (lambda* (#:key outputs #:allow-other-keys)
-- 
2.33.0

-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca

Message #11 received at 50341 <at> debbugs.gnu.org (full text, mbox):

From: "Collin J. Doering" <collin <at> rekahsoft.ca>
To: 50341 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/1] gnu: Update emacs-org-roam to include extensions
Date: Thu, 02 Sep 2021 12:48:12 -0400

Noticed that this duplicates (https://issues.guix.gnu.org/50333),
however in 50333, another build phase is added to copy over extensions
which is not necessary give the #:include option (as used in the patchset).

On 02 Sep 2021 at 12:36, "Collin J. Doering" <collin <at> rekahsoft.ca> wrote:

> ---
>  gnu/packages/emacs-xyz.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index c106e81fa5..bb6d0b0757 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -28232,7 +28232,8 @@ snippets for Emacs.")
>          (base32 "092xn0sqc7b7f6pdf7m6c3giqqbh6fq02mfz8qrg0wmx4ds1isqp"))))
>      (build-system emacs-build-system)
>      (arguments
> -     `(#:phases
> +     `(#:include (cons "^extensions/" %default-include)
> +       #:phases
>         (modify-phases %standard-phases
>           (add-after 'install 'install-image
>             (lambda* (#:key outputs #:allow-other-keys)
> -- 
> 2.33.0


-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca

Message #16 received at 50341-done <at> debbugs.gnu.org (full text, mbox):

From: "Collin J. Doering" <collin <at> rekahsoft.ca>
To: 50341-done <at> debbugs.gnu.org
Subject: Re: [PATCH 1/1] gnu: Update emacs-org-roam to include extensions
Date: Fri, 03 Sep 2021 10:25:43 -0400

I realized this morning that this change, unlike
https://issues.guix.gnu.org/50333 does not copy extensions into the
load-path that will be used, which is certainly not favorable.

I think that longer term we likely want to have a separate package that
includes these org-roam extensions.

Closing this issue in preference of 50333.

On 02 Sep 2021 at 12:48, "Collin J. Doering" <collin <at> rekahsoft.ca> wrote:

> Noticed that this duplicates (https://issues.guix.gnu.org/50333),
> however in 50333, another build phase is added to copy over extensions
> which is not necessary give the #:include option (as used in the patchset).
>
> On 02 Sep 2021 at 12:36, "Collin J. Doering" <collin <at> rekahsoft.ca> wrote:
>
>> ---
>>  gnu/packages/emacs-xyz.scm | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>> index c106e81fa5..bb6d0b0757 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -28232,7 +28232,8 @@ snippets for Emacs.")
>>          (base32 "092xn0sqc7b7f6pdf7m6c3giqqbh6fq02mfz8qrg0wmx4ds1isqp"))))
>>      (build-system emacs-build-system)
>>      (arguments
>> -     `(#:phases
>> +     `(#:include (cons "^extensions/" %default-include)
>> +       #:phases
>>         (modify-phases %standard-phases
>>           (add-after 'install 'install-image
>>             (lambda* (#:key outputs #:allow-other-keys)
>> -- 
>> 2.33.0


-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.