Received: (at 50349) by debbugs.gnu.org; 4 Sep 2021 10:30:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 04 06:30:44 2021 Received: from localhost ([127.0.0.1]:46732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mMSwe-0004vo-JE for submit <at> debbugs.gnu.org; Sat, 04 Sep 2021 06:30:44 -0400 Received: from tobias.gr ([80.241.217.52]:52802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <me@HIDDEN>) id 1mMSwc-0004te-TT for 50349 <at> debbugs.gnu.org; Sat, 04 Sep 2021 06:30:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=B41d/fUFQ6LW/ OzHnKop50u7iApzpKCspUfYvAXUVjo=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=ps8G6JtVdsaZA7XET2H6daWRvxM8jWzFTJ3Mq1 OLGR5tTlD+7arleST7GcYAkDyTMq7XGmzdFRt8WWITxvPDbGT+nAPGwGc3h8zXqxxcNFIg PNtdyqKhgdtITTpIzZLFlpmiG93wKdWT6e3HYwbTs2henHXHdZ3ADsdzuGzDW7T4FrUCKo Il8syocytIkxZnwP+/7vTiGSA1ESBt/7rfOGKlJq6FXgoXZjDhJ/QuPvzkdgR2LWd9Kc7y URm1gcuEIO6kQ2iPkanKyKe8Shz9z/e+VoT6U0LDHPSDrkU/7M2A2QU4xX6G7gejjVLLTT 46RFFmBc7bbHsjOSbt7ch8Xg== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 057642c7 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 4 Sep 2021 10:30:37 +0000 (UTC) References: <15d01b32313f5f2f291b120597719ae92bd26acd.1630639896.git.iskarian@HIDDEN> <757b7543b931335c3725264edfbc79c012aa10fc.camel@HIDDEN> From: Tobias Geerinckx-Rice <me@HIDDEN> To: Maxime Devos <maximedevos@HIDDEN> Subject: Re: [bug#50349] [PATCH] packages: Add 'define-package' syntax. Date: Sat, 04 Sep 2021 12:09:26 +0200 In-reply-to: <757b7543b931335c3725264edfbc79c012aa10fc.camel@HIDDEN> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87y28caazy.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50349 Cc: Sarah Morgensen <iskarian@HIDDEN>, 50349 <at> debbugs.gnu.org, guix-patches@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable All, To keep a link with previous =E2=80=98define-package=E2=80=99 discussion, I= 've=20 merged this bug with #15284. It was never resolved IMO and things=20 have changed since 2013 with the label-less input style. Maxime Devos =E5=86=99=E9=81=93=EF=BC=9A > This could be even shorter in the special case that the variable=20 > name > and package name are the same (modulo types): > > (define-package "my-favorite-package" > (version ...) > ...) (define-anything STRING ...) is just too weird to ack. Are there=20 any package names that aren't currently valid symbols? Is there a=20 good reason for them? Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYTNK0Q0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15/+AA/2KDGdPwCf27KyEllAKu87PGffRIUv4hutkxnCW9 i5gSAQCuuf5NC9Fxhj/d+lejfiRjfYNNUPJaqrD/2zrR2co2CA== =NCTi -----END PGP SIGNATURE----- --=-=-=--
bug-guix@HIDDEN:bug#50349; Package guix.
Full text available.Received: (at submit) by debbugs.gnu.org; 4 Sep 2021 10:30:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 04 06:30:50 2021 Received: from localhost ([127.0.0.1]:46736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mMSwj-00051Q-Pi for submit <at> debbugs.gnu.org; Sat, 04 Sep 2021 06:30:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:54926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <me@HIDDEN>) id 1mMSwi-00050Z-Vu for submit <at> debbugs.gnu.org; Sat, 04 Sep 2021 06:30:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1mMSwi-0005Hb-LF for guix-patches@HIDDEN; Sat, 04 Sep 2021 06:30:48 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:51422) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1mMSwf-0006kr-F0 for guix-patches@HIDDEN; Sat, 04 Sep 2021 06:30:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=B41d/fUFQ6LW/ OzHnKop50u7iApzpKCspUfYvAXUVjo=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=ps8G6JtVdsaZA7XET2H6daWRvxM8jWzFTJ3Mq1 OLGR5tTlD+7arleST7GcYAkDyTMq7XGmzdFRt8WWITxvPDbGT+nAPGwGc3h8zXqxxcNFIg PNtdyqKhgdtITTpIzZLFlpmiG93wKdWT6e3HYwbTs2henHXHdZ3ADsdzuGzDW7T4FrUCKo Il8syocytIkxZnwP+/7vTiGSA1ESBt/7rfOGKlJq6FXgoXZjDhJ/QuPvzkdgR2LWd9Kc7y URm1gcuEIO6kQ2iPkanKyKe8Shz9z/e+VoT6U0LDHPSDrkU/7M2A2QU4xX6G7gejjVLLTT 46RFFmBc7bbHsjOSbt7ch8Xg== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 057642c7 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 4 Sep 2021 10:30:37 +0000 (UTC) References: <15d01b32313f5f2f291b120597719ae92bd26acd.1630639896.git.iskarian@HIDDEN> <757b7543b931335c3725264edfbc79c012aa10fc.camel@HIDDEN> From: Tobias Geerinckx-Rice <me@HIDDEN> To: Maxime Devos <maximedevos@HIDDEN> Subject: Re: [bug#50349] [PATCH] packages: Add 'define-package' syntax. Date: Sat, 04 Sep 2021 12:09:26 +0200 In-reply-to: <757b7543b931335c3725264edfbc79c012aa10fc.camel@HIDDEN> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87y28caazy.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@HIDDEN; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: Sarah Morgensen <iskarian@HIDDEN>, 50349 <at> debbugs.gnu.org, guix-patches@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable All, To keep a link with previous =E2=80=98define-package=E2=80=99 discussion, I= 've=20 merged this bug with #15284. It was never resolved IMO and things=20 have changed since 2013 with the label-less input style. Maxime Devos =E5=86=99=E9=81=93=EF=BC=9A > This could be even shorter in the special case that the variable=20 > name > and package name are the same (modulo types): > > (define-package "my-favorite-package" > (version ...) > ...) (define-anything STRING ...) is just too weird to ack. Are there=20 any package names that aren't currently valid symbols? Is there a=20 good reason for them? Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYTNK0Q0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15/+AA/2KDGdPwCf27KyEllAKu87PGffRIUv4hutkxnCW9 i5gSAQCuuf5NC9Fxhj/d+lejfiRjfYNNUPJaqrD/2zrR2co2CA== =NCTi -----END PGP SIGNATURE----- --=-=-=--
bug-guix@HIDDEN:bug#50349; Package guix.
Full text available.Tobias Geerinckx-Rice <me@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Tobias Geerinckx-Rice <me@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Tobias Geerinckx-Rice <me@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 50349) by debbugs.gnu.org; 4 Sep 2021 08:42:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 04 04:42:18 2021 Received: from localhost ([127.0.0.1]:46563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mMRFi-000526-0V for submit <at> debbugs.gnu.org; Sat, 04 Sep 2021 04:42:18 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:52822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maximedevos@HIDDEN>) id 1mMRFd-00051v-RM for 50349 <at> debbugs.gnu.org; Sat, 04 Sep 2021 04:42:17 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by laurent.telenet-ops.be with bizsmtp id pkiB2500Q0mfAB401kiBB1; Sat, 04 Sep 2021 10:42:12 +0200 Message-ID: <757b7543b931335c3725264edfbc79c012aa10fc.camel@HIDDEN> Subject: Re: [bug#50349] [PATCH] packages: Add 'define-package' syntax. From: Maxime Devos <maximedevos@HIDDEN> To: Sarah Morgensen <iskarian@HIDDEN>, 50349 <at> debbugs.gnu.org Date: Sat, 04 Sep 2021 10:42:02 +0200 In-Reply-To: <15d01b32313f5f2f291b120597719ae92bd26acd.1630639896.git.iskarian@HIDDEN> References: <15d01b32313f5f2f291b120597719ae92bd26acd.1630639896.git.iskarian@HIDDEN> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-zmWTNKeAvQv7YpgDsQG/" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1630744932; bh=QIQ9/+U50VNJ/m3kq5gmUWD/XEeVlBaI/3vtAUaJ4G8=; h=Subject:From:To:Date:In-Reply-To:References; b=ZDVKuWNuH5bI45/qk0CeJK7fxGK7ACPED+c7z+ksdNSylSyhJUFESmCPVt43h5ZZA RW4ryjZAZXy8J4M80pZ4vfa58/ZcbvXx9LFmYd7aqcr+RAKXl84q6sXca6OycNgXcK bmW5X+uFDKke/H2sRV5SYce5zXdyR2CRNYWSL3k9kB+s9DnWK7O8pw+QMn44jkST4j zUQfJ8l2+xvWi4HCazWzp2s3lGhKRF487QrSTL/kEmRxmRM4pShsK4ILBaB05NFSwC AZGM3gM9vwoX9slPm5tSFy8mlsiuiEh/CA9rcwoS84sNaOc1rIMe2gg8ZIR7vmior7 H/exZtlce4TqA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50349 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) --=-zmWTNKeAvQv7YpgDsQG/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sarah Morgensen schreef op do 02-09-2021 om 21:06 [-0700]: > Hello Guix, >=20 > This patch adds a shorthand for "(define-public name (package ...))": >=20 > (define-package my-favorite-package > (name "my-favorite-package") > ...) This could be even shorter in the special case that the variable name and package name are the same (modulo types): (define-package "my-favorite-package" (version ...) ...) 'datum->syntax' and 'string->symbol' can be used to turn "my-favorite-packa= ge" into an identifier. A 'define-unexported-package' might be required in some places. > The purpose is primarily to save the horizontal indent, but IMO it looks > better, and is marginally more clear for newcomers. I think ideally we c= ould > eventually transition to using this syntax as the primary syntax and only= use > 'define-public' when necessary. >=20 > There are some downsides... it's one more form to keep track of, and 'let= ' > forms can't easily be used with it. >=20 > Since it's a syntax rule, it doesn't cause packages to rebuild (tested). = I've > also tested the indentation rules, indent-code.el, and the snippets. >=20 > This probably deserves a documentation addition, but I wasn't sure where = to > add it without confusing newcomers. Suggestions welcome! =E2=80=98Defining Packages=E2=80=99 would be a good place I think. > What do you all think? This looks nice to me. IIUC, the define-package is intended to be clearer to newcomers, so you might want to ask for feedback on the new syntax on help-guix@HIDDEN Greetings, Maxime. --=-zmWTNKeAvQv7YpgDsQG/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYTMxWhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7sKYAP9w+XTSzxWZhmUnqm6b2HrJBnke pSydXdNSCWBe9TK8qgD/VHtoAU9jniP90C59rVH8baidLxFnPW7dJ7wctbyXeg4= =+pGj -----END PGP SIGNATURE----- --=-zmWTNKeAvQv7YpgDsQG/--
guix-patches@HIDDEN:bug#50349; Package guix-patches.
Full text available.
Received: (at 50349) by debbugs.gnu.org; 3 Sep 2021 21:56:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 03 17:56:44 2021
Received: from localhost ([127.0.0.1]:45982 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mMHAx-00021K-VG
for submit <at> debbugs.gnu.org; Fri, 03 Sep 2021 17:56:44 -0400
Received: from out0.migadu.com ([94.23.1.103]:15803)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <iskarian@HIDDEN>) id 1mMHAu-00021A-Gm
for 50349 <at> debbugs.gnu.org; Fri, 03 Sep 2021 17:56:42 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1;
t=1630706199;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to;
bh=qEybClVhktQXsFa1aYpZcVf6+Vlq2l9FsyrgHZc+ZUE=;
b=aY4rmFM6zRDi1lub90Selq63k+T/iIMV7kxldGtHRuR5SBkCh5U1fGUg5Wi67ehwMWdmdJ
Pijhr6J9B4T812eGk3hqH4WjTzzCnmfMFNuANGwc9pvPIAopgVrJea6DQPr+usR8/oix2w
HhuX1isK79exnZWDe609djIdOHtXg7U=
From: Sarah Morgensen <iskarian@HIDDEN>
To: zimoun <zimon.toutoune@HIDDEN>
Subject: Re: [bug#50349] [PATCH] packages: Add 'define-package' syntax.
Date: Fri, 03 Sep 2021 14:56:36 -0700
In-Reply-To: zimoun's message of "Fri, 03 Sep 2021 07:41:18 +0200 (15 hours,
51 minutes, 17 seconds ago)"
Message-ID: <86k0jxxqzv.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: iskarian@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 50349
Cc: 50349 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Hi,
zimoun <zimon.toutoune@HIDDEN> writes:
> Hi Sarah,
>
> On Thu, 02 Sep 2021 at 21:06, Sarah Morgensen <iskarian@HIDDEN> wrote:
>
>> (define-package my-favorite-package
>> (name "my-favorite-package")
>> ...)
>>
>> The purpose is primarily to save the horizontal indent, but IMO it looks
>> better, and is marginally more clear for newcomers. I think ideally we =
could
>> eventually transition to using this syntax as the primary syntax and onl=
y use
>> 'define-public' when necessary.
>
> On one hand, I think it is a good idea; especially for newcomers. On
> the other hand, it will break =E2=80=99git-blame=E2=80=99, isn=E2=80=99t =
it?
Yes, there would be a one-time discontinuity. Reformats like this can
be ignored with the `--ignore-ref' option, or with a file and a config
option:
.git-blame-ignore-revs:
--8<---------------cut here---------------start------------->8---
# Convert 'define-public' forms to 'define-package' forms
15d01b32313f5f2f291b120597719ae92bd26acd
--8<---------------cut here---------------end--------------->8---
.git/config:
--8<---------------cut here---------------start------------->8---
[blame]
ignoreRevsFile =3D .git-blame-ignore-revs
--8<---------------cut here---------------end--------------->8---
We could include the latter in e.g. a `.gitconfig' file committed to the
repo, but in order to use config settings from the file, users would
have to first run
git config --local include.path ../.gitconfig
Thankfully, this only has to be done once per clone. If you really
wanted to make sure it got run, I suppose you could add it to a 'make'
target.
--
Sarah
guix-patches@HIDDEN:bug#50349; Package guix-patches.
Full text available.Received: (at 50349) by debbugs.gnu.org; 3 Sep 2021 05:57:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 03 01:57:40 2021 Received: from localhost ([127.0.0.1]:42580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mM2Cq-00061P-Iq for submit <at> debbugs.gnu.org; Fri, 03 Sep 2021 01:57:40 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:35810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <zimon.toutoune@HIDDEN>) id 1mM2Co-00061C-CH for 50349 <at> debbugs.gnu.org; Fri, 03 Sep 2021 01:57:39 -0400 Received: by mail-wr1-f52.google.com with SMTP id i6so6538216wrv.2 for <50349 <at> debbugs.gnu.org>; Thu, 02 Sep 2021 22:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:in-reply-to:references:date:message-id:mime-version :content-transfer-encoding; bh=Y8B4Vw/RtQ7E7bSQ8H69adXa7h7sA223u5r+betwoVs=; b=Z81tbLYlhNoG5NwJe1ZW5uTyK00RwtzamWeYxymOR94prPzn4cNte86WWVT5sL6rkE pWjUR1RpOkVoKAWmZK8dbTQYsTGFj9BBMb75440F6vfvLP45N3QZdnKTkXr/FNiMqJV2 ZMRyrk0wYR7O9wz0hAQXcygqZYVDmP6mcFTmYXtFyFRFf+qiVHGl5hM9Hm5+oHjeFYk4 1S56p+xfDu+Nl370hFXZD1Rr/CWXGEreAmvhUEn9+/PTBj/AKy3ksSPiJ+A6iuK8/jV3 RmpKDT2+l98f9nTpDvYwKbXsglpQ0hQtb2CBPJSxZEtlxUZX1Uh9fSJx87ugFkewPjmw f7Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=Y8B4Vw/RtQ7E7bSQ8H69adXa7h7sA223u5r+betwoVs=; b=Mnd5PPLMqzBbAYwEXoZiGFHPL6NpfKyFFAWa5SBBSoQNAWJpx3BzbDB25YaFIpxKyo yRvRLAxv8w96jx2in0haHi1/FTDay72j6OfK4ZMMELaMt1Q8+TF7p931UNM9pvFYw9y2 +Qq6JPrh70g0ukAoYDFejjj0VEqWtsaStCeXnA4z2tBbbHE+wAAeA6GxlRm0WsOquTtw pzdZEky8BwEbx8qKHWkdS+URmjXSbQqekIieNg5HLXzyMPRsQkBeXm4YGlTrrSNjxuFU IDGUa1KZZpN9C5h0588mfSCHPsF9ZX681mh0RXOjw5jrcM36+M1MuOOwFILrwJ4XWq6t wBlA== X-Gm-Message-State: AOAM532YIs8rhzgMCptvBukkmQKjzwFUX7M5INQI+wmLggPrb63nXxwi ZjAs1fbbfMbXgJG9OKCoY9OxDVjXIR/JLQ== X-Google-Smtp-Source: ABdhPJwn9bomkuENq4IdnnYo1blbLl0uGWsTQhcAwJtXEzcDVNv2ph0Osd/Ln3bqWUHpDmSHHtrwEA== X-Received: by 2002:adf:dd11:: with SMTP id a17mr1957321wrm.132.1630648652472; Thu, 02 Sep 2021 22:57:32 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id l2sm3489881wmi.1.2021.09.02.22.57.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 22:57:32 -0700 (PDT) From: zimoun <zimon.toutoune@HIDDEN> To: Sarah Morgensen <iskarian@HIDDEN>, 50349 <at> debbugs.gnu.org Subject: Re: [bug#50349] [PATCH] packages: Add 'define-package' syntax. In-Reply-To: <15d01b32313f5f2f291b120597719ae92bd26acd.1630639896.git.iskarian@HIDDEN> References: <15d01b32313f5f2f291b120597719ae92bd26acd.1630639896.git.iskarian@HIDDEN> Date: Fri, 03 Sep 2021 07:41:18 +0200 Message-ID: <86h7f21aip.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50349 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Sarah, On Thu, 02 Sep 2021 at 21:06, Sarah Morgensen <iskarian@HIDDEN> wrote: > (define-package my-favorite-package > (name "my-favorite-package") > ...) > > The purpose is primarily to save the horizontal indent, but IMO it looks > better, and is marginally more clear for newcomers. I think ideally we c= ould > eventually transition to using this syntax as the primary syntax and only= use > 'define-public' when necessary. On one hand, I think it is a good idea; especially for newcomers. On the other hand, it will break =E2=80=99git-blame=E2=80=99, isn=E2=80=99t it? Therefore, I am not convinced such change is worth for =E2=80=99gnu/package= s/=E2=80=99. Instead it seems worth only for teaching custom packages. Explaining to people in my labs, they are often confused between =E2=80=99define=E2=80=99= and =E2=80=99define-public=E2=80=99. But then, there is two =E2=80=9Cstyles=E2= =80=9D and people could be more confused. Well, my feelings are mixed. Thanks for opening the discussion. :-) Cheers, simon
guix-patches@HIDDEN:bug#50349; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 3 Sep 2021 04:06:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 03 00:06:38 2021
Received: from localhost ([127.0.0.1]:42511 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mM0TO-00036F-3u
for submit <at> debbugs.gnu.org; Fri, 03 Sep 2021 00:06:38 -0400
Received: from lists.gnu.org ([209.51.188.17]:53296)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <iskarian@HIDDEN>) id 1mM0TM-000367-LI
for submit <at> debbugs.gnu.org; Fri, 03 Sep 2021 00:06:37 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:48324)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <iskarian@HIDDEN>) id 1mM0TL-0003eL-LS
for guix-patches@HIDDEN; Fri, 03 Sep 2021 00:06:36 -0400
Received: from out0.migadu.com ([94.23.1.103]:39653)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <iskarian@HIDDEN>) id 1mM0TI-0004Sp-0E
for guix-patches@HIDDEN; Fri, 03 Sep 2021 00:06:35 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1;
t=1630641989;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding;
bh=CvJCpfvD/KAVUiSNJ0d1E4N2r9otbKVcqE68XxN2hCE=;
b=SzB2uPCwny/d2VdiLyh/9NcRDpaRJBrm1vnYGnJBRUoiaVoss3qb6RZ3/L+KwateHJpr1V
PvP+Vh3DMBqyCnkVnzSYT4Amyk04iUFXOPEBmsrGGEgz3St+hMaBnNbZ2Y6rNd5+sHzgyf
90XUBQjh7CD/W9NhQ0qysIvFDBrGeAA=
From: Sarah Morgensen <iskarian@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] packages: Add 'define-package' syntax.
Date: Thu, 2 Sep 2021 21:06:26 -0700
Message-Id: <15d01b32313f5f2f291b120597719ae92bd26acd.1630639896.git.iskarian@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: iskarian@HIDDEN
Received-SPF: pass client-ip=94.23.1.103; envelope-from=iskarian@HIDDEN;
helo=out0.migadu.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)
* guix/packages.scm (define-package): New syntax.
* .dir-locals.el: Add indent rule for 'define-package'.
* etc/indent-code.el (main): Adjust package search regex accordingly.
* etc/snippets/text-mode/guix-commit-message-add-cl-package: Likewise.
* etc/snippets/text-mode/guix-commit-message-add-package: Likewise.
* etc/snippets/text-mode/guix-commit-message-rename-package: Likewise.
* etc/snippets/text-mode/guix-commit-message-update-package: Likewise.
---
Hello Guix,
This patch adds a shorthand for "(define-public name (package ...))":
(define-package my-favorite-package
(name "my-favorite-package")
...)
The purpose is primarily to save the horizontal indent, but IMO it looks
better, and is marginally more clear for newcomers. I think ideally we could
eventually transition to using this syntax as the primary syntax and only use
'define-public' when necessary.
There are some downsides... it's one more form to keep track of, and 'let'
forms can't easily be used with it.
Since it's a syntax rule, it doesn't cause packages to rebuild (tested). I've
also tested the indentation rules, indent-code.el, and the snippets.
This probably deserves a documentation addition, but I wasn't sure where to
add it without confusing newcomers. Suggestions welcome!
(If this is accepted, we'll also want to make a few changes to
emacs-guix/elisp/guix-devel.el, adding 'define-package' to
'guix-devel-keywords' and to 'guix-devel-scheme-indent' with level 1.)
What do you all think?
--
Sarah
.dir-locals.el | 1 +
etc/indent-code.el | 2 +-
etc/snippets/text-mode/guix-commit-message-add-cl-package | 2 +-
etc/snippets/text-mode/guix-commit-message-add-package | 2 +-
etc/snippets/text-mode/guix-commit-message-rename-package | 4 ++--
etc/snippets/text-mode/guix-commit-message-update-package | 2 +-
guix/packages.scm | 8 ++++++++
7 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/.dir-locals.el b/.dir-locals.el
index aaa48ab552..8141cf4fc2 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -71,6 +71,7 @@
(eval . (put 'with-writable-file 'scheme-indent-function 2))
(eval . (put 'package 'scheme-indent-function 0))
+ (eval . (put 'define-package 'scheme-indent-function 1))
(eval . (put 'package/inherit 'scheme-indent-function 1))
(eval . (put 'origin 'scheme-indent-function 0))
(eval . (put 'build-system 'scheme-indent-function 0))
diff --git a/etc/indent-code.el b/etc/indent-code.el
index bdea8ee8bf..b83659f2f9 100755
--- a/etc/indent-code.el
+++ b/etc/indent-code.el
@@ -94,7 +94,7 @@
;; Indent the definition of PACKAGE-NAME in FILE-NAME.
(find-file file-name)
(goto-char (point-min))
- (if (re-search-forward (concat "^(define\\(\\|-public\\) +"
+ (if (re-search-forward (concat "^(define\\(\\|-public\\|-package\\) +"
package-name)
nil t)
(let ((indent-tabs-mode nil))
diff --git a/etc/snippets/text-mode/guix-commit-message-add-cl-package b/etc/snippets/text-mode/guix-commit-message-add-cl-package
index e255736b05..eb0de677e7 100644
--- a/etc/snippets/text-mode/guix-commit-message-add-cl-package
+++ b/etc/snippets/text-mode/guix-commit-message-add-cl-package
@@ -7,7 +7,7 @@ gnu: Add ${1:`(with-temp-buffer
(magit-git-wash #'magit-diff-wash-diffs
"diff" "--staged")
(beginning-of-buffer)
- (when (search-forward "+(define-public " nil 'noerror)
+ (when (re-search-forward "+(define-\\(public\\|package\\) " nil 'noerror)
(replace-regexp-in-string
"^sbcl-" ""
(thing-at-point 'sexp 'no-properties))))`}.
diff --git a/etc/snippets/text-mode/guix-commit-message-add-package b/etc/snippets/text-mode/guix-commit-message-add-package
index 7cebd4023a..11aeceb129 100644
--- a/etc/snippets/text-mode/guix-commit-message-add-package
+++ b/etc/snippets/text-mode/guix-commit-message-add-package
@@ -7,7 +7,7 @@ gnu: Add ${1:`(with-temp-buffer
(magit-git-wash #'magit-diff-wash-diffs
"diff" "--staged")
(goto-char (point-min))
- (when (re-search-forward "\\+(define-public \\(\\S-+\\)" nil 'noerror)
+ (when (re-search-forward "\\+(define-\\(?:public\\|package\\) \\(\\S-+\\)" nil 'noerror)
(match-string-no-properties 1)))`}.
* `(car (magit-staged-files))` ($1): New variable.
\ No newline at end of file
diff --git a/etc/snippets/text-mode/guix-commit-message-rename-package b/etc/snippets/text-mode/guix-commit-message-rename-package
index 9695ca1b3d..2315443573 100644
--- a/etc/snippets/text-mode/guix-commit-message-rename-package
+++ b/etc/snippets/text-mode/guix-commit-message-rename-package
@@ -7,12 +7,12 @@ gnu: ${1:`(with-temp-buffer
(magit-git-wash #'magit-diff-wash-diffs
"diff" "--staged")
(beginning-of-buffer)
- (when (search-forward "-(define-public " nil 'noerror)
+ (when (re-search-forward "-(define-\\(public\\|package\\) " nil 'noerror)
(thing-at-point 'sexp 'no-properties)))`}: Rename package to ${2:`(with-temp-buffer
(magit-git-wash #'magit-diff-wash-diffs
"diff" "--staged")
(beginning-of-buffer)
- (when (search-forward "+(define-public " nil 'noerror)
+ (when (re-search-forward "+(define-\\(public\\|package\\) " nil 'noerror)
(thing-at-point 'sexp 'no-properties)))`}.
* `(car (magit-staged-files))` ($1): Define in terms of
diff --git a/etc/snippets/text-mode/guix-commit-message-update-package b/etc/snippets/text-mode/guix-commit-message-update-package
index f187419aa2..1d39e28b77 100644
--- a/etc/snippets/text-mode/guix-commit-message-update-package
+++ b/etc/snippets/text-mode/guix-commit-message-update-package
@@ -8,7 +8,7 @@ gnu: ${1:`(with-temp-buffer
(magit-git-wash #'magit-diff-wash-diffs
"diff" "--staged")
(goto-char (point-min))
- (when (re-search-forward "(define-public \\(\\S-+\\)" nil 'noerror)
+ (when (re-search-forward "(define-\\(?:public\\|package\\) \\(\\S-+\\)" nil 'noerror)
(match-string-no-properties 1)))`}: Update to ${2:`(with-temp-buffer
(magit-git-wash #'magit-diff-wash-diffs
"diff" "--staged")
diff --git a/guix/packages.scm b/guix/packages.scm
index c825f427d8..ecd0b7e47d 100644
--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -6,6 +6,7 @@
;;; Copyright © 2017, 2019, 2020 Efraim Flashner <efraim@HIDDEN>
;;; Copyright © 2019 Marius Bakke <mbakke@HIDDEN>
;;; Copyright © 2021 Chris Marusich <cmmarusich@HIDDEN>
+;;; Copyright © 2021 Sarah Morgensen <iskarian@HIDDEN>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -99,6 +100,7 @@ (define-module (guix packages)
package-supported-systems
package-properties
package-location
+ define-package
hidden-package
hidden-package?
package-superseded
@@ -425,6 +427,12 @@ (define-record-type* <package>
package)
16)))))
+(define-syntax-rule (define-package name body ...)
+ "Equivalent to (define-public name (package body ...))."
+ (define-public name
+ (package
+ body ...)))
+
(define-syntax-rule (package/inherit p overrides ...)
"Like (package (inherit P) OVERRIDES ...), except that the same
transformation is done to the package P's replacement, if any. P must be a bare
base-commit: 95c29d2746943733cbe8df7013854d45bb0df413
--
2.31.1
Sarah Morgensen <iskarian@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#50349; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.