GNU bug report logs - #50393
[PATCH] gnu: Add wlsunset.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50393 in the body.
You can then email your comments to 50393 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: raingloom <raingloom <at> riseup.net>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add wlsunset.
Date: Sun, 5 Sep 2021 07:11:50 +0200

* gnu/packages/xdisorg.scm (wlsunset): New variable.
---
 gnu/packages/xdisorg.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index 006b1c11ac..396a704d80 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -3015,3 +3015,31 @@ System.  This includes such features as
MouseKeys, AccessX, StickyKeys, BounceKeys, and SlowKeys.  It includes
a graphical program to help with MouseKeys-acceleration management.")
     (license license:bsd-3)))
+
+(define-public wlsunset
+  (package
+    (name "wlsunset")
+    (version "0.2.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://git.sr.ht/~kennylevinsen/wlsunset/")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0hhsddh3rs066rbsjksr8kcwg8lvglbvs67dq0r5wx5c1xcwb51w"))))
+    (build-system meson-build-system)
+    (inputs
+     `(("wayland-protocols" ,wayland-protocols)
+       ("wayland" ,wayland)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (synopsis "Day/night gamma adjustments for Wayland compositors")
+    (home-page "https://sr.ht/~kennylevinsen/wlsunset/")
+    (description
+     "Day/night gamma adjustments for Wayland compositors supporting
+wlr-gamma-control-unstable-v1.  Also known as a blue light filter or
night +light.")
+    (license license:expat)))
-- 
2.32.0

Message #8 received at 50393 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: raingloom <raingloom <at> riseup.net>
Cc: 50393 <at> debbugs.gnu.org
Subject: Re: [bug#50393] [PATCH] gnu: Add wlsunset.
Date: Mon, 06 Sep 2021 11:08:59 +0200

Hello,

raingloom <raingloom <at> riseup.net> writes:

> +(define-public wlsunset

Thank you. Some nits follow.

> +  (package
> +    (name "wlsunset")
> +    (version "0.2.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://git.sr.ht/~kennylevinsen/wlsunset/")
> +             (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "0hhsddh3rs066rbsjksr8kcwg8lvglbvs67dq0r5wx5c1xcwb51w"))))
> +    (build-system meson-build-system)
> +    (inputs
> +     `(("wayland-protocols" ,wayland-protocols)
> +       ("wayland" ,wayland)))

Could you order inputs alphabetically?

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (synopsis "Day/night gamma adjustments for Wayland compositors")
> +    (home-page "https://sr.ht/~kennylevinsen/wlsunset/")
> +    (description
> +     "Day/night gamma adjustments for Wayland compositors supporting
> +wlr-gamma-control-unstable-v1.  Also known as a blue light filter or
> night +light.")

Could you use complete sentences for the description? I suggest using
markup: @samp{wlr-gamma-control-unstable-v1}.

Regards,
-- 
Nicolas Goaziou

Message #13 received at 50393-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: raingloom <raingloom <at> riseup.net>
Cc: 50393-done <at> debbugs.gnu.org
Subject: Re: [bug#50393] [PATCH] gnu: Add wlsunset.
Date: Wed, 15 Sep 2021 21:28:38 +0200

Hello,

raingloom <raingloom <at> riseup.net> writes:

> Thanks for the feedback, here is the fixed patch.

Thank you. I tweaked the description and applied it.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.