GNU bug report logs - #50438
[PATCH] gnu: thunar: Update to 4.17.1

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50438 in the body.
You can then email your comments to 50438 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: André A. Gomes <andremegafone <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: thunar: Update to 4.17.1
Date: Mon, 06 Sep 2021 22:47:29 +0300

[0001-gnu-thunar-Update-to-4.17.1.patch (text/x-patch, attachment)]

From f8c178fdff2fd8de69a7a09777d2b7588b6fe5de Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20A=2E=20Gomes?= <andremegafone <at> gmail.com>
Date: Mon, 6 Sep 2021 22:37:12 +0300
Subject: [PATCH] gnu: thunar: Update to 4.17.1.

* gnu/packages/xfce.scm (thunar): Update to 4.17.1.
[inputs]: Add gvfs.
---
 gnu/packages/xfce.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index c506f5e463..b40c5ce70a 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -15,6 +15,7 @@
 ;;; Copyright © 2020 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
 ;;; Copyright © 2020, 2021 Michael Rohleder <mike <at> rohleder.de>
 ;;; Copyright © 2021 Brendan Tildesley <mail <at> brendan.scot>
+;;; Copyright © 2021 André A. Gomes <andremegafone <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -781,7 +782,7 @@ like appearance, display, keyboard and mouse settings.")
 (define-public thunar
   (package
     (name "thunar")
-    (version "4.16.8")
+    (version "4.17.1")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://archive.xfce.org/src/xfce/"
@@ -789,7 +790,7 @@ like appearance, display, keyboard and mouse settings.")
                                   "thunar-" version ".tar.bz2"))
               (sha256
                (base32
-                "159ircj0mahx54fqsr3l3ynk690zlpc6ar5pnyhhpk90s8la5303"))))
+                "0w957z22asd7dgchib99013csr628pvakagsqg38w6zhsmb9dy9k"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)
@@ -797,6 +798,7 @@ like appearance, display, keyboard and mouse settings.")
     (inputs
      `(("exo" ,exo)
        ("gobject-introspection" ,gobject-introspection)
+       ("gvfs" ,gvfs)
        ("libexif" ,libexif)
        ("libgudev" ,libgudev)
        ("libnotify" ,libnotify)
-- 
2.33.0

Message #10 received at 50438-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: André A. Gomes <andremegafone <at> gmail.com>
Cc: 50438-done <at> debbugs.gnu.org
Subject: Re: bug#50438: [PATCH] gnu: thunar: Update to 4.17.1
Date: Wed, 15 Sep 2021 16:51:42 +0200

Hi,

André A. Gomes <andremegafone <at> gmail.com> skribis:

>>From f8c178fdff2fd8de69a7a09777d2b7588b6fe5de Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Andr=C3=A9=20A=2E=20Gomes?= <andremegafone <at> gmail.com>
> Date: Mon, 6 Sep 2021 22:37:12 +0300
> Subject: [PATCH] gnu: thunar: Update to 4.17.1.
>
> * gnu/packages/xfce.scm (thunar): Update to 4.17.1.
> [inputs]: Add gvfs.

Applied, thanks!

Ludo’.

Message #13 received at 50438 <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: 50438 <at> debbugs.gnu.org
Cc: andremegafone <at> gmail.com, ludo <at> gnu.org
Subject: Re: bug#50438: [PATCH] gnu: thunar: Update to 4.17.1
Date: Wed, 15 Sep 2021 17:10:43 +0200

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:
>>>From f8c178fdff2fd8de69a7a09777d2b7588b6fe5de Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Andr=C3=A9=20A=2E=20Gomes?= <andremegafone <at> gmail.com>
>> Date: Mon, 6 Sep 2021 22:37:12 +0300
>> Subject: [PATCH] gnu: thunar: Update to 4.17.1.
>>
>> * gnu/packages/xfce.scm (thunar): Update to 4.17.1.
>> [inputs]: Add gvfs.
>
> Applied, thanks!
>

I think, 4.17 is the development branch of xfce/thunar, no?

(https://lists.nongnu.org/archive/html/guix-patches/2021-02/msg00839.html)

-- 
Sind Sie auch vom Vögeln wachgeworden?
Und verwechseln Sie auch manchmal Dativ und Akkusativ?

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 50438 <at> debbugs.gnu.org (full text, mbox):

From: André A. Gomes <andremegafone <at> gmail.com>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: ludo <at> gnu.org, 50438 <at> debbugs.gnu.org
Subject: Re: bug#50438: [PATCH] gnu: thunar: Update to 4.17.1
Date: Wed, 15 Sep 2021 21:48:50 +0300

Michael Rohleder <mike <at> rohleder.de> writes:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>>>>From f8c178fdff2fd8de69a7a09777d2b7588b6fe5de Mon Sep 17 00:00:00 2001
>>> From: =?UTF-8?q?Andr=C3=A9=20A=2E=20Gomes?= <andremegafone <at> gmail.com>
>>> Date: Mon, 6 Sep 2021 22:37:12 +0300
>>> Subject: [PATCH] gnu: thunar: Update to 4.17.1.
>>>
>>> * gnu/packages/xfce.scm (thunar): Update to 4.17.1.
>>> [inputs]: Add gvfs.
>>
>> Applied, thanks!
>>
>
> I think, 4.17 is the development branch of xfce/thunar, no?
>
> (https://lists.nongnu.org/archive/html/guix-patches/2021-02/msg00839.html)

Oh, I wasn't aware of this.  I was confused myself, so I checked thunar's
wikipedia page that states that the stable release is 4.17.1.  The
latest is 4.17.5 so I thought it made sense.  

https://en.wikipedia.org/wiki/Thunar

My goal with this patch was mainly to include gvfs.  I don't really care
about the version.

How shall I proceed?  Thanks.


-- 
André A. Gomes
"Free Thought, Free World"

Message #19 received at 50438 <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: André A. Gomes <andremegafone <at> gmail.com>
Cc: ludo <at> gnu.org, 50438 <at> debbugs.gnu.org
Subject: Re: bug#50438: [PATCH] gnu: thunar: Update to 4.17.1
Date: Wed, 15 Sep 2021 22:22:33 +0200

[Message part 1 (text/plain, inline)]

André A. Gomes <andremegafone <at> gmail.com> writes:
>> I think, 4.17 is the development branch of xfce/thunar, no?
>>
>> (https://lists.nongnu.org/archive/html/guix-patches/2021-02/msg00839.html)
>
> Oh, I wasn't aware of this.  I was confused myself, so I checked thunar's
> wikipedia page that states that the stable release is 4.17.1.  The
> latest is 4.17.5 so I thought it made sense.  
>
> https://en.wikipedia.org/wiki/Thunar

xfce has a release model like this:
https://www.xfce.org/about/releasemodel

Currently, this means 4.16 is the released version, 4.17 is the
development version (which becomes 4.18).

I think wikipedia is wrong here, because the announcement of 4.17.5
(https://mail.xfce.org/pipermail/xfce-announce/2021-September/001059.html)
says:

...
Release notes for 4.17.5
========================
[Please note that this is a development release.]
...

> My goal with this patch was mainly to include gvfs.  I don't really care
> about the version.
>
> How shall I proceed?  Thanks.

Make a patch that just does that.
Maybe, it could be useful to mention the reason for the inclusion of
gvfs, but I'm not sure.


Regards
mike

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 50438 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: "André A. Gomes" <andremegafone <at> gmail.com>,
 50438 <at> debbugs.gnu.org
Subject: Re: bug#50438: [PATCH] gnu: thunar: Update to 4.17.1
Date: Thu, 16 Sep 2021 21:59:23 +0200

Hi,

Michael Rohleder <mike <at> rohleder.de> skribis:

> André A. Gomes <andremegafone <at> gmail.com> writes:
>>> I think, 4.17 is the development branch of xfce/thunar, no?
>>>
>>> (https://lists.nongnu.org/archive/html/guix-patches/2021-02/msg00839.html)

Oh sorry, I had forgotten about that.  :-/

I’ll revert the upgrade and keep the gvfs addition.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.