GNU bug report logs - #50546
[PATCH] imv: Update to 4.1.0 and adjust arguments+inputs.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50546 in the body.
You can then email your comments to 50546 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] imv: Update to 4.1.0 and adjust arguments+inputs.
Date: Sun, 12 Sep 2021 19:49:42 +0800

[0001-gnu-imv-Update-to-4.1.0-and-adjust-arguments-inputs.patch (text/x-patch, inline)]

From 69060bd446332a5e48f9ec44f4b71f07c3a3ca0c Mon Sep 17 00:00:00 2001
From: Z572 <873216071 <at> qq.com>
Date: Thu, 9 Sep 2021 21:36:54 +0800
Subject: [PATCH] gnu: imv: Update to 4.1.0 and adjust arguments+inputs.

* gnu/packages/image-viewers.scm (imv): [version]: Update to 4.1.0.
[build-system]: Replace with meson-build-system.
[phases]: Remove (delete 'configure)
[make-flags]: Remove it.
[inputs]: Remove asciidoc. Add libheif, libjpeg-turbo, libinih, libnsgif,
librsvg-next, libtiff
[native-inputs]: Add asciidoc, Add git-minimal
---
 gnu/packages/image-viewers.scm | 31 +++++++++++++++++--------------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 3b45c25e21..80987a174c 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2021 Stefan Reichör <stefan <at> xsteve.at>
 ;;; Copyright © 2021 Raghav Gururajan <rg <at> raghavgururajan.name>
 ;;; Copyright © 2021 jgart <jgart <at> dismail.de>
+;;; Copyright © 2021 Zheng Junjie <873216071 <at> qq.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -80,6 +81,7 @@
   #:use-module (gnu packages qt)
   #:use-module (gnu packages suckless)
   #:use-module (gnu packages terminals)
+  #:use-module (gnu packages version-control)
   #:use-module (gnu packages video)
   #:use-module (gnu packages web)
   #:use-module (gnu packages xdisorg)
@@ -739,7 +741,7 @@ displayed in a terminal.")
 (define-public imv
   (package
     (name "imv")
-    (version "4.1.0")
+    (version "4.3.0")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -747,13 +749,12 @@ displayed in a terminal.")
                     (commit (string-append "v" version))))
               (sha256
                (base32
-                "0gk8g178i961nn3bls75a8qpv6wvfvav6hd9lxca1skaikd33zdx"))
+                "12xcayyzmfknbff04z8jdlxsnnimgisqiah0bw07cyxx8ksmdzqw"))
               (file-name (git-file-name name version))))
-    (build-system gnu-build-system)
+    (build-system meson-build-system)
     (arguments
      `(#:phases
        (modify-phases %standard-phases
-         (delete 'configure)
          (add-after 'install 'record-absolute-file-names
            (lambda* (#:key outputs #:allow-other-keys)
              ;; 'imv' is a script that execs 'imv-x11' or 'imv-wayland'.
@@ -763,22 +764,24 @@ displayed in a terminal.")
                (substitute* (string-append bin "/imv")
                  (("imv-")
                   (string-append bin "/imv-")))
-               #t))))
-       #:make-flags
-       (list ,(string-append "CC=" (cc-for-target))
-             (string-append "PREFIX=" (assoc-ref %outputs "out"))
-             (string-append "CONFIGPREFIX="
-                            (assoc-ref %outputs "out") "/etc"))))
+               #t))))))
     (inputs
-     `(("asciidoc" ,asciidoc)
-       ("freeimage" ,freeimage)
+     `(("freeimage" ,freeimage)
        ("glu" ,glu)
-       ("librsvg" ,librsvg)
+       ("libheif" ,libheif)
+       ("libjpeg-turbo" ,libjpeg-turbo)
+       ("libinih" ,libinih)
+       ("libnsgif" ,libnsgif)
+       ("librsvg" ,librsvg-next)
+       ("libtiff" ,libtiff)
        ("libxkbcommon" ,libxkbcommon)
        ("pango" ,pango)
        ("wayland" ,wayland)))
     (native-inputs
-     `(("cmocka" ,cmocka)
+     `(("asciidoc" ,asciidoc)
+       ("cmocka" ,cmocka)
+       ;; why build need it?
+       ("git" ,git-minimal)
        ("pkg-config" ,pkg-config)))
     (synopsis "Image viewer for tiling window managers")
     (description "@code{imv} is a command line image viewer intended for use
-- 
2.33.0

[Message part 2 (text/plain, inline)]

-- 
over

Message #10 received at 50546-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Z572 <873216071 <at> qq.com>
Cc: 50546-done <at> debbugs.gnu.org
Subject: Re: bug#50546: [PATCH] imv: Update to 4.1.0 and adjust
 arguments+inputs.
Date: Tue, 21 Sep 2021 15:02:43 +0200

Hi,

Z572 <873216071 <at> qq.com> skribis:

>>From 69060bd446332a5e48f9ec44f4b71f07c3a3ca0c Mon Sep 17 00:00:00 2001
> From: Z572 <873216071 <at> qq.com>
> Date: Thu, 9 Sep 2021 21:36:54 +0800
> Subject: [PATCH] gnu: imv: Update to 4.1.0 and adjust arguments+inputs.
>
> * gnu/packages/image-viewers.scm (imv): [version]: Update to 4.1.0.
> [build-system]: Replace with meson-build-system.
> [phases]: Remove (delete 'configure)
> [make-flags]: Remove it.
> [inputs]: Remove asciidoc. Add libheif, libjpeg-turbo, libinih, libnsgif,
> librsvg-next, libtiff
> [native-inputs]: Add asciidoc, Add git-minimal

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.