GNU bug report logs - #50565
[PATCH] services: tlp: added start-charge-thresh-bat0 & co. to the config

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50565 in the body.
You can then email your comments to 50565 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Attila Lendvai <attila <at> lendvai.name>
To: guix-patches <at> gnu.org
Cc: Attila Lendvai <attila <at> lendvai.name>
Subject: [PATCH] services: tlp: added start-charge-thresh-bat0 & co. to the
 config
Date: Mon, 13 Sep 2021 13:00:30 +0200

---
 gnu/services/pm.scm | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/gnu/services/pm.scm b/gnu/services/pm.scm
index 256c6a7fa7..bf3d8004c7 100644
--- a/gnu/services/pm.scm
+++ b/gnu/services/pm.scm
@@ -253,6 +253,22 @@ default, performance, powersave.")
    (string "powersave")
    "Same as @code{pcie-aspm-ac} but on BAT mode.")
 
+  (start-charge-thresh-bat0
+   (maybe-non-negative-integer 'disabled)
+   "Percentage when battery 0 should begin charging.")
+
+  (stop-charge-thresh-bat0
+   (maybe-non-negative-integer 'disabled)
+   "Percentage when battery 0 should stop charging.")
+
+  (start-charge-thresh-bat1
+   (maybe-non-negative-integer 'disabled)
+   "Percentage when battery 1 should begin charging.")
+
+  (stop-charge-thresh-bat1
+   (maybe-non-negative-integer 'disabled)
+   "Percentage when battery 1 should stop charging.")
+
   (radeon-power-profile-on-ac
    (string "high")
    "Radeon graphics clock speed level.  Alternatives are
-- 
2.33.0

Message #8 received at 50565 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Attila Lendvai <attila <at> lendvai.name>
Cc: 50565 <at> debbugs.gnu.org
Subject: Re: bug#50565: [PATCH] services: tlp: added
 start-charge-thresh-bat0 & co. to the config
Date: Tue, 21 Sep 2021 14:02:30 +0000

Hello,

> +  (start-charge-thresh-bat0
> +   (maybe-non-negative-integer 'disabled)
> +   "Percentage when battery 0 should begin charging.")
> +
> +  (stop-charge-thresh-bat0
> +   (maybe-non-negative-integer 'disabled)
> +   "Percentage when battery 0 should stop charging.")
> +
> +  (start-charge-thresh-bat1
> +   (maybe-non-negative-integer 'disabled)
> +   "Percentage when battery 1 should begin charging.")
> +
> +  (stop-charge-thresh-bat1
> +   (maybe-non-negative-integer 'disabled)
> +   "Percentage when battery 1 should stop charging.")

It would be nice if you could document those new fields in the "TLP
daemon" section of the doc/guix.texi file.

Note that the commit message should also respect the conventions
specified here:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html.

Could you send an updated version :)?

Thanks,

Mathieu

Message #11 received at 50565 <at> debbugs.gnu.org (full text, mbox):

From: Attila Lendvai <attila <at> lendvai.name>
To: 50565 <at> debbugs.gnu.org
Cc: Attila Lendvai <attila <at> lendvai.name>
Subject: [PATCH] services: tlp: Added config variables for battery charging.
Date: Thu, 23 Sep 2021 08:09:10 +0200

* gnu/services/pm.scm (tlp-configuration): Added start-charge-thresh-bat0,
stop-charge-thresh-bat0, start-charge-thresh-bat1, stop-charge-thresh-bat1.
* doc/guix.texi (Power Management Services): Document them.
---
 doc/guix.texi       | 28 ++++++++++++++++++++++++++++
 gnu/services/pm.scm | 16 ++++++++++++++++
 2 files changed, 44 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index b15a45a977..3056157bfe 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -28464,6 +28464,34 @@ Defaults to @samp{"powersave"}.
 
 @end deftypevr
 
+@deftypevr {@code{tlp-configuration} parameter} maybe-non-negative-integer start-charge-thresh-bat0
+Percentage when battery 0 should begin charging. Only supported on some laptops.
+
+Defaults to @samp{disabled}.
+
+@end deftypevr
+
+@deftypevr {@code{tlp-configuration} parameter} maybe-non-negative-integer stop-charge-thresh-bat0
+Percentage when battery 0 should stop charging. Only supported on some laptops.
+
+Defaults to @samp{disabled}.
+
+@end deftypevr
+
+@deftypevr {@code{tlp-configuration} parameter} maybe-non-negative-integer start-charge-thresh-bat1
+Percentage when battery 1 should begin charging. Only supported on some laptops.
+
+Defaults to @samp{disabled}.
+
+@end deftypevr
+
+@deftypevr {@code{tlp-configuration} parameter} maybe-non-negative-integer stop-charge-thresh-bat1
+Percentage when battery 1 should stop charging. Only supported on some laptops.
+
+Defaults to @samp{disabled}.
+
+@end deftypevr
+
 @deftypevr {@code{tlp-configuration} parameter} string radeon-power-profile-on-ac
 Radeon graphics clock speed level.  Alternatives are low, mid, high,
 auto, default.
diff --git a/gnu/services/pm.scm b/gnu/services/pm.scm
index 256c6a7fa7..bf3d8004c7 100644
--- a/gnu/services/pm.scm
+++ b/gnu/services/pm.scm
@@ -253,6 +253,22 @@ default, performance, powersave.")
    (string "powersave")
    "Same as @code{pcie-aspm-ac} but on BAT mode.")
 
+  (start-charge-thresh-bat0
+   (maybe-non-negative-integer 'disabled)
+   "Percentage when battery 0 should begin charging.")
+
+  (stop-charge-thresh-bat0
+   (maybe-non-negative-integer 'disabled)
+   "Percentage when battery 0 should stop charging.")
+
+  (start-charge-thresh-bat1
+   (maybe-non-negative-integer 'disabled)
+   "Percentage when battery 1 should begin charging.")
+
+  (stop-charge-thresh-bat1
+   (maybe-non-negative-integer 'disabled)
+   "Percentage when battery 1 should stop charging.")
+
   (radeon-power-profile-on-ac
    (string "high")
    "Radeon graphics clock speed level.  Alternatives are
-- 
2.33.0

Message #16 received at 50565-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 50565-done <at> debbugs.gnu.org
Cc: Mathieu Othacehe <othacehe <at> gnu.org>, attila.lendvai <at> gmail.com
Subject: [PATCH] services: tlp: added start-charge-thresh-bat0 & co. to the
 config
Date: Wed, 02 Feb 2022 10:43:18 +0100

I’ve pushed this after very minor changes (double spacing in the
documentation, and present tense in the commit message).

Thank you!

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.