GNU bug report logs - #50576
28.0.50; display-buffer-in-previous-window no longer accepts window value for previous-window

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50576 in the body.
You can then email your comments to 50576 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adam Porter <adam <at> alphapapa.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; display-buffer-in-previous-window no longer accepts window
 value for previous-window
Date: Mon, 13 Sep 2021 19:43:34 -0500

Hi Juri, et al,

It seems the patch in this message:

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45688#116

which was installed causes the function
display-buffer-in-previous-window to fail when called with an alist
having the previous-window key set to a window value, because it calls
boundp on the value unconditionally rather than checking the type of
the value.

Message #8 received at 50576 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Adam Porter <adam <at> alphapapa.net>
Cc: 50576 <at> debbugs.gnu.org
Subject: Re: bug#50576: 28.0.50; display-buffer-in-previous-window no longer
 accepts window value for previous-window
Date: Tue, 14 Sep 2021 09:35:48 +0300

> It seems the patch in this message:
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45688#116
>
> which was installed causes the function
> display-buffer-in-previous-window to fail when called with an alist
> having the previous-window key set to a window value, because it calls
> boundp on the value unconditionally rather than checking the type of
> the value.

Sorry, this was a wrong assumption.  Does this patch correctly fix it?

diff --git a/lisp/window.el b/lisp/window.el
index 2960384e15..1c795cf684 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -8363,7 +8363,7 @@ display-buffer-in-previous-window
 	    (throw 'best t)))))
     ;; When ALIST has a `previous-window' entry, that entry may override
     ;; anything we found so far.
-    (when (and previous-window (boundp previous-window))
+    (when (and previous-window (symbolp previous-window) (boundp previous-window))
       (setq previous-window (symbol-value previous-window)))
     (when (and (setq window previous-window)
 	       (window-live-p window)

Message #11 received at 50576 <at> debbugs.gnu.org (full text, mbox):

From: Adam Porter <adam <at> alphapapa.net>
To: Juri Linkov <juri <at> linkov.net>
Cc: 50576 <at> debbugs.gnu.org
Subject: Re: bug#50576: 28.0.50; display-buffer-in-previous-window no longer
 accepts window value for previous-window
Date: Tue, 14 Sep 2021 08:37:17 -0500

Hi Juri,

On Tue, Sep 14, 2021 at 1:44 AM Juri Linkov <juri <at> linkov.net> wrote:

> Sorry, this was a wrong assumption.  Does this patch correctly fix it?
>
> diff --git a/lisp/window.el b/lisp/window.el
> index 2960384e15..1c795cf684 100644
> --- a/lisp/window.el
> +++ b/lisp/window.el
> @@ -8363,7 +8363,7 @@ display-buffer-in-previous-window
>             (throw 'best t)))))
>      ;; When ALIST has a `previous-window' entry, that entry may override
>      ;; anything we found so far.
> -    (when (and previous-window (boundp previous-window))
> +    (when (and previous-window (symbolp previous-window) (boundp previous-window))
>        (setq previous-window (symbol-value previous-window)))
>      (when (and (setq window previous-window)
>                (window-live-p window)

Yes, that seems to work.  Thanks.

Message #14 received at 50576 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Adam Porter <adam <at> alphapapa.net>
Cc: 50576 <at> debbugs.gnu.org
Subject: Re: bug#50576: 28.0.50; display-buffer-in-previous-window no longer
 accepts window value for previous-window
Date: Wed, 15 Sep 2021 09:48:33 +0300

tags 50576 fixed
close 50576 28.0.50
thanks

>> Sorry, this was a wrong assumption.  Does this patch correctly fix it?
>>
>> diff --git a/lisp/window.el b/lisp/window.el
>> index 2960384e15..1c795cf684 100644
>> --- a/lisp/window.el
>> +++ b/lisp/window.el
>> @@ -8363,7 +8363,7 @@ display-buffer-in-previous-window
>>             (throw 'best t)))))
>>      ;; When ALIST has a `previous-window' entry, that entry may override
>>      ;; anything we found so far.
>> -    (when (and previous-window (boundp previous-window))
>> +    (when (and previous-window (symbolp previous-window) (boundp previous-window))
>>        (setq previous-window (symbol-value previous-window)))
>>      (when (and (setq window previous-window)
>>                (window-live-p window)
>
> Yes, that seems to work.  Thanks.

Thanks for the bug report.  Now fixed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.