GNU bug report logs - #50577
28.0.50; Check-in fails in VC tests with commit.gpgSign true

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50577 in the body.
You can then email your comments to 50577 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Check-in fails in VC tests with commit.gpgSign true
Date: Tue, 14 Sep 2021 11:51:23 +0100

Severity: wishlist

My global ~/.config/git/config says:

  [commit]
    gpgSign = true

My Emacs checkout's local .git/config says:

  [commit]
    gpgSign = false

Nevertheless, 'make test/vc-tests' sees the following test fail:

--8<---------------cut here---------------start------------->8---
Registering (foo)... 
Registering (foo)... done
Mark set
Press C-c C-c when you are done editing.
Enter a change comment.  Type C-c C-c when done
Checking in foo...
Test vc-test-git06-version-diff backtrace:
  signal(error ("Failed (status 128): git --no-pager commit -m Test...
  error("Failed (%s): %s" "status 128" "git --no-pager commit -m Testi
  vc-do-command("*vc*" 0 "git" (":(literal)foo") "--no-pager" "commit"
  apply(vc-do-command "*vc*" 0 "git" (":(literal)foo") ("--no-pager" "
  vc-git-command(nil 0 (":(literal)foo") "commit" "-m" "Testing vc-ver
  apply(vc-git-command nil 0 (":(literal)foo") ("commit" "-m" "Testing
  vc-git-checkin(("foo") "Summary: Testing vc-version-diff\n" nil)
  apply(vc-git-checkin (("foo") "Summary: Testing vc-version-diff\n" n
  vc-call-backend(Git checkin ("foo") "Summary: Testing vc-version-dif
  #f(compiled-function (files comment) #<bytecode -0x4a430ccb4d2a198>)
  vc-finish-logentry()
  funcall-interactively(vc-finish-logentry)
  call-interactively(vc-finish-logentry)
  log-edit-done()
  (progn (if (memq backend '(RCS CVS SCCS)) (progn (vc-checkout tmp-na
  (save-current-buffer (set-buffer buff) (progn (if (memq backend '(RC
  (let ((buff (find-file tmp-name))) (save-current-buffer (set-buffer 
  (let* ((tmp-name (expand-file-name "foo" default-directory)) (files 
  (progn (add-hook 'vc-test--cleanup-hook (list 'lambda nil (cons 'del
  (unwind-protect (progn (add-hook 'vc-test--cleanup-hook (list 'lambd
  (let ((vc-handled-backends (list backend)) (default-directory (file-
  vc-test--version-diff(Git)
  (lambda nil (let ((value-269 (gensym "ert-form-evaluation-aborted-")
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name vc-test-git06-version-diff :documenta
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
  ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
  ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
  eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
  command-line-1(("-L" ":." "-L" "./../../elpa/packages/url-http-ntlm/
  command-line()
  normal-top-level()
Test vc-test-git06-version-diff condition:
    (error "Failed (status 128): git --no-pager commit -m Testing vc-version-diff\n\n --only -- :(literal)foo")
   FAILED  14/21  vc-test-git06-version-diff (0.038991 sec)
--8<---------------cut here---------------end--------------->8---

Disabling my global commit.gpgSign setting allows the test to pass.
How can we protect the test suite from such global settings?

Thanks,

-- 
Basil

In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars)
 of 2021-09-14 built on tia
Repository revision: 1e83d04214f27a79a4d4841772da946e24cbf21d
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure 'CC=ccache gcc' 'CFLAGS=-Og -ggdb' --config-cache
 --prefix=/home/blc/.local --enable-checking=structs
 --with-x-toolkit=lucid --with-file-notification=yes --with-x'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
X11 XAW3D XDBE XIM XPM LUCID ZLIB

Important settings:
  value of $LANG: en_IE.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting system-font-setting font-render-setting
cairo x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 50683 5829)
 (symbols 48 6619 1)
 (strings 32 18945 1298)
 (string-bytes 1 611959)
 (vectors 16 13364)
 (vector-slots 8 178283 7678)
 (floats 8 23 44)
 (intervals 56 230 0)
 (buffers 992 10))

Message #8 received at 50577 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>, 50577 <at> debbugs.gnu.org
Subject: Re: bug#50577: 28.0.50; Check-in fails in VC tests with
 commit.gpgSign true
Date: Tue, 14 Sep 2021 14:29:25 +0300

On 14.09.2021 13:51, Basil L. Contovounesios via Bug reports for GNU 
Emacs, the Swiss army knife of text editors wrote:
> Disabling my global commit.gpgSign setting allows the test to pass.
> How can we protect the test suite from such global settings?

Is there an environment variable which would disable GPG signing?

Message #11 received at 50577 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 50577 <at> debbugs.gnu.org
Subject: Re: bug#50577: 28.0.50;
 Check-in fails in VC tests with commit.gpgSign true
Date: Tue, 14 Sep 2021 10:54:36 -0400

Tests are run with HOME=/nonexistent to avoid just this kind of issue,
so how are settings in your user home directory being found?
(I have wondered if some XDG_ variables(s) also need to be set.)

Message #14 received at 50577 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 50577 <at> debbugs.gnu.org
Subject: Re: bug#50577: 28.0.50;
 Check-in fails in VC tests with commit.gpgSign true
Date: Tue, 14 Sep 2021 10:59:30 -0400

Perhaps you have an explicit XDG_CONFIG_HOME set in your environment,
and perhaps test/Makefile should set (or unset) that variable too.

Message #17 received at 50577 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 50577 <at> debbugs.gnu.org
Subject: Re: bug#50577: 28.0.50; Check-in fails in VC tests with
 commit.gpgSign true
Date: Tue, 14 Sep 2021 20:55:38 +0100

Glenn Morris [2021-09-14 10:59 -0400] wrote:

> Perhaps you have an explicit XDG_CONFIG_HOME set in your environment,

Yes, my ~/.profile says:

export XDG_CONFIG_HOME="${XDG_CONFIG_HOME:-${HOME}/.config}"

> and perhaps test/Makefile should set (or unset) that variable too.

Indeed, 'make XDG_CONFIG_HOME=/nonexistent test/vc-tests' succeeds.

Thanks,

-- 
Basil

Message #20 received at 50577 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 50577 <at> debbugs.gnu.org
Subject: Re: bug#50577: 28.0.50; Check-in fails in VC tests with
 commit.gpgSign true
Date: Tue, 14 Sep 2021 20:59:19 +0100

Dmitry Gutov [2021-09-14 14:29 +0300] wrote:

> On 14.09.2021 13:51, Basil L. Contovounesios via Bug reports for GNU Emacs, the
> Swiss army knife of text editors wrote:
>> Disabling my global commit.gpgSign setting allows the test to pass.
>> How can we protect the test suite from such global settings?
>
> Is there an environment variable which would disable GPG signing?

Not that I know of, but Glenn's suggestion to set XDG_CONFIG_HOME sounds
like TRT.

Thanks,

-- 
Basil

Message #23 received at 50577 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 50577 <at> debbugs.gnu.org
Subject: Re: bug#50577: 28.0.50; Check-in fails in VC tests with
 commit.gpgSign true
Date: Wed, 15 Sep 2021 01:36:40 +0300

On 14.09.2021 22:59, Basil L. Contovounesios wrote:
> Not that I know of, but Glenn's suggestion to set XDG_CONFIG_HOME sounds
> like TRT.

Could you try adding it yourself, to see that it works?

test/lisp/vc/vc-tests.el, somewhere around line 627.

Message #26 received at 50577 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: "Basil L. Contovounesios" <contovob <at> tcd.ie>, 50577 <at> debbugs.gnu.org
Subject: Re: bug#50577: 28.0.50;
 Check-in fails in VC tests with commit.gpgSign true
Date: Tue, 14 Sep 2021 19:40:52 -0400

I think 42b49e9 should suffice.

Message #29 received at 50577 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 50577 <at> debbugs.gnu.org
Subject: Re: bug#50577: 28.0.50; Check-in fails in VC tests with
 commit.gpgSign true
Date: Wed, 15 Sep 2021 00:52:21 +0100

Dmitry Gutov [2021-09-15 01:36 +0300] wrote:

> On 14.09.2021 22:59, Basil L. Contovounesios wrote:
>> Not that I know of, but Glenn's suggestion to set XDG_CONFIG_HOME sounds
>> like TRT.
>
> Could you try adding it yourself, to see that it works?
>
> test/lisp/vc/vc-tests.el, somewhere around line 627.

Setting XDG_CONFIG_HOME there works too, but why not set it for all
tests, like we do with HOME?

I was hoping someone more familiar with test/Makefile.in would beat me
to it, but if not I'll propose a patch soon.

Thanks,

-- 
Basil

Message #32 received at 50577 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 50577 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#50577: 28.0.50; Check-in fails in VC tests with
 commit.gpgSign true
Date: Wed, 15 Sep 2021 01:03:45 +0100

close 50577 28.1
quit

Glenn Morris [2021-09-14 19:40 -0400] wrote:

> I think 42b49e9 should suffice.

Even better, thanks!

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.