GNU bug report logs - #50655
[PATCH] gnu: Add falltergeist.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50655 in the body.
You can then email your comments to 50655 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add falltergeist.
Date: Sat, 18 Sep 2021 10:05:16 +0000

* gnu/packages/games.scm (falltergeist): New variable.

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index c39770c260..ca0e46749c 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -1133,6 +1133,34 @@ regular @command{cat}, but it also adds terminal escape codes between
 characters and lines resulting in a rainbow effect.")
       (license license:wtfpl2))))

+(define-public falltergeist
+  (package
+    (name "falltergeist")
+    (version "0.3.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/falltergeist/falltergeist")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "05cg58i2g32wbmrvmdsicic8xs83gld3qr1p7r4lnlckcl1l7dy4"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f))
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (inputs `(("sdl" ,(sdl-union (list sdl2
+                                       sdl2-image
+                                       sdl2-mixer)))
+              ("glew" ,glew)
+              ("glm" ,glm)))
+    (synopsis "Opensource crossplatform Fallout 2 game engine")
+    (description "Opensource crossplatform Fallout 2 game engine.  Game data
+should be placed in ~/.local/share/falltergeist.")
+    (home-page "https://falltergeist.org/")
+    (license license:gpl3)))
+
 (define-public foobillard++
   ;; Even though this latest revision is old already, stable release is
   ;; lagging way behind it, and has issues with textures rendering.
--
2.32.0

Message #8 received at 50655 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: phodina <phodina <at> protonmail.com>, 50655 <at> debbugs.gnu.org
Subject: Re: [bug#50655] [PATCH] gnu: Add falltergeist.
Date: Mon, 20 Sep 2021 14:36:33 +0200

[Message part 1 (text/plain, inline)]

On Sat, Sep 18 2021, phodina via Guix-patches via wrote:

> * gnu/packages/games.scm (falltergeist): New variable.
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index c39770c260..ca0e46749c 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -1133,6 +1133,34 @@ regular @command{cat}, but it also adds terminal escape codes between
>  characters and lines resulting in a rainbow effect.")
>        (license license:wtfpl2))))
>
> +(define-public falltergeist
> +  (package
> +    (name "falltergeist")
> +    (version "0.3.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/falltergeist/falltergeist")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "05cg58i2g32wbmrvmdsicic8xs83gld3qr1p7r4lnlckcl1l7dy4"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f))

What’s the reason for disabling tests?

> +    (native-inputs `(("pkg-config" ,pkg-config)))
> +    (inputs `(("sdl" ,(sdl-union (list sdl2
> +                                       sdl2-image
> +                                       sdl2-mixer)))
> +              ("glew" ,glew)
> +              ("glm" ,glm)))
> +    (synopsis "Opensource crossplatform Fallout 2 game engine")
> +    (description "Opensource crossplatform Fallout 2 game engine.  Game data
> +should be placed in ~/.local/share/falltergeist.")

The description should consist of one or more full sentences (the first
sentence is lacking a subject).  The path should use Texinfo syntax:

  @file{~/.local/share/filltergeist}


> +    (home-page "https://falltergeist.org/")
> +    (license license:gpl3)))

‘license.txt’ says gpl3+.

Could you send an updated patch?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 50655 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 50655 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: Add falltergeist.
Date: Mon, 27 Sep 2021 22:24:38 +0000

Hi Xinglu,

here's the updated patch.

I'm not entirely sure about the license though I'm not a lawyer. I checked the file license.txt and it still seems to me as GPL3, don't know how to spot the "or later" -> GPL3+.

--8<---------------cut here---------------start------------->8---

* gnu/packages/games.scm (falltergeist): New variable.

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index c39770c260..7d08fafc13 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -1133,6 +1133,34 @@ regular @command{cat}, but it also adds terminal escape codes between
 characters and lines resulting in a rainbow effect.")
       (license license:wtfpl2))))

+(define-public falltergeist
+  (package
+    (name "falltergeist")
+    (version "0.3.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/falltergeist/falltergeist")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "05cg58i2g32wbmrvmdsicic8xs83gld3qr1p7r4lnlckcl1l7dy4"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f)) ; no tests provided
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (inputs `(("sdl" ,(sdl-union (list sdl2
+                                       sdl2-image
+                                       sdl2-mixer)))
+              ("glew" ,glew)
+              ("glm" ,glm)))
+    (synopsis "Opensource Fallout 2 game engine")
+    (description "This package provides opensource Fallout 2 game engine.
+Game data should be placed in @file{~/.local/share/falltergeist.}")
+    (home-page "https://falltergeist.org/")
+    (license license:gpl3+)))
+
 (define-public foobillard++
   ;; Even though this latest revision is old already, stable release is
   ;; lagging way behind it, and has issues with textures rendering.
--
2.32.0

Message #14 received at 50655 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: phodina <phodina <at> protonmail.com>
Cc: 50655 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Add falltergeist.
Date: Tue, 28 Sep 2021 21:14:02 +0200

[Message part 1 (text/plain, inline)]

On Mon, Sep 27 2021, phodina wrote:

> Hi Xinglu,
>
> here's the updated patch.
>
> I'm not entirely sure about the license though I'm not a lawyer. I
> checked the file license.txt and it still seems to me as GPL3, don't
> know how to spot the "or later" -> GPL3+.

On line 637, it says

  This program is free software: you can redistribute it and/or modify
  it under the terms of the GNU General Public License as published by
  the Free Software Foundation, either version 3 of the License, or
  (at your option) any later version.

> --8<---------------cut here---------------start------------->8---
>
> * gnu/packages/games.scm (falltergeist): New variable.
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index c39770c260..7d08fafc13 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -1133,6 +1133,34 @@ regular @command{cat}, but it also adds terminal escape codes between
>  characters and lines resulting in a rainbow effect.")
>        (license license:wtfpl2))))
>
> +(define-public falltergeist
> +  (package
> +    (name "falltergeist")
> +    (version "0.3.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/falltergeist/falltergeist")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "05cg58i2g32wbmrvmdsicic8xs83gld3qr1p7r4lnlckcl1l7dy4"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f)) ; no tests provided
> +    (native-inputs `(("pkg-config" ,pkg-config)))
> +    (inputs `(("sdl" ,(sdl-union (list sdl2
> +                                       sdl2-image
> +                                       sdl2-mixer)))
> +              ("glew" ,glew)
> +              ("glm" ,glm)))
> +    (synopsis "Opensource Fallout 2 game engine")
> +    (description "This package provides opensource Fallout 2 game engine.
> +Game data should be placed in @file{~/.local/share/falltergeist.}")
> +    (home-page "https://falltergeist.org/")
> +    (license license:gpl3+)))

LGTM!

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 50655-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: phodina <phodina <at> protonmail.com>, 50655-done <at> debbugs.gnu.org
Subject: Re: [bug#50655] [PATCH v2] gnu: Add falltergeist.
Date: Tue, 28 Sep 2021 21:40:56 +0200

Hello,

Xinglu Chen <public <at> yoctocell.xyz> writes:

> On Mon, Sep 27 2021, phodina wrote:
>
>> here's the updated patch.

Thank you. I removed "opensource" since everything is free in Guix, and pushed.

>
> LGTM!

Thanks for the review.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.