GNU bug report logs - #50657
[PATCH] gnu: Add vpn-slice.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50657 in the body.
You can then email your comments to 50657 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add vpn-slice.
Date: Sat, 18 Sep 2021 10:23:30 +0000

* gnu/packages/vpn.scm (vpn-slice): New variable.

diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm
index 330a3271b4..4d49597564 100644
--- a/gnu/packages/vpn.scm
+++ b/gnu/packages/vpn.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2021 Domagoj Stolfa <ds815 <at> gmx.com>
 ;;; Copyright © 2021 Raghav Gururajan <rg <at> raghavgururajan.name>
 ;;; Copyright © 2021 jgart <jgart <at> dismail.de>
+;;; Copyright © 2021 Petr Hodina  <phodina <at> protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -432,6 +433,31 @@ file for more details.")
            ;; src/libstrongswan/plugins/des/des_crypter.c
            license:bsd-4))))

+(define-public vpn-slice
+  (package
+    (name "vpn-slice")
+    (version "0.15")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "vpn-slice" version))
+        (sha256
+          (base32
+            "0lv3g1bq6ssz6fn6zlzn12dahc4d7nf7kjwxsnb5d7gdrfp36lbx"))))
+    (build-system python-build-system)
+    (native-inputs `(("python-pytest" ,python-pytest)))
+    (propagated-inputs
+      `(("python-dnspython" ,python-dnspython)
+        ("python-setproctitle" ,python-setproctitle)))
+    (home-page
+      "https://github.com/dlenski/vpn-slice")
+    (synopsis
+      "Easy and secure split-tunnel VPN setup")
+    (description
+      "Minimize your contact with an intrusive VPN - split your traffic
+between the VPN tunnel and your normal network interfaces")
+    (license license:gpl3)))
+
 (define-public vpnc
   (package
    (name "vpnc")
--
2.32.0

Message #8 received at 50657 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: phodina <phodina <at> protonmail.com>, 50657 <at> debbugs.gnu.org
Subject: Re: [bug#50657] [PATCH] gnu: Add vpn-slice.
Date: Mon, 20 Sep 2021 14:37:40 +0200

[Message part 1 (text/plain, inline)]

On Sat, Sep 18 2021, phodina via Guix-patches via wrote:

> * gnu/packages/vpn.scm (vpn-slice): New variable.
>
> diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm
> index 330a3271b4..4d49597564 100644
> --- a/gnu/packages/vpn.scm
> +++ b/gnu/packages/vpn.scm
> @@ -18,6 +18,7 @@
>  ;;; Copyright © 2021 Domagoj Stolfa <ds815 <at> gmx.com>
>  ;;; Copyright © 2021 Raghav Gururajan <rg <at> raghavgururajan.name>
>  ;;; Copyright © 2021 jgart <jgart <at> dismail.de>
> +;;; Copyright © 2021 Petr Hodina  <phodina <at> protonmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -432,6 +433,31 @@ file for more details.")
>             ;; src/libstrongswan/plugins/des/des_crypter.c
>             license:bsd-4))))
>
> +(define-public vpn-slice
> +  (package
> +    (name "vpn-slice")
> +    (version "0.15")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "vpn-slice" version))
> +        (sha256
> +          (base32
> +            "0lv3g1bq6ssz6fn6zlzn12dahc4d7nf7kjwxsnb5d7gdrfp36lbx"))))
> +    (build-system python-build-system)
> +    (native-inputs `(("python-pytest" ,python-pytest)))
> +    (propagated-inputs
> +      `(("python-dnspython" ,python-dnspython)
> +        ("python-setproctitle" ,python-setproctitle)))
> +    (home-page
> +      "https://github.com/dlenski/vpn-slice")

Please avoid unnecessary newlines.

> +    (synopsis
> +      "Easy and secure split-tunnel VPN setup")

Likewise.

> +    (description
> +      "Minimize your contact with an intrusive VPN - split your traffic
> +between the VPN tunnel and your normal network interfaces")

The sentence lacks a subject and a period, and the single “-” should be
replaced by “---”, which is the proper Texinfo syntax.

I noticed that the README says

  It automatically looks up named hosts, using the VPN's DNS servers,
  and adds entries for them to your /etc/hosts

I don’t know about Guix System, but on NixOS /etc/hosts is read-only, so
this wouldn’t work.

> +    (license license:gpl3)))

‘LICENSE.txt’ says gpl3+.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 50657 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 50657 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: Add vpn-slice.
Date: Mon, 27 Sep 2021 22:32:45 +0000

Hi Xinglu,

I checked the /etc/hosts and seems that on Guix System there aren't symlink to the /gnu/store.

$ readlink -f /etc/hostname
/etc/hostname

--8<---------------cut here---------------start------------->8---

* gnu/packages/vpn.scm (vpn-slice): New variable.

diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm
index 330a3271b4..cf79bc07f8 100644
--- a/gnu/packages/vpn.scm
+++ b/gnu/packages/vpn.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2021 Domagoj Stolfa <ds815 <at> gmx.com>
 ;;; Copyright © 2021 Raghav Gururajan <rg <at> raghavgururajan.name>
 ;;; Copyright © 2021 jgart <jgart <at> dismail.de>
+;;; Copyright © 2021 Petr Hodina  <phodina <at> protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -432,6 +433,29 @@ file for more details.")
            ;; src/libstrongswan/plugins/des/des_crypter.c
            license:bsd-4))))

+(define-public vpn-slice
+  (package
+    (name "vpn-slice")
+    (version "0.15")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "vpn-slice" version))
+        (sha256
+          (base32
+            "0lv3g1bq6ssz6fn6zlzn12dahc4d7nf7kjwxsnb5d7gdrfp36lbx"))))
+    (build-system python-build-system)
+    (native-inputs `(("python-pytest" ,python-pytest)))
+    (propagated-inputs
+      `(("python-dnspython" ,python-dnspython)
+        ("python-setproctitle" ,python-setproctitle)))
+    (home-page "https://github.com/dlenski/vpn-slice")
+    (synopsis "Easy and secure split-tunnel VPN setup")
+    (description "This package allows you to minimize your contact with
+an intrusive VPN --- split your traffic between the VPN tunnel and your normal
+network interfaces")
+    (license license:gpl3)))
+
 (define-public vpnc
   (package
    (name "vpnc")
--
2.32.0

Message #14 received at 50657 <at> debbugs.gnu.org (full text, mbox):

From: Allan Adair <allan <at> adair.no>
To: 50657 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add vpn-slice.
Date: Mon, 01 Nov 2021 15:04:56 +0100

Any progress on approving or denying this patch? Just a user wanting to
use this package ☺

Message #17 received at 50657 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 50657 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Add vpn-slice.
Date: Fri, 03 Dec 2021 15:35:02 +0000

ping

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: phodina via Guix-patches via <guix-patches <at> gnu.org>
Cc: 50657 <at> debbugs.gnu.org, Xinglu Chen <public <at> yoctocell.xyz>,
 phodina <phodina <at> protonmail.com>
Subject: Re: [bug#50657] [PATCH v2] gnu: Add vpn-slice.
Date: Sun, 05 Dec 2021 12:14:22 +0100

Hello,

phodina via Guix-patches via <guix-patches <at> gnu.org> writes:

> I checked the /etc/hosts and seems that on Guix System there aren't symlink to the /gnu/store.
>
> $ readlink -f /etc/hostname
> /etc/hostname

But it is read-only, isn't it? If so, how can the program do its stuff,
since it is supposed to modify the file?

> +        (sha256
> +          (base32
> +            "0lv3g1bq6ssz6fn6zlzn12dahc4d7nf7kjwxsnb5d7gdrfp36lbx"))))

Nitpick: Hash string should be on the same line as base32

> +    (description "This package allows you to minimize your contact with
> +an intrusive VPN --- split your traffic between the VPN tunnel and your normal
> +network interfaces")

Nitpick: I think English does not add spaces between "---".

> +    (license license:gpl3)))

You forgot to change the license, as suggested by Xinglu Chen.

Regards,
-- 
Nicolas Goaziou

Message #28 received at 50657-done <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: phodina <phodina <at> protonmail.com>, 50657-done <at> debbugs.gnu.org
Subject: Re: [bug#50657] [PATCH] gnu: Add vpn-slice.
Date: Fri, 01 Sep 2023 13:38:30 -0700

[Message part 1 (text/plain, inline)]

On 2021-09-18, phodina wrote:
> +(define-public vpn-slice
> +  (package
> +    (name "vpn-slice")
> +    (version "0.15")

vpn-slice 0.16.1 was added in commit
79415548f7acc3afd8a79fb8ca5d103ad065a2bf.

Marking as done.

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.