GNU bug report logs - #50659
Fontify Libtool macros in autoconf-mode

Previous Next

Package: emacs;

Reported by: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Date: Sat, 18 Sep 2021 11:51:01 UTC

Severity: wishlist

Tags: patch

Fixed in version 28.1

Done: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50659 in the body.
You can then email your comments to 50659 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#50659; Package emacs. (Sat, 18 Sep 2021 11:51:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Basil L. Contovounesios" <contovob <at> tcd.ie>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 18 Sep 2021 11:51:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: bug-gnu-emacs <at> gnu.org
Subject: Fontify Libtool macros in autoconf-mode
Date: Sat, 18 Sep 2021 12:49:58 +0100
[Message part 1 (text/plain, inline)]
Severity: wishlist
Tags: patch

The built-in autoconf-mode currently fontifies Autoconf (AC_*),
Autoheader (AH_*), Automake (AM_*), and M4sh (AS_*) macro names as
keywords.

What about including Libtool (LT_*) macros in the list?

[0001-Font-lock-Libtool-macros-in-autoconf-mode.patch (text/x-diff, inline)]
From d0cfd2afd9e451e851e55ce6a2fc3f49a4517b80 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Date: Sat, 18 Sep 2021 11:49:07 +0100
Subject: [PATCH] Fontify Libtool macros in autoconf-mode

* lisp/progmodes/autoconf.el (autoconf-font-lock-keywords): Apply
font-lock-keyword-face also to Libtool's LT_* macros.
---
 lisp/progmodes/autoconf.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/autoconf.el b/lisp/progmodes/autoconf.el
index 73cf290f43..78148ccf85 100644
--- a/lisp/progmodes/autoconf.el
+++ b/lisp/progmodes/autoconf.el
@@ -44,7 +44,7 @@ autoconf-definition-regexp
   "A\\(?:H_TEMPLATE\\|C_\\(?:SUBST\\|DEFINE\\(?:_UNQUOTED\\)?\\)\\)(\\[*\\(\\(?:\\sw\\|\\s_\\)+\\)\\]*")
 
 (defvar autoconf-font-lock-keywords
-  `(("\\_<A[CHMS]_\\(?:\\sw\\|\\s_\\)+" . font-lock-keyword-face)
+  `(("\\_<\\(?:A[CHMS]\\|LT\\)_\\(?:\\sw\\|\\s_\\)+" . font-lock-keyword-face)
     (,autoconf-definition-regexp
      1 font-lock-function-name-face)
     ;; Are any other M4 keywords really appropriate for configure.ac,
-- 
2.33.0

[Message part 3 (text/plain, inline)]
Thanks,

-- 
Basil

In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars)
 of 2021-09-17 built on tia
Repository revision: 12d2fb58c416b557924174f57bfb1c9b9e7cf999
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux bookworm/sid

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#50659; Package emacs. (Sat, 18 Sep 2021 12:01:01 GMT) Full text and rfc822 format available.

Message #8 received at 50659 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 50659 <at> debbugs.gnu.org
Subject: Re: bug#50659: Fontify Libtool macros in autoconf-mode
Date: Sat, 18 Sep 2021 15:00:32 +0300
> Date: Sat, 18 Sep 2021 12:49:58 +0100
> From:  "Basil L. Contovounesios" via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> The built-in autoconf-mode currently fontifies Autoconf (AC_*),
> Autoheader (AH_*), Automake (AM_*), and M4sh (AS_*) macro names as
> keywords.
> 
> What about including Libtool (LT_*) macros in the list?

SGTM, thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#50659; Package emacs. (Sat, 18 Sep 2021 12:16:01 GMT) Full text and rfc822 format available.

Message #11 received at 50659 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 50659 <at> debbugs.gnu.org
Subject: Re: bug#50659: Fontify Libtool macros in autoconf-mode
Date: Sat, 18 Sep 2021 13:15:08 +0100
close 50659 28.1
quit

Eli Zaretskii [2021-09-18 15:00 +0300] wrote:

>> Date: Sat, 18 Sep 2021 12:49:58 +0100
>> From:  "Basil L. Contovounesios" via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> The built-in autoconf-mode currently fontifies Autoconf (AC_*),
>> Autoheader (AH_*), Automake (AM_*), and M4sh (AS_*) macro names as
>> keywords.
>> 
>> What about including Libtool (LT_*) macros in the list?
>
> SGTM, thanks.

Thanks, done.

Fontify Libtool macros in autoconf-mode
1b623d0fbf 2021-09-18 13:12:32 +0100
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=1b623d0fbf5e69910379a8f1e23006419b046e23

-- 
Basil




bug marked as fixed in version 28.1, send any further explanations to 50659 <at> debbugs.gnu.org and "Basil L. Contovounesios" <contovob <at> tcd.ie> Request was from "Basil L. Contovounesios" <contovob <at> tcd.ie> to control <at> debbugs.gnu.org. (Sat, 18 Sep 2021 12:16:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 17 Oct 2021 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 186 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.