GNU bug report logs - #50661
[PATCH] gnu: Add valeronoi.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50661 in the body.
You can then email your comments to 50661 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add valeronoi.
Date: Sat, 18 Sep 2021 13:25:40 +0000

* gnu/packages/engineering.scm (valeronoi): New variable.

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 46622f3a1f..37f927a7a3 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -24,6 +24,7 @@
 ;;; Copyright © 2021 qblade <qblade <at> protonmail.com>
 ;;; Copyright © 2021 Gerd Heber <gerd.heber <at> gmail.com>
 ;;; Copyright © 2021 Guillaume Le Vaillant <glv <at> posteo.net>
+;;; Copyright © 2021 Petr Hodina <phodina <at> protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -127,6 +128,7 @@
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xiph)
   #:use-module (gnu packages openkinect)
+  #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xorg))

 (define-public librecad
@@ -1168,6 +1170,32 @@ educational use.  As such, there is an emphasis on capabilities that improve
 the 'showing the effect of'-style of operation.")
     (license license:gpl2+)))

+(define-public valeronoi
+(package
+  (name "valeronoi")
+  (version "v0.1.3")
+  (source (origin
+            (method git-fetch)
+            (uri
+	      (git-reference
+		(url "https://github.com/ccoors/Valeronoi")
+		(commit version)))
+            (sha256
+             (base32
+              "1a866h37xmhrnl7hnkhdzjjm8dpjwhq0va2g6hdcp7y949d82ipp"))))
+  (build-system cmake-build-system)
+  (arguments
+    `(#:phases
+      (modify-phases %standard-phases
+		     (replace 'check
+			      (lambda* (#:key outputs #:allow-other-keys)
+				(invoke "./valeronoi-tests"))))))
+  (inputs `(("qtbase" ,qtbase-5) ("qtsvg" ,qtsvg) ("openssl" ,openssl) ("libxkbcommon" ,libxkbcommon) ("cgal" ,cgal) ("gmp" ,gmp) ("mpfr" ,mpfr) ("boost" ,boost)))
+  (synopsis "WiFi mapping companion app for Valetudo")
+  (description "Valeronoi (Valetudo + Voronoi) is a companion for Valetudo for generating WiFi signal strength maps. It visualizes them using a Voronoi diagram.")
+  (home-page "https://github.com/ccoors/Valeronoi")
+  (license license:gpl3)))
+
 (define-public volk
   (package
     (name "volk")
--
2.32.0

Message #8 received at 50661 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: "50661 <at> debbugs.gnu.org" <50661 <at> debbugs.gnu.org>
Subject: [PATCH v2] gnu: Add valeronoi.
Date: Sat, 18 Sep 2021 13:37:52 +0000

Fixed forgotten formatting issues.

--8<---------------cut here---------------start------------->8--

* gnu/packages/engineering.scm (valeronoi): New variable.

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 46622f3a1f..f61fa04a43 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -24,6 +24,7 @@
 ;;; Copyright © 2021 qblade <qblade <at> protonmail.com>
 ;;; Copyright © 2021 Gerd Heber <gerd.heber <at> gmail.com>
 ;;; Copyright © 2021 Guillaume Le Vaillant <glv <at> posteo.net>
+;;; Copyright © 2021 Petr Hodina <phodina <at> protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -127,6 +128,7 @@
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xiph)
   #:use-module (gnu packages openkinect)
+  #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xorg))

 (define-public librecad
@@ -1168,6 +1170,42 @@ educational use.  As such, there is an emphasis on capabilities that improve
 the 'showing the effect of'-style of operation.")
     (license license:gpl2+)))

+(define-public valeronoi
+(package
+  (name "valeronoi")
+  (version "v0.1.3")
+  (source (origin
+            (method git-fetch)
+            (uri
+             (git-reference
+              (url "https://github.com/ccoors/Valeronoi")
+              (commit version)))
+            (file-name (git-file-name name version))
+            (sha256
+             (base32
+              "1a866h37xmhrnl7hnkhdzjjm8dpjwhq0va2g6hdcp7y949d82ipp"))))
+  (build-system cmake-build-system)
+  (arguments
+    `(#:phases
+      (modify-phases %standard-phases
+       (replace 'check
+        (lambda* (#:key outputs #:allow-other-keys)
+         (invoke "./valeronoi-tests"))))))
+  (inputs `(("qtbase" ,qtbase-5)
+            ("qtsvg" ,qtsvg)
+            ("openssl" ,openssl)
+            ("libxkbcommon" ,libxkbcommon)
+            ("cgal" ,cgal)
+            ("gmp" ,gmp)
+            ("mpfr" ,mpfr)
+            ("boost" ,boost)))
+  (synopsis "WiFi mapping companion app for Valetudo")
+  (description "Valeronoi (Valetudo + Voronoi) is a companion for Valetudo
+for generating WiFi signal strength maps.  It visualizes them using a Voronoi
+diagram.")
+  (home-page "https://github.com/ccoors/Valeronoi")
+  (license license:gpl3)))
+
 (define-public volk
   (package
     (name "volk")
--
2.32.0

Message #11 received at 50661 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: phodina <phodina <at> protonmail.com>, "50661 <at> debbugs.gnu.org"
 <50661 <at> debbugs.gnu.org>
Subject: Re: [bug#50661] [PATCH v2] gnu: Add valeronoi.
Date: Wed, 22 Sep 2021 18:27:31 +0200

[Message part 1 (text/plain, inline)]

On Sat, Sep 18 2021, phodina via Guix-patches via wrote:

> Fixed forgotten formatting issues.
>
> --8<---------------cut here---------------start------------->8--
>
> * gnu/packages/engineering.scm (valeronoi): New variable.
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index 46622f3a1f..f61fa04a43 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -24,6 +24,7 @@
>  ;;; Copyright © 2021 qblade <qblade <at> protonmail.com>
>  ;;; Copyright © 2021 Gerd Heber <gerd.heber <at> gmail.com>
>  ;;; Copyright © 2021 Guillaume Le Vaillant <glv <at> posteo.net>
> +;;; Copyright © 2021 Petr Hodina <phodina <at> protonmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -127,6 +128,7 @@
>    #:use-module (gnu packages xml)
>    #:use-module (gnu packages xiph)
>    #:use-module (gnu packages openkinect)
> +  #:use-module (gnu packages xdisorg)
>    #:use-module (gnu packages xorg))
>
>  (define-public librecad
> @@ -1168,6 +1170,42 @@ educational use.  As such, there is an emphasis on capabilities that improve
>  the 'showing the effect of'-style of operation.")
>      (license license:gpl2+)))
>
> +(define-public valeronoi
> +(package
> +  (name "valeronoi")
> +  (version "v0.1.3")

The version string should not contain the “v”, and the latest version
seems to be 0.1.4.

> +  (source (origin
> +            (method git-fetch)
> +            (uri
> +             (git-reference
> +              (url "https://github.com/ccoors/Valeronoi")
> +              (commit version)))
> +            (file-name (git-file-name name version))
> +            (sha256
> +             (base32
> +              "1a866h37xmhrnl7hnkhdzjjm8dpjwhq0va2g6hdcp7y949d82ipp"))))
> +  (build-system cmake-build-system)
> +  (arguments
> +    `(#:phases
> +      (modify-phases %standard-phases
> +       (replace 'check
> +        (lambda* (#:key outputs #:allow-other-keys)
> +         (invoke "./valeronoi-tests"))))))

The ‘outputs’ argument isn’t used, and the ‘check’ phase doesn’t respect
the ‘--without-tests’ package transformation.  The following snippet
would fix this.

  (lambda* (#:key tests? #:allow-other-keys)
    (when tests?
      (invoke "./valeronoi-tests")))

> +  (inputs `(("qtbase" ,qtbase-5)
> +            ("qtsvg" ,qtsvg)
> +            ("openssl" ,openssl)
> +            ("libxkbcommon" ,libxkbcommon)
> +            ("cgal" ,cgal)
> +            ("gmp" ,gmp)
> +            ("mpfr" ,mpfr)
> +            ("boost" ,boost)))
> +  (synopsis "WiFi mapping companion app for Valetudo")
> +  (description "Valeronoi (Valetudo + Voronoi) is a companion for Valetudo
> +for generating WiFi signal strength maps.  It visualizes them using a Voronoi
> +diagram.")
> +  (home-page "https://github.com/ccoors/Valeronoi")
> +  (license license:gpl3)))

The ‘COPYING’ file says gpl3+.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 50661 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: "50661 <at> debbugs.gnu.org" <50661 <at> debbugs.gnu.org>
Subject: [PATCH v3] gnu: Add valeronoi.
Date: Mon, 27 Sep 2021 22:52:06 +0000

* gnu/packages/engineering.scm (valeronoi): New variable.

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 46622f3a1f..9dacc6c948 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -24,6 +24,7 @@
 ;;; Copyright © 2021 qblade <qblade <at> protonmail.com>
 ;;; Copyright © 2021 Gerd Heber <gerd.heber <at> gmail.com>
 ;;; Copyright © 2021 Guillaume Le Vaillant <glv <at> posteo.net>
+;;; Copyright © 2021 Petr Hodina <phodina <at> protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -127,6 +128,7 @@
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xiph)
   #:use-module (gnu packages openkinect)
+  #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xorg))

 (define-public librecad
@@ -1168,6 +1170,43 @@ educational use.  As such, there is an emphasis on capabilities that improve
 the 'showing the effect of'-style of operation.")
     (license license:gpl2+)))

+(define-public valeronoi
+(package
+  (name "valeronoi")
+  (version "0.1.4")
+  (source (origin
+            (method git-fetch)
+            (uri
+             (git-reference
+              (url "https://github.com/ccoors/Valeronoi")
+              (commit (string-append "v" version))))
+            (file-name (git-file-name name version))
+            (sha256
+             (base32
+              "1zp653bjqsyixa5j1pp9k12iqsl8dz72yyi38asxmcym1wngsjcd"))))
+  (build-system cmake-build-system)
+  (arguments
+    `(#:phases
+      (modify-phases %standard-phases
+       (replace 'check
+         (lambda* (#:key tests? #:allow-other-keys)
+           (when tests?
+             (invoke "./valeronoi-tests")))))))
+  (inputs `(("qtbase" ,qtbase-5)
+            ("qtsvg" ,qtsvg)
+            ("openssl" ,openssl)
+            ("libxkbcommon" ,libxkbcommon)
+            ("cgal" ,cgal)
+            ("gmp" ,gmp)
+            ("mpfr" ,mpfr)
+            ("boost" ,boost)))
+  (synopsis "WiFi mapping companion app for Valetudo")
+  (description "Valeronoi (Valetudo + Voronoi) is a companion for Valetudo
+for generating WiFi signal strength maps.  It visualizes them using a Voronoi
+diagram.")
+  (home-page "https://github.com/ccoors/Valeronoi")
+  (license license:gpl3+)))
+
 (define-public volk
   (package
     (name "volk")
--
2.32.0

Message #17 received at 50661 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: "50661 <at> debbugs.gnu.org" <50661 <at> debbugs.gnu.org>
Subject: Re: [PATCH v3] gnu: Add valeronoi.
Date: Fri, 03 Dec 2021 15:36:04 +0000

ping

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: phodina via Guix-patches via <guix-patches <at> gnu.org>
Cc: Xinglu Chen <public <at> yoctocell.xyz>, phodina <phodina <at> protonmail.com>,
 "50661 <at> debbugs.gnu.org" <50661-done <at> debbugs.gnu.org>
Subject: Re: [bug#50661] [PATCH v3] gnu: Add valeronoi.
Date: Fri, 03 Dec 2021 21:39:53 +0100

Hello,

phodina via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/engineering.scm (valeronoi): New variable.

Applied, with the changes below:

> +  (inputs `(("qtbase" ,qtbase-5)
> +            ("qtsvg" ,qtsvg)
> +            ("openssl" ,openssl)
> +            ("libxkbcommon" ,libxkbcommon)
> +            ("cgal" ,cgal)
> +            ("gmp" ,gmp)
> +            ("mpfr" ,mpfr)
> +            ("boost" ,boost)))

I sorted inputs alphabetically.

> +  (synopsis "WiFi mapping companion app for Valetudo")

I replace "app" with "application"

Note: there is a new release. You may want to update it.

Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.