GNU bug report logs - #50664
[PATCH core-updates-frozen] gnu: curl: Respect #:tests?.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Sarah Morgensen <iskarian@HIDDEN>; Keywords: patch; dated Sat, 18 Sep 2021 17:15:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.
Added blocking bug(s) 50358 Request was from Mathieu Othacehe <mathieu@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 50664 <at> debbugs.gnu.org:


Received: (at 50664) by debbugs.gnu.org; 19 Sep 2021 18:46:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Sep 19 14:46:57 2021
Received: from localhost ([127.0.0.1]:39951 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mS1q4-0006Os-QI
	for submit <at> debbugs.gnu.org; Sun, 19 Sep 2021 14:46:57 -0400
Received: from out2.migadu.com ([188.165.223.204]:25661)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <iskarian@HIDDEN>) id 1mS1q3-0006Oh-6Q
 for 50664 <at> debbugs.gnu.org; Sun, 19 Sep 2021 14:46:56 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1;
 t=1632077214;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=/XNaXmMW70QGzvNgrd1TcE1P768IjpNgd4X2Ui9GJVs=;
 b=e9Ap/vYNWURo6DJNicJZTZedGwEXWKHPINqtYci1vfj4pS7Bq5H1OM2c1ZROl9ifqtxZ0p
 lRQVBSvzrHi1qGppuczFLgrqzhh7ZpBbAl4/8a8FlzcAfaV/J8jn05a3sZyPaTcV/hI255
 nyvI0Qz7gVGEFYwIMQdhw2iw076s2ds=
From: Sarah Morgensen <iskarian@HIDDEN>
To: 50664 <at> debbugs.gnu.org
Subject: [PATCH core-updates-frozen v2] gnu: curl: Respect #:tests?.
Date: Sun, 19 Sep 2021 11:46:52 -0700
Message-Id: <d09fb1addde0001d8c2303ea067839ed34d5553d.1632076975.git.iskarian@HIDDEN>
In-Reply-To: <8d416ea3a4f64a4a4df52084e5a9e5cce11c3c0b.1631944982.git.iskarian@HIDDEN>
References: <8d416ea3a4f64a4a4df52084e5a9e5cce11c3c0b.1631944982.git.iskarian@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: iskarian@HIDDEN
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 50664
Cc: othacehe@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/curl.scm (curl)[arguments]<#:phases>{check}: Respect #:tests?.
---
Changes from v1:

* Do not provide a default value for tests?, since gnu-build-system provides
  one.

--
Sarah
 gnu/packages/curl.scm | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm
index 063a919700..4c90c7b301 100644
--- a/gnu/packages/curl.scm
+++ b/gnu/packages/curl.scm
@@ -124,16 +124,16 @@
              (rename-file (string-append out "/share/man/man3")
                           (string-append doc "/share/man/man3"))
              #t)))
-        (replace
-         'check
-         (lambda _
-           (substitute* "tests/runtests.pl"
-             (("/bin/sh") (which "sh")))
+        (replace 'check
+          (lambda* (#:key tests? #:allow-other-keys)
+            (substitute* "tests/runtests.pl"
+              (("/bin/sh") (which "sh")))
 
-           ;; The top-level "make check" does "make -C tests quiet-test", which
-           ;; is too quiet.  Use the "test" target instead, which is more
-           ;; verbose.
-           (invoke "make" "-C" "tests" "test"))))))
+            (when tests?
+              ;; The top-level "make check" does "make -C tests quiet-test", which
+              ;; is too quiet.  Use the "test" target instead, which is more
+              ;; verbose.
+              (invoke "make" "-C" "tests" "test")))))))
    (synopsis "Command line tool for transferring data with URL syntax")
    (description
     "curl is a command line tool for transferring data with URL syntax,

base-commit: 8613652f3f80105f35db13d6d9308257bbff8474
-- 
2.33.0





Information forwarded to guix-patches@HIDDEN:
bug#50664; Package guix-patches. Full text available.

Message received at 50664 <at> debbugs.gnu.org:


Received: (at 50664) by debbugs.gnu.org; 19 Sep 2021 15:50:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Sep 19 11:50:43 2021
Received: from localhost ([127.0.0.1]:39621 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mRz5X-0001UZ-DG
	for submit <at> debbugs.gnu.org; Sun, 19 Sep 2021 11:50:43 -0400
Received: from eggs.gnu.org ([209.51.188.92]:48654)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1mRz5V-0001UN-Q9
 for 50664 <at> debbugs.gnu.org; Sun, 19 Sep 2021 11:50:42 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:56126)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <othacehe@HIDDEN>)
 id 1mRz5O-0005mY-HZ; Sun, 19 Sep 2021 11:50:35 -0400
Received: from [178.250.34.74] (port=33554 helo=meije)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1mRz5B-00052l-3y; Sun, 19 Sep 2021 11:50:32 -0400
From: Mathieu Othacehe <othacehe@HIDDEN>
To: Sarah Morgensen <iskarian@HIDDEN>
Subject: Re: bug#50664: [PATCH core-updates-frozen] gnu: curl: Respect
 #:tests?.
References: <8d416ea3a4f64a4a4df52084e5a9e5cce11c3c0b.1631944982.git.iskarian@HIDDEN>
Date: Sun, 19 Sep 2021 15:50:18 +0000
In-Reply-To: <8d416ea3a4f64a4a4df52084e5a9e5cce11c3c0b.1631944982.git.iskarian@HIDDEN>
 (Sarah Morgensen's message of "Sat, 18 Sep 2021 10:14:34 -0700")
Message-ID: <878rzsd0p1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 50664
Cc: 50664 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


Hello Sarah,

> +          (lambda* (#:key (tests? (not target)) #:allow-other-keys)

I'm not sure we need the default value here, as it's already part of the
build system.

Otherwise looks nice. We can apply when merging other world rebuilding
changes, or directly on core-updates for the next round.

Thanks,

Mathieu




Information forwarded to guix-patches@HIDDEN:
bug#50664; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 18 Sep 2021 17:14:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 18 13:14:46 2021
Received: from localhost ([127.0.0.1]:36774 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mRdvK-0008EG-3n
	for submit <at> debbugs.gnu.org; Sat, 18 Sep 2021 13:14:46 -0400
Received: from lists.gnu.org ([209.51.188.17]:55198)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <iskarian@HIDDEN>) id 1mRdvH-0008E7-Tu
 for submit <at> debbugs.gnu.org; Sat, 18 Sep 2021 13:14:44 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:44704)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <iskarian@HIDDEN>) id 1mRdvH-000767-Od
 for guix-patches@HIDDEN; Sat, 18 Sep 2021 13:14:43 -0400
Received: from out1.migadu.com ([91.121.223.63]:53472)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <iskarian@HIDDEN>) id 1mRdvE-0005lF-Hj
 for guix-patches@HIDDEN; Sat, 18 Sep 2021 13:14:43 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1;
 t=1631985277;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:
 content-transfer-encoding:content-transfer-encoding;
 bh=WQRG53X5TfjlOcWC41/QqVGv1EYD1bNly5JCIxGQkpA=;
 b=Gdgn7vrzytD4zPrv0TQJimqg1ZD7SiH2xydO2rqZccDnOzyULm+DJFk4TjrglBRAX1w5/p
 6uJwt+t4YC1qGozsSBaz/uLPSYV+7eByYvTP1RNYoWxLttLpGTZ3ka6a6AbARbOBN4Vs2O
 +Jck7U0OWmstOpYYGUbt6YWr5ANKTlo=
From: Sarah Morgensen <iskarian@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH core-updates-frozen] gnu: curl: Respect #:tests?.
Date: Sat, 18 Sep 2021 10:14:34 -0700
Message-Id: <8d416ea3a4f64a4a4df52084e5a9e5cce11c3c0b.1631944982.git.iskarian@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: iskarian@HIDDEN
Received-SPF: pass client-ip=91.121.223.63; envelope-from=iskarian@HIDDEN;
 helo=out1.migadu.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

* gnu/packages/curl.scm (curl)[arguments]<#:phases>{check}: Respect #:tests?.
---
 gnu/packages/curl.scm | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm
index 063a919700..17aed51fdd 100644
--- a/gnu/packages/curl.scm
+++ b/gnu/packages/curl.scm
@@ -124,16 +124,16 @@
              (rename-file (string-append out "/share/man/man3")
                           (string-append doc "/share/man/man3"))
              #t)))
-        (replace
-         'check
-         (lambda _
-           (substitute* "tests/runtests.pl"
-             (("/bin/sh") (which "sh")))
+        (replace 'check
+          (lambda* (#:key (tests? (not target)) #:allow-other-keys)
+            (substitute* "tests/runtests.pl"
+              (("/bin/sh") (which "sh")))
 
-           ;; The top-level "make check" does "make -C tests quiet-test", which
-           ;; is too quiet.  Use the "test" target instead, which is more
-           ;; verbose.
-           (invoke "make" "-C" "tests" "test"))))))
+            (when tests?
+              ;; The top-level "make check" does "make -C tests quiet-test", which
+              ;; is too quiet.  Use the "test" target instead, which is more
+              ;; verbose.
+              (invoke "make" "-C" "tests" "test")))))))
    (synopsis "Command line tool for transferring data with URL syntax")
    (description
     "curl is a command line tool for transferring data with URL syntax,

base-commit: 8613652f3f80105f35db13d6d9308257bbff8474
-- 
2.33.0





Acknowledgement sent to Sarah Morgensen <iskarian@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#50664; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 19 Sep 2021 19:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.